Re: [PATCH v2 1/2] libsas: Don't process sas events in static works

d sas_hash_addr(u8 *hashed, const u8 *sas_addr) > > void sas_hae_reset(struct work_struct *work) > { > - struct sas_ha_event *ev = to_sas_ha_event(work); > - struct sas_ha_struct *ha = ev->ha; > - > - clear_bit(HAE_RESET, >pending); > } I don't r

[PATCH] scsi: sas: scsi_queue_work can fail, so make callers aware

, which is handy when changing to dynamically allocated work in libsas as well, as discussed here: https://lkml.org/lkml/2017/6/14/121. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- drivers/scsi/libsas/sas_event.c| 36 ++-- drivers/scsi/

Re: [PATCH v3] lpfc: Fix panic on BFS configuration.

gned-off-by: Dick Kennedy <dick.kenn...@broadcom.com> > Signed-off-by: James Smart <james.sm...@broadcom.com> > Fixes: 96418b5e2c88 ("scsi: lpfc: Fix eh_deadline setting for sli3 adapters.") > Cc: sta...@vger.kernel.org > --- Looks good, Re

Re: [PATCH] scsi_lib: Add #include

d-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Christoph Hellwig <h...@lst.de> > Cc: Hannes Reinecke <h...@suse.com> > Cc: Johannes Thumshirn <jthumsh...@suse.de> > --- Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes

Re: [PATCH] libfc: do not flood console with messages 'libfc: queue full ...'

ith messages > > libfc: queue full, reducing can_queue to 512 > > With this patch the message is printed only once (ie when it's > actually changed). > > Signed-off-by: Hannes Reinecke <h...@suse.com> > --- Acked-by: Johannes Thumshirn

Re: [PATCH 2/5] scsi: bnx2fc: convert per-CPU thread to workqueue

qlogic-storage-upstr...@qlogic.com > Cc: Christoph Hellwig <h...@lst.de> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse

to -ENODEV. > > Cc: qlogic-storage-upstr...@qlogic.com > Cc: Christoph Hellwig <h...@lst.de> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH 3/5] scsi: bnx2fc: clean up header definitions

compile-tested due to -ENODEV. > > Cc: qlogic-storage-upstr...@qlogic.com > Cc: Christoph Hellwig <h...@lst.de> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH 1/5] scsi: bnx2i: convert to workqueue

logic.com > Cc: Christoph Hellwig <h...@lst.de> > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > --- Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>

Re: [PATCH 5/5] scsi: bnx2fc: convert bnx2fc_l2_rcv_thread() to workqueue

f > schedule_work_on() instead schedule_work() :) > > This patch was only compile-tested due to -ENODEV. > > Cc: qlogic-storage-upstr...@qlogic.com > Cc: Christoph Hellwig <h...@lst.de> > Cc: fcoe-de...@open-fcoe.org > Signed-off-by: Sebastian Andrzej Siewior <bige..

Re: [PATCH] Fix few small typos in fcoe.c

On 06/01/2017 02:05 PM, Milan P. Gandhi wrote: > This patch does a cleanup and fixes few small typos in fcoe.c > > Signed-off-by: Milan P. Gandhi <mgan...@redhat.com> > --- Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org>

Re: [PATCH] Eliminate extra 'out_free' label from fcoe_init function

t happens to the fcoe_wq then? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key

Re: [PATCH] Remove an extra out label in _fcoe_create function

On 06/01/2017 02:08 PM, Milan P. Gandhi wrote: > This patch removes an extra out label in _fcoe_create function > where we return if creation of FCOE interface is failed. > > Signed-off-by: Milan P. Gandhi <mgan...@redhat.com> > --- Thanks, Acked-by: Johannes Thums

[PATCH blktests 3/3] sg/001: add regression test for syzcaller generated GPF

Add a regression test for commit 48ae8484e9fc ("scsi: sg: don't return bogus Sg_requests"). This is a general protection fault triggered by syzcaller. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- tests/sg/001 | 48 ++

[PATCH blktests 1/3] Add ability to build test-cases

Add the ability to build test cases from C files. This is handy for things like syzcaller reproducers and all other kinds of test binaries. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- Makefile | 26 +++- src/.gitignore | 1 + src/Makefile | 14 ++ src/sg-001.c

[PATCH blktests 0/3] Add SCSI generic test group

the 'timeout' program in my testcase. Johannes Thumshirn (3): Add ability to build test-cases tests/sg: add SCSI generic test grouop sg/001: add regression test for syzcaller generated GPF Makefile | 26 +++- common/sg| 22 +++ src/.gitignore | 1 + src/Makefile | 14

[PATCH blktests 2/3] tests/sg: add SCSI generic test grouop

Add a test group for tests of the SCSI generic driver and and functions common to the SCSI generic driver and it's test cases. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> --- common/sg | 22 ++ tests/sg/group | 40 +

Re: [PATCH 03/28] ibmvfc: Do not call fc_block_scsi_eh() on host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 02/28] mptfc: Do not call fc_block_scsi_eh() on host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 01/28] scsi: fix comment in scsi_device_set_state()

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 08/28] bfa: move bus reset to target reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 13/28] qlogicpti: move bus reset to host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 14/28] acornscsi: move bus reset to host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 20/28] nsp32: drop bus reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 28/28] NCR5380: Clear all unissued commands on host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 01/47] aacraid: split off functions to generate reset FIB

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 16/28] qlogicfas: move bus_reset to host_reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 15/28] NCR5380: Move bus reset to host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 24/28] megaraid_mbox: drop duplicate bus reset and device reset function

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 23/28] bnx2fc: remove obsolete bnx2fc_eh_host_reset() definition

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 02/47] aacraid: split off host reset

the space between the asterisk and the variable names. Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnbe

Re: [PATCH 04/28] fc_fcp: do not call fc_block_scsi_eh() from host reset

Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 05/28] fnic: do not call host reset from command abort

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 06/28] uas: move eh_bus_reset_handler to eh_device_reset_handler

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 07/28] libsas: move bus_reset_handler() to target_reset_handler()

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 11/28] scsi: drop bus reset for wd33c93-compatible boards

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state

reap_ref_release() will take the wrong path. The end > result is a panic: Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> Although we've been tampering with the target removal code for quite some time now, so I really have the gut feeling we haven't really fixed th

Re: [PATCH 09/28] hptiop: Simplify reset handling

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 10/28] fdomain: move bus reset to host reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 18/28] ppa: drop duplicate bus_reset handler

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 17/28] imm: drop duplicate bus_reset handler

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 21/28] aha152x: drop bus reset

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 12/28] rtsx: drop bus reset function

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

; Signed-off-by: Khazhismel Kumykov <kha...@google.com> > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting? -- Johannes Thumshirn Storage jthumsh...@sus

Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device

On Wed, Sep 20, 2017 at 10:50:18AM -0700, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 12:30:41PM +0200, Johannes Thumshirn wrote: > > the problem with libfc currently is it is made for fcoe, despite being named > > libfc. > > Well, that's my point - we should be

Re: [PATCH 1/2] scsi_dh: Return SCSI_DH_XX error code from ->attach()

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH] scsi_transport_fc: set scsi_target_id upon rescan

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] fcoe-utils: Fix get_ctlr_num() for large ctlr_* indices

Applied, thanks. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [PATCH v3 1/3] nvme_fc: create fc class and transport device

r fcoe, despite being named libfc. The other hand it is hard-wired to FCP so bringing NVMe into it is a bit challanging, BTDT. It's not that it is impossible, it's just not something that can be done in a day or two of hacking. Anyways, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -

Re: [PATCH 2/2] scsi_dh: suppress errors from unsupported devices

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH] scsi: fcoe: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] scsi: fixup kernel warning during rmmod()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 2/9] bfa: don't reset max_segments for every bsg request

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 1/9] bsg-lib: fix use-after-free under memory-pressure

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [BUG] scsi/fcoe: Sleep-in-atomic bugs in fcoe driver

or the report, coincidentally I have a bug report for this as well (in a real setup not just static analysis) and gave the reporter a patch to test. Once it's verified I'll post it here. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.d

Re: [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues

y what I would call a sane API. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerpr

Re: [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues

go away eventually by cleaning that mess up. OK then, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF:

Re: [PATCH 7/9] bsg-lib: remove bsg_job.req

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 8/9] block: pass full fmode_t to blk_verify_command

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 6/9] bsg-lib: introduce a timeout field in struct bsg_job

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 9/9] bsg: split handling of SCSI CDBs vs transport requeues

y what I would call a sane API. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerpr

Re: [PATCH 5/9] scsi_transport_sas: check reply payload length instead of bidi request

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 4/9] qla2xxx: don't break the bsg-lib abstractions

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 3/9] libfc: don't assign resid_len in fc_lport_bsg_request

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

sult = DID_" drivers/scsi/ | wc -l 419 -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

), msg and driver byte will follow as well. But all this is on top of this patch, which IMHO is stable material (we had an actual customer bug with this). Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

@(none)$ pwd > /sys/devices/platform/HISI0162:01/host0/port-0:0/expander-0:0/port-0:0:7/end_device-0:0:7 > root@(none)$ more ./target0:0:3/0:0:3:0/block/sdd/queue/scheduler > noop [cfq] Maybe missing CONFIG_IOSCHED_DEADLINE? Thanks, Johannes -- Joh

[PATCH v3] scsi: fc: check for rport presence in fc_block_scsi_eh

of the API gracefully. Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com> Reviewed-by: Hannes Reinecke <h...@suse.de> --- Martin, I'm not sure if I have already sent it out or not if I already did send this v3 please ignore

[PATCH] scsi: use set_host_byte instead of open-coding it

Call set_host_byte() instead of open-coding it. Converted using this simple Coccinelle spatch @@ local idexpression struct scsi_cmnd *c; expression E1; @@ - c->result = E1 << 16; + set_host_byte(c, E1); Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> Cc: St

Re: [PATCHv6 5/5] scsi_devinfo: fixup string compare

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCHv6 4/5] scsi_devinfo: Whitespace fixes

Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Nort

Re: [PATCH 1/5] qla2xxx: Add module param ql2xenablemsix

econstructing a previous stsate, it wouldn't make much sense to rename it then. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [PATCH] scsi: aic7xxx: make a couple of functions static

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 1/1] scsi/libfc: fix a deadlock in fc_rport_work

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH] scsi: libfc: Convert timers to use timer_setup()

Looks good, Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v2 1/8] lib/scatterlist: Introduce sgl_alloc() and sgl_free()

Thanks Bart, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 4/8] nvmet/rdma: Use sgl_alloc() and sgl_free()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 3/8] nvmet/fc: Use sgl_alloc() and sgl_free()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 1/8] lib: Introduce sgl_alloc() and sgl_free()

; That's something I can change. I don't have a strong opinion about whether > these declarations should go into a new header file or into > linux/scatterlist.h. Yes please do (and the implementaion should go into lib/scatterlist.c). Additionally please get rid of the new CONFIG_SGL_ALLOC as well.

Re: [PATCH 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 8/8] scsi/pmcraid: Use sgl_alloc_order() and sgl_free_order()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 7/8] scsi/pmcraid: Remove an unused structure member

Fair enough, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCHv6 2/5] scsi: Export blacklist flags to sysfs

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCHv6 1/5] scsi_debug: allow to specify inquiry vendor and model

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCHv6 3/5] scsi_devinfo: Reformat blacklist flags

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones

On Fri, Sep 08, 2017 at 11:48:09AM +0200, Christoph Hellwig wrote: > On Fri, Sep 08, 2017 at 10:39:25AM +0200, Johannes Thumshirn wrote: > > It's a shame we have all this overflow checking kcalloc() and > > kmalloc_array() functions but none of them is taking NUMA nodes i

Re: [PATCH V2 06/12] scsi: sd_zbc: Rearrange code

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 03/12] scsi: sd_zbc: Move ZBC declarations to scsi_proto.h

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 09/12] scsi: sd_zbc: Limit zone write locking to sequential zones

UMA nodes into account. But that has nothing to do with your patch, just a general rant, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE

Re: [PATCH V2 02/12] block: Fix declaration of blk-mq scheduler functions

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 01/12] block: Fix declaration of blk-mq debugfs functions

On Fri, Sep 08, 2017 at 01:16:29AM +0900, Damien Le Moal wrote: > __blk_mq_debugfs_rq_show() and blk_mq_debugfs_rq_show() are exported > symbols but ar eonly declared in the block internal file are only Otherwise this looks good to me, Reviewed-by: Johannes Thumshirn &l

Re: [PATCH V2 07/12] scsi: sd_zbc.c: Use well defined macros

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 08/12] scsi: sd_zbc: Fix sd_zbc_read_zoned_characteristics()

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 05/12] scsi: sd_zbc: Fix comments and indentation

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH V2 04/12] scsi: sd_zbc: Move zbc disk declarations to sd_zbc.h

Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [PATCH 1/3] fcoe: move fcoe_interface_remove() out of fcoe_interface_cleanup()

With an updates patch description (see Lee's mail) Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF:

Re: [PATCH 2/3] fcoe: separate out fcoe_vport_remove()

Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 3/3] fcoe: open-code fcoe_destroy_work() for NETDEV_UNREGISTER

Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: 4.13+git: undefined references to bsg_setup_queue and bsg_job_done

get 'vmlinux' failed > make: *** [vmlinux] Error 1 There's a fix from Arnd [1] for this and it is in Martin's queue. [1] 580b71e9f64e0e6e9063466fce4564c56156695d Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de

<    7   8   9   10   11   12   13   14   15   >