After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups for
kobjects.
Signed-off-by: Johannes Thumshir
After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups for
kobjects.
Signed-off-by: Johannes Thumshir
After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups for
kobjects.
Signed-off-by: Johannes Thumshir
an idea how to tackle the ordering issues and place it into
sas_unregister_ha() as per James' comment.
Thanks,
Johannes
Johannes Thumshirn (5):
scsi: isci: remove the SAS host after the SCSI host
aic94xx: remove the SAS host after the SCSI host
scsi: hisi_sas: remove the SAS host
After commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive") changed the
removal path of kernfs to make it recursive we have to remove the SAS host
before the SCSI host or we will see sysfs warnings on not found sysfs groups
for kobjects.
Signed-off-by: Johannes Thumshir
On Fri, Apr 21, 2017 at 09:34:18AM +0100, John Garry wrote:
> Thanks Johannes.
>
> @wangyijing, can you test this patchset please (specifically 3/5)? I know
> that you have the modified version of libsas which you dabbled with
> upstreaming.
>
> On 21/04/2017 09:04, Joh
; free for re-use on another IO.
>
> If there is no outstanding activity on the exchange, the driver will send a
> ABTS to the Initiator. Upon completion of this WQE, the exchange / context
> is freed for re-use on another IO.
>
> Signed-off-by: Dick Ke
the patches? They're for
drivers/scsi/lpfc/ after all. I just want to avoid confusion and possible
merge conflicts.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX G
On Fri, Apr 21, 2017 at 01:19:41PM +0200, Christoph Hellwig wrote:
>
> Any reason to not just make sas_remove_host call scsi_remove_host
> to ensure we get the ordering right?
No other than "haven't thought of it". But let me double check the LLDDs fist.
--
rsive").
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Suggested-by: Christoph Hellwig <h...@lst.de>
Cc: Hannes Reinecke <h...@suse.de>
Cc: James Bottomley <j...@linux.vnet.ibm.com>
Cc: Jinpu Wang <jinpu.w...@profitbricks.com>
Cc: John Garry <john.
NVMET sends a GID_FT and determines if an NVMEP_INITIATOR
> it has is UNMAPPED but no longer in the zone membership.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
&
ne work queue with the
> supported size.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
mart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendö
On Thu, Apr 20, 2017 at 04:03:05PM +0200, Christoph Hellwig wrote:
> We'll get all proper errors reported through ->end_io and ->errors will
> go away soon.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@s
-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
On Thu, Apr 20, 2017 at 04:03:14PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Easy enough,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
On Thu, Apr 20, 2017 at 04:03:15PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Just to be sure nothings forgotten, does this change need an update for
blktrace as well?
--
Johannes Thumshirn Sto
k Wilk <konrad.w...@oracle.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendö
On Thu, Apr 20, 2017 at 04:02:54PM +0200, Christoph Hellwig wrote:
> The driver never sets req->errors, so blk_execute_rq will always return 0.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com>
> ---
R
On Thu, Apr 20, 2017 at 04:03:03PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
On Thu, Apr 20, 2017 at 04:03:04PM +0200, Christoph Hellwig wrote:
> dm never uses rq->errors, so there is no need to pass an error argument
> to blk_mq_complete_request.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthum
On Thu, Apr 20, 2017 at 04:03:07PM +0200, Christoph Hellwig wrote:
> Instead of using req->errors, which will go away.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de
On Thu, Apr 20, 2017 at 05:25:58PM +0200, Christoph Hellwig wrote:
> On Thu, Apr 20, 2017 at 05:20:56PM +0200, Johannes Thumshirn wrote:
> > On Thu, Apr 20, 2017 at 04:03:15PM +0200, Christoph Hellwig wrote:
> > > Signed-off-by: Christoph Hellwig <h...@lst.de>
> >
c_hba *phba, struct lpfc_iocbq
> *cmdwqe,
> +struct lpfc_wcqe_complete *wcqe)
> {
> struct lpfc_nvmet_rcv_ctx *ctxp;
> struct lpfc_nvmet_tgtport *tgtp;
> @@ -1706,35 +1881,54 @@ lpfc_nvmet_xmt_fcp_abort_cmp(struct lpfc_hba *phba,
>
eprom(),
b) Linux error codes are negative,
c) ahd_write_seeprom() has 'retval' and 'error' for returning error values
back to the caller (which doesn't care...)
So to sum it up, this change doesn't change anything here. But "fixing" the
list above would make a change.
HTH,
by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49
ut was reduced
> because timeout failure is the same as timeout.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.d
pnvme_rport->port_id,
> + ndlp->nlp_state, ndlp->nlp_type);
> + return -ENODEV;
This if statement is horrible to read with all those parenthesis. It really
looks more like LISP than C. IIRC I already told you this in my last revie
ioned to a non active state.
>
> There is no need to print the node pointer address for a node that
> is not active the DID should be enough to debug.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com&
ded debug message to log XRI split.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
om.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
om.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH,
com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smitha
...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE
BC B5 56 56 23 61 00 00 00 61 04 00 01 98 00 00 30 00 00 00
> 00 10 00 18 00 00 00 00 02 14 00 18 28 00 01 00 00 00 00 00
> 00 00 00 00 00 00 00 18 00 00 00 00 B0 6B 07 57 BC B5 75 75
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: Ja
kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
But I'd really like to see a Tested-by from Junichi here.
--
Johannes Thumshirn Storag
the driver sets the hdr_version to V1 so all is good.
> When I tested the V1 WQ_CREATE, the mailbox failed causing
> the driver to unload.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
on the localport and lport in lpfc_nvme_update_localport and
> dump messages if they are NULL and just exit.
> Also one alingment issue fixed.
> Repalces the ifdef with the IS_ENABLED macro.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: Jame
hbalock is not
> needed to issue io to the nvme work queue.
>
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
4(struct pci_dev *pdev, const
> struct pci_device_id *pid)
> goto out_unset_pci_mem_s4;
> }
>
> + cnt = phba->cfg_iocb_cnt * 1024;
> + if (phba->nvmet_support)
> + cnt += (phba->cfg_nvmet_mrq_post * phba->cfg_nvmet_mrq);
So
t; + vport->vport_flag &= ~FAWWPN_SET;
> + if (vvvl == 1 && (cpu_to_be32(*fawwpn_key)) ==
> + FAPWWN_KEY_VENDOR)
> + vport->vport_flag |= FAWWPN_SET;
> + }
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.d
-after-free
situations.
The subject is wrong, should be something like "scsi: libfc convert
fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390.
Other than that
Acked-by: Johannes Thumshirn <j...@kernel.org>
Turns out that it is better that all these patches go throug
> This looks OK to me.
>>>>
>>>> Acked-by: Chris Leech <cle...@redhat.com>
>>>
>>> Thank you for review! Do you have a tree that can take this change?
>>
>> Hi Elena,
>>
>> iscsi like fcoe should go via the SCSI tree.
>
> Tha
gned-off-by: Kees Cook <keesc...@chromium.org>
>>> Signed-off-by: David Windsor <dwind...@gmail.com>
>>
>> This looks OK to me.
>>
>> Acked-by: Chris Leech <cle...@redhat.com>
>
> Thank you for review! Do you have a tree that can take this change
t(csk) does a
kref_get(>refcnt), so this will at lease leak a kref. It will also "leak"
the atids_in_use in cxgb3_alloc_atid() as there's a call to cxgb3_free_atid()
missing. Looks like the complete cleanup path is worng here.
But I'd prefer having Karen or someone else at
s.
The subject is wrong, should be something like "scsi: libfc convert
fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390.
Other than that
Acked-by: Johannes Thumshirn <j...@kernel.org>
--
Johannes Thumshirn
c FastLinQ offload iSCSI driver
> framework.")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Wed, Apr 05, 2017 at 04:18:54PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
for additional smaller fields that will appear soon.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
On Wed, Apr 05, 2017 at 04:18:53PM +0200, Christoph Hellwig wrote:
> Don't pass the status explicitly but derive it from the requeust,
> and unwind the complex condition to be more readable.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Looks good,
Reviewed-b
> to common code.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Thanks a lot.
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de
Byte,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CA
parate patch.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnber
h instead of replicating the same patch 29
times?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham N
while ((deferfcp = list_first_entry_or_null(>pending_cmd_list,
struct nvmet_fc_defer_fcp_req,
req_list)) != NULL) {
?
Other than that,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Th
On Wed, Aug 02, 2017 at 10:32:20AM +0200, Johannes Thumshirn wrote:
> On Tue, Aug 01, 2017 at 03:12:40PM -0700, James Smart wrote:
> > This patch is intended to enter the kernel through the nvme block
> > tree which pulls in the nvmet_fc api change at the same time. It is
> >
sz %d from %06x\n",
> + oxid, size, sid);
> + /* defer reposting rcv buffer till .defer_rcv callback */
> + ctxp->rqb_buffer = (void *)nvmebuf;
nvmebuf is a 'struct rqb_dmabuf *' and ctxp->rqb_buffer expects 'struct
rqb_
dd indentation.
> Please reformat to have type and variable on one line.
And use Linux types and no CamelCase and no typedefs (especially not for
pointers), you're not on Windows here.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh..
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
rning by switching to dev64_ul().
div64_ul() ^
Otherwise,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX Gm
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
switch()es are so much nicer to read :-)
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF:
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
onstruct.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
it treats -ENOMEM and a valid pointer
> the same. But the documentation says we should be passing an error
> pointer.
Acked-by: Johannes Thumshirn <j...@kernel.org>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49
b is a SATA disk, the rest are SAS.
This is awesome. I hope I have some time reviewing the patches themselfes
soon.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldst
tation for hp->resid is wrong. It says:
>
> int resid; /* [o] dxfer_len - actual_transferred */
>
> My guess is that resid stands for Response ID but I'm not positive.
Nope, it's the residual length. It's set by scsi_req::resid_len
--
Johannes Thumshirn
_dxfer().
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Reported-by: Colin Ian King <colin.k...@canonical.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Cc: Douglas Gilbert <dgilb...@interlog.com>
---
drivers/scsi/sg.c | 7 +--
1 file changed
?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerpri
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
Fixes: 28676d869bbb ("scsi: sg: check for valid direction before starting the
request")
Reported-by: Chris Clayton <chris2...@googlemail.com>
Tested-by: Chris Clayton <chris2...@googlemail.com>
Cc: Douglas Gi
On Wed, Jul 12, 2017 at 03:35:34PM -0700, Song Liu wrote:
> + if (!test_bit(sshdr->sense_key & 0xf,
> + >sense_event_filter))
While being technically correct, this looks a bit kludgy. Please pass
in the whole sense_key without masking it.
Byte,
Johan
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Omar, ping?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38
is fixed with:
commit 68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47
Author: Johannes Thumshirn <jthumsh...@suse.de>
Date: Fri Jul 7 10:56:38 2017 +0200
scsi: sg: fix SG_DXFER_FROM_DEV transfers
SG_DXFER_FROM_DEV transfers do not necessarily have a dxferp as we set
it to NULL for the old s
With an updated changelog,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer
Thanks Himanshu,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Sm
"Done %s.\n", __func__);
> + }
In patch 1 you change all the
if (rval != QLA_SUCCESS) {
qla_dbg();
} else {
qla_dbg();
}
into a single qla_dbg. Now you re-introduce the pattern here.
> +int qla27xx_get_zio_threshold(scsi_qla_host_t *vha, uint16_t *valu
es I requested when reviewing the last
patchset. But I agree at least a "no functional changes introduced" would be
very beneficial.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
csi_qla_host *vha)
> ql_log(ql_log_info, fcport->vha, 0x2114, "%s: fcport=%p\n",
> __func__, fcport);
>
> + init_completion(>nvme_del_done);
> nvme_fc_unregister_remoteport(fcport->nvme_remote_port);
>
g_io_hdr_t *hp)
{
+
+ pr_info("%s: dxfer_direction: %d, dxfer_len: %d\n",
+ __func__, hp->dxfer_direction, hp->dxfer_len);
+
switch (hp->dxfer_direction) {
case SG_DXFER_NONE:
if (hp->dxferp || hp->dxfer_len > 0)
Than
0, can we rely on dxferp being present?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Gr
Looks good,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
Looks good to me,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Sm
Thanks,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard,
On Fri, Jul 21, 2017 at 09:32:28AM -0700, Himanshu Madhani wrote:
> +typedef enum {
> + TYPE_SRB,
> + TYPE_TGT_CMD,
> +} cmd_type_t;
Minor Nitpick if you have to re-send, please no typedefs.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
--
Don't make any assumptions on the sg_io_hdr_t::dxfer_direction or the
sg_io_hdr_t::dxferp in order to determine if it is a valid request. The
only way we can check for bad requests is by checking if the length exceeds
256M.
Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de>
care combinations was, that user-space could then
easily crash the kernel. This is the reason I introduced sg_is_valid_dxfer().
It's sole purpuse was to avoid more CVEs, but unfortunately it turned into
quite some regressions.
Thanks,
Johannes
--
Johannes Thumshirn
On Wed, Jul 26, 2017 at 11:17:09AM +0200, Arnd Bergmann wrote:
> Ah, it was only below the "---" line, so I'll skip the resending
> unless you want me
> to add a comment in the Kconfig file.
Nah no need, really.
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
m, the current symbol can only be "m" or
> "n", while "X=y" means it can have any value.
>
> So for "depends on X || X=n", the current symbol cannot be "y" when "X=m",
> but otherwise can have any of t
is black magic, but X || X=n ? I have no doubt you do the right
thing, I just don't understand it.
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
On Tue, Jul 25, 2017 at 01:25:07PM -0500, Jason L Tibbitts III wrote:
> >>>>> "JT" == Johannes Thumshirn <jthumsh...@suse.de> writes:
> ioctl(3, SG_IO, {interface_id='S', dxfer_direction=SG_DXFER_TO_DEV,
> cmd_len=12, cmdp="\xa5\x00\x00\x00\x00\
On Fri, Jul 21, 2017 at 02:23:16PM -0500, Jason L Tibbitts III wrote:
> I can also apply the debugging patch and try again if that would give
> you more useful information.
Yes please (on top of the snippet I've sent you last).
Thanks a lot,
Johannes
--
Johannes Thu
Doug,
On Wed, Jul 19, 2017 at 10:36:54AM +0200, Johannes Thumshirn wrote:
> On Wed, Jul 19, 2017 at 03:13:34AM -0500, Jason L Tibbitts III wrote:
> > [ 46.304530] sg_is_valid_dxfer: dxfer_direction: -2, dxfer_len: 0
>
> Ahh now I see the -2 (SG_DXFER_TO_DEV) is the crucial poin
On Wed, Jul 05, 2017 at 08:06:17AM +0100, Chris Clayton wrote:
> I can provide the full traces or any other diagnostics, if they would help.
Yes this would definitively help. An strace log would be great so I
can make a local reproducer.
Thanks,
Johannes
--
Johannes Thumsh
perror("write");
if (errno == EINVAL)
printf("FAIL\n");
goto out_close;
}
printf("PASS\n");
out_close:
close(fd);
}
--
Johannes Thumshirn Sto
901 - 1000 of 1470 matches
Mail list logo
