Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Eric Paris
On Wed, 2008-02-20 at 08:50 -0500, Stephen Smalley wrote: > On Wed, 2008-02-20 at 11:08 +0100, Miklos Szeredi wrote: > > > Please don't introduce a special case for just nfs. All filesystems > > > should control their mount options, so please provide some library > > > helpers for context= handli

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Stephen Smalley
On Wed, 2008-02-20 at 11:08 +0100, Miklos Szeredi wrote: > > Please don't introduce a special case for just nfs. All filesystems > > should control their mount options, so please provide some library > > helpers for context= handling and move it into all filesystems that > > can support selinux.

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Stephen Smalley
On Wed, 2008-02-20 at 11:25 +1100, James Morris wrote: > On Tue, 19 Feb 2008, Christoph Hellwig wrote: > > > Please don't introduce a special case for just nfs. All filesystems > > should control their mount options, so please provide some library > > helpers for context= handling and move it in

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-20 Thread Miklos Szeredi
> Please don't introduce a special case for just nfs. All filesystems > should control their mount options, so please provide some library > helpers for context= handling and move it into all filesystems that > can support selinux. Hmm, looks like selinux is not showing it's mount options in /pro

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-19 Thread James Morris
On Tue, 19 Feb 2008, Christoph Hellwig wrote: > Please don't introduce a special case for just nfs. All filesystems > should control their mount options, so please provide some library > helpers for context= handling and move it into all filesystems that > can support selinux. It's not so much a

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-19 Thread Casey Schaufler
--- Christoph Hellwig <[EMAIL PROTECTED]> wrote: > Please don't introduce a special case for just nfs. All filesystems > should control their mount options, so please provide some library > helpers for context= handling and move it into all filesystems that > can support selinux. Smack has opti

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-19 Thread Eric Paris
On Tue, 2008-02-19 at 17:24 -0500, Christoph Hellwig wrote: > Please don't introduce a special case for just nfs. All filesystems > should control their mount options, so please provide some library > helpers for context= handling and move it into all filesystems that > can support selinux. A li

Re: NFS/LSM: allow NFS to control all of its own mount options

2008-02-19 Thread Christoph Hellwig
Please don't introduce a special case for just nfs. All filesystems should control their mount options, so please provide some library helpers for context= handling and move it into all filesystems that can support selinux. - To unsubscribe from this list: send the line "unsubscribe linux-securit

NFS/LSM: allow NFS to control all of its own mount options

2008-02-19 Thread Eric Paris
In the current code (approved by SELinux and NFS people in 2004) SELinux tries to understand NFS's binary mount data. This blows up in the face of things like nohide mounts which don't use struct nfs_mount_data and I assume just looking at the code that things don't work since NFS moved to using n