Re: [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

Hi, On Sat, Sep 19, 2015 at 1:39 AM, Hans de Goede wrote: > Hi, > > On 09/18/2015 11:39 AM, Tom Rini wrote: >> >> On Fri, Sep 18, 2015 at 11:17:00AM -0400, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 09/18/2015 11:02 AM, Tom Rini wrote: On Fri, Sep 18, 2015 at

[linux-sunxi] [PATCH 0/4] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 Q8 format tablets

Hi Maxime, This series adds support for the PWM controlled backlight on the A23/A33 Q8 tablets. The A23/A33 SoCs have the same PWM controller as the A20, and the tablets use it to dim the LCD backlight. The patches are pretty self-explaining. Hans, could you test this on your TZX 723Q4? It's

[linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33

The PWM controller has 2 outputs, with one usable pin for each. Add a pinmux setting for the first channel. This is often used for backlight dimming on tablets. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-a23-a33.dtsi | 7 +++ 1 file changed, 7 insertions(+)

[linux-sunxi] [PATCH 4/4] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 Q8 format tablets

The LCD backlight on the A23/A33 Q8 format tablets is enabled with a GPIO controlled regulator, and brightness controlled with the SoC's PWM controller. The backlight is powered from the AXP223 PMIC's DC1SW output, which is not supported yet. A proper bootloader is required to enable it. The

[linux-sunxi] [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33

A23/A33 have a PWM controller that is compatible to the one on the A20. Add a device node for it. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-a23-a33.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi

[linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets

A23/A33 based Q8 format tablets use channel 0 of the PWM controller for backlight dimming. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi

[linux-sunxi] Compiling u-boot (sunxi/next)

Hey all, just working on a _defconfig for our board and noticed that u-boot fails to compile if my defconfig doesn't have: # CONFIG_CMD_IMLS is not set What supprised me is that it has to be in there as a comment to unset it. I would have imaged that it would be unset by default and only be

[linux-sunxi] Re: [PATCH 0/5] ARM: sunxi: Introduce CHIP support

On Friday 18 September 2015 10:48:45 Maxime Ripard wrote: > > Here is a serie introducing the support for the Allwinner R8 and the > Nextthing's CHIP. > > Support is almost complete for the CHIP itself, the only missing part > for now is the WiFi chip that needs to be powered through two

[linux-sunxi] Re: Compiling u-boot (sunxi/next)

Hey Ian, On 18-09-15 10:32, Ian Campbell wrote: On Fri, 2015-09-18 at 10:22 +0200, Olliver Schinagl wrote: Hey all, Did you CC the wrong Hans by mistake? Yeah, curse you auto-complete :S just working on a _defconfig for our board and noticed that u-boot fails to compile if my defconfig

[linux-sunxi] Re: [PATCH 2/5] ARM: sun5i: Add R8 DTSI

Hi, On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard wrote: > The R8 is very close to the A13, but it still has a few differences, > notably a composite output, which the A13 lacks. > > Add a DTSI based on the A13's to hold those differences. > > Signed-off-by:

[linux-sunxi] Re: [PATCH 1/5] ARM: sunxi: Add R8 support

On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard wrote: > The R8 is a new Allwinner SoC based on the A13. While both are very > similar, there's still a few differences. Introduce a new compatible to > deal with them. > > Signed-off-by: Maxime Ripard

[linux-sunxi] [PATCH 2/5] ARM: sun5i: Add R8 DTSI

The R8 is very close to the A13, but it still has a few differences, notably a composite output, which the A13 lacks. Add a DTSI based on the A13's to hold those differences. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun5i-r8.dtsi | 61

[linux-sunxi] [PATCH 4/5] ARM: sun5i: dt: Add UART3 CTS and RTS pins

Add a separate pinctrl node for the UART3 CTS and RTS pins shared between the A10s and A13. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun5i.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/sun5i.dtsi

[linux-sunxi] [PATCH 3/5] ARM: sun5i: dt: Move uart3 pinctrl node to common DTSI

The uart3 pins are shared between the A10s and A13, move the pinctrl node to the common DTSI to avoid duplication. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun5i-a10s.dtsi | 7 --- arch/arm/boot/dts/sun5i.dtsi | 7 +++ 2 files changed, 7

[linux-sunxi] [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS

The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video jack and two connectors to plug additional boards on top of it. Signed-off-by: Maxime Ripard ---

[linux-sunxi] [PATCH 1/5] ARM: sunxi: Add R8 support

The R8 is a new Allwinner SoC based on the A13. While both are very similar, there's still a few differences. Introduce a new compatible to deal with them. Signed-off-by: Maxime Ripard --- arch/arm/mach-sunxi/sunxi.c | 3 ++- drivers/clk/sunxi/clk-sunxi.c | 1

[linux-sunxi] [PATCH 0/5] ARM: sunxi: Introduce CHIP support

Hi, Here is a serie introducing the support for the Allwinner R8 and the Nextthing's CHIP. Support is almost complete for the CHIP itself, the only missing part for now is the WiFi chip that needs to be powered through two combined regulators (AXP209's LDO3 and LDO4). The audio codec is also

[linux-sunxi] Re: Compiling u-boot (sunxi/next)

On Fri, 2015-09-18 at 10:22 +0200, Olliver Schinagl wrote: > Hey all, Did you CC the wrong Hans by mistake? > just working on a _defconfig for our board and noticed that u-boot fails > to compile if my defconfig doesn't have: > # CONFIG_CMD_IMLS is not set > > What supprised me is that it has

[linux-sunxi] Re: [PATCH 5/6] ARM: dts: sun6i: Add support for Sinlinx A31s SDK board

On Wed, Sep 16, 2015 at 2:20 PM, Maxime Ripard wrote: > On Mon, Sep 14, 2015 at 03:24:47PM +0800, Chen-Yu Tsai wrote: >> On Fri, Aug 28, 2015 at 8:34 PM, Maxime Ripard >> wrote: >> > On Fri, Aug 28, 2015 at 05:54:38PM +0800,

[linux-sunxi] Re: [PATCH 2/3] ARM: dts: sun5i: Add sun5i-q8-common.dtsi

On Sat, Sep 05, 2015 at 04:55:52PM +0200, Hans de Goede wrote: > This is the sun5i / a13 version of sun8i-q8-common.dtsi for use in dts > files for a13 q8 based tablets. Compared to sun8i this uses uart1 for the > serial console, and PG0 for card-detect for mmc0. > > This also adds pmic and otg

[linux-sunxi] Re: [PATCH 2/3] ARM: dts: sun5i: Add sun5i-q8-common.dtsi

On Thu, Sep 10, 2015 at 05:05:39PM +0200, Hans de Goede wrote: > Hi, > > On 09-09-15 16:01, Maxime Ripard wrote: > >On Tue, Sep 08, 2015 at 11:26:51PM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 09/08/2015 04:33 PM, Maxime Ripard wrote: > >>>On Sat, Sep 05, 2015 at 04:55:52PM +0200, Hans de

[linux-sunxi] [PATCH 5/6] ARM: sun5i: dt: Add UART3 CTS and RTS pins

Add a separate pinctrl node for the UART3 CTS and RTS pins shared between the A10s and A13. Signed-off-by: Maxime Ripard --- arch/arm/dts/sun5i.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/dts/sun5i.dtsi b/arch/arm/dts/sun5i.dtsi

[linux-sunxi] [PATCH 4/6] ARM: sun5i: dt: Move uart3 pinctrl node to common DTSI

The uart3 pins are shared between the A10s and A13, move the pinctrl node to the common DTSI to avoid duplication. Signed-off-by: Maxime Ripard --- arch/arm/dts/sun5i-a10s.dtsi | 7 --- arch/arm/dts/sun5i.dtsi | 7 +++ 2 files changed, 7

[linux-sunxi] [PATCH 6/6] sunxi: Add CHIP support

The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video jack and two connectors to plug additional boards on top of it. Signed-off-by: Maxime Ripard --- arch/arm/dts/Makefile

[linux-sunxi] [PATCH 3/6] sunxi: Add the R8 DTSI

The R8 is very close to the A13, but it still has a few differences, notably a composite output, which the A13 lacks. Add a DTSI based on the A13's to hold those differences. Signed-off-by: Maxime Ripard --- arch/arm/dts/sun5i-r8.dtsi | 61

[linux-sunxi] [PATCH 0/6] ARM: sunxi: Introduce CHIP support

Hi, Here is a serie introducing the support for the Allwinner R8 and the Nextthing's CHIP. The only missing parts for now are the display on the composite output and the NAND support that will come in due time. Everything else should work just fine, including the USB gadget and host support.

[linux-sunxi] Re: [PATCH 1/5] ARM: sunxi: Add R8 support

On Fri, Sep 18, 2015 at 05:47:44PM +0800, Chen-Yu Tsai wrote: > On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard > wrote: > > The R8 is a new Allwinner SoC based on the A13. While both are very > > similar, there's still a few differences. Introduce a new

[linux-sunxi] [PATCH 1/6] sunxi: Add an option to disable MMC

Some devices don't have any MMC devices, so it doesn't really make sense to enable the MMC related functions and options for them. Add an option to disable the MMC support entirely. Signed-off-by: Maxime Ripard --- arch/arm/cpu/armv7/sunxi/board.c | 6 ++

[linux-sunxi] [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support

The current fastboot support assumes that CONFIG_FASTBOOT_FLASH implies that we have an MMC in our system, which might not be the case if we have some other storage device. Change the configuration option protecting that call to FASTBOOT_FLASH_MMC_DEV, that makes much more sense. Signed-off-by:

[linux-sunxi] Re: [PATCH 2/5] ARM: sun5i: Add R8 DTSI

On Fri, Sep 18, 2015 at 05:41:47PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard > wrote: > > The R8 is very close to the A13, but it still has a few differences, > > notably a composite output, which the A13 lacks. > > > >

[linux-sunxi] Re: [PATCH 0/5] ARM: sunxi: Introduce CHIP support

Hi Arnd, On Fri, Sep 18, 2015 at 11:02:33AM +0200, Arnd Bergmann wrote: > On Friday 18 September 2015 10:48:45 Maxime Ripard wrote: > > > > Here is a serie introducing the support for the Allwinner R8 and the > > Nextthing's CHIP. > > > > Support is almost complete for the CHIP itself, the only

[linux-sunxi] Re: [PATCH 3/4] input: Add new sun4i-keypad driver

Hi Yassin, On Fri, Sep 18, 2015 at 10:19:55AM +1000, Yassin Jaffer wrote: > Hi Maxime > > I appreciate your time and efforts . > > Do you need that rate to be enforced, or is it some leftover from the > > allwinner BSP? > > > I've found that clock rate works fine with the default denounce and

Re: [linux-sunxi] [PATCH 1/6] sunxi: Add an option to disable MMC

Hi, First if all, thanks for the patches for this. I've a couple of comments on a few of them (including this one) I'll reply to the one I've comments on. no reply means I think it is fine :) On 09/18/2015 08:06 AM, Maxime Ripard wrote: Some devices don't have any MMC devices, so it doesn't

Re: [linux-sunxi] [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support

Hi, On 09/18/2015 08:06 AM, Maxime Ripard wrote: The current fastboot support assumes that CONFIG_FASTBOOT_FLASH implies that we have an MMC in our system, which might not be the case if we have some other storage device. Change the configuration option protecting that call to

Re: [linux-sunxi] [PATCH 6/6] sunxi: Add CHIP support

Hi, On 09/18/2015 08:06 AM, Maxime Ripard wrote: The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video jack and two connectors to plug additional boards on top of it. Signed-off-by: Maxime Ripard

[linux-sunxi] Re: [PATCH 5/6] ARM: sun5i: dt: Add UART3 CTS and RTS pins

On Fri, Sep 18, 2015 at 02:06:19PM +0200, Maxime Ripard wrote: > Add a separate pinctrl node for the UART3 CTS and RTS pins shared between > the A10s and A13. > > Signed-off-by: Maxime Ripard Reviewed-by: Tom Rini -- Tom -- You

[linux-sunxi] Re: [PATCH 1/6] sunxi: Add an option to disable MMC

Hi, On 09/18/2015 11:02 AM, Tom Rini wrote: On Fri, Sep 18, 2015 at 02:06:15PM +0200, Maxime Ripard wrote: Some devices don't have any MMC devices, so it doesn't really make sense to enable the MMC related functions and options for them. Add an option to disable the MMC support entirely.

[linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

On Fri, 2015-09-18 at 14:06 +0200, Maxime Ripard wrote: > The R8 is very close to the A13, but it still has a few differences, > notably a composite output, which the A13 lacks. > > Add a DTSI based on the A13's to hold those differences. Is this a direct import of one from the Linux tree? > >

[linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard wrote: > The R8 is very close to the A13, but it still has a few differences, > notably a composite output, which the A13 lacks. > > Add a DTSI based on the A13's to hold those differences. > > Signed-off-by: Maxime Ripard

[linux-sunxi] Re: [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support

On Fri, Sep 18, 2015 at 02:06:16PM +0200, Maxime Ripard wrote: > The current fastboot support assumes that CONFIG_FASTBOOT_FLASH implies > that we have an MMC in our system, which might not be the case if we have > some other storage device. > > Change the configuration option protecting that

[linux-sunxi] Re: [PATCH 1/6] sunxi: Add an option to disable MMC

On Fri, Sep 18, 2015 at 02:06:15PM +0200, Maxime Ripard wrote: > Some devices don't have any MMC devices, so it doesn't really make sense to > enable the MMC related functions and options for them. > > Add an option to disable the MMC support entirely. > > Signed-off-by: Maxime Ripard

[linux-sunxi] Re: [PATCH 4/6] ARM: sun5i: dt: Move uart3 pinctrl node to common DTSI

On Fri, Sep 18, 2015 at 02:06:18PM +0200, Maxime Ripard wrote: > The uart3 pins are shared between the A10s and A13, move the pinctrl node > to the common DTSI to avoid duplication. > > Signed-off-by: Maxime Ripard Reviewed-by: Tom Rini

[linux-sunxi] Re: [PATCH 6/6] sunxi: Add CHIP support

On Fri, Sep 18, 2015 at 02:06:20PM +0200, Maxime Ripard wrote: > The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of > RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video jack > and two connectors to plug additional boards on top of it. > > Signed-off-by:

[linux-sunxi] Re: [PATCH 0/5] ARM: sunxi: Introduce CHIP support

On Friday 18 September 2015 14:19:05 Maxime Ripard wrote: > > There's actually two issues that are pretty orthogonal: > > * the fact that the regulator to power the wifi chip needs to be > enabled before it enumerates and the driver is probed. The MMC > pwrseq stuff seems to fix that,

[linux-sunxi] Re: [PATCH 0/5] ARM: sunxi: Introduce CHIP support

On Friday 18 September 2015 15:55:38 Maxime Ripard wrote: > > And I don't think it's something the MMC core should deal with. The > device itself has a single pin to provide its power, it's the board > that is wired that way. The way I was seeing it was more that I needed > to create a regulator

[linux-sunxi] Re: [PATCH 0/5] ARM: sunxi: Introduce CHIP support

On Fri, Sep 18, 2015 at 03:18:57PM +0200, Arnd Bergmann wrote: > On Friday 18 September 2015 14:19:05 Maxime Ripard wrote: > > > > There's actually two issues that are pretty orthogonal: > > > > * the fact that the regulator to power the wifi chip needs to be > > enabled before it

[linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS

On Fri, Sep 18, 2015 at 4:48 PM, Maxime Ripard wrote: > The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of > RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video jack > and two connectors to plug additional boards on top of

[linux-sunxi] Re: [PATCH 3/3] ARM: dts: sun5i: Add dts file for q8 formfactor a13 based tablets

On Sat, Sep 05, 2015 at 04:55:53PM +0200, Hans de Goede wrote: > This commits adds a generic dts file for q8 formfactor a13 based tablets. > > The tablets ship in many variants, with the difference mainly being the > touchscreen controller / accelerometer / wifi chip used. > > The wifi is USB

Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33

On Fri, Sep 18, 2015 at 11:30 PM, Hans de Goede wrote: > Hi, > > On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: >> >> The PWM controller has 2 outputs, with one usable pin for each. >> >> Add a pinmux setting for the first channel. This is often used >> for backlight dimming on

Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets

On Fri, Sep 18, 2015 at 11:32 PM, Hans de Goede wrote: > Hi, > > On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: >> >> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for >> backlight dimming. >> >> Signed-off-by: Chen-Yu Tsai >> --- >>

Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33

Hi, Good stuff, thanks for working on this. On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: A23/A33 have a PWM controller that is compatible to the one on the A20. Add a device node for it. Signed-off-by: Chen-Yu Tsai Looks good to me: Reviewed-by: Hans de Goede

Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets

Hi, On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: A23/A33 based Q8 format tablets use channel 0 of the PWM controller for backlight dimming. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [linux-sunxi] [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting for A23/A33

Hi, On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: The PWM controller has 2 outputs, with one usable pin for each. Add a pinmux setting for the first channel. This is often used for backlight dimming on tablets. Signed-off-by: Chen-Yu Tsai ---

Re: [linux-sunxi] [PATCH 0/5] ARM: sunxi: Introduce CHIP support

Hi, On 09/18/2015 04:48 AM, Maxime Ripard wrote: Hi, Here is a serie introducing the support for the Allwinner R8 and the Nextthing's CHIP. Support is almost complete for the CHIP itself, the only missing part for now is the WiFi chip that needs to be powered through two combined regulators

Re: [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

Hi, On 09/18/2015 11:39 AM, Tom Rini wrote: On Fri, Sep 18, 2015 at 11:17:00AM -0400, Hans de Goede wrote: Hi, On 09/18/2015 11:02 AM, Tom Rini wrote: On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard wrote: The R8 is very close to the A13, but it still has a few differences, notably

Re: [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

Hi, On 09/18/2015 11:02 AM, Tom Rini wrote: On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard wrote: The R8 is very close to the A13, but it still has a few differences, notably a composite output, which the A13 lacks. Add a DTSI based on the A13's to hold those differences.

Re: [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

On Fri, Sep 18, 2015 at 11:17:00AM -0400, Hans de Goede wrote: > Hi, > > On 09/18/2015 11:02 AM, Tom Rini wrote: > >On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard wrote: > > > >>The R8 is very close to the A13, but it still has a few differences, > >>notably a composite output, which the

Re: [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

On Fri, Sep 18, 2015 at 11:39:25AM -0400, Hans de Goede wrote: > Hi, > > On 09/18/2015 11:39 AM, Tom Rini wrote: > >On Fri, Sep 18, 2015 at 11:17:00AM -0400, Hans de Goede wrote: > >>Hi, > >> > >>On 09/18/2015 11:02 AM, Tom Rini wrote: > >>>On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard