Hi,
On 07/04/2014 08:53 PM, Henrik Nordström wrote:
> fre 2014-07-04 klockan 17:14 +0800 skrev Wills Wang:
>> +gctrl = readl(&mmchost->reg->gctrl);
>> +gctrl &= ~SUNXI_MMC_GCTRL_ACCESS_BY_AHB;
> The above line seems redundant / unnecessary.
These lines are based on read-mo
fre 2014-07-04 klockan 17:14 +0800 skrev Wills Wang:
> +gctrl = readl(&mmchost->reg->gctrl);
> +gctrl &= ~SUNXI_MMC_GCTRL_ACCESS_BY_AHB;
> >>> The above line seems redundant / unnecessary.
> >> These lines are based on read-modify-write principle, the mmc hardware on
> >> sunxi h
Hi,
Hi,
On 07/04/2014 04:31 AM, Wills Wang wrote:
Hi,
diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index bbfe8a3..f0cb760 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -173,8 +173,6 @@ static int mmc_core_init(struct mmc *mmc)
/* Reset controlle
Hi,
On 07/04/2014 04:31 AM, Wills Wang wrote:
> Hi,
>>
>>> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
>>> index bbfe8a3..f0cb760 100644
>>> --- a/drivers/mmc/sunxi_mmc.c
>>> +++ b/drivers/mmc/sunxi_mmc.c
>>> @@ -173,8 +173,6 @@ static int mmc_core_init(struct mmc *mmc)
>>>
Hi,
diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index bbfe8a3..f0cb760 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -173,8 +173,6 @@ static int mmc_core_init(struct mmc *mmc)
/* Reset controller */
writel(SUNXI_MMC_GCTRL_RESET, &mmchos
Hi,
On 07/03/2014 10:56 AM, Wills Wang wrote:
> ---
> drivers/mmc/sunxi_mmc.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Thanks for the patch, I see that hno has already applied it to u-boot-sunxi,
we're going to need to do the same upstream, but before I prepare a patch
Thanks! Applied.
tor 2014-07-03 klockan 16:56 +0800 skrev Wills Wang:
> ---
> drivers/mmc/sunxi_mmc.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
> index bbfe8a3..f0cb760 100644
> --- a/drivers/mmc/sunxi_mmc
---
drivers/mmc/sunxi_mmc.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index bbfe8a3..f0cb760 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -173,8 +173,6 @@ static int mmc_core_init(struct m
