Re: [PATCH v17 11/16] fprobe: Rewrite fprobe on function-graph tracer

2024-10-21 Thread Heiko Carstens
> > Please note that this only works for addresses in the kernel address > > space. For user space the full 64 bit address range (minus the top > > page) can be used for user space applications. > > I wonder what is the unsigned long size (stack entry size) of the > s390? is it 64bit? The s390 ke

Re: [PATCH v17 11/16] fprobe: Rewrite fprobe on function-graph tracer

2024-10-18 Thread Heiko Carstens
On Wed, Oct 16, 2024 at 10:10:22AM -0400, Steven Rostedt wrote: > On Wed, 16 Oct 2024 14:07:31 +0200 > Sven Schnelle wrote: > > I haven't yet fully understood why this logic is needed, but the > > WARN_ON_ONCE triggers on s390. I'm assuming this fails because fp always > > has the upper bits of th

Re: [PATCH v16 04/18] function_graph: Replace fgraph_ret_regs with ftrace_regs

2024-10-16 Thread Heiko Carstens
On Wed, Oct 16, 2024 at 08:47:20AM +0900, Masami Hiramatsu wrote: > On Tue, 15 Oct 2024 20:39:06 +0200 > Heiko Carstens wrote: > > > That would make things much simpler... e.g. your new patch is also > > writing r3 to fregs, why? > > BTW, according to the document [

Re: [PATCH v16 04/18] function_graph: Replace fgraph_ret_regs with ftrace_regs

2024-10-15 Thread Heiko Carstens
On Tue, Oct 15, 2024 at 10:29:17AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Use ftrace_regs instead of fgraph_ret_regs for tracing return value > on function_graph tracer because of simplifying the callback interface. > > The CONFIG_HAVE_FUNCTION_GRAPH_RETVAL

Re: [PATCH v16 09/18] tracing: Add ftrace_fill_perf_regs() for perf event

2024-10-15 Thread Heiko Carstens
On Tue, Oct 15, 2024 at 10:30:15AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Add ftrace_fill_perf_regs() which should be compatible with the > perf_fetch_caller_regs(). In other words, the pt_regs returned from the > ftrace_fill_perf_regs() must satisfy 'user_m

Re: [PATCH v15 09/19] tracing: Add ftrace_fill_perf_regs() for perf event

2024-10-09 Thread Heiko Carstens
On Sun, Sep 15, 2024 at 06:11:14PM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Add ftrace_fill_perf_regs() which should be compatible with the > perf_fetch_caller_regs(). In other words, the pt_regs returned from the > ftrace_fill_perf_regs() must satisfy 'user_m

Re: [PATCH v2 2/2] ftrace: Consolidate ftrace_regs accessor functions for archs using pt_regs

2024-10-09 Thread Heiko Carstens
ll also make it easier to add new accessor functions to > ftrace_regs as it will mean having to touch less architectures. > > Suggested-by: Masami Hiramatsu (Google) > Signed-off-by: Steven Rostedt (Google) ... > arch/s390/include/asm/ftrace.h | 26 + Acked-by: Heiko Carstens # s390

Re: [PATCH v2 1/2] ftrace: Make ftrace_regs abstract from direct use

2024-10-09 Thread Heiko Carstens
t; > Acked-by: Catalin Marinas > Signed-off-by: Steven Rostedt (Google) > --- ... > arch/s390/include/asm/ftrace.h | 23 ++- > arch/s390/kernel/asm-offsets.c | 4 ++-- > arch/s390/kernel/ftrace.c| 2 +- > arch/s390/lib/test_unwind.c | 4 ++-- Acked-by: Heiko Carstens # s390

Re: [PATCH v2 0/2] ftrace: Make ftrace_regs abstract and consolidate code

2024-10-09 Thread Heiko Carstens
On Tue, Oct 08, 2024 at 07:05:27PM -0400, Steven Rostedt wrote: > > This is based on: > > https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git/ > ftrace/for-next > > ftrace_regs was created to hold registers that store information to save > function parameters, return val

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Heiko Carstens
On Mon, Oct 07, 2024 at 08:54:58PM -0400, Steven Rostedt wrote: > On Mon, 7 Oct 2024 20:47:43 -0400 > Steven Rostedt wrote: > #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs)->regs; }) > > I may send a v2 (tomorrow). Could you also write against which tree this patch is? It does

Re: [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs

2024-09-16 Thread Heiko Carstens
On Mon, Sep 16, 2024 at 12:29:30PM -0400, Steven Rostedt wrote: > On Mon, 16 Sep 2024 14:16:56 +0200 > Heiko Carstens wrote: > > > This does not pass the ftrace selftests. Please merge the patch below > > into this patch. With that: > > > > Acked-by: Heiko C

Re: [PATCH v14 04/19] function_graph: Replace fgraph_ret_regs with ftrace_regs

2024-09-16 Thread Heiko Carstens
; - stg %r2,__FGRAPH_RET_GPR2(%r3) > > + stg %r2,(__SF_GPRS+2*8)(%r15) > > + stg %r15,(__SF_GPRS+15*8)(%r15) > > lgr %r2,%r3 > > brasl %r14,ftrace_return_to_handler > > - aghi%r15,STACK_FRAME_OVERHEAD+__FGRAPH_RET_SIZE > > + aghi