Re: [PATCH net-next v8 6/7] mptcp: introducing a helper into active reset logic

2024-04-23 Thread Matthieu Baerts
. > > Note: using SK_RST_REASON_NOT_SPECIFIED is the same as > SK_RST_REASON_MPTCP_RST_EUNSPEC. They are both unknown. So we can convert > it directly. It looks good to me, thanks: Reviewed-by: Matthieu Baerts (NGI0) Cheers, Matt -- Sponsored by the NGI0 Core fund.

Re: [PATCH net-next v8 5/7] mptcp: support rstreason for passive reset

2024-04-23 Thread Matthieu Baerts
nclude ', but our CI is fine with it, it is also added in the next commit, and probably already included via include/net/request_sock.h. So I guess that's fine.) Other than that, it looks good to me: Reviewed-by: Matthieu Baerts (NGI0) Cheers, Matt -- Sponsored by the NGI0 Core fund.

Re: [PATCH net-next v8 3/7] rstreason: prepare for active reset

2024-04-23 Thread Matthieu Baerts
.c | 5 +++-- For the modifications in MPTCP: Acked-by: Matthieu Baerts (NGI0) Cheers, Matt -- Sponsored by the NGI0 Core fund.

Re: [PATCH net-next v8 2/7] rstreason: prepare for passive reset

2024-04-23 Thread Matthieu Baerts
Hi Jason, On 23/04/2024 09:21, Jason Xing wrote: > From: Jason Xing > > Adjust the parameter and support passing reason of reset which > is for now NOT_SPECIFIED. No functional changes. (...) > net/mptcp/subflow.c| 8 +--- For the modifications in MPTCP: Ack

Re: [PATCH net-next v8 1/7] net: introduce rstreason to detect why the RST is sent

2024-04-23 Thread Matthieu Baerts
ks good to me regarding the modifications linked to MPTCP. Acked-by: Matthieu Baerts (NGI0) Cheers, Matt -- Sponsored by the NGI0 Core fund.

Re: [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent

2024-04-22 Thread Matthieu Baerts
On 22/04/2024 11:17, Jason Xing wrote:> On Mon, Apr 22, 2024 at 4:47 PM Matthieu Baerts wrote: >> On 22/04/2024 05:01, Jason Xing wrote: >>> From: Jason Xing (...) >>> diff --git a/include/net/rstreason.h b/include/net/rstreason.h >>> new file mode 100644

Re: [PATCH net-next v7 1/7] net: introduce rstreason to detect why the RST is sent

2024-04-22 Thread Matthieu Baerts
Hi Jason, On 22/04/2024 05:01, Jason Xing wrote: > From: Jason Xing > > Add a new standalone file for the easy future extension to support > both active reset and passive reset in the TCP/DCCP/MPTCP protocols. Thank you for looking at that! (...) > diff --git a/include/net/rstreason.h b/inclu