[PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-17 Thread Jason Xing
From: Jason Xing In production, there are so many cases about why the RST skb is sent but we don't have a very convenient/fast method to detect the exact underlying reasons. RST is implemented in two kinds: passive kind (like tcp_v4_send_reset()) and active kind (like tcp_send_active_reset()). T

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-17 Thread Jason Xing
On Wed, Apr 17, 2024 at 4:51 PM Jason Xing wrote: > > From: Jason Xing > > In production, there are so many cases about why the RST skb is sent but > we don't have a very convenient/fast method to detect the exact underlying > reasons. > > RST is implemented in two kinds: passive kind (like tcp_v

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jakub Kicinski
On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xing wrote: > I'm not sure why the patch series has been changed to 'Changes > Requested', until now I don't think I need to change something. > > Should I repost this series (keeping the v6 tag) and then wait for > more comments? If Eric doesn't like it -

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jason Xing
On Thu, Apr 18, 2024 at 11:46 PM Jakub Kicinski wrote: > > On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xing wrote: > > I'm not sure why the patch series has been changed to 'Changes > > Requested', until now I don't think I need to change something. > > > > Should I repost this series (keeping the v6

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Eric Dumazet
On Thu, Apr 18, 2024 at 6:24 PM Jason Xing wrote: > > On Thu, Apr 18, 2024 at 11:46 PM Jakub Kicinski wrote: > > > > On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xing wrote: > > > I'm not sure why the patch series has been changed to 'Changes > > > Requested', until now I don't think I need to change

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jason Xing
On Fri, Apr 19, 2024 at 2:51 AM Eric Dumazet wrote: > > On Thu, Apr 18, 2024 at 6:24 PM Jason Xing wrote: > > > > On Thu, Apr 18, 2024 at 11:46 PM Jakub Kicinski wrote: > > > > > > On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xing wrote: > > > > I'm not sure why the patch series has been changed to

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jason Xing
On Fri, Apr 19, 2024 at 6:29 AM Jason Xing wrote: > > On Fri, Apr 19, 2024 at 2:51 AM Eric Dumazet wrote: > > > > On Thu, Apr 18, 2024 at 6:24 PM Jason Xing > > wrote: > > > > > > On Thu, Apr 18, 2024 at 11:46 PM Jakub Kicinski wrote: > > > > > > > > On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xi

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jason Xing
> When I said "If you feel the need to put them in a special group, this > is fine by me.", > this was really about partitioning the existing enum into groups, if > you prefer having a group of 'RES reasons' Are you suggesting copying what we need from enum skb_drop_reason{} to enum sk_rst_reason{

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-18 Thread Jason Xing
On Fri, Apr 19, 2024 at 7:26 AM Jason Xing wrote: > > > When I said "If you feel the need to put them in a special group, this > > is fine by me.", > > this was really about partitioning the existing enum into groups, if > > you prefer having a group of 'RES reasons' > > Are you suggesting copying

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Eric Dumazet
On Fri, Apr 19, 2024 at 4:31 AM Jason Xing wrote: > > On Fri, Apr 19, 2024 at 7:26 AM Jason Xing wrote: > > > > > When I said "If you feel the need to put them in a special group, this > > > is fine by me.", > > > this was really about partitioning the existing enum into groups, if > > > you pref

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Jason Xing
On Fri, Apr 19, 2024 at 3:02 PM Eric Dumazet wrote: > > On Fri, Apr 19, 2024 at 4:31 AM Jason Xing wrote: > > > > On Fri, Apr 19, 2024 at 7:26 AM Jason Xing > > wrote: > > > > > > > When I said "If you feel the need to put them in a special group, this > > > > is fine by me.", > > > > this was

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Eric Dumazet
On Fri, Apr 19, 2024 at 9:29 AM Jason Xing wrote: > > On Fri, Apr 19, 2024 at 3:02 PM Eric Dumazet wrote: > > > > On Fri, Apr 19, 2024 at 4:31 AM Jason Xing > > wrote: > > > > > > On Fri, Apr 19, 2024 at 7:26 AM Jason Xing > > > wrote: > > > > > > > > > When I said "If you feel the need to pu

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Jason Xing
On Fri, Apr 19, 2024 at 3:44 PM Eric Dumazet wrote: > > On Fri, Apr 19, 2024 at 9:29 AM Jason Xing wrote: > > > > On Fri, Apr 19, 2024 at 3:02 PM Eric Dumazet wrote: > > > > > > On Fri, Apr 19, 2024 at 4:31 AM Jason Xing > > > wrote: > > > > > > > > On Fri, Apr 19, 2024 at 7:26 AM Jason Xing

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Jason Xing
On Fri, Apr 19, 2024 at 4:00 PM Jason Xing wrote: > > On Fri, Apr 19, 2024 at 3:44 PM Eric Dumazet wrote: > > > > On Fri, Apr 19, 2024 at 9:29 AM Jason Xing > > wrote: > > > > > > On Fri, Apr 19, 2024 at 3:02 PM Eric Dumazet wrote: > > > > > > > > On Fri, Apr 19, 2024 at 4:31 AM Jason Xing >

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Steven Rostedt
On Fri, 19 Apr 2024 16:00:20 +0800 Jason Xing wrote: > If other experts see this thread, please help me. I would appreciate > it. I have strong interests and feel strong responsibility to > implement something like this patch series. It can be very useful!! I'm not a networking expert, but as I'

Re: [PATCH net-next v6 0/7] Implement reset reason mechanism to detect

2024-04-19 Thread Jason Xing
Hello Steven, On Sat, Apr 20, 2024 at 10:36 AM Steven Rostedt wrote: > > On Fri, 19 Apr 2024 16:00:20 +0800 > Jason Xing wrote: > > > If other experts see this thread, please help me. I would appreciate > > it. I have strong interests and feel strong responsibility to > > implement something lik