Re: [PATCH] usb: gadget: Add Interface Association Descriptor to ECM

2012-09-07 Thread Sebastian Andrzej Siewior
On Sat, Sep 08, 2012 at 12:04:18AM +0200, Linus Walleij wrote: > Argh, Praveena, save me here ... I was being patch secretary > this time, but to my untrained USB-eyes it looks like you're right, > interested in patching it? Don't worry, I take care of this. Just wanted to get sure that this was n

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-07 Thread Peter Chen
On Fri, Sep 7, 2012 at 11:44 PM, Alan Stern wrote: > On Fri, 7 Sep 2012, Peter Chen wrote: > >> > >> > Here's the problem we face: The class driver submits packets 1, 2, 3, >> > and 4. They get sent properly, but the completion interrupt is >> > delayed. As a result, the class driver's completi

Re: [PATCH] usb: gadget: Add Interface Association Descriptor to ECM

2012-09-07 Thread Linus Walleij
On Fri, Sep 7, 2012 at 8:51 PM, Sebastian Andrzej Siewior wrote: > On Wed, Jan 25, 2012 at 11:02:03AM +0100, Linus Walleij wrote: >> static struct usb_descriptor_header *ecm_fs_function[] = { >> /* CDC ECM control descriptors */ >> + (struct usb_descriptor_header *) &ecm_iad_descriptor

Re: [PATCH resend2] Input: usbtouchscreen - initialize eGalax devices

2012-09-07 Thread Forest Bond
Hi Dmitry, On Tue, Sep 04, 2012 at 11:07:04PM -0700, Dmitry Torokhov wrote: > On Mon, Sep 03, 2012 at 01:33:50PM -0400, Forest Bond wrote: > > From: Forest Bond > > > > Certain eGalax devices expose an interface with class HID and protocol > > None. Some work with usbhid and some work with usbt

[RFC] combine / merge usb descriptor generation

2012-09-07 Thread Sebastian Andrzej Siewior
I've been looking how to avoid '#include "[fu]_*.c"' and I think I start with common code for the creation / handling of descriptors. I don't understand why each / most gadget set f->hs_descriptors and f->ss_descriptors depending on the gadget speed. This makes no sense as composite does not "leak

Re: [PATCH] usb: gadget: Add Interface Association Descriptor to ECM

2012-09-07 Thread Sebastian Andrzej Siewior
On Wed, Jan 25, 2012 at 11:02:03AM +0100, Linus Walleij wrote: > --- a/drivers/usb/gadget/f_ecm.c > +++ b/drivers/usb/gadget/f_ecm.c > @@ -97,6 +97,20 @@ static inline unsigned ecm_bitrate(struct usb_gadget *g) > > /* interface descriptor: */ > > +static struct usb_interface_assoc_descriptor >

Re: [PATCH net-next 0/2] qmi_wwan changes intended for 3.7

2012-09-07 Thread David Miller
From: Bjørn Mork Date: Fri, 7 Sep 2012 19:36:05 +0200 > Just a couple of minor improvements for 3.7. The QMI > message size issue is not considered important enough for > stable. It does not affect the primary device function > at all, and I consider it more of a feature enhancement > than a f

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Oliver Neukum
On Friday 07 September 2012 17:23:33 Alexey ORISHKO wrote: > There is a temptation to send full NTBs even with a single IP packet, > But it will lead to wasted USB bandwidth and reduced ability to send > real data for other functions in the device or other devices on the > same root hub. Most impo

Re: [PATCH 1/10] drivers/net/usb/sierra_net.c: removes unnecessary semicolon

2012-09-07 Thread David Miller
From: Peter Senna Tschudin Date: Thu, 6 Sep 2012 18:09:08 +0200 > From: Peter Senna Tschudin > > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin Applied, thanks. -- To unsubscribe from this list: send the line "unsub

[PATCH net-next 2/2] net: qmi_wwan: use a single bind function for all device types

2012-09-07 Thread Bjørn Mork
Refactoring the bind code lets us use a common driver_info struct for all supported devices, simplifying the code a bit. The real advantage is that devices using the CDC ECM interface layout now also can be added dynamically using the new_id sysfs interface. This simplifies testing of new devices

[PATCH net-next 1/2] net: qmi_wwan: increase max QMI message size to 4096

2012-09-07 Thread Bjørn Mork
QMI requests exceeding 1500 bytes are possible and device firmware does not handle fragmented messages very well. It is therefore necessary to increase the maximum message size from the current 512 bytes. The protocol message size limit is not documented in any publicly known source, but the out

[PATCH net-next 0/2] qmi_wwan changes intended for 3.7

2012-09-07 Thread Bjørn Mork
Just a couple of minor improvements for 3.7. The QMI message size issue is not considered important enough for stable. It does not affect the primary device function at all, and I consider it more of a feature enhancement than a fix. Bjørn Mork (2): net: qmi_wwan: increase max QMI message siz

Re: [BUG] - USB3 bluetooth device not working properly?

2012-09-07 Thread Sarah Sharp
On Fri, Sep 07, 2012 at 01:22:43AM +0200, Miroslav Sabljic wrote: > On 09/06/2012 08:12 PM, Sarah Sharp wrote: > >So, try compiling a kernel from the for-usb-linus-plus-set-addr branch > >in the same git repo, and see if that helps. If it doesn't, please turn > >on CONFIG_USB_XHCI_HCD_DEBUGGING an

Re: MBIM

2012-09-07 Thread Dan Williams
On Fri, 2012-09-07 at 10:53 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Thursday 06 September 2012 10:17:46 Bjørn Mork wrote: > >> Not really related, but I am still worrying how MBIM is going to fit > >> into the usbnet model where you have a strict relation between one > >> netdev an

Re: When enabling usb autosuspend, new usb devices aren't recognized

2012-09-07 Thread Florian Merz
Hi Bjørn, If I find the time, I'll try the fixes this evening. Thanks for the hint. Florian Merz > > This sounds terribly similar to the issues I had with linux-next a while > ago. And those issues are still present in mainline. Florian could try > the fixes available in > > > http://git.k

Re: When enabling usb autosuspend, new usb devices aren't recognized

2012-09-07 Thread Bjørn Mork
Alan Stern writes: > On Thu, 6 Sep 2012, Florian Merz wrote: > >> I've attached the dmesg (USB_DEBUG enabled) output from boot to >> enabling a usb port manually (380) until plugging in a device (404). > > I think the problem shows up in these lines: > > [3.520138] xhci_hcd :00:14.0: powe

Re: When enabling usb autosuspend, new usb devices aren't recognized

2012-09-07 Thread Florian Merz
> I think the problem shows up in these lines: > > [3.520138] xhci_hcd :00:14.0: power state changed by ACPI to D2 > [5.542872] ehci_hcd :00:1a.0: power state changed by ACPI to D2 > [5.642683] ehci_hcd :00:1d.0: power state changed by ACPI to D2 > > It may be that your host

Re: [PATCH] EHCI: Update qTD next pointer in QH overlay region during unlink

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Alan Stern wrote: > On Fri, 7 Sep 2012, Pavankumar Kondeti wrote: > > > There is a possibility of QH overlay region having reference to a stale > > qTD pointer during unlink. > > > > Consider an endpoint having two pending qTD before unlink process begins. > > The endpoint's

Re: When enabling usb autosuspend, new usb devices aren't recognized

2012-09-07 Thread Alan Stern
On Thu, 6 Sep 2012, Florian Merz wrote: > I've attached the dmesg (USB_DEBUG enabled) output from boot to > enabling a usb port manually (380) until plugging in a device (404). I think the problem shows up in these lines: [3.520138] xhci_hcd :00:14.0: power state changed by ACPI to D2 [

Re: [PATCH] EHCI: Update qTD next pointer in QH overlay region during unlink

2012-09-07 Thread Pavan Kondeti
On 9/7/2012 9:22 PM, Alan Stern wrote: > On Fri, 7 Sep 2012, Pavankumar Kondeti wrote: > >> There is a possibility of QH overlay region having reference to a stale >> qTD pointer during unlink. >> >> Consider an endpoint having two pending qTD before unlink process begins. >> The endpoint's QH que

Re: [PATCH] EHCI: Update qTD next pointer in QH overlay region during unlink

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Pavankumar Kondeti wrote: > There is a possibility of QH overlay region having reference to a stale > qTD pointer during unlink. > > Consider an endpoint having two pending qTD before unlink process begins. > The endpoint's QH queue looks like this. > > qTD1 --> qTD2 --> Dumm

Re: Wrong SSD sector count with current F17 (right with live)

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Michael J Gruber wrote: > On Fri, Sep 7, 2012 at 11:30 AM, Michael J Gruber > wrote: > > [Originally posted to fedora general, where Alan Cox suspected a usb > > issue and suggested this list.] > > > > F17 with current updates gets the sector count wrong (too large by 5) > > f

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-07 Thread Alan Stern
On Fri, 7 Sep 2012, Peter Chen wrote: > > > > Here's the problem we face: The class driver submits packets 1, 2, 3, > > and 4. They get sent properly, but the completion interrupt is > > delayed. As a result, the class driver's completion handler doesn't > > get called until too late; the frame

Re: [GIT PULL] USB fixes for v3.6-rc4

2012-09-07 Thread Greg KH
On Thu, Sep 06, 2012 at 08:05:01PM +0300, Felipe Balbi wrote: > Hi Greg, > > Here's my previous pull request now rebased on top of v3.6-rc4. Sorry > for the inconvenience my "never rebase" methodology :-) > > Note that I'm rebased on top of v3.6-rc4, so you should probably merge > that tag on you

RE: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > Sent: Friday, September 07, 2012 3:09 PM > > > > Until we do something with network device framework in order to get > > access to upper layer Tx queue we need to utilize timer. > > Could you explain your reasoning? Fro

Re: [PATCH] USB: PLAT_ORION fulfils USB_ARCH_HAS_EHCI

2012-09-07 Thread Jason Cooper
On Mon, Sep 03, 2012 at 08:21:15PM +0200, Andrew Lunn wrote: > The various Orion SoCs, i.e. orion5x, kirkwood, dove, mv78xx0 > and 370/XP have EHCI. Make sure USB_ARCH_HAS_EHCI reflects this. > > Reported-by: Sebastian Hesselbarth > Signed-off-by: Andrew Lunn oops, almost lost this thread. We

Re: [PATCH] usb: cdc-ncm: struct usb_cdc_ncm_ndp_input_size not initialized

2012-09-07 Thread Greg KH
On Fri, Sep 07, 2012 at 10:55:27AM +0200, Frank Hoffmann wrote: > Hello, > > the mail address in the MAINTAINERS file is not correct, so I send > the patch again. > I hope it finds the way in the official kernel sources. Please send the patch in a format that it can be applied in (hint, you need

RE: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Alexey ORISHKO
> -Original Message- > From: Ming Lei [mailto:tom.leim...@gmail.com] > Sent: Friday, September 07, 2012 2:58 PM > > Several issues need to be improved: > > Tx path: > > 1. IP packets must be accumulated in one NTB. Currently it's done via > data copy. > > Preferred way would be a possibili

Re: [PATCH] usb: gadget: at91_udc: fix dt support

2012-09-07 Thread Nicolas Ferre
On 09/07/2012 03:27 PM, Fabio Porcedda : > Don't fail the initialization check for the platform_data > if there is avaiable an associated device tree node. > > Signed-off-by: Fabio Porcedda Acked-by: Nicolas Ferre Thanks, bye, > --- > drivers/usb/gadget/at91_udc.c | 2 +- > 1 file changed, 1

[PATCH] usb: gadget: at91_udc: fix dt support

2012-09-07 Thread Fabio Porcedda
Don't fail the initialization check for the platform_data if there is avaiable an associated device tree node. Signed-off-by: Fabio Porcedda --- drivers/usb/gadget/at91_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Oliver Neukum
On Friday 07 September 2012 14:01:23 Alexey ORISHKO wrote: > The experience from early implementations and prototyping of NCM was that > using NCM with 4-8kB NTB increased max throughput in loop-mode by a factor > of 5-6 even 8-10 times compared to using ECM. One real-world example was > modem for

Re: Wrong SSD sector count with current F17 (right with live)

2012-09-07 Thread Michael J Gruber
On Fri, Sep 7, 2012 at 11:30 AM, Michael J Gruber wrote: > [Originally posted to fedora general, where Alan Cox suspected a usb > issue and suggested this list.] > > F17 with current updates gets the sector count wrong (too large by 5) > for my SSD (Jetflash USB), resulting in read errors (during

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Ming Lei
On Thu, Sep 6, 2012 at 4:13 PM, Alexey ORISHKO wrote: >> -Original Message- >> From: Oliver Neukum [mailto:oneu...@suse.de] > > >> looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very >> dirty games because usbnet doesn't have a notion about aggregating >> packets for a s

[PATCH] usb/core: use bin2bcd() for bcdDevice in RH

2012-09-07 Thread Sebastian Andrzej Siewior
The kernel's version number is used as decimal in the bcdDevice field of the RH descriptor. For kernel version v3.12 we would see 3.0c in lsusb. I am not sure how important it is to stick with bcd values since this is this way since we started git history and nobody complained (however back then we

Re: [PATCH 8/29 v2] usb/gadget: remove global variable composite in composite.c

2012-09-07 Thread Michal Nazarewicz
On Fri, Sep 07 2012, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > > This patch removes the global variable composite in composite.c. > The private data which was saved there is now passed via an additional > argument to the bind() function in struct usb_gadget_driver. > >

RE: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > Sent: Friday, September 07, 2012 9:36 AM > > > Well, that is the mistake. Using a timer is a bad idea. > > > > Why is a bad idea? Without a timer, how can usbnet or low level > > driver aggregate the later coming transm

Re: [RFC 2/6] usb/dwc3: fix isoc END TRANSFER Condition

2012-09-07 Thread Pratyush Anand
On 9/7/2012 4:50 PM, Sergei Shtylyov wrote: >There were still some corner cases where isoc transfer was not able to >restart, specially when missed does not happen , and gadget does Missed what does not happen? Its missed isoc. I will try to amend it more clearly in final submission. Ca

Re: [RFC 2/6] usb/dwc3: fix isoc END TRANSFER Condition

2012-09-07 Thread Sergei Shtylyov
Hello. On 07-09-2012 8:33, Pratyush Anand wrote: There were still some corner cases where isoc transfer was not able to restart, specially when missed does not happen , and gadget does Missed what does not happen? not queue any new request during giveback. Cleanup function calls giveb

Re: [PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation in inc_enq and inc_deq function

2012-09-07 Thread Sergei Shtylyov
Hello. On 06-09-2012 19:47, Girish Verma wrote: Resending patch with latest kernel code: That comment should have been put after the --- tear line. In xhci-ring.c, function inc_enq and inc_deq calculate the dma address of trb but never used. Signed-off-by: Girish Verma --- driver

Re: [RFC PATCH V2 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-09-07 Thread Lan Tianyu
On 2012/9/5 22:39, Alan Stern wrote: On Wed, 5 Sep 2012, Lan Tianyu wrote: This is copied from xhci_usb3_hub_descriptor(). struct usb_hub_descriptor { __u8 bDescLength; __u8 bDescriptorType; __u8 bNbrPorts; __le16 wHubCharacteristics; __u8 bPwrOn2Pwr

Wrong SSD sector count with current F17 (right with live)

2012-09-07 Thread Michael J Gruber
[Originally posted to fedora general, where Alan Cox suspected a usb issue and suggested this list.] F17 with current updates gets the sector count wrong (too large by 5) for my SSD (Jetflash USB), resulting in read errors (during boot, fdisk reading the disk etc.) for those sectors. While everyth

Re: [PATCH] usb: cdc-ncm: struct usb_cdc_ncm_ndp_input_size not initialized

2012-09-07 Thread Frank Hoffmann
Hello, the mail address in the MAINTAINERS file is not correct, so I send the patch again. I hope it finds the way in the official kernel sources. -- Kind regards, Frank Hoffmann Thesycon GmbH On 06.09.2012 14:35, Frank Hoffmann wrote: Hello, we developing CDC/NCM firmware and found that t

Re: MBIM

2012-09-07 Thread Bjørn Mork
Oliver Neukum writes: > On Thursday 06 September 2012 10:17:46 Bjørn Mork wrote: >> Not really related, but I am still worrying how MBIM is going to fit >> into the usbnet model where you have a strict relation between one >> netdev and one USB interface. Do you see any way usbnet could be >> ext

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-07 Thread Richard Zhao
On Thu, Sep 06, 2012 at 05:18:29PM +0200, Marc Kleine-Budde wrote: > On 09/06/2012 05:15 PM, Richard Zhao wrote: > > Hi Marc, > > > > usbmisc_imx6q.c is only for imx6x. And for a certain running kernel, > > there will be always one driver instance. > > It's currently only for imx6q, but I've patc

[PATCH 8/29 v2] usb/gadget: remove global variable composite in composite.c

2012-09-07 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior This patch removes the global variable composite in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style

MBIM (was: Re: changing usbnet's API to better deal with cdc-ncm)

2012-09-07 Thread Oliver Neukum
On Thursday 06 September 2012 10:17:46 Bjørn Mork wrote: > Not really related, but I am still worrying how MBIM is going to fit > into the usbnet model where you have a strict relation between one > netdev and one USB interface. Do you see any way usbnet could be > extended to manage a list of net

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-07 Thread Oliver Neukum
On Friday 07 September 2012 11:55:53 Ming Lei wrote: > On Fri, Sep 7, 2012 at 1:56 AM, Oliver Neukum wrote: > > On Friday 07 September 2012 00:09:13 Ming Lei wrote: > >> On Thu, Sep 6, 2012 at 4:30 PM, Bjørn Mork wrote: > >> > Ming Lei writes: > > > >> >> Looks the introduced .tx_bundle is not n

Re: [PATCH 02/29] usb/gadget: move bind callback into driver struct usb_composite_driver

2012-09-07 Thread Sebastian Andrzej Siewior
> Would it make sense to merge patches 2, 4, 5 and 6 into a single one? > They all deal with the same thing (ie. they bring back ->bind callback) > and it seems to me like all those changes belong in a single patch as > otherwise they produce some intermediate states, which don't have clean > purpo