Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 11:19:09 Ming Lei wrote: > On Tue, Oct 9, 2012 at 4:47 PM, Oliver Neukum wrote: > > > > Using GFP_KERNEL you preclude using those in resume() and error handling. > > Please pass a gfp_t parameter. > > IMO, it is not a big deal because generally only several bytes are

Re: [PATCH 12/12] usbnet: make device out of suspend before calling usbnet_read/write_cmd

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 10:33:17 Ming Lei wrote: > On Tue, Oct 9, 2012 at 4:50 PM, Oliver Neukum wrote: > > This is awkward to use in suspend()/resume() > > Could you make both versions available? > > Good catch, thanks for your review. > > As far as I can think of, the mutex_is_locked() tr

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum wrote: > > No, the problem is autoresume. > > Suppose we have a device with two interface. Interface A be usbnet; interface > B > something you page on. Now consider that you can only resume both interfaces > and this is (and needs to be) done synchr

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 13:56:16 Ming Lei wrote: > On Wed, Oct 10, 2012 at 11:19 AM, Ming Lei wrote: > > On Tue, Oct 9, 2012 at 4:47 PM, Oliver Neukum wrote: > >> > >> Using GFP_KERNEL you preclude using those in resume() and error handling. > >> Please pass a gfp_t parameter. > > > > IMO, i

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 16:17:25 Ming Lei wrote: > On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum wrote: > > We need to use GFP_NOIO in situations the helper cannot know about. > > Please add a gfp_t parameter. Then the caller will solve that. > > Considered that most of drivers call the he

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 4:39 PM, Oliver Neukum wrote: > On Wednesday 10 October 2012 16:17:25 Ming Lei wrote: >> On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum wrote: > >> > We need to use GFP_NOIO in situations the helper cannot know about. >> > Please add a gfp_t parameter. Then the caller will

Re: [PATCH] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open

2012-10-10 Thread Oliver Neukum
On Sunday 07 October 2012 11:57:12 Constantine Shulyupin wrote: > From: Constantine Shulyupin > > Function skel_open increments usage count for the device with kref_get and > the usage count should be decremented on the function failure. > > Some last changes in function skel_open and finally c

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 17:48:54 Ming Lei wrote: > On Wed, Oct 10, 2012 at 4:39 PM, Oliver Neukum wrote: > > On Wednesday 10 October 2012 16:17:25 Ming Lei wrote: > >> On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum wrote: > > > >> > We need to use GFP_NOIO in situations the helper cannot kno

[PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open

2012-10-10 Thread Constantine Shulyupin
From: Constantine Shulyupin Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure. Some last changes in function skel_open and finally commit 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race" introdu

[PATCH 0/4 v2] Adding usb2.0 host-phy support for exynos5250

2012-10-10 Thread Vivek Gautam
This patchset is based on the work by Praveen Paneri for samsung-usbphy driver: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 Changes from v1: - squashed the patch "ARM: S3C64XX: Add phy_type to pmu_isolation" into "usb: phy: samsung: Add host phy support to samsung-phy driver

[PATCH 1/4 v2] usb: phy: samsung: Add host phy support to samsung-phy driver

2012-10-10 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy.c and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Vivek Gautam --- arch/arm/mach-exynos/setup-usb-phy.c |2 +- arch/arm/mach-s3c64xx/setup-usb-phy.c|2 +- arch/arm/plat-samsung/include/plat/usb-p

[PATCH 3/4 v2] USB: ehci-s5p: Add phy driver support

2012-10-10 Thread Vivek Gautam
Adding the transceiver to ehci driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-s5p.c | 65 +- 1 files changed, 45 insertions(+), 20 deletions(-) d

[PATCH 2/4 v2] ARM: Exynos5250: Enabling samsung-usbphy driver

2012-10-10 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the platform data. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 12 +- arch/arm/boot/dts/exynos5250.dtsi |5 ++ arch/arm/mach-exynos/Kconfig |1 + arch/arm/ma

[PATCH 4/4 v2] USB: ohci-exynos: Add phy driver support

2012-10-10 Thread Vivek Gautam
Adding the transceiver to ohci driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam --- drivers/usb/host/ohci-exynos.c | 65 +++ 1 files changed, 45 insertions(+), 20 deletions(-) d

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 6:08 PM, Oliver Neukum wrote: > > A reset always applies to the whole device. Resets are used in error > handling of block devices (storage and uas). If you reset a device, > pre_reset() and post_reset() of all interfaces need to be called. So they > are part of the SCSI e

RE: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread David Laight
> On Wed, Oct 10, 2012 at 6:08 PM, Oliver Neukum wrote: > > > A reset always applies to the whole device. Resets are used in error > > handling of block devices (storage and uas). If you reset a device, > > pre_reset() and post_reset() of all interfaces need to be called. So they > > are part of

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 12:25:58 David Laight wrote: > > On Wed, Oct 10, 2012 at 6:08 PM, Oliver Neukum wrote: > > > > > A reset always applies to the whole device. Resets are used in error > > > handling of block devices (storage and uas). If you reset a device, > > > pre_reset() and post_r

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 7:25 PM, David Laight wrote: > > What about the error handler/sleep/resume code calling into the > memory allocator to indicate that all allocates be GFP_NOIO until > it calls back to indicate that the restricted path is complete. > Might be a per-cpu count? IMO, it might

[PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Oliver Neukum
For mice with card readers the HID driver can deadlock as its post_reset() method allocates memory. GFP_NOIO must be used in a block layer error handler, which usbhid can be indirectly part of. Signed-off-by: Oliver Neukum CC: sta...@kernel.org --- drivers/hid/hid-core.c|7 ++- d

[PATCH v6] Enable USB peripheral mode on dm365 EVM

2012-10-10 Thread Constantine Shulyupin
From: Constantine Shulyupin Sets USB PHY clock source to 24 MHz clock and call USB configuration from board initialization. Tested with OTG configuration, usb gadget g_zero on DM365 EVM connected to PC. References: Definition of USB_PHY_CTRL and PHYCLKFREQ: - http://www.makelinux.com/lib/ti/D

Re: [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote: > From: Constantine Shulyupin > > Function skel_open increments usage count for the device with kref_get and > the usage count should be decremented on the function failure. > > Some last changes in function skel_open and finall

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Jiri Kosina
On Wed, 10 Oct 2012, Oliver Neukum wrote: > For mice with card readers the HID driver can deadlock as its > post_reset() method allocates memory. GFP_NOIO must be used in a block > layer error handler, which usbhid can be indirectly part of. Hi Oliver, umm ... could you please elaborate how th

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-10 Thread Jarkko Huijts
On Tue, 2012-10-09 at 07:59 -0700, Greg KH wrote: > On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > > I have e-mailed FTDI's support to ask whether the assumptions described > > above are true and whether there is no register to read the actual > > amount of data in the hardware bu

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Bjørn Mork
Oliver Neukum writes: > For mice with card readers the HID driver can deadlock > as its post_reset() method allocates memory. GFP_NOIO > must be used in a block layer error handler, which > usbhid can be indirectly part of. I am wondering a bit where this will eventually end. Given enough time,

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 14:56:04 Jiri Kosina wrote: > On Wed, 10 Oct 2012, Oliver Neukum wrote: > > > For mice with card readers the HID driver can deadlock as its > > post_reset() method allocates memory. GFP_NOIO must be used in a block > > layer error handler, which usbhid can be indirec

[PATCH v3.6.1] usb: serial: ftdi_sio: Add missing chars_in_buffer function

2012-10-10 Thread Jarkko Huijts
From: Jarkko Huijts The driver does not wait until the hardware buffer (for data from the PC to the UART line) is drained when tcdrain or close is called in an application. Solution: Implement a chars_in_buffer function that checks both the software and hardware buffer. If the TEMT (TX empty) bit

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 15:11:29 Bjørn Mork wrote: > Oliver Neukum writes: > > > For mice with card readers the HID driver can deadlock > > as its post_reset() method allocates memory. GFP_NOIO > > must be used in a block layer error handler, which > > usbhid can be indirectly part of. > >

[PATCH 0/3] USB: dwc3: Add suspend/resume support

2012-10-10 Thread Vikas C Sajjan
From: Vikas Sajjan This patchset adds suspend/resume functionality to dwc3-core layer and xhci-platform driver. It also adds S2R support to dwc3-exynos glue layer. Based on 'usb-next' branch. Vikas Sajjan (3): usb: dwc3: Add the suspend/resume functionality usb: xhci: Add the suspend/resume

[PATCH 1/3] usb: dwc3: Add the suspend/resume functionality

2012-10-10 Thread Vikas C Sajjan
From: Vikas Sajjan Adding the suspend and resume funtionality to DWC3 core. Signed-off-by: Abhilash Kesavan Signed-off-by: Vikas C Sajjan CC: Doug Anderson --- drivers/usb/dwc3/core.c | 268 +- 1 files changed, 169 insertions(+), 99 deletions(-)

[PATCH 2/3] usb: xhci: Add the suspend/resume functionality

2012-10-10 Thread Vikas C Sajjan
From: Vikas Sajjan Adding the suspend and resume functionality for the XHCI driver Signed-off-by: Abhilash Kesavan Signed-off-by: Vikas C Sajjan CC: Doug Anderson --- drivers/usb/host/xhci-plat.c | 44 ++ 1 files changed, 44 insertions(+), 0 deletion

[PATCH 3/3] exynos5: usb: dwc3: Add the suspend/resume functionality

2012-10-10 Thread Vikas C Sajjan
From: Vikas Sajjan Adding the suspend and resume functionality to exynos dwc3 driver Signed-off-by: Abhilash Kesavan Signed-off-by: Vikas C Sajjan CC: Doug Anderson --- drivers/usb/dwc3/dwc3-exynos.c | 60 1 files changed, 60 insertions(+), 0 deleti

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 8:20 PM, Oliver Neukum wrote: > For mice with card readers the HID driver can deadlock > as its post_reset() method allocates memory. GFP_NOIO > must be used in a block layer error handler, which > usbhid can be indirectly part of. IMO, this kind of "fix" should be discuss

[PATCH v3] USB: usb-skeleton.c: fix compilation error and restored kref_put on fail in skel_open

2012-10-10 Thread Constantine Shulyupin
From: Constantine Shulyupin Fixing compilaton error. Incrementing usage counter only on successful execution of skel_open. Removing redundant locking Some last changes in function skel_open and finally commit 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race" introduced a bug in func

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 22:07:02 Ming Lei wrote: > On Wed, Oct 10, 2012 at 8:20 PM, Oliver Neukum wrote: > > For mice with card readers the HID driver can deadlock > > as its post_reset() method allocates memory. GFP_NOIO > > must be used in a block layer error handler, which > > usbhid can b

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Bjørn Mork
Oliver Neukum writes: > On Wednesday 10 October 2012 15:11:29 Bjørn Mork wrote: > >> won't hurt that much, it feels somewhat wrong to put unnecessary >> restrictions into all existing interface drivers just because there is >> some device which in theory could cause the driver to lockup. After >>

Re: USB-OTG enabled phone mount desktop partitions via USB port

2012-10-10 Thread Alan Stern
On Tue, 9 Oct 2012, 杨苏立 Yang Su Li wrote: > That's great! > > They do have a newer net2282 board though. That's not supported by Linux? It is. The same driver supports both net2280 and net2282. > Also, seems like if I want to use this board to resemble an USB mass > storage (which is backed by

Re: [PATCH v2 4/4] usb: refine phy notify operation during connection and disconnection

2012-10-10 Thread Alan Stern
On Wed, 10 Oct 2012, Peter Chen wrote: > > That means the first patch breaks the code. People running "git > > bisect" might happen to hit a commit in between the two patches, and > > their kernels won't compile. That's not acceptable. > > So, a good practice is merging .h (changed API) and .

locking, reset, memory allocations and deadlocks

2012-10-10 Thread Oliver Neukum
Hi, Ming Lei made me look. I found a scenario I don't like. Suppose we have a device with two interfaces #1 and #0 Let #1 be storage and #0 be vendor specific and the skeleton driver bound to it. CPU A

Re: About resume time optimization for bus resume routine

2012-10-10 Thread Alan Stern
On Wed, 10 Oct 2012, Peter Chen wrote: > On Tue, Oct 09, 2012 at 11:03:47AM -0400, Alan Stern wrote: > > On Tue, 9 Oct 2012, Peter Chen wrote: > > > > > Hi Alan, > > > > > > When I try to optimize system resume time, I find bus resume routine > > > cost much time (> 20ms), even there is no devic

Re: locking, reset, memory allocations and deadlocks

2012-10-10 Thread Alan Stern
On Wed, 10 Oct 2012, Oliver Neukum wrote: > Hi, > > Ming Lei made me look. I found a scenario I don't like. > Suppose we have a device with two interfaces #1 and #0 > Let #1 be storage and #0 be vendor specific and the skeleton driver bound to > it. > > > CPU A

Re: [PATCH v3.6.1] usb: serial: ftdi_sio: Add missing chars_in_buffer function

2012-10-10 Thread Alan Cox
On Wed, 10 Oct 2012 15:05:06 +0200 Jarkko Huijts wrote: > From: Jarkko Huijts > > The driver does not wait until the hardware buffer (for data from the PC to > the > UART line) is drained when tcdrain or close is called in an application. > Solution: Implement a chars_in_buffer function that c

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Ming Lei
Oliver, sorry for missing list. On Wed, Oct 10, 2012 at 10:12 PM, Oliver Neukum wrote: > Which components? We generally don't do that. We may have > a problem with locks being held though. As I pointed out before, rebind may be involved to reset path, and probe(), disconnect(), some sysfs thing

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Alan Stern
On Thu, 11 Oct 2012, Ming Lei wrote: > Oliver, sorry for missing list. > > On Wed, Oct 10, 2012 at 10:12 PM, Oliver Neukum wrote: > > > Which components? We generally don't do that. We may have > > a problem with locks being held though. > > As I pointed out before, rebind may be involved to r

[RFC] net: usbnet: add pre and post_reset support

2012-10-10 Thread Bjørn Mork
Signed-off-by: Bjørn Mork --- What do you think about something like this? Does it have to be more complicated? Somewhat tested, and seems to do the job for me. drivers/net/usb/usbnet.c | 32 include/linux/usb/usbnet.h |2 ++ 2 files changed, 34 inserti

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-10 Thread Dmitry Torokhov
Jiri, Are you OK with this change? Yann, Is the device usable at all with generic HID driver? If it isn't then maybe we should blacklist it unconditionally? Thanks. On Sat, Oct 06, 2012 at 03:14:46PM +0200, Yann Cantin wrote: > > Signed-off-by: Yann Cantin > --- > drivers/hid/hid-core.c |

[PATCH 0/3] various minor cleanup for usbip

2012-10-10 Thread Bart Westgeest
Mainly cosmetic changes Bart Westgeest (3): staging: usbip: replaced pointer arithmetic, and strongly type function return. staging: usbip: make rh_port_disconnect static staging: usbip: cleanup of comments drivers/staging/usbip/stub_dev.c | 10 - drivers/staging/usbip/st

[PATCH 1/3] staging: usbip: replaced pointer arithmetic, and strongly type function return.

2012-10-10 Thread Bart Westgeest
Replaced pointer arithmetic by using array indexing, and changed function return type for usbip_alloc_iso_desc_pdu from 'void*' to 'struct usbip_iso_packet_descriptor'. Signed-off-by: Bart Westgeest --- drivers/staging/usbip/stub_tx.c |2 +- drivers/staging/usbip/usbip_common.c | 23 +

[PATCH 2/3] staging: usbip: make rh_port_disconnect static

2012-10-10 Thread Bart Westgeest
Signed-off-by: Bart Westgeest --- drivers/staging/usbip/vhci.h |1 - drivers/staging/usbip/vhci_hcd.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/usbip/vhci.h b/drivers/staging/usbip/vhci.h index c66b8b3..5dddc4d 100644 --- a/drivers/staging/us

[PATCH 3/3] staging: usbip: cleanup of comments

2012-10-10 Thread Bart Westgeest
Removed commented-out code, obsolete comments, and fixed comment typos. Signed-off-by: Bart Westgeest --- drivers/staging/usbip/stub_dev.c | 10 -- drivers/staging/usbip/stub_rx.c |5 ++--- drivers/staging/usbip/stub_tx.c |1 - drivers/staging/usbip/usbip_common.c

Re: [PATCH 2/3] usb: xhci: Add the suspend/resume functionality

2012-10-10 Thread Sarah Sharp
On Wed, Oct 10, 2012 at 07:35:48PM +0530, Vikas C Sajjan wrote: > From: Vikas Sajjan > > Adding the suspend and resume functionality for the XHCI driver > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vikas C Sajjan > CC: Doug Anderson Acked-by: Sarah Sharp Felipe, you want to take th

[PATCH] USB: fix port probing and removal in garmin_gps

2012-10-10 Thread Alan Stern
This patch (as1615) fixes a bug in the Garmin USB serial driver. It uses attach, disconnect, and release routines to carry out actions that should be handled by port_probe and port_remove routines, because they access port-specific data. The bug causes an oops when the device in unplugged, becaus

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Oliver Neukum
On Thursday 11 October 2012 00:00:20 Ming Lei wrote: > > This is much harder than it sounds. > > Keeping allowed gfp_flag inside task_struct should be one solution, and > let that teach mm to allocate memory, see the draft idea below: Very clever. However, how hot are the code paths you are addi

Re: [RFC] net: usbnet: add pre and post_reset support

2012-10-10 Thread Oliver Neukum
On Wednesday 10 October 2012 18:34:52 Bjørn Mork wrote: > Signed-off-by: Bjørn Mork > --- > What do you think about something like this? Does it have to > be more complicated? Somewhat tested, and seems to do the > job for me. Looks good. Which minidriver did you test with? Regards

[PATCH 3.6.0- 0/7] USB: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla Running below Coccinelle lookup pattern like below on the latest kernel showed about 52 hits. This patch series is a subset of those 52 patches, so that it will be easy for maintainers to review. Hopefully these patches will get rid of some code duplication in kernel.

[PATCH 3.6.0- 1/7] usb/am35x: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/am35x.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/

[PATCH 3.6.0- 2/7] usb/blackfin: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/blackfin.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb

[PATCH 3.6.0- 3/7] usb/da8xx: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/da8xx.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/

[PATCH 3.6.0- 4/7] usb/davinci: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/davinci.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/m

[PATCH 3.6.0- 6/7] usb/ux500: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/ux500.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/

[PATCH 3.6.0- 7/7] usb/mv_otg: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/otg/mv_otg.c | 14 +- 1 files changed, 1 insertions(+), 13 deletions(-) diff --git a/drivers/usb/otg/mv_otg.c b/drivers/usb/otg/

[PATCH 3.6.0- 5/7] usb/tusb6010: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla --- drivers/usb/musb/tusb6010.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/tusb6010.c b/drivers/usb

pre_reset() in bas-gigaset.c

2012-10-10 Thread Oliver Neukum
Hi, I was looking at the driver and saw potential problems. As pre_reset() and suspend() are identical there is a problem with resetting. /* kill all URBs and delayed work that might still be pending */ usb_kill_urb(ucs->urb_ctrl); usb_kill_urb(ucs->urb_int_in); d

Re: [RFT] usb: Don't enable LPM if the exit latency is zero.

2012-10-10 Thread Gabor Takacs
Dear Sarah, > Great, I'm glad your disk works now! > > You can check if the roothub goes into a low power state by watching > whether the parent hub reports U0 or U1/U2 in its port status registers. > You can do this by running > > watch -n 1 'sudo lsusb -v -d 1d6b:0003 | grep "Hub Port Status" -A4

[no subject]

2012-10-10 Thread United Seabears Corp.
Hi there: I am seeking assistance with a USB Wimax modem for Sprint/Virgin Mobile to be used on a laptop with Kubuntu 12.04 and/or 12.10. The modem is a 3G/4G modem, Franklin Wireless U600 and Beceem ??? for the 4G part. It is activated via Windows and has an active Virgin Mobile account. At t

Re: [RFC] net: usbnet: add pre and post_reset support

2012-10-10 Thread Bjørn Mork
Oliver Neukum writes: > On Wednesday 10 October 2012 18:34:52 Bjørn Mork wrote: >> Signed-off-by: Bjørn Mork >> --- >> What do you think about something like this? Does it have to >> be more complicated? Somewhat tested, and seems to do the >> job for me. > > Looks good. Which minidriver did yo

[PATCH 1/3] USB: EHCI: move logging macros to ehci.h

2012-10-10 Thread Alan Stern
In preparation for splitting the ehci-hcd driver into a core library and separate platform-specific driver modules, this patch (as1616) moves the console logging macros from ehci-dbg.c to ehci.h, where they will be available to the platform drivers. Signed-off-by: Alan Stern --- drivers/usb/ho

[PATCH 2/3] USB: EHCI: make ehci_read_frame_index platform independent

2012-10-10 Thread Alan Stern
In preparation for splitting the ehci-hcd driver into a core library and separate platform-specific driver modules, this patch (as1617) changes the way ehci_read_frame_index() is handled. Since the same core library will have to work with both PCI and non-PCI platforms, the quirk handler routine w

[PATCH 3/3] USB: EHCI: move ehci_update_device() to ehci-lpm.c

2012-10-10 Thread Alan Stern
In preparation for splitting the ehci-hcd driver into a core library and separate platform-specific driver modules, this patch (as1618) moves ehci_update_device() from a couple of platform-specific source files into ehci-lpm.c. This is where it should have been all along, since all it does is call

Re: [PATCH v6] Enable USB peripheral mode on dm365 EVM

2012-10-10 Thread Sergei Shtylyov
Hello. On 10-10-2012 14:33, Constantine Shulyupin wrote: From: Constantine Shulyupin Sets USB PHY clock source to 24 MHz clock and call USB configuration from board initialization. Tested with OTG configuration, usb gadget g_zero on DM365 EVM connected to PC. References: Definition of USB

Re: [PATCH v6] Enable USB peripheral mode on dm365 EVM

2012-10-10 Thread Constantine Shulyupin
Sekhar Nori: Looks like all PHY related configuration is currently happening in drivers/usb/musb/davinci.c and the same register is also being written to for other platforms. Can you move the code you have included in board file to the driver? As we move towards DT, we need to avoid register config

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

2012-10-10 Thread Oliver Neukum
On Friday 28 September 2012 16:16:04 j...@eclis.ch wrote: > From: Jean-Christian de Rivaz > > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572 > and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized. > > Reference: > http://www.conexant.com/servlets/Downl

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-10 Thread Greg KH
On Wed, Oct 10, 2012 at 03:05:09PM +0200, Jarkko Huijts wrote: > On Tue, 2012-10-09 at 07:59 -0700, Greg KH wrote: > > On Tue, Oct 09, 2012 at 12:21:56PM +0200, Jarkko Huijts wrote: > > > I have e-mailed FTDI's support to ask whether the assumptions described > > > above are true and whether there

Re: [RFC] net: usbnet: add pre and post_reset support

2012-10-10 Thread Sergei Shtylyov
Hello. On 10-10-2012 18:34, Bjørn Mork wrote: Signed-off-by: Bjørn Mork --- What do you think about something like this? Does it have to be more complicated? Somewhat tested, and seems to do the job for me. drivers/net/usb/usbnet.c | 32 include/linux

Re: [RFC] net: usbnet: add pre and post_reset support

2012-10-10 Thread Bjørn Mork
Sergei Shtylyov wrote: >Hello. > >On 10-10-2012 18:34, Bjørn Mork wrote: > >> Signed-off-by: Bjørn Mork >> --- >> What do you think about something like this? Does it have to >> be more complicated? Somewhat tested, and seems to do the >> job for me. >> >> >> drivers/net/usb/usbnet.c | 32

REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers

2012-10-10 Thread Henrik Rydberg
Hi Hans, Alan, Greg, commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a Author: Hans de Goede Date: Wed Jul 4 09:18:03 2012 +0200 usbdevfs: Use scatter-gather lists for large bulk transfers breaks an usb programming cable over here. The problem is reported as "bulk tranfer failed" [sic]

Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers

2012-10-10 Thread Peter Stuge
Hej Henrik, Henrik Rydberg wrote: > commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a > Author: Hans de Goede > Date: Wed Jul 4 09:18:03 2012 +0200 > > usbdevfs: Use scatter-gather lists for large bulk transfers > > breaks an usb programming cable over here. The problem is reported as >

Re: USB-OTG enabled phone mount desktop partitions via USB port

2012-10-10 Thread 杨苏立 Yang Su Li
Hi, Thank you all for the enormous help. I have already asked the lab to order net2280/net2282 for me. And I will repo what I get once I set this thing up. Best. Suli On Wed, Oct 10, 2012 at 9:21 AM, Alan Stern wrote: > On Tue, 9 Oct 2012, 杨苏立 Yang Su Li wrote: > >> That's great! >> >> They d

Re: [RFT] usb: Don't enable LPM if the exit latency is zero.

2012-10-10 Thread Sarah Sharp
On Wed, Oct 10, 2012 at 09:01:01PM +0200, Gabor Takacs wrote: > Dear Sarah, > > Great, I'm glad your disk works now! > > > > You can check if the roothub goes into a low power state by watching > > whether the parent hub reports U0 or U1/U2 in its port status registers. > > You can do this by runni

Re: Etron USB 3.0 xHCI

2012-10-10 Thread Matthew Hall
On Mon, Oct 08, 2012 at 02:34:24PM -0700, Gary E. Miller wrote: > > The error you're getting seems to me to indicate a > > hardware issue, and I'm really not sure how to solve it. > > Could be, I find many people have problems with the chip. > > > > Cards with the Etron chip on them are $14 on ne

Re:3G/4G modem Wireless U600

2012-10-10 Thread Thomas Schäfer
Am Mittwoch, 10. Oktober 2012 um 21:02:02 schrieb United Seabears Corp.: > Hi there: > > I am seeking assistance with a USB Wimax modem for Sprint/Virgin Mobile > to be used on a laptop with Kubuntu 12.04 and/or 12.10. The modem is a > 3G/4G modem, Franklin Wireless U600 and Beceem ??? for the 4G

Re: [ebeam PATCH v2 1/2] hid: Blacklist eBeam devices

2012-10-10 Thread Yann Cantin
Hi, Le 10/10/2012 18:37, Dmitry Torokhov a écrit : > Is the device usable at all with generic HID driver? If it isn't then > maybe we should blacklist it unconditionally? Without the libusb based proprietary stack, the device is unusable under linux. If i correctly understand, libusb need a driv

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

2012-10-10 Thread Jean-Christian de Rivaz
On Wed, Oct 10, 2012 at 09:42:32PM +0200, Oliver Neukum wrote: > On Friday 28 September 2012 16:16:04 j...@eclis.ch wrote: > > From: Jean-Christian de Rivaz > > > > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572 > > and device ID 0x1340. It need the NO_UNION_NORMAL quirk t

Re: Re:3G/4G modem Wireless U600

2012-10-10 Thread Dan Williams
On Wed, 2012-10-10 at 23:46 +0200, Thomas Schäfer wrote: > Am Mittwoch, 10. Oktober 2012 um 21:02:02 schrieb United Seabears Corp.: > > Hi there: > > > > I am seeking assistance with a USB Wimax modem for Sprint/Virgin Mobile > > to be used on a laptop with Kubuntu 12.04 and/or 12.10. The modem is

Re: Etron USB 3.0 xHCI

2012-10-10 Thread Gary E. Miller
Yo Matthew! On Wed, 10 Oct 2012 14:15:33 -0700 Matthew Hall wrote: > I'm wondering, what are my other options? How can I go about > acquiring a PCIe card that uses a known-good working USB 3.0 chip > instead? Or what else can I do to sort this issue out? I just got one of these with the VLI VL8

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-10 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I [120919 04:32]: > Added a driver for usb3 phy that handles the interaction between usb phy > device and dwc3 controller. > > This also includes device tree support for usb3 phy driver and > the documentation with device tree binding information is updated. > > Curre

[PATCH] usb: renesas_usbhs: add DMAEngine support on mod_host

2012-10-10 Thread Kuninori Morimoto
This patch enabled dma mapping, and used dma transfer handler on mod_host Signed-off-by: Kuninori Morimoto --- Felipe I sent some patches before, and I guess it will go to v3.8 branch. please let me know if you want me to resend these. drivers/usb/renesas_usbhs/mod_host.c | 17 ++

[PATCH] usb: renesas_usbhs: return -EINVAL if scatter/gather type DMA

2012-10-10 Thread Kuninori Morimoto
renesas_usbhs can't handle scatter/gather type DMA. Thus, return -EINVAL is better than WARNING() on mod_gadget Signed-off-by: Kuninori Morimoto --- drivers/usb/renesas_usbhs/mod_gadget.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadge

Re: [PATCH] usbhid: use GFP_NOIO in reset code path

2012-10-10 Thread Ming Lei
On Thu, Oct 11, 2012 at 12:20 AM, Alan Stern wrote: > This makes a lot of sense. It remains to be seen whether you can > convince the people on LKML to allow a new field to be added to > task_struct. If the idea can fix the kind of problem, I mean other block devices might have the problem too,

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-10 Thread Ming Lei
On Wed, Oct 10, 2012 at 1:51 PM, Oliver Neukum wrote: > > No, the problem is autoresume. > > Suppose we have a device with two interface. Interface A be usbnet; interface > B > something you page on. Now consider that you can only resume both interfaces > and this is (and needs to be) done synchr

Re: About resume time optimization for bus resume routine

2012-10-10 Thread Peter Chen
On Wed, Oct 10, 2012 at 10:48:39AM -0400, Alan Stern wrote: > On Wed, 10 Oct 2012, Peter Chen wrote: > > > On Tue, Oct 09, 2012 at 11:03:47AM -0400, Alan Stern wrote: > > > On Tue, 9 Oct 2012, Peter Chen wrote: > > > > > > > Hi Alan, > > > > > > > > When I try to optimize system resume time, I f

Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers

2012-10-10 Thread Henrik Rydberg
On Wed, Oct 10, 2012 at 10:34:59PM +0200, Peter Stuge wrote: > Hej Henrik, > > Henrik Rydberg wrote: > > commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a > > Author: Hans de Goede > > Date: Wed Jul 4 09:18:03 2012 +0200 > > > > usbdevfs: Use scatter-gather lists for large bulk transfers > >

RE: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

2012-10-10 Thread Manjunathappa, Prakash
Hi, On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote: > From: Constantine Shulyupin > > Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly > CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MUSB_HOST > and set MUSB_OTG configuration by default > because th

Re: RE: [PATCH] usb: remove CONFIG_USB_MUSB_HOST etc

2012-10-10 Thread Heiko Schocher
Hello Manjunathappa On 11.10.2012 07:42, Manjunathappa, Prakash wrote: Hi, On Mon, Oct 08, 2012 at 18:47:07, Constantine Shulyupin wrote: From: Constantine Shulyupin Remove USB configuration in arch/arm/mach-davinci/usb.c accordingly CONFIG_USB_MUSB_OTG CONFIG_USB_MUSB_PERIPHERAL CONFIG_USB_MU

Re: REGRESSION: usbdevfs: Use-scatter-gather-lists-for-large-bulk-transfers

2012-10-10 Thread Peter Stuge
Henrik Rydberg wrote: > > What is the programming cable and software that uses it? > > The programmer is impact, using libusbx-1.0.14-1. Do you know for a fact that your version calls libusb-1.0? Did you establish this with e.g. strace? ISE 11.1 impact uses only libusb.so, ie. libusb-0.1. Depend