This patchset fixes two problems:
- Add correct phy notify operation during connect/disconnect
- Change phy notify's API
---
Changes for v5:
- Split patchset, and move out phy notify_suspend/resume for later
submission.
Changes for v4:
- Delete useless lines which forgot to delete at last patch.
The real reason causes mx23 fail are:
- Calling mxs_phy_hw_init(mxs_phy) again at connection
- Error connect/disconnect nodity at hub.c
The coming patch will fix above two problems, Mike Thompson
tested his hardware works OK after commented out this delay
setting.
This reverts commit 363366cf61c
As phy is working, re-init phy may cause unexpected results
Signed-off-by: Peter Chen
---
drivers/usb/otg/mxs-phy.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c
index c1a67cb..5b09f33 100644
--- a/drivers/usb/otg/m
At commit 925aa46ba963a4da6d8ee6ab1d04a02ffa8db62b, Richard Zhao
adds the phy notification callback
when port change occurs. In fact, this phy notification should
be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during high speed host mode.
2. Do not set HW_USBPHY_
The old parameter "port" is useless for phy notify, as one usb
phy is only for one usb port. New parameter "speed" stands for
the device's speed which is on the port, this "speed" parameter
is needed at some platforms which will do some phy operations
according to device's speed.
Signed-off-by: Pe
On Mon, Oct 22, 2012 at 03:33:19AM +, Li Yang-R58472 wrote:
>
>
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Saturday, October 20, 2012 1:37 AM
> > To: Simon Haggett
> > Cc: Li Yang-R58472; Felipe Balbi; Greg Kroah-Hartman; linux-
> > u...@vger.kernel.
Hi,
On Sat, Oct 20, 2012 at 09:12:27PM +0200, Christoph Fritz wrote:
> On Fri, 2012-10-19 at 13:44 +0300, Felipe Balbi wrote:
> > > I thought about this too but wasn't able to use chipidea with
> > > MXC_EHCI_INTERNAL_PHY as it's called in fsl_udc.
> >
> > that's a matter of writing the PHY drive
Hi,
On Fri, Oct 19, 2012 at 10:29:35AM -0600, Stephen Warren wrote:
> On 10/19/2012 09:35 AM, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Oct 19, 2012 at 04:08:05PM +0530, Venu Byravarasu wrote:
> >> NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc. In
> >> order to support USB PHY dri
On Friday, October 19, 2012 5:27 PM Felipe Balbi wrote:
> > I think what we want here is a possibility to configure multiple
> > functions in one gadget (under one udc, in other words).
>
> eventually, but not until we do the ground work/housekeeping to get there.
> We definitely don't want to
Hello, Anil Nair!
Nice to meet you.
Thanks for the information!Are you right by the following recognition?
->The relations of the client and the server are reverse.
■Configuration of the "USB/IP"
###
# Application #-guvcview etc..
### ##
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, October 19, 2012 9:06 PM
> To: Venu Byravarasu
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
> ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v3 resen
The patch introduces the flag of memalloc_noio_resume in
'struct dev_pm_info' to help PM core to teach mm not allocating
memory with GFP_KERNEL flag for avoiding probable deadlock
problem.
As explained in the comment, any GFP_KERNEL allocation inside
runtime_resume on any one of device in the path
This patch applyes the introduced pm_runtime_set_memalloc_noio on
block device so that PM core will teach mm to not allocate memory with
GFP_IOFS when calling the runtime_resume callback for block devices.
Cc: Jens Axboe
Signed-off-by: Ming Lei
---
block/genhd.c |8
1 file changed,
Deadlock might be caused by allocating memory with GFP_KERNEL in
runtime_resume callback of network devices in iSCSI situation, so
mark network devices and its ancestor as 'memalloc_noio_resume'
with the introduced pm_runtime_set_memalloc_noio().
Cc: "David S. Miller"
Cc: Eric Dumazet
Cc: David
This patch applies the introduced memalloc_noio_save() and
memalloc_noio_restore() to force memory allocation with no I/O
during runtime_resume callback on device which is marked as
memalloc_noio_resume.
Cc: Alan Stern
Cc: Oliver Neukum
Cc: Rafael J. Wysocki
Signed-off-by: Ming Lei
---
driver
If one storage interface or usb network interface(iSCSI case)
exists in current configuration, memory allocation with
GFP_KERNEL during usb_device_reset() might trigger I/O transfer
on the storage interface itself and cause deadlock because
the 'us->dev_mutex' is held in .pre_reset() and the storag
This patch introduces PF_MEMALLOC_NOIO on process flag('flags' field of
'struct task_struct'), so that the flag can be set by one task
to avoid doing I/O inside memory allocation in the task's context.
The patch trys to solve one deadlock problem caused by block device,
and the problem may happen
Hi,
This patchset try to solve one deadlock problem which might be caused
by memory allocation with block I/O during runtime resume and block device
error handling path. Traditionly, the problem is addressed by passing
GFP_NOIO statically to mm, but that is not a effective solution, see
detailed d
This commit sets removable subclass for Casio EX-N1 digital camera.
Signed-off-by: Oleksandr Chumachenko
Signed-off-by: Michael Shigorin
---
The patch has been tested within an ALT Linux kernel:
http://git.altlinux.org/people/led/packages/?p=kernel-image-3.0.git;a=commitdiff;h=c0fd891836e89fe0c
Hi,
On Mon, Oct 22, 2012 at 02:00:00PM +0530, Venu Byravarasu wrote:
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Friday, October 19, 2012 9:06 PM
> > To: Venu Byravarasu
> > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
> > ba...@ti.com; linux
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Monday, October 22, 2012 3:33 PM
> To: Venu Byravarasu
> Cc: ba...@ti.com; st...@rowland.harvard.edu;
> gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH v3 res
Hi,
On Mon, Oct 22, 2012 at 03:47:02PM +0530, Venu Byravarasu wrote:
> > -Original Message-
> > From: Felipe Balbi [mailto:ba...@ti.com]
> > Sent: Monday, October 22, 2012 3:33 PM
> > To: Venu Byravarasu
> > Cc: ba...@ti.com; st...@rowland.harvard.edu;
> > gre...@linuxfoundation.org; linux
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Monday, October 22, 2012 3:46 PM
> To: Venu Byravarasu
> Cc: ba...@ti.com; st...@rowland.harvard.edu;
> gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH v3 res
* Sergei Shtylyov | 2012-10-17 23:38:20 [+0200]:
>Hello.
Hi Sergei,
>On 17-10-2012 21:06, Sebastian Andrzej Siewior wrote:
>
>>--- a/drivers/usb/gadget/serial.c
>>+++ b/drivers/usb/gadget/serial.c
>>@@ -129,19 +129,33 @@ MODULE_PARM_DESC(n_ports, "number of ports to create,
>>default=1");
>>
Hi,
On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:
> On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:
> > On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote:
> > > Some gadget drivers may attempt to dequeue requests for an endpoint
> > > that has already been disabled
Hi,
On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote:
> Hi,
>
> On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:
> > On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:
> > > On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote:
> > > > Some gadget drivers m
* Andrzej Pietrasiewicz | 2012-10-18 13:17:18 [+0200]:
>Hello Sebastian,
Hi Andrzej,
>Thank you for the patches. By no means am I questioning your work;
>I have a question, though. Please see inline.
Feel free to question my work. If you have a better idea of doing
something, feel free to bring
* Andrzej Pietrasiewicz | 2012-10-18 14:45:14 [+0200]:
>Hello Sebastian,
Hi Andrzej,
>Which Linux version does this patch apply to?
This is
- v3.7-rc1
- Greg's stable/next
- Felipe's master
- my pending series (need to address review)
If you pull from
git://git.linutronix.de/users/bigeasy/
Hi Alan,
I will update the patch with necessary comments and repush.However,do
you think this patch may cause some other deleterious effects?
On Thu, Oct 18, 2012 at 10:52 PM, Alan Stern wrote:
> On Thu, 18 Oct 2012, megha dey wrote:
>
>> While trying to copy some file(>400 MB) from PC to devic
Hi
On 22/10/12 11:47, Laurent Pinchart wrote:
Hi,
On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote:
On Saturday, October 20, 2012 1:37 AM Felipe Balbi wrote:
On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote:
Some gadget drivers may attempt to dequeue requests for an endpo
On Monday, October 22, 2012 1:03 PM Sebastian Andrzej Siewior wrote:
> * Andrzej Pietrasiewicz | 2012-10-18 13:17:18 [+0200]:
>
> >Hello Sebastian,
> Hi Andrzej,
>
>
> This should not happen, I should have put the module.
>
> >Even if the caller did call usb_put_function, the uf->mod is no
[+ Sekhar, Vaibhav, Afzal]
On 17.10.2012 16:32, Daniel Mack wrote:
> I've spent some time rebasing assorted patches for AM33xx SoC USB
> interfaces onto 3.7-rc1 and I thought they might be interesting to
> others, so I share them here.
>
> One thing I had to do in order to get it working was reve
On Mon, 22 Oct 2012, Tony Prisk wrote:
> I suspected this might be a problem when I first looked at the ehci
> code, and in working on the ehci-platform driver recently it has become
> apparent this is actually going to be a problem in the near future.
>
> Because of the way ehci-hcd includes the
On Mon, Oct 22, 2012 at 10:13:07AM -0400, Alan Stern wrote:
> On Mon, 22 Oct 2012, Tony Prisk wrote:
>
> > I suspected this might be a problem when I first looked at the ehci
> > code, and in working on the ehci-platform driver recently it has become
> > apparent this is actually going to be a pro
On Mon, 22 Oct 2012, Felipe Balbi wrote:
> Hi,
>
> On Fri, Oct 19, 2012 at 10:29:35AM -0600, Stephen Warren wrote:
> > On 10/19/2012 09:35 AM, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Fri, Oct 19, 2012 at 04:08:05PM +0530, Venu Byravarasu wrote:
> > >> NVIDIA produces several Tegra SoCs viz
Hi Daniel,
* Daniel Mack, October 22, 2012 6:44 PM:
> [+ Sekhar, Vaibhav, Afzal]
> And what about these patches in general? I got bounces for the address
> Ajay Kumar Gupta who is the original author of most
> of them, and I wonder whether he isn't working for TI (and consequently
> on this pat
* Andrzej Pietrasiewicz | 2012-10-22 10:13:48 [+0200]:
>Perhaps I should have been more explicit about this: by RFC I mean something
>not intended for merging yet but rather a proof of concept or the like.
>
>However, I am confused taken this:
>
>http://marc.info/?l=linux-usb&m=132431126927355&w=2
On 22.10.2012 16:25, Mohammed, Afzal wrote:
> * Daniel Mack, October 22, 2012 6:44 PM:
>
>> [+ Sekhar, Vaibhav, Afzal]
>
>> And what about these patches in general? I got bounces for the address
>> Ajay Kumar Gupta who is the original author of most
>> of them, and I wonder whether he isn't work
On Mon, 22 Oct 2012, Ming Lei wrote:
> +void pm_runtime_set_memalloc_noio(struct device *dev, bool enable)
> +{
> + dev->power.memalloc_noio_resume = enable;
> +
> + if (!dev->parent)
> + return;
> +
> + if (enable) {
> + pm_runtime_set_memalloc_noio(dev->parent
On Mon, 22 Oct 2012, Ming Lei wrote:
> If one storage interface or usb network interface(iSCSI case)
> exists in current configuration, memory allocation with
> GFP_KERNEL during usb_device_reset() might trigger I/O transfer
> on the storage interface itself and cause deadlock because
> the 'us->d
On Mon, 22 Oct 2012, megha dey wrote:
> Hi Alan,
> I will update the patch with necessary comments and repush.However,do
> you think this patch may cause some other deleterious effects?
If I did, I wouldn't have said it was okay.
Alan Stern
--
To unsubscribe from this list: send the line "uns
* Alan Stern | 2012-09-21 14:25:58 [-0400]:
>On Fri, 21 Sep 2012, Sebastian Andrzej Siewior wrote:
>
>> DMA_ADDR_INVALID is used by the UDC driver and the gadgets should
>> provide only a buffer address. Everything else should be taken core of
>> by the UDC and udc-core.
>>
>> Signed-off-by: Seba
On Sun, 21 Oct 2012, Tony Prisk wrote:
> +static u64 ehci_dma_mask = DMA_BIT_MASK(32);
...
> + /* Right now device-tree probed devices don't get dma_mask set.
> + * Since shared usb code relies on it, set it here for now.
> + * Once we have dma capability bi
On Sun, 21 Oct 2012, Charlie Sager wrote:
> ok, here is the output from lsusb -v
> just the device in question.
>
>
>
> Bus 002 Device 002: ID 1808:
> Couldn't open device, some information will be missing
> Device Descriptor:
>bLength18
>bDescriptorT
Hello,
> ■Configuration of the "usb-vhci"
>
>###
># Application #-guvcview etc..
>### ##
># Server #--[network]--# Client #
>### ##~~~(USB Device)
>
>-OS: Linux
On Sun, 21 Oct 2012, Artem S. Tashkinov wrote:
> dmesg messages up to a crash can be seen here:
> https://bugzilla.kernel.org/attachment.cgi?id=84221
The first problem in the log is endpoint list corruption. Here's a
debugging patch which should provide a little more information.
Alan Stern
On 22.10.2012 17:17, Alan Stern wrote:
> On Sun, 21 Oct 2012, Artem S. Tashkinov wrote:
>
>> dmesg messages up to a crash can be seen here:
>> https://bugzilla.kernel.org/attachment.cgi?id=84221
>
> The first problem in the log is endpoint list corruption. Here's a
> debugging patch which shou
On Sun, 21 Oct 2012, Holger Hans Peter Freyther wrote:
> On Mon, Oct 15, 2012 at 04:21:47PM -0400, Alan Stern wrote:
> > On Mon, 15 Oct 2012, Holger Freyther wrote:
>
> Hi,
>
> >
> > Actually, it would help to compare two usbmon traces taken on the same
> > computer, one using xhci-hcd and the
On Mon, 22 Oct 2012, Daniel Mack wrote:
> On 22.10.2012 17:17, Alan Stern wrote:
> > On Sun, 21 Oct 2012, Artem S. Tashkinov wrote:
> >
> >> dmesg messages up to a crash can be seen here:
> >> https://bugzilla.kernel.org/attachment.cgi?id=84221
> >
> > The first problem in the log is endpoint l
On 10/20/2012 04:10 PM, Tony Prisk wrote:
> Add a binding document for ehci-platform driver.
>
> Signed-off-by: Tony Prisk
> ---
> .../devicetree/bindings/usb/ehci-platform.txt | 27
>
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/
After 2 1/2 years, I figure it's about time for a new release of
usbview, as some people still use it, and with recent kernels making
usbfs go away, there have been some reports of problems.
Big changes from the 1.1 release in 2009 is:
- gtk3 support
- use debugfs instead of obsole
On Mon, Oct 22, 2012 at 11:52:16AM -0400, Alan Stern wrote:
> On Sun, 21 Oct 2012, Holger Hans Peter Freyther wrote:
> > On Mon, Oct 15, 2012 at 04:21:47PM -0400, Alan Stern wrote:
> Unfortunately there's nothing here to indicate the cause of the
> problem. Either the scanner just stopped working
Hello Greg,
But while compiling it i am getting an error,
"checking for GTK... no
configure: error: Package requirements (gtk+-3.0 >= 3.0) were not met:
No package 'gtk+-3.0' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
A
On Oct 22, 2012, Alan Stern wrote:
> A BUG() at these points would crash the machine hard. And where we
> came from doesn't matter; what matters is the values in the pointers.
OK, here's what the kernel prints with your patch:
usb 6.1.4: ep 86 list del corruption prev: e5103b54 e5103a94 e5103
On Mon, 22 Oct 2012, Stephen Warren wrote:
> On 10/20/2012 04:10 PM, Tony Prisk wrote:
> > Add a binding document for ehci-platform driver.
> > +Optional properties:
> > +- caps-offset : offset to the capabilities register (default = 0)
> > +- has-tt : controller has transaction translator(s).
>
Anil -
On Mon, 2012-10-22 at 22:49 +0530, Anil Nair wrote:
> Hello Greg,
>
> But while compiling it i am getting an error,
>
> "checking for GTK... no
> configure: error: Package requirements (gtk+-3.0 >= 3.0) were not met:
>
> No package 'gtk+-3.0' found
...
> The OS i am using is ubuntu-11.
On 10/22/2012 11:34 AM, Alan Stern wrote:
> On Mon, 22 Oct 2012, Stephen Warren wrote:
>
>> On 10/20/2012 04:10 PM, Tony Prisk wrote:
>>> Add a binding document for ehci-platform driver.
>
>>> +Optional properties:
>>> +- caps-offset : offset to the capabilities register (default = 0)
>>> +- has-
On Mon, 2012-10-22 at 10:13 -0400, Alan Stern wrote:
> On Mon, 22 Oct 2012, Tony Prisk wrote:
>
> > I suspected this might be a problem when I first looked at the ehci
> > code, and in working on the ehci-platform driver recently it has become
> > apparent this is actually going to be a problem in
On Mon, Oct 22, 2012 at 12:37:03PM -0500, Steven J. Magnani wrote:
> Anil -
>
> On Mon, 2012-10-22 at 22:49 +0530, Anil Nair wrote:
> > Hello Greg,
> >
> > But while compiling it i am getting an error,
> >
> > "checking for GTK... no
> > configure: error: Package requirements (gtk+-3.0 >= 3.0)
On Mon, 22 Oct 2012, Artem S. Tashkinov wrote:
> OK, here's what the kernel prints with your patch:
>
> usb 6.1.4: ep 86 list del corruption prev: e5103b54 e5103a94 e51039d4
>
> A small delay before I got thousands of list_del corruption messages would
> have been nice, but I managed to catch th
On Mon, Oct 15, 2012 at 08:42:47AM +0200, Rafael J. Wysocki wrote:
> Sorry for the delay, I have been distracted by a number of things.
Me too. :)
> On Monday 24 of September 2012 15:10:36 Sarah Sharp wrote:
> > On Tue, Sep 25, 2012 at 12:09:06AM +0200, Rafael J. Wysocki wrote:
> > > What about h
On Mon, Oct 08, 2012 at 03:11:22PM +0200, Florian Fainelli wrote:
> Use the ehci platform driver power_{on,suspend,off} callbacks to perform the
> USB block gate enabling/disabling as what the ehci-au1xxx.c driver does.
> Update the db1200 and db1300 defconfigs to now select the EHCI platform
> dri
On Mon, Oct 08, 2012 at 03:11:38PM +0200, Florian Fainelli wrote:
> Convert the Alchemy platform to register the ohci-platform driver, now that
> the ohci-platform driver properly handles the specific ohci-au1xxx resume
> from suspend case.
>
> This also greatly simplifies the power_{on,off} callb
On Wed, Oct 17, 2012 at 11:39:17AM -0700, Yuliya T wrote:
> Hi Sarah,
>
> Wanted to check back on this previous report: is this a fundamental
> bug in the hardware or can there be a workaround in the XHCI driver to
> support this? I did find that if the control transfers are 512B in
> length (in
On Mon, Oct 08, 2012 at 03:11:14PM +0200, Florian Fainelli wrote:
> Hi all,
>
> This patch series contains EHCI and OHCI platform drivers conversions,
> allowing quite some EHCI and OHCI platform drivers to be deleted.
>
> While converting, Alan Stern asked me to fold some cleanups and fixes in t
Hello Greg and Steven,
>> I can't speak for Ubuntu, but on Fedora installing gtk3-devel eliminated
>> the message you describe.
>
> Yes, that is required. Anil, let me know if you have that type of
> package installed, and if after doing so, you still get the same error.
I should have googled th
On Thu, Sep 27, 2012 at 11:08:49PM +0800, Ming Lei wrote:
> There are two patches on usb hub autosuspend.
These patches no longer apply to my tree, can you refresh them against
linux-next and resend them so that I can apply them?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "
On Fri, Oct 19, 2012 at 07:18:00PM +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Oct 08, 2012 at 03:47:35PM -0700, Sarah Sharp wrote:
> > On Mon, Oct 08, 2012 at 04:05:00PM -0400, Alan Stern wrote:
> > > On Mon, 8 Oct 2012, Sarah Sharp wrote:
> > >
> > > > The Set SEL control transfer tells a devi
On Mon, 22 Oct 2012, Sarah Sharp wrote:
> On Mon, Oct 15, 2012 at 08:42:47AM +0200, Rafael J. Wysocki wrote:
> > Sorry for the delay, I have been distracted by a number of things.
>
> Me too. :)
>
> > On Monday 24 of September 2012 15:10:36 Sarah Sharp wrote:
> > > On Tue, Sep 25, 2012 at 12:09:
Hi
I have come across a scenario where usbnet can leak memory allocated to tx
urb.
usbnet Driver anchors the tx urbs and defers the urb submission if a
transmit request comes when the interface is suspended. Anchoring urb
increments the urb reference count. These deferred urbs are later accessed
On Tue, Oct 23, 2012 at 12:09:00AM +0530, Anil Nair wrote:
> Hello Greg,
>
> I had only one doubt though the tool seems to work for rooted users only?
> when i try to launch it as a normal user it gives me error saying,
>
> "
> Can not open the file /sys/kernel/debug/usb/devices
>
> Verify that
On Mon, 22 Oct 2012, Stephen Warren wrote:
> >>> +- has-tt : controller has transaction translator(s).
> >>> +- has-synopsys-hc-bug : controller has the synopsys hc bug
> >>
> >> That would normally be determined by the driver based on the particular
> >> compatible value that is in device tree.
>
On Mon, Oct 22, 2012 at 11:52:16AM -0400, Alan Stern wrote:
> On Sun, 21 Oct 2012, Holger Hans Peter Freyther wrote:
Dear Alan,
thanks for having a look.
> Did you connect the scanner to the computer with a USB-2 cable or a
> USB-3 cable? Not that it's supposed to matter...
I used the same ca
On Mon, Oct 22, 2012 at 10:01:04AM -0700, Sarah Sharp wrote:
Dear Sarah,
> > Maybe Sarah can give you some pointers on where to look next.
>
> I've asked for a physical bus trace from one of our QA folks with the
> same scanner. I think that will shed some light on whether this is a
> host-side
On Mon, 22 Oct 2012, Ming Lei wrote:
> Deadlock might be caused by allocating memory with GFP_KERNEL in
> runtime_resume callback of network devices in iSCSI situation, so
> mark network devices and its ancestor as 'memalloc_noio_resume'
> with the introduced pm_runtime_set_memalloc_noio().
Is th
On Mon, Oct 22, 2012 at 11:39:26AM -0700, Hemant Kumar wrote:
> Hi
>
> I have come across a scenario where usbnet can leak memory allocated to tx
> urb.
>
> usbnet Driver anchors the tx urbs and defers the urb submission if a
> transmit request comes when the interface is suspended. Anchoring urb
On Mon, Oct 22, 2012 at 09:15:09PM +0200, Holger Hans Peter Freyther wrote:
> On Mon, Oct 22, 2012 at 10:01:04AM -0700, Sarah Sharp wrote:
>
> Dear Sarah,
>
> > > Maybe Sarah can give you some pointers on where to look next.
> >
> > I've asked for a physical bus trace from one of our QA folks wi
I've sent these patches in pieces already, now here the complete thing. I
added a few stable tags for around 5 patches, please have a special look
on them :) It is mostly harmless because it is the hardly taken error path.
I believe most of the line removal here is comming from the last patch and
The descriptor list for FS speed was not NULL terminated. This patch
fixes this.
While here one of the twe two bAlternateSetting assignments for the BOT
interface. Both assign 0, one is enough.
Cc: stable
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/tcm_usb_gadget.c |1 +
Commit d11519 ("usb: gadget: Add Interface Association Descriptor to
ECM") added the IAD descriptor to FS and HS descriptors. The SS
descriptor has been left out probably because it has been added "just
recently".
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_ecm.c |1 +
I think this wrong since 72c973dd ("usb: gadget: add
usb_endpoint_descriptor to struct usb_ep"). If we fail to allocate an ep
or bail out early we shouldn't check for the descriptor which is
assigned at ep_enable() time.
Cc: Tatyana Brokhman
Cc: stable
Signed-off-by: Sebastian Andrzej Siewior
-
The HS descriptors are only created if HS is supported by the UDC but we
never free them.
Cc: stable
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_midi.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index b2
This function works only on FS or HS. If the gadget is HS capable only
HS descriptors are assigned. If we plug it to an 1.1 host it won't work
because we have only 2.0 descriptors. This patch changes the behavior to
provide both sets.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadg
In case something goes wrong here, don't leak memory / endpoints.
Cc: jassisinghb...@gmail.com
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_uac2.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/f_uac2.c b/d
Whether highspeed configuration is valid or not is something that
composite decides and not the gadget. That gadget can only provide the
required descriptors for it.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_midi.c |1 -
drivers/usb/gadget/f_uac1.c |1 -
2 files c
The 9 for HS means 32ms. Use the macro to make it easier to read.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/storage_common.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/storage_common.c
b/drivers/usb/gadget/storage_common.c
The 5+4 magic for HS tries to aim 32ms which is also what is intended
with 1 << 5 for FS. This little macro should make this easier to
understand.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_acm.c|7 +++
drivers/usb/gadget/f_ecm.c|8
drivers/usb
Hi,
Frank Schäfer wrote:
> Am 05.10.2012 18:44, schrieb Octavio Alvarez:
>> On 10/05/2012 07:56 AM, Alan Stern wrote:
>>> On Mon, 9 Jul 2012, Octavio Alvarez wrote:
> What happens if you unplug only the keyboard, or only the mouse?
The only thing I can confirm for now is that with b
On Mon, Oct 22, 2012 at 06:45:36AM +1100, Bernard Blackham wrote:
> This patch cleans up much of the locking in usbip, as well as fixing
> some logic errors. In particular:
>
> - some spinlocks were taken with interrupts disabled in some
>places, but not always.
>
> - many error paths dupli
On Mon, Oct 22, 2012 at 06:44:41AM +1100, Bernard Blackham wrote:
> This patch set fixes a number of crashes, deadlocks and resource
> leaks in usbip. It also makes some changes to improve style and
> consistency.
I've applied 2 of these, care to redo the rest against my latest
usb-next tree and r
HS and SS descriptors are staticaly created. They are updated during the
bind process with the endpoint address, string id or interface numbers.
After that, the descriptor chain is linked to struct usb_function which
is used by composite in order to serve the GET_DESCRIPTOR requests,
number of avai
There is no need for this variable in between.
Cc: jassisinghb...@gmail.com
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_uac2.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/gadget/f_uac2.c b/drivers/usb/ga
The "video->minor = -1" assigment is done in V4L2 by
video_register_device() so it is removed here.
Now. uvc_function_bind() calls in error case uvc_function_unbind() for
cleanup. The problem is that uvc_function_unbind() frees the uvc struct
and uvc_bind_config() does as well in error case of usb_
This patch removes the shifting and masking of interface and its alt
setting and provides its own variable.
This looks better and is smaller:
textdata bss dec hex filename
x86-32
6940 956 5679521f10 gadget/audio.o.old
6908 956 5679201ef0 gadget/a
DMA_ADDR_INVALID is used by the UDC driver and the gadgets should
provide only a buffer address. Everything else should be taken core of
by the UDC and udc-core.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_uac2.c |3 ---
drivers/usb/gadget/inode.c |3 ---
2 files c
Instead of calling usb_string_id() multiple times I replace it with one
usb_string_ids_tab(). The NULL pointer in struct usb_string with "" and
are not overwritten in fail or unbind case.
The conditional assignment remains because some gadget recycle the string
ID because the same descriptor (and s
Cc: stable
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_phonet.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index 8ee9268..a6c19a4 100644
--- a/drivers/usb/gadget/f_phonet.c
+++
Some devices do not support the 8 byte variants of the NTB input
size control messages despite announcing such support in their
NCM or MBIM functional descriptor.
According to the NCM specification, all devices must support the
4 byte variant regardless of whether or not the flag is set:
If bit
[for those who reviewed v1 of this series: patch #1 is the only one
changed in v2]
The USB Communications Device Class "Mobile Broadband Interface Model"
(MBIM) is the USB-IFs alternative to the current chipset/vendor
specific solutions to "Mobile Broadband" device management. The
specification, i
The NCM 1.0 spefication makes provisions for linking more than
one NDP into a single NTB. This is important for MBIM support,
where these NDPs might be of different types.
Following the chain of NDPs is also correct for NCM, and will
not change anything in the common case where there is only
one N
1 - 100 of 133 matches
Mail list logo
