[PATCH 1/4] ARM: dts: mxs-phy: Change mxs phy clock usage

2013-01-10 Thread Peter Chen
For mxs-phy user i.mx6q, the PHY's clock is controlled by hardware automatically, the software only needs to enable it at probe, this clock should be used like below: - Enable at mxs-phy's probe, and disable at mxs-phy's remove, so The clk framework doesn't need to know it. But other mxs-phy user

[PATCH 2/4] usb: mxs-phy: Change mxs phy clock usage

2013-01-10 Thread Peter Chen
As we mark mxs-phy as dummy clock for i.mx6q, we only need to enable it at probe, this clock doesn't need to be managed by clock framework. Signed-off-by: Peter Chen --- drivers/usb/otg/mxs-phy.c | 44 1 files changed, 44 insertions(+), 0 deletions(

[PATCH 3/4] usb: mxs-phy: add set_suspend API

2013-01-10 Thread Peter Chen
It needs to call set_suspend during USB suspend/resume Signed-off-by: Peter Chen --- drivers/usb/otg/mxs-phy.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c index 7dca384..40643c9 100644 --- a/dr

[PATCH 4/4] usb: chipidea: imx: Add system suspend/resume API

2013-01-10 Thread Peter Chen
During the system suspend/resume procedure, the USB also needs to go suspend/resume procedure, this patch adds related APIs. It is tested at i.mx6q sabrelite. Meanwhile, it fixes the bug that the USB will out of work after system suspend/resume. Signed-off-by: Peter Chen --- drivers/usb/chipidea

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-10 Thread Vivek Gautam
Hi Sylwester, On Thu, Jan 10, 2013 at 3:12 AM, Sylwester Nawrocki wrote: > Hi, > > > On 12/28/2012 10:13 AM, Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam > > ... > >>

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: > I've had a quick look at the trace posted at > https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows URBs > that are successfully submitted. I'm not sure what useful information I could > get from the trace. The

[PATCH 0/8] usb/dwc3: misc patches rebased at dwc3-for-v3.8

2013-01-10 Thread Pratyush Anand
Most of these patches have alreday been posted in past but still they have not been applied to tree. These are rebased on tag dwc3-for-v3.8. Pratyush Anand (8): usb/dwc3: Enable usb2 LPM only when connected as usb2.0 usb/dwc3: Fix missed isoc usb/dwc3: Correct Return from ep_queue usb/dwc3

[PATCH 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-10 Thread Pratyush Anand
Synopsys says: The HIRD Threshold field must be set to ‘0’ when the device core is operating in super speed mode. This patch implements above statement. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 31 ++- 1 files changed, 18 insertions(+), 13 dele

[PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Pratyush Anand
There are two reasons to generate missed isoc. 1. when the host does not poll for all the data. 2. because of application-side delays that prevent all the data from being transferred in programmed microframe. Current code was able to handle first case only. Now we take following approach to hand

[PATCH 4/8] usb/dwc3: fix isoc END TRANSFER Condition

2013-01-10 Thread Pratyush Anand
There were still some corner cases where isoc transfer was not able to restart, specially when missed isoc does not happen , and in fact gadget does not queue any new request during giveback. Cleanup function calls giveback first, which provides a way to queue another request to gadget. But gadget

[PATCH 6/8] usb/dwc3: No need to pass params in case of UPDATE TRANSFER

2013-01-10 Thread Pratyush Anand
UPDATE transfer does not need any parameters. So, no need to prepare it. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 55d8bfd..d263b71 10064

[PATCH 3/8] usb/dwc3: Correct Return from ep_queue

2013-01-10 Thread Pratyush Anand
Its better to return from each if condition as they are mutually exclusive. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index bbbcd2e..4d24711 100644

[PATCH 8/8] usb/dwc3: req->queued must be forced to false in cleanup

2013-01-10 Thread Pratyush Anand
I am not sure, why I found it during SG debugging. But, I noticed that even when req_queued list was empty, there were some request in request_list having queued flag true. If I run test second time, it first removes all request from request_list and hence busy_slot was wrongly incremented. Signed

[PATCH 7/8] usb/dwc3: Fix scatter gather implementation

2013-01-10 Thread Pratyush Anand
To work with scatter gather properly, fixes have been done in number of functions. I will explain requirement of each fixes one by one. start_slot: used to retrieve all request of SG during cleanup dwc3_gadget_giveback: We need to skip link TRB if it was one of the intermediate TRB of SG. dwc3_p

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-10 Thread Benoit Cousson
Hi Kishon, On 01/10/2013 07:19 AM, kishon wrote: > On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote: >> Hi, >> >> On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: >>> On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: This patch series adds dt data to get MUSB workin

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 13:13:58 Ming Lei wrote: > IMO, there is a minor fault in the error handling path of > uvc_status_start() inside uvc_v4l2_open(), and the 'users' count > should have been decreased before usb_autopm_put_interface(). > In theory, the warning can be triggered when the devi

[PATCH] uvc: fix race of open and suspend in error case

2013-01-10 Thread Oliver Neukum
Ming Lei reported: IMO, there is a minor fault in the error handling path of uvc_status_start() inside uvc_v4l2_open(), and the 'users' count should have been decreased before usb_autopm_put_interface(). In theory, the warning can be triggered when the device is opened just between usb_autopm_put_i

[BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Felipe Balbi
Hi, Some recent patch has caused fsl_mxc_udc.c driver to fail compilation because it can't find anymore. I would like this to be fixed still during this -rc cycle. Thank you -- balbi signature.asc Description: Digital signature

[PATCH 5/8] usb/dwc3: Fix skip LINK-TRB on ISOC

2013-01-10 Thread Pratyush Anand
When we reach to link trb, we just need to increase free_slot and then calculate TRB. Return is not correct, as it will cause wrong TRB DMA address to fetch in case of update transfer. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 13 + 1 files changed, 5 insertions

Re: [PATCH] usb: gadget: move the global the_dev variable to their users

2013-01-10 Thread Felipe Balbi
On Thu, Nov 08, 2012 at 07:24:13PM +0100, Sebastian Andrzej Siewior wrote: > the u_ether.c file has a global variable named the_dev which keeps a > pointer to the network device after it has been created via > gether_setup_name(). It is only used internally by u_ether. This patches > moves the vari

Re: [V2 PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:00PM -0500, Chao Xie wrote: > This patches converts the driver into the new style start/stop > interface. As a result the driver no longer uses the static > global the_conroller variable. > > Signed-off-by: Chao Xie Care to refresh ? patching file drivers/usb/gadge

RE: [PATCH 1/1]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2013-01-10 Thread Fangxiaozhi (Franko)
Dear Sebastian: > -Original Message- > From: Sebastian Andrzej Siewior [mailto:sebast...@breakpoint.cc] > Sent: Thursday, January 10, 2013 5:30 AM > To: Fangxiaozhi (Franko) > Cc: Linlei (Lei Lin); Huqiao (C); linux-usb@vger.kernel.org > Subject: Re: [PATCH 1/1]linux-usb:optimize to match

Re: [V2 PATCH 02/27] usb: gadget: mv_udc: use devm_xxx for probe

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:01PM -0500, Chao Xie wrote: > use devm_xxx for udc driver probe. So we do need care about > the resources release in driver remove or failure handling > in driver probe. > > Signed-off-by: Chao Xie care to refresh ? patching file drivers/usb/gadget/mv_udc_core.c Hu

Re: [V2 PATCH 08/27] usb: gadget: mv_udc: fix the value of tranceiver

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:07PM -0500, Chao Xie wrote: > usally we will use udc->tranceiver == NULL or > udc->tranceiver != NULL. > So when failed to get the udc->tranceiver by usb_get_phy(), we > directly set udc->tranceiver to be NULL. > Then the source code will not need macro IS_ERR_OR_NULL(

Re: [V2 PATCH 20/27] usb: gadget: mv_udc: add extern chip support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:19PM -0500, Chao Xie wrote: > Because arch-mmp will make use of irq domain for irq > allocation, the irqs allocated for PMIC is dynamical. > The vbus/idpin irqs from PMIC can not be passed by platform data. > Using the extern chip APIs provides by PHY driver can solve

Re: [V2 PATCH 20/27] usb: gadget: mv_udc: add extern chip support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:19PM -0500, Chao Xie wrote: > Because arch-mmp will make use of irq domain for irq > allocation, the irqs allocated for PMIC is dynamical. > The vbus/idpin irqs from PMIC can not be passed by platform data. > Using the extern chip APIs provides by PHY driver can solve

Re: [V2 PATCH 25/27] usb: gadget: mv_udc: add device tree support

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:06:24PM -0500, Chao Xie wrote: > In original driver, we have callbacks in platform data, and some > dynamically allocations variables in platform data. > Now, these blocks are removed, the device tree support is easier > now. > > Signed-off-by: Chao Xie care to refresh

Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2013-01-10 Thread Felipe Balbi
Hi, On Tue, Jan 08, 2013 at 04:32:41PM +0800, Chao Xie wrote: > On Sat, Jan 5, 2013 at 9:35 AM, Chao Xie wrote: > > hi, Felipe > > How about these patches? i see that 3.8-rc2 is tagged but these > > patches are not merged. Thanks. > > > > On Tue, Dec 4, 2012 at 3:34 PM, Haojian Zhuang > > wrote

Re: [PATCH] uvc: fix race of open and suspend in error case

2013-01-10 Thread Laurent Pinchart
Hi Oliver, Thank you for the patch. On Thursday 10 January 2013 11:04:55 Oliver Neukum wrote: > Ming Lei reported: > IMO, there is a minor fault in the error handling path of > uvc_status_start() inside uvc_v4l2_open(), and the 'users' count > should have been decreased before usb_autopm_put_inte

Re: [PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 03:23:16PM +0530, Pratyush Anand wrote: > There are two reasons to generate missed isoc. > > 1. when the host does not poll for all the data. > 2. because of application-side delays that prevent all the data from > being transferred in programmed microframe. > > Current co

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-10 Thread kishon
Hi, On Thursday 10 January 2013 03:28 PM, Benoit Cousson wrote: Hi Kishon, On 01/10/2013 07:19 AM, kishon wrote: On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote: Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote

Re: [PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Pratyush Anand
On 1/10/2013 4:20 PM, Felipe Balbi wrote: On Thu, Jan 10, 2013 at 03:23:16PM +0530, Pratyush Anand wrote: There are two reasons to generate missed isoc. 1. when the host does not poll for all the data. 2. because of application-side delays that prevent all the data from being transferred in pro

xhci module fails when booting in UEFI mode

2013-01-10 Thread Frederik Himpe
I've got a HP EliteBook 8470p on which I installed Debian Wheezy in UEFI mode. With both the 3.2 kernel from Wheezy, as the 3.7.1 kernel from experimental, xhci fails to initialize and my USB mouse connected to one of these ports is not recognized at all. The USB3 ports work fine in Windows. [

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-10 Thread Linus Walleij
On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri wrote: > This patch converts the module to use clk_prepare_enable and > clk_disable_unprepare variants as required by common clock framework. > > Without this the system crash during probe function. > > Signed-off-by: Fabio Baltieri Acked-by: Linus

Re: [PATCH 2/8] usb/dwc3: Fix missed isoc

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 04:47:05PM +0530, Pratyush Anand wrote: > On 1/10/2013 4:20 PM, Felipe Balbi wrote: > >On Thu, Jan 10, 2013 at 03:23:16PM +0530, Pratyush Anand wrote: > >>There are two reasons to generate missed isoc. > >> > >>1. when the host does not poll for all the data. > >>2. because

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2013-01-10 Thread Felipe Balbi
On Mon, Nov 12, 2012 at 09:01:33PM +0300, Sergei Shtylyov wrote: > This patch fixes the following: > > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from > the function dma_controller_create() to the function > .init.text:cppi_controller_start() > The function __devinit

Re: [V2 PATCH 00/27] mv-usb fix and enhancement patches

2013-01-10 Thread Felipe Balbi
On Tue, Nov 27, 2012 at 10:05:59PM -0500, Chao Xie wrote: > The patches are divied into 4 parts > 1. bug fixes > usb: gadget: mv_udc: use udc_start and udc_stop functions > usb: gadget: mv_udc: use devm_xxx for probe > usb: gadget: mv_udc: fix the clk APIs > usb: otg: mv_otg: use devm_xxx f

Re: [PATCH] usb: musb: Double buffering issues in host mode TX

2013-01-10 Thread Felipe Balbi
On Fri, Jan 04, 2013 at 05:10:33PM +0530, Supriya Karanth wrote: > From: supriya karanth > > Whenever an URB is programmed for transfer, the TXFIFO > is flushed. This results in valid packets of the > previous transfer to get flushed when double buffering > is enabled (The MUSB_TXCSR_FIFONOTEMPTY

Re: [PATCH 2/3] usb/acpi: binding xhci root hub usb port with ACPI

2013-01-10 Thread Sergei Shtylyov
Hello. On 10-01-2013 10:52, Lan Tianyu wrote: This patch is to bind xhci root hub usb port with its acpi node. The port num in the acpi table matches with the sequence in the xhci extended capabilities table. So call usb_hcd_find_raw_port_number() to transfer hub port num into raw port number w

ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi Alan, with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined [enabled by default] drivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of the previous definition drivers/usb/host/ehci-mxc.c:28

Re: [PATCH 4/8] usb/dwc3: fix isoc END TRANSFER Condition

2013-01-10 Thread Sergei Shtylyov
Hello. On 10-01-2013 13:53, Pratyush Anand wrote: There were still some corner cases where isoc transfer was not able to restart, specially when missed isoc does not happen , and in fact gadget does not queue any new request during giveback. Cleanup function calls giveback first, which provi

[PATCH 2/2] usb: host: ohci-tmio: fix compile warning

2013-01-10 Thread Felipe Balbi
Fix the following compile warning: In file included from drivers/usb/host/ohci-hcd.c:1170:0: drivers/usb/host/ohci-tmio.c: In function 'tmio_start_hc': drivers/usb/host/ohci-tmio.c:130:2: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_s

[PATCH 1/2] usb: host: imx21: fix compile error

2013-01-10 Thread Felipe Balbi
Fix the following compile errors: drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration specifiers or '...' before string constant drivers/usb/host/imx21-hcd.c:1930:15: error: expected declaration specifiers or '...' before string constant drivers/usb/host/imx21-hcd.c:1931:16: error:

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2013-01-10 Thread Sergei Shtylyov
Hello. On 10-01-2013 15:59, Felipe Balbi wrote: This patch fixes the following: WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from the function dma_controller_create() to the function .init.text:cppi_controller_start() The function __devinit dma_controller_create(

Re: [PATCH 1/2] usb: host: imx21: fix compile error

2013-01-10 Thread Felipe Balbi
On Thu, Jan 10, 2013 at 10:41:44AM -0200, Fabio Estevam wrote: > On Thu, Jan 10, 2013 at 10:32 AM, Felipe Balbi wrote: > > Fix the following compile errors: > > > > drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration > > specifiers or '...' before string constant > > drivers/usb/hos

Re: [PATCH 1/3] driver core: add helper macro for platform_driver_probe() boilerplate

2013-01-10 Thread Fabio Porcedda
Hi Greg, I'm sorry, In the previous email I used your wrong email address, in this email I've used your correct email address. Best regards Fabio Porcedda On Wed, Jan 9, 2013 at 12:15 PM, Fabio Porcedda wrote: > For simple modules that contain a single platform_driver without any > additional se

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-10 Thread Felipe Balbi
Hi, On Mon, Dec 24, 2012 at 07:28:33PM +0530, Vivek Gautam wrote: > DWC3 controller curretly depends on CONFIG_USB and CONFIG_USB_GADGET. > Some hardware may like to use only host feature on dwc3. > So, removing the dependency of USB_DWC3 on USB_GADGET > and further modulating the dwc3 core to ena

Re: [PATCH 1/2] usb: host: imx21: fix compile error

2013-01-10 Thread Fabio Estevam
On Thu, Jan 10, 2013 at 10:32 AM, Felipe Balbi wrote: > Fix the following compile errors: > > drivers/usb/host/imx21-hcd.c:1929:20: error: expected declaration specifiers > or '...' before string constant > drivers/usb/host/imx21-hcd.c:1930:15: error: expected declaration specifiers > or '...' b

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-10 Thread Fabio Baltieri
Hello Linus, On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote: > On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri > wrote: > > > This patch converts the module to use clk_prepare_enable and > > clk_disable_unprepare variants as required by common clock framework. > > > > Without this

[PATCH] CDC_NCM adding support IFF_NOARP for buggy device

2013-01-10 Thread Wei Shuai
Signed-off-by: Wei Shuai --- drivers/net/usb/cdc_ncm.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 71b6e92..9903f79 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -5

[balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

2013-01-10 Thread Fengguang Wu
Hi Fabio, FYI, there are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: df2167b3770a6ed33eb567d390b1a24a7efddcd9 commit: df2167b3770a6ed33eb567d390b1a24a7efddcd9 [13/13] usb: convert drivers/usb/* to use module_platform_driver_

Re: [PATCH] CDC_NCM adding support IFF_NOARP for buggy device

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 21:59:28 Wei Shuai wrote: Hi, I am afraid this is done in an unclean manner. > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 71b6e92..9903f79 100644 > --- a/drivers/net/usb/cdc_ncm.c > +++ b/drivers/net/usb/cdc_ncm.c > @@ -545,6 +545,7 @@

Re: [balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

2013-01-10 Thread Felipe Balbi
Hi, On Thu, Jan 10, 2013 at 10:10:02PM +0800, Fengguang Wu wrote: > > Hi Fabio, > > FYI, there are new compile warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > head: df2167b3770a6ed33eb567d390b1a24a7efddcd9 > commit: df2167b3770a6ed33eb567d3

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Greg KH
On Thu, Jan 10, 2013 at 12:08:35PM +0200, Felipe Balbi wrote: > Hi, > > Some recent patch has caused fsl_mxc_udc.c driver to fail compilation > because it can't find anymore. > > I would like this to be fixed still during this -rc cycle. Me too, who's sending a patch? :) -- To unsubscribe fro

Re: [balbi-usb:gadget 13/13] drivers/usb/gadget/m66592-udc.c:1756:1: warning: data definition has no type or storage class

2013-01-10 Thread Greg KH
On Thu, Jan 10, 2013 at 04:12:16PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Jan 10, 2013 at 10:10:02PM +0800, Fengguang Wu wrote: > > > > Hi Fabio, > > > > FYI, there are new compile warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > > h

Re: [PATCH 1/2] USB: fsl-mph-dr-of: fix regression on mpc5121e

2013-01-10 Thread Anatolij Gustschin
Hi Greg, On Tue, 4 Dec 2012 14:23:21 +0100 Anatolij Gustschin wrote: > fsl-ehci probing fails on mpc5121e: > ... > ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver > fsl-ehci fsl-ehci.0: Freescale On-Chip EHCI Host Controller > fsl-ehci fsl-ehci.0: new USB bus registered, assigned bus

Re: [PATCH 2/2] USB: ehci-fsl: fix regression on mpc5121e

2013-01-10 Thread Anatolij Gustschin
Hi Greg, On Tue, 4 Dec 2012 10:22:06 -0500 (EST) Alan Stern wrote: > On Tue, 4 Dec 2012, Anatolij Gustschin wrote: > > > mpc5121e doesn't have system interface registers, accessing this > > register address space cause the machine check exception and a > > kernel crash: > > > > ... > > Machine

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Laurent Pinchart wrote: > Hi Josh, > > On Tuesday 08 January 2013 11:03:22 Josh Boyer wrote: > > On Tue, Jan 08, 2013 at 10:51:20AM -0500, Alan Stern wrote: > > > On Mon, 7 Jan 2013, Josh Boyer wrote: > > > > Hi, > > > > > > > > We've had a few reports in Fedora of users hit

Re: [PATCH 1/3] usb: add find_raw_port_number callback to struct hc_driver()

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Lan Tianyu wrote: > xhci driver divides the root hub into two logical hubs which work > respectively for usb 2.0 and usb 3.0 devices. They are independent > devices in the usb core. But in the ACPI table, it's one device node > and all usb2.0 and usb3.0 ports are under it. Bin

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Oliver Neukum wrote: > On Thursday 10 January 2013 00:05:55 Laurent Pinchart wrote: > > > I've had a quick look at the trace posted at > > https://bugzilla.redhat.com/show_bug.cgi?id=879462 but usbmon only shows > > URBs > > that are successfully submitted. I'm not sure wh

Re: [PATCH 2/2] usb: host: ohci-tmio: fix compile warning

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > Fix the following compile warning: > > In file included from drivers/usb/host/ohci-hcd.c:1170:0: > drivers/usb/host/ohci-tmio.c: In function 'tmio_start_hc': > drivers/usb/host/ohci-tmio.c:130:2: warning: format '%llx' expects argument > of type 'long l

Re: [PATCH 1/3] usb: add find_raw_port_number callback to struct hc_driver()

2013-01-10 Thread Lan Tianyu
于 2013/1/10 23:14, Alan Stern 写道: On Thu, 10 Jan 2013, Lan Tianyu wrote: xhci driver divides the root hub into two logical hubs which work respectively for usb 2.0 and usb 3.0 devices. They are independent devices in the usb core. But in the ACPI table, it's one device node and all usb2.0 and u

[PATCH] USB: select USB_ARCH_HAS_EHCI for MXS

2013-01-10 Thread Maxime Ripard
Commit 09f6ffde introduced a dependency on USB_EHCI_HCD for the chipidea USB host driver, that in turns depends on USB_ARCH_HAS_EHCI. If this symbol is not set for MXS, the MXS boards are not able to use the chipidea driver anymore. Signed-off-by: Maxime Ripard --- drivers/usb/Kconfig |1 +

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > Hi Alan, > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined > [enabled by default] > drivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of

Re: USB autosuspend vs. URB submission

2013-01-10 Thread Oliver Neukum
On Thursday 10 January 2013 10:20:42 Alan Stern wrote: > On Thu, 10 Jan 2013, Oliver Neukum wrote: > > In the long run it is probably a good idea to pass duplicated URBs to > > usbmon by > > a special code path. > > I'd prefer to add extra information to the WARN_ONCE message. Even > though it

Re: [PATCH] USB: select USB_ARCH_HAS_EHCI for MXS

2013-01-10 Thread Sergei Shtylyov
Hello. On 01/10/2013 06:35 PM, Maxime Ripard wrote: > Commit 09f6ffde introduced a dependency on USB_EHCI_HCD for the chipidea Please also specify the summary of that commit in parens (or however you like). > USB host driver, that in turns depends on USB_ARCH_HAS_EHCI. > If this symbol is

Re: [PATCH] CDC_NCM adding support IFF_NOARP for buggy device

2013-01-10 Thread Sergei Shtylyov
Hello. On 01/10/2013 04:59 PM, Wei Shuai wrote: > Signed-off-by: Wei Shuai > --- > drivers/net/usb/cdc_ncm.c | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c > index 71b6e92..9903f79 100644 > --- a/

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi, On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi Alan, > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > > > drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined > > [enable

[PATCH 12/14] ARM: OMAP2+: omap4panda: Adapt HUB power to regulator framework

2013-01-10 Thread Roger Quadros
We model the HUB_POWER GPIO as a fixed regulator device. This regulator is then used as "vcc" supply for the USB PHY device and is managed by the PHY driver. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 38 +++ 1 files changed, 33 insert

[PATCH 14/14] ARM: OMAP2+: omap4panda: Remove irrelevant USB host platform data

2013-01-10 Thread Roger Quadros
These platform data bits are no longer used so remove them. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c index

[PATCH 13/14] ARM: OMAP2+: omap4panda: Adapt HUB reset to regulator framework

2013-01-10 Thread Roger Quadros
We model the HUB_RESET GPIO as a fixed regulator device. This regulator is then used as "reset" supply for the USB PHY device and is managed by the PHY driver. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 48 ++-- 1 files changed, 33 ins

[PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-10 Thread Roger Quadros
If the OMAP's Host controller is in PHY mode then we instantiate a platform device for the PHY (one for each port in PHY mode) and hold a reference to it so that we can use the usb_phy API, e.g. while suspend/resume. The platform data for the PHY must be supplied in the newly added .phy_config par

[PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-10 Thread Roger Quadros
We use "vcc" as the supply name for the PHY's power supply. The power supply will be enabled during .init() and disabled during .shutdown() Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/

[PATCH 06/14] mfd: omap-usb-host: update nports in platform_data

2013-01-10 Thread Roger Quadros
EHCI driver would need to know the number of ports available on the platform. We set the nports parameter of platform_data based on IP version if it was not already provided. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-10 Thread Roger Quadros
Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and avoids creating multiple copies of platform data. Sign

[PATCH 11/14] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data

2013-01-10 Thread Roger Quadros
Provide platform data for the USB host's PHY. Also get rid of managing PHY clock. This will now be done by the phy driver. For that to work we create a clock alias that links the PHY clock name to the PHY device name. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 3

[PATCH 10/14] usb: ehci-omap: Remove PHY regulator handling code

2013-01-10 Thread Roger Quadros
PHY regulator handling must be done in the PHY driver Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 31 +-- 1 files changed, 1 insertions(+), 30 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 46b28d6..0

[PATCH 03/14] usb: xceiv: nop: Manage PHY clock

2013-01-10 Thread Roger Quadros
If the PHY has a clock associated to it then manage the clock. We just enable the clock in .init() and disable it in .shutdown(). Add clk_rate parameter in platform data and configure the clock rate during probe if supplied. Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c |

[PATCH 09/14] usb: ehci-omap: Remove PHY reset handling code

2013-01-10 Thread Roger Quadros
Reset GPIO handling for the PHY must be done in the PHY driver. We use the PHY helpers instead to reset the PHY. Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 70 ++ 1 files changed, 10 insertions(+), 60 deletions(-) diff --git a/drive

[PATCH 08/14] mfd: omap-usb-host: Remove PHY reset handling code

2013-01-10 Thread Roger Quadros
PHY reset GPIO handling will be done in the PHY driver Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 47 --- 1 files changed, 0 insertions(+), 47 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index

[PATCH 05/14] usb: phy: nop: Handle RESET for the PHY

2013-01-10 Thread Roger Quadros
We expect the RESET line to be modeled as a regulator with supply name "reset". The regulator should be modeled such that enabling the regulator brings the PHY device out of RESET and disabling the regulator holds the device in RESET. They PHY will be held in RESET in .shutdown() and brought out o

[PATCH 00/14] USB: omap-ehci: Move PHY management to PHY driver

2013-01-10 Thread Roger Quadros
The OMAP's High Speed Host controller can interface to ULPI/UTMI PHY's transparently i.e. whithout requiring the device drivers to access the PHY [1]. However, the OS must ensure that the PHY has the necessary resources (power/clock/reset) enabled before it is used. Till now, the omap-ehci driver

[PATCH 02/14] usb: phy: Add new API usb_get_phy_from_dev()

2013-01-10 Thread Roger Quadros
This API allows PHY users to get the usb_phy data structure from a device handle. Signed-off-by: Roger Quadros --- drivers/usb/otg/otg.c | 36 include/linux/usb/phy.h |6 ++ 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/drivers/u

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > Hi, > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > Hi Alan, > > > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > > > > > drivers/usb/host/ehci-h

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-10 Thread Sergei Shtylyov
Hello. On 01/10/2013 07:51 PM, Roger Quadros wrote: > We use "vcc" as the supply name for the PHY's power supply. > The power supply will be enabled during .init() and disabled > during .shutdown() > Signed-off-by: Roger Quadros > --- > drivers/usb/otg/nop-usb-xceiv.c | 18 ++

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi, > > > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > > > Hi Alan, > > > > > > > > with v3.8-rc3, ehci-hcd

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
-ENOROGER :-p On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: > Hi > > On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > Hi, > > > > > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > > > On Thu, 10

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > -ENOROGER :-p > > On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: > > Hi > > > > On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > > > Hi, > > > > > > > > On Thu, Jan 10,

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Roger Quadros wrote: > If the OMAP's Host controller is in PHY mode then we instantiate > a platform device for the PHY (one for each port in PHY mode) and > hold a reference to it so that we can use the usb_phy API, e.g. > while suspend/resume. > > The platform data for the

Problem with

2013-01-10 Thread Diederick Huijbers ☾
Hi, While I was writing a basic v4l2 video grabber I got a wierd bug which I've been discussing with pinchartl and devinheitmueller on freenode #v4l2. The problem is that my /dev/video0 devices disappears when I start my application and press CTRL-C without handling the signal/interupt and closin

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-10 Thread Tony Lindgren
* Roger Quadros [130110 08:54]: > Let's have a single platform data structure for the OMAP's High-Speed > USB host subsystem instead of having 3 separate ones i.e. one for > board data, one for USB Host (UHH) module and one for USB-TLL module. > > This makes the code much simpler and avoids creat

Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Peter Chen
On Thu, Jan 10, 2013 at 06:30:06AM -0800, Greg KH wrote: > On Thu, Jan 10, 2013 at 12:08:35PM +0200, Felipe Balbi wrote: > > Hi, > > > > Some recent patch has caused fsl_mxc_udc.c driver to fail compilation > > because it can't find anymore. > > > > I would like this to be fixed still during thi

Re: [PATCH 1/4] ARM: dts: mxs-phy: Change mxs phy clock usage

2013-01-10 Thread Shawn Guo
On Thu, Jan 10, 2013 at 04:35:51PM +0800, Peter Chen wrote: > For mxs-phy user i.mx6q, the PHY's clock is controlled by > hardware automatically, the software only needs to enable it > at probe, this clock should be used like below: > > - Enable at mxs-phy's probe, and disable at mxs-phy's remove,

Re: [PATCH] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-10 Thread Ming Lei
Cc netdev and usb lists. On Fri, Jan 11, 2013 at 9:17 AM, wrote: > From: Freddy Xin > > This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0 > to gigabit ethernet adapters. It's based on the AX88xxx driver but > the usb commands used to access registers for AX88179 are completely

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-10 Thread Ming Lei
On Sat, Jan 5, 2013 at 9:26 AM, Dan Williams wrote: > On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: >> On Friday 04 January 2013 10:48:16 Dan Williams wrote: >> > Some drivers (ex sierra_net) need the status interrupt URB >> > active even when the device is closed, because they receive >

RE: [PATCH 1/4] ARM: dts: mxs-phy: Change mxs phy clock usage

2013-01-10 Thread Chen Peter-B29397
> On Thu, Jan 10, 2013 at 04:35:51PM +0800, Peter Chen wrote: > > For mxs-phy user i.mx6q, the PHY's clock is controlled by > > hardware automatically, the software only needs to enable it > > at probe, this clock should be used like below: > > > > - Enable at mxs-phy's probe, and disable at mxs-

RE: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Li Yang-R58472
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, January 10, 2013 10:30 PM > To: Felipe Balbi > Cc: Li Yang-R58472; linux-usb@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on >

RE: [BUILD BREAK] usb: gadget: fsl_mxc_udc can't compile on current v3.8-rc3

2013-01-10 Thread Chen Peter-B29397
> > > > > > Some recent patch has caused fsl_mxc_udc.c driver to fail compilation > > > because it can't find anymore. > > > > > > I would like this to be fixed still during this -rc cycle. > > > > Me too, who's sending a patch? :) > > Hi Peter, > > Who is currently working on the i.mx USB? >

Re: Linux USB redirection

2013-01-10 Thread Chirkut Daruwalla
Hello everyone, I've been focusing (for now) on getting USBIP to work and its been an uphill battle. On LinuxMint 14 64bit I am able to build all the modules. I'm also able to load usbip-core.ko. But when I load vhci-hcd.ko, the load is successful but immediately after that the system just hangs

Re: Linux USB redirection

2013-01-10 Thread Anil Nair
Hello Chirkut, > On LinuxMint 14 64bit I am able to build all the modules. I'm also > able to load usbip-core.ko. But when I load vhci-hcd.ko, the load is > successful but immediately after that the system just hangs completely > - no response to keyboard or mouse, but no kernel crash. Only way ou

  1   2   >