Re: [PATCH v2 09/12] usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-27 Thread Felipe Balbi
HI, On Tue, Mar 26, 2013 at 09:24:30PM +0100, Michael Grzeschik wrote: > On Tue, Mar 26, 2013 at 07:55:46PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Tue, Mar 26, 2013 at 05:58:45PM +0100, Michael Grzeschik wrote: > > > A static count of transfer descriptors was used everywhere in the driver

Re: [PATCH] usb: Fix compile error by selecting USB_OTG_UTILS

2013-03-27 Thread Felipe Balbi
On Tue, Mar 26, 2013 at 01:37:41PM -0700, Greg KH wrote: > On Tue, Mar 26, 2013 at 09:25:35PM +0100, Roland Stigge wrote: > > On 03/26/2013 08:24 PM, Felipe Balbi wrote: > > > commit ? > > > > 1c2088812f095df77f4b3224b65db79d7111a300 > > Showed up in 3.9-rc3. > > Felipe, I can take this directly

Re: Two remain problems at chipidea driver

2013-03-27 Thread Marc Kleine-Budde
On 03/27/2013 02:35 AM, Peter Chen wrote: > On Tue, Mar 26, 2013 at 12:35:44PM +0200, Alexander Shishkin wrote: >> >> I'm thinking now that what Felipe suggests is probably the best at least >> for the time being. That is, if we don't want host, for example, in the >> product build, we just compile

Re: [PATCH v2 09/12] usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-27 Thread Alexander Shishkin
Felipe Balbi writes: > HI, > > On Tue, Mar 26, 2013 at 09:24:30PM +0100, Michael Grzeschik wrote: >> On Tue, Mar 26, 2013 at 07:55:46PM +0200, Felipe Balbi wrote: >> > Hi, >> > >> > On Tue, Mar 26, 2013 at 05:58:45PM +0100, Michael Grzeschik wrote: >> > > A static count of transfer descriptors w

Re: [PATCH v4 00/12] usb: chipidea: udc: fixes, iso ep and multi td support

2013-03-27 Thread Michael Grzeschik
On Tue, Mar 26, 2013 at 03:50:47PM -0700, Greg KH wrote: > On Tue, Mar 26, 2013 at 11:57:48PM +0200, Alexander Shishkin wrote: > > Also, when you resend this patchset, *please* make sure all the patches > > in it have the same version number, which is greater than *any* of these > > patches had bef

Re: Linux USB file storage gadget with new UDC

2013-03-27 Thread victor yeo
Hi, >> Understand, UDC driver will call driver->setup(), and if the return >> value is negative, UDC driver has to set dev->protocol_stall = 1 and >> maybe call usb_ep_set_halt(). However, the hardware won't be able to >> send out zero length response. > > Don't be silly; of course it can. Nobody

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Matthijs Kooijman
Hi folks, > I don't think we are consistent in any way. PowerPC sets up a 32 bit > DMA mask for all devices during DT probe from arch code, while the > common code sets up coherent_dma_mask but not dma_mask, except > for AMBA devices, which also get the 32 bit mask. > > The MIPS Octeon and PowerP

Re: [PATCH v5 06/12] usb: chipidea: udc: configure iso endpoints

2013-03-27 Thread Peter Chen
On Tue, Mar 26, 2013 at 07:49:07PM +0200, Felipe Balbi wrote: > Hi, > > On Tue, Mar 26, 2013 at 05:58:42PM +0100, Michael Grzeschik wrote: > > The implementation is derived from the fsl_udc_core code in > > fsl_ep_enable and makes basic iso handling possible. > > > > Signed-off-by: Michael Grzesc

[PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-27 Thread Matthijs Kooijman
Hi folks, while going through the dwc2 driver, I've found that there is a lot of places that need info from the hwcfg registers. Currently, each of these places do their own bitshifting and masking, but it occurs to me that the code would become cleaner if all this happened in single place, so all

usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread B, Ravi
Hi I am observing issue while streaming video from usb camera connected to host controller based on mentor graphics. The issue is root caused that there are huge SOF gaps seen between the two isochronous IN token issued by host controller. This is due to fact, significant amount of time is spen

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-27 Thread Graeme Gregory
On 26/03/13 20:23, Stephen Warren wrote: > On 03/26/2013 10:57 AM, Graeme Gregory wrote: >> On 26/03/13 16:22, Stephen Warren wrote: >>> On 03/26/2013 03:27 AM, Graeme Gregory wrote: >>> ... If we are tightly coupling as above then using platform_irq is an extra inefficiency. You both hav

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-27 Thread Michael Grzeschik
On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > Hi Alexander, Fabio, Greg, [...] > > 618bfec Revert "USB: chipidea: add vbus detect for udc" > > This one, though, I will pick. I miss that patch in your posted series. -- Pengutronix e.K.

Re: [PATCH 4/4] usb: gadget: mv_u3d: drop ARCH dependency

2013-03-27 Thread Felipe Balbi
Hi, On Fri, Mar 22, 2013 at 09:30:17AM +0200, Felipe Balbi wrote: > this driver compiles fine everywhere which > means we can use linux-next to compile it > for us frequently. > > By dropping the arch dependency, we also > ensure driver writers don't add virtual > arch-depdencies to the driver by

Re: [PATCH V2 0/6] remove the clock name from pdata

2013-03-27 Thread Felipe Balbi
Hi, On Mon, Mar 25, 2013 at 03:06:51AM -0400, Chao Xie wrote: > The clock is defined by device, so the driver knows how many > clocks needed by the device. > The orignal way that passing the clock name by pdata is not correct. > The following patches fix it. > > V2->V1: >typo fix >rebased

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-27 Thread Felipe Balbi
Hi, On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: > MUSB controller cannot work in DMA mode with misaligned buffers, > switching in PIO mode. > > HCD core has hooks that allow to override the default DMA > mapping and unmapping routines for host controllers that have > special D

Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-03-27 Thread Felipe Balbi
Hi, On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote: > @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct platform_device > *pdev) > static struct samsung_usbphy_drvdata usb3phy_exynos5 = { > .cpu_type = TYPE_EXYNOS5250, > .devphy_en_mask =

Re: xhci page fault panic on Ubuntu kernel with HP desktop hardware

2013-03-27 Thread Yann Sionneau
Le 26/03/2013 17:30, Sarah Sharp a écrit : > On Tue, Mar 26, 2013 at 12:11:13PM +0100, Yann Sionneau wrote: >> Le 25/03/2013 19:13, Sarah Sharp a écrit : >>> On Mon, Mar 25, 2013 at 05:43:40PM +0100, Yann Sionneau wrote: >>> Please compile with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING >>

Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-03-27 Thread Tomasz Figa
Hi Felipe, On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote: > Hi, > > On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote: > > @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct > > platform_device *pdev)> > > static struct samsung_usbphy_drvdata usb3phy_exynos5 = {

Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-03-27 Thread Felipe Balbi
Hi, On Wed, Mar 27, 2013 at 02:26:08PM +0100, Tomasz Figa wrote: > Hi Felipe, > > On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote: > > Hi, > > > > On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote: > > > @@ -307,6 +310,7 @@ static int samsung_usb3phy_remove(struct > > > platf

Re: [PATCH V4 0/2] UVC webcam gadget related changes

2013-03-27 Thread Felipe Balbi
Hi, On Thu, Mar 21, 2013 at 01:56:07PM +0530, Bhupesh Sharma wrote: > This patchset tries to enhance the UVC webcam gadget driver and is based on > Laurent's git tree available here (head uvc-gadget): > git://linuxtv.org/pinchartl/uvcvideo.git > > Note that to ease review and integration of these

Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-03-27 Thread Tomasz Figa
On Wednesday 27 of March 2013 15:31:49 Felipe Balbi wrote: > Hi, > > On Wed, Mar 27, 2013 at 02:26:08PM +0100, Tomasz Figa wrote: > > Hi Felipe, > > > > On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Mar 26, 2013 at 03:53:12PM +0100, Tomasz Figa wrote: >

Renesas sparse errors

2013-03-27 Thread Felipe Balbi
Hi Kuninori, Renesas USB driver constantly gives me sparse errors: linux/drivers/usb/renesas_usbhs/common.c:313:17: error: incompatible types in conditional expression (different base types) linux/drivers/usb/renesas_usbhs/common.c:322:17: error: incompatible types in conditional expression (di

Re: [PATCH 3/6] usb: phy: samsung: Consolidate reference clock rate handling

2013-03-27 Thread Felipe Balbi
Hi, On Wed, Mar 27, 2013 at 02:39:08PM +0100, Tomasz Figa wrote: > On Wednesday 27 of March 2013 15:31:49 Felipe Balbi wrote: > > Hi, > > > > On Wed, Mar 27, 2013 at 02:26:08PM +0100, Tomasz Figa wrote: > > > Hi Felipe, > > > > > > On Wednesday 27 of March 2013 15:19:58 Felipe Balbi wrote: > > >

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-27 Thread Alexander Shishkin
Michael Grzeschik writes: > On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> > Hi Alexander, Fabio, Greg, > > [...] > >> > 618bfec Revert "USB: chipidea: add vbus detect for udc" >> >> This one, though, I will pick. > > I miss that patch in you

Re: Linux USB file storage gadget with new UDC

2013-03-27 Thread Alan Stern
On Wed, 27 Mar 2013, victor yeo wrote: > Thanks, the halt feature is ok now. The SCSI_READ_10 command has a > problem. The reply value from do_read is -5, which means -EIO. The > for(;;) loop in do_read() was probably broken at "if (amount_left == > 0)". Is this if-statement valid? Yes, it is. d

Re: [PATCH V4 0/2] UVC webcam gadget related changes

2013-03-27 Thread Laurent Pinchart
Hi Felipe, On Wednesday 27 March 2013 15:33:15 Felipe Balbi wrote: > On Thu, Mar 21, 2013 at 01:56:07PM +0530, Bhupesh Sharma wrote: > > This patchset tries to enhance the UVC webcam gadget driver and is based > > on Laurent's git tree available here (head uvc-gadget): > > git://linuxtv.org/pincha

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-27 Thread Greg KH
On Wed, Mar 27, 2013 at 10:48:17AM +0100, Matthijs Kooijman wrote: > Hi folks, > > while going through the dwc2 driver, I've found that there is a lot of > places that need info from the hwcfg registers. Currently, each of these > places do their own bitshifting and masking, but it occurs to me th

Re: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-27 Thread Matthijs Kooijman
Hi Greg, > But yes, it does seem to be a good idea, Ok, thanks. > as long as these options can't change over time. It's only read-only registers, or registers whose power-on values determine their maximum possible value, so they indeed won't change over time. Gr. Matthijs -- To unsubscribe fro

[PATCH v6 3/6] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-27 Thread Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 3 ++- 1 file changed,

[PATCH v6 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
Hi, this series solve some issues with the chipidea udc. The series is based on v3.9-rc4 Michael Grzeschik (6): usb: chipidea: udc: add attribute aligned(4) to shared memory structs usb: chipidea: udc: only clear active and halted bits in qhead usb: chipidea: udc: move ZLT flag change to e

[PATCH v6 5/6] usb: chipidea: udc: don't truncate requests to single tds

2013-03-27 Thread Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the controller can handle with one td and to keep working. That patch fixes that with proper error handling instead. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v6 4/6] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-27 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea

[PATCH v6 2/6] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-27 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea

[PATCH v6 1/6] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-27 Thread Michael Grzeschik
The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The compiler currently does not know about the alignment of the memory layout, and will create strb and ldrb operations.

[PATCH v6 6/6] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-27 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside usb_e

Re: [PATCH v6 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Alexander Shishkin
Michael Grzeschik writes: > Hi, > > this series solve some issues with the chipidea udc. > > The series is based on v3.9-rc4 Didn't you forget Felipe's reviewed-bys? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vg

Re: [PATCH v6 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
On Wed, Mar 27, 2013 at 06:06:51PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > Hi, > > > > this series solve some issues with the chipidea udc. > > > > The series is based on v3.9-rc4 > > Didn't you forget Felipe's reviewed-bys? Yes, i will repost v7 in a minute. Thanks,

[PATCH v7 3/6] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-27 Thread Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Cc: stable Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc

[PATCH v7 6/6] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-27 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside usb_e

[PATCH v7 5/6] usb: chipidea: udc: don't truncate requests to single tds

2013-03-27 Thread Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the controller can handle with one td and to keep working. That patch fixes that with proper error handling instead. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
Hi, this series solve some issues with the chipidea udc. The series is based on v3.9-rc4. Michael Grzeschik (6): usb: chipidea: udc: add attribute aligned(4) to shared memory structs usb: chipidea: udc: only clear active and halted bits in qhead usb: chipidea: udc: move ZLT flag change to

[PATCH v7 2/6] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-27 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Cc: stable Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH v7 1/6] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-27 Thread Michael Grzeschik
The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The compiler currently does not know about the alignment of the memory layout, and will create strb and ldrb operations.

[PATCH v7 4/6] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-27 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-27 Thread David Linares
On 26 March 2013 18:50, Alan Stern wrote: > On Tue, 26 Mar 2013, David Linares wrote: > >> >> The device I am working on is an embedded device, therefore the wireless >> >> adapter has to be connected to the internal hub. This hub and the whole >> >> device >> >> are powered via an usb cable. >>

Re: [PATCH v6 6/6] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-27 Thread Alexander Shishkin
Michael Grzeschik writes: > There is no need to call ep_queue unlocked inside the own driver. We > move its functionionality into an unlocked version. > > This patch removes potential unlocked timeslots inside > isr_setup_status_phase and isr_get_status_response, in which the lock > got released

Re: [PATCH v7 1/6] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-27 Thread Greg KH
On Wed, Mar 27, 2013 at 05:21:13PM +0100, Michael Grzeschik wrote: > The udc uses an shared dma memory space between hard and software. This > memory layout is described in ci13xxx_qh and ci13xxx_td which are marked > with the attribute ((packed)). > > The compiler currently does not know about th

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Alexander Shishkin
Michael Grzeschik writes: > Hi, > > this series solve some issues with the chipidea udc. > > The series is based on v3.9-rc4. > > Michael Grzeschik (6): > usb: chipidea: udc: add attribute aligned(4) to shared memory structs > usb: chipidea: udc: only clear active and halted bits in qhead >

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Marc Kleine-Budde
On 03/27/2013 05:35 PM, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> Hi, >> >> this series solve some issues with the chipidea udc. >> >> The series is based on v3.9-rc4. >> >> Michael Grzeschik (6): >> usb: chipidea: udc: add attribute aligned(4) to shared memory structs >> usb

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Marc Kleine-Budde
On 03/27/2013 05:37 PM, Marc Kleine-Budde wrote: > On 03/27/2013 05:35 PM, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> >>> Hi, >>> >>> this series solve some issues with the chipidea udc. >>> >>> The series is based on v3.9-rc4. >>> >>> Michael Grzeschik (6): >>> usb: chipidea: udc

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
On Wed, Mar 27, 2013 at 06:35:30PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > Hi, > > > > this series solve some issues with the chipidea udc. > > > > The series is based on v3.9-rc4. > > > > Michael Grzeschik (6): > > usb: chipidea: udc: add attribute aligned(4) to shar

[PATCH 0/4] usb: remote_wakeup code clean up and usb port related feature

2013-03-27 Thread Lan Tianyu
PATCH 1 is for code clean up. PATCH 2~3 is to introduce usb port power off new feature PATCH 4 is to fix usb port doesn't register to any bus_type usb: add usb_enable/disable_remote_wakeup() usb: introduce usb force power off mechanism usb: Add usb port system pm support usb: register usb port to

[PATCH 1/4] usb: add usb_enable/disable_remote_wakeup()

2013-03-27 Thread Lan Tianyu
usb2.0 and usb3.0 devices have different ways to enalbe/disable remote wakeup. This patch is to put both their operations into the seperate functions. Otherwise, usb_control_msg() has some long arguments and are usually nested some indentations. So encapsulating it into seperate functions would be

[PATCH 3/4] usb: Add usb port system pm support

2013-03-27 Thread Lan Tianyu
This patch is to add usb port system pm support. Add usb port's system suspend/resume callbacks and call usb_port_runtime_resume/suspend() to power off these ports whose pm qos NO_POWER_OFF flag is not set, system wakeup is disabled and persist is enalbed. During system pm, usb port should be powe

[PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-27 Thread Lan Tianyu
Usb port isn't assigned to any bus_type. This seems not good from Greg's comments. http://marc.info/?l=linux-usb&m=136200364929942&w=2 This patch is to register usb port to usb_bus_type. The usb port's original name is "portX". This will cause name confilct after adding usb port to usb_bus

[PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-27 Thread Lan Tianyu
Some devices' firmware will be broken at some points. Power down and power on device can help device to rework in this case. This patch is to add ioctl cmd USBDEVFS_POWER_RESET for usbfs node to repower usb device. First, call hub_port_logical_disconnect() to disconnect device. Second, Power down

Re: [PATCH v7 1/6] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-27 Thread Michael Grzeschik
On Wed, Mar 27, 2013 at 09:31:33AM -0700, Greg KH wrote: > On Wed, Mar 27, 2013 at 05:21:13PM +0100, Michael Grzeschik wrote: > > The udc uses an shared dma memory space between hard and software. This > > memory layout is described in ci13xxx_qh and ci13xxx_td which are marked > > with the attribu

RE: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-27 Thread Lan, Tianyu
A small tool to test this patch. #include #include #include #include #include #include #define USBDEVFS_POWER_RESET _IO('U', 28) int main(int argc, char **argv) { const char *filename; int fd; int rc; if (argc != 2) { fprintf(stderr, "

Re: [PATCH V4 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-03-27 Thread Laurent Pinchart
Hi Bhupesh, Thanks for the patch. Please see below for a couple of small comments. On Thursday 21 March 2013 13:56:08 Bhupesh Sharma wrote: > This patch reworks the videobuffer management logic present in the UVC > webcam gadget and ports it to use the "more apt" videobuf2 framework for > video b

Re: [PATCH V4 2/2] usb: gadget/uvc: Add support for 'get_unmapped_area' for MMUless architectures

2013-03-27 Thread Laurent Pinchart
Hi Bhupesh, Thanks for the patch. On Thursday 21 March 2013 13:56:09 Bhupesh Sharma wrote: > This patch adds the support for 'get_unmapped_area' in UVC gadget > which is called when the 'mmap' system call is executed on MMUless > architectures. > > Signed-off-by: Bhupesh Sharma Acked-by: Laure

Re: usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread Laurent Pinchart
Hi Ravi, On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: > Hi > > I am observing issue while streaming video from usb camera connected to host > controller based on mentor graphics. The issue is root caused that there > are huge SOF gaps seen between the two isochronous IN token issued by host

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-27 Thread Alan Stern
On Wed, 27 Mar 2013, David Linares wrote: > Thanks Alan. I understand, but the USB cable is plugged into an AC/DC > adaptor which can provide an output of 1A. After breaking out an USB > cable, I measured that the consumption of my board is around 130mA > (nothing connected to the hub). Then I mea

Re: [PATCH 1/4] usb: add usb_enable/disable_remote_wakeup()

2013-03-27 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: > usb2.0 and usb3.0 devices have different ways to enalbe/disable > remote wakeup. This patch is to put both their operations into > the seperate functions. Otherwise, usb_control_msg() has some > long arguments and are usually nested some indentations. So >

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-27 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: > Some devices' firmware will be broken at some points. Power down > and power on device can help device to rework in this case. > > This patch is to add ioctl cmd USBDEVFS_POWER_RESET for usbfs node > to repower usb device. First, call hub_port_logical_disc

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-27 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: > This patch is to add usb port system pm support. Add > usb port's system suspend/resume callbacks and call > usb_port_runtime_resume/suspend() to power off these > ports whose pm qos NO_POWER_OFF flag is not set, system > wakeup is disabled and persist is e

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-27 Thread Alan Stern
On Thu, 28 Mar 2013, Lan Tianyu wrote: > Usb port isn't assigned to any bus_type. This seems not good from > Greg's comments. > http://marc.info/?l=linux-usb&m=136200364929942&w=2 > > This patch is to register usb port to usb_bus_type. The usb port's > original name is "portX". This will ca

RE: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-27 Thread Alan Stern
On Wed, 27 Mar 2013, Lan, Tianyu wrote: > A small tool to test this patch. > > #include > #include > #include > #include > #include > #include > > #define USBDEVFS_POWER_RESET _IO('U', 28) > > int main(int argc, char **argv) > { > const char *filename; > int fd; > in

RE: [PATCH/RFC] staging: dwc: Moving all hwcfg accesses to one place

2013-03-27 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Wednesday, March 27, 2013 8:42 AM > To: Greg KH > > Hi Greg, > > > But yes, it does seem to be a good idea, > > Ok, thanks. > > > as long as these options can't change over time. > It's only read-only registers, or registers whose pow

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Peter Vasil
Hi again, the patch works fine on my WM8850 netbook. I didn't get any unused-function warning on build, most likely because I have CONFIG_PM set in kernel config. Regards, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-27 Thread David Linares
On 27 March 2013 18:35, Alan Stern wrote: > On Wed, 27 Mar 2013, David Linares wrote: > >> Thanks Alan. I understand, but the USB cable is plugged into an AC/DC >> adaptor which can provide an output of 1A. After breaking out an USB >> cable, I measured that the consumption of my board is around 1

[PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
This lets us use the ehci-generic driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes problems with multiplatform configurations. Tested-by: Tony Prisk Tested-b

Piggy-backing new hardware using old usb-serial

2013-03-27 Thread Wesley W. Terpstra
Good evening, We are developing a custom piece of hardware that provides the equivalent of two serial console interfaces. They do not speak the AT command set. One port provides an interactive console to the user for configuration purposes (via minicom/etc). The other speaks a proprietary protocol

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-27 Thread Alan Stern
On Wed, 27 Mar 2013, David Linares wrote: > Please correct me if I am wrong. > On my iMX25 board, I have got a 1-port root_hub which will provide > 500mA max to its unique child. You should check that against the iMX25's specs. It's possible that the root hub has a current limit lower than 500

Re: Piggy-backing new hardware using old usb-serial

2013-03-27 Thread Greg KH
On Wed, Mar 27, 2013 at 08:45:38PM +0100, Wesley W. Terpstra wrote: > Good evening, > > We are developing a custom piece of hardware that provides the > equivalent of two serial console interfaces. They do not speak the AT > command set. One port provides an interactive console to the user for > c

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Alan Stern
On Wed, 27 Mar 2013, Arnd Bergmann wrote: > This lets us use the ehci-generic driver on platforms without special > requirements for their ehci controllers. Well, actually the driver's name is "ehci-platform". And the patch lets us use it on platforms where the DMA mask hasn't been set up, as o

[PATCH] USB: improve port transitions when EHCI starts up

2013-03-27 Thread Alan Stern
It seems to be getting more common recently for EHCI host controllers to be probed after their companion UHCI or OHCI controllers. This may be caused partly by splitting the ehci-pci driver out from ehci-hcd, or it may be caused by changes in the way the kernel does driver probing. Regardless, it

[PATCH] USB: avoid error messages when a device is disconnected

2013-03-27 Thread Alan Stern
This patch (as1673) reduces the amount of log spew from the hub driver by removing a bunch of error messages in the case where the device in question is already known to have been disconnected. Since the disconnect event itself appears in the log, there's no need for other error messages. Signed-

[PATCH 1/2] USB: use "global suspend" for system sleep on USB-2 buses

2013-03-27 Thread Alan Stern
This patch (as1674) speeds up system sleep transitions by not suspending each individual device on a USB-1.1 or USB-2 bus. The devices will automatically go into suspend when their root hubs are suspended (i.e., stop sending out Start-Of-Frame packets) -- this is what the USB spec calls "global su

[PATCH 2/2] USB: remove CONFIG_USB_SUSPEND option

2013-03-27 Thread Alan Stern
This patch (as1675) removes the CONFIG_USB_SUSPEND option, essentially replacing it everywhere with CONFIG_PM_RUNTIME (except for one place in hub.c, where it is replaced with CONFIG_PM because the code needs to be used in both runtime and system PM). The net result is code shrinkage and simplific

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Alexander Shishkin
Michael Grzeschik writes: > On Wed, Mar 27, 2013 at 06:35:30PM +0200, Alexander Shishkin wrote: >> Michael Grzeschik writes: >> >> > Hi, >> > >> > this series solve some issues with the chipidea udc. >> > >> > The series is based on v3.9-rc4. >> > >> > Michael Grzeschik (6): >> > usb: chipide

Re: Piggy-backing new hardware using old usb-serial

2013-03-27 Thread Wesley W. Terpstra
On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: > > Our current prototypes borrow the Sierra VID > And the USB-IF might revoke your vendor id, if they find you shipping a > device with a different vendor id than the one you have been assigned. One of the reasons we borrowed that VID is that we d

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Peter Vasil
On Wed, Mar 27, 2013 at 9:09 PM, Alan Stern wrote: > On Wed, 27 Mar 2013, Arnd Bergmann wrote: > >> This lets us use the ehci-generic driver on platforms without special >> requirements for their ehci controllers. > > Well, actually the driver's name is "ehci-platform". And the patch > lets us us

Re: [PATCH v7 0/6] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
On Wed, Mar 27, 2013 at 10:24:04PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > On Wed, Mar 27, 2013 at 06:35:30PM +0200, Alexander Shishkin wrote: > >> Michael Grzeschik writes: > >> > >> > Hi, > >> > > >> > this series solve some issues with the chipidea udc. > >> > > >>

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
On Wednesday 27 March 2013, Peter Vasil wrote: > Hi, unfortunately I still can't apply it on 3.9-rc4 :-( > > $ git apply --check ehci-dt-bus-glue.patch > error: removal patch leaves file contents > error: drivers/usb/host/ehci-vt8500.c: patch does not apply > > Looks git really doesn't like ehci-

[PATCH v4] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
This lets us use the ehci-platform driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes problems with multiplatform configurations. Tested-by: Tony Prisk Tested-

Re: 3.8.4: ohci question

2013-03-27 Thread Bjorn Helgaas
[+cc linux-usb] On Wed, Mar 27, 2013 at 11:37 AM, Udo van den Heuvel wrote: > Hello, > > When my dmesg gives me a growing number of lines like the one below, > what is going on? > > ohci_hcd :00:12.0: urb 88023025c500 path 2 ep1in 6c16 cc 6 > --> status -71 > > Please let me know! >

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Peter Vasil
On Wed, Mar 27, 2013 at 10:41 PM, Arnd Bergmann wrote: > On Wednesday 27 March 2013, Peter Vasil wrote: >> Hi, unfortunately I still can't apply it on 3.9-rc4 :-( >> >> $ git apply --check ehci-dt-bus-glue.patch >> error: removal patch leaves file contents >> error: drivers/usb/host/ehci-vt8500.c:

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
On Wednesday 27 March 2013, Peter Vasil wrote: > Hm, no idea what the latest versions are :-) I use archlinux, with > latest updates installed. > Here are my git and patch versions: > > $ git --version > git version 1.8.2 > $ patch --version > GNU patch 2.7.1 > > Btw. my git understands format-pa

Re: xhci page fault panic on Ubuntu kernel with HP desktop hardware

2013-03-27 Thread Sarah Sharp
On Wed, Mar 27, 2013 at 02:24:24PM +0100, Yann Sionneau wrote: > > Le 26/03/2013 17:30, Sarah Sharp a écrit : > > On Tue, Mar 26, 2013 at 12:11:13PM +0100, Yann Sionneau wrote: > >> Le 25/03/2013 19:13, Sarah Sharp a écrit : > >>> On Mon, Mar 25, 2013 at 05:43:40PM +0100, Yann Sionneau wrote: > >>

[PATCH v8 4/8] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-27 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index

[PATCH v8 8/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-03-27 Thread Michael Grzeschik
The prepared memory for the qhead needs to be contiguos and 2K aligned. We change the code from allocating extra buffer for every ep qhead to one big area. This patch lowers the amount of code to prepare the memory. Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/ci.h | 9 +++--

[PATCH v8 2/8] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-27 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v8 7/8] usb: chipidea: udc: fix possible memory leak in _ep_nuke

2013-03-27 Thread Michael Grzeschik
In hardware_enqueue code adds one extra td with dma_pool_alloc if mReq->req.zero is true. When _ep_nuke will be called for that endpoint, dma_pool_free will not be called to free that memory again. That patch fixes this. Cc: stable Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c

[PATCH v8 6/8] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-27 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside usb_e

[PATCH v8 1/8] usb: chipidea: udc: add attribute aligned(4) to shared memory structs

2013-03-27 Thread Michael Grzeschik
The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The compiler currently does not know about the alignment of the memory layout, and will create strb and ldrb operations.

[PATCH v8 5/8] usb: chipidea: udc: don't truncate requests to single tds

2013-03-27 Thread Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the controller can handle with one td and to keep working. That patch fixes that with proper error handling instead. Reported-by: Felipe Balbi Signed-off-by: Michael Grzeschik --- drivers/usb/chipidea/udc.c | 4 ++-- 1 file change

[PATCH v8 0/8] usb: chipidea: udc: bugfixes

2013-03-27 Thread Michael Grzeschik
Hi, this series solve some issues with the chipidea udc. The series is based on v3.9-rc4. Thanks, Michael Michael Grzeschik (8): usb: chipidea: udc: add attribute aligned(4) to shared memory structs usb: chipidea: udc: only clear active and halted bits in qhead usb: chipidea: udc: move ZL

[PATCH v8 3/8] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-27 Thread Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Signed-off-by: Michael Grzeschik Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/udc.c | 3 ++-

Re: Piggy-backing new hardware using old usb-serial

2013-03-27 Thread Greg KH
On Wed, Mar 27, 2013 at 09:28:11PM +0100, Wesley W. Terpstra wrote: > On Wed, 2013-03-27 at 13:06 -0700, Greg KH wrote: > > > Our current prototypes borrow the Sierra VID > > And the USB-IF might revoke your vendor id, if they find you shipping a > > device with a different vendor id than the one y

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-27 Thread Lan Tianyu
On 2013/3/28 2:47, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote What happens if there's no device plugged in to the port, but the hub is enabled for remote wakeup? How will the hub be able to detect a plug-in event if the port isn't powered? Alan Stern Hi Alan: Great thanks

  1   2   >