RE: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Svetoslav Neykov
Hi Michael, On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote: Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are

[PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar manjunath.gou...@linaro.org Separate the SPEAr host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before SPEAr can

[PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers

2013-03-28 Thread Arnd Bergmann
Like the EHCI driver, OHCI supports a large number of different platform glue drivers by directly including them, which causes problems with conflicting macro definitions in some cases. As more ARM architecture specific back-ends are required to coexist in a single build, we should split those out

[PATCH v3 5/7] USB: EHCI: make ehci-atmel a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar manjunath.gou...@linaro.org Separate the Atmel host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before Atmel can

[PATCH v3 0/7] USB EHCI multiplatform series again

2013-03-28 Thread Arnd Bergmann
Hi Alan, These are the current patches from Manjunath, after I helped him address the remaining review comments and found a few more in the process. Unfortunately, Manjunath is currently on vacation and I will be away for the next couple of days when he returns, so I took the liberty to send the

[PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-28 Thread Arnd Bergmann
The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan

[PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar manjunath.gou...@linaro.org Separate the Orion host controller driver from ehci-hcd host code into its own driver module because of following reason. With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at

[PATCH v3 3/7] USB: EHCI: make ehci-s5p a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar manjunath.gou...@linaro.org Separate the Samsung S5P/EXYNOS host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed

[PATCH v3 6/7] USB: EHCI: make ehci-msm a separate driver

2013-03-28 Thread Arnd Bergmann
From: Manjunath Goudar manjunath.gou...@linaro.org Separate the Qualcomm QSD/MSM on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still

RE: [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver

2013-03-28 Thread Svetoslav Neykov
Alexander Shishkin wrote: No need to initialize it like this, it should save a few bytes in .data. Ok. Why can't you just use ci13xxx_platform_data? It looks like you don't need a glue driver is drivers/usb/chipidea at all, you can register ci_hdrc right from the ath79/dev-usb.c You are right. I

RE: [PATCH v2 1/2] usb: chipidea: big-endian support

2013-03-28 Thread Svetoslav Neykov
Alexander Shishkin wrote: Svetoslav Neykov svetos...@neykov.name writes: Convert between big-endian and little-endian format when accessing the usb controller structures which are little-endian by specification. Fix cases where the little-endian memory layout is taken for granted. The patch

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread David Howells
Sarah Sharp sarah.a.sh...@linux.intel.com wrote: I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI driver is built in? Or is there some other point I'm missing? Sorry, I

Re: [PATCH 2/4] usb: introduce usb force power off mechanism

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 05:00:23PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote: Some devices' firmware will be broken at some points. Power down and power on device can help device to rework in this case.

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Fri, Mar 29, 2013 at 03:08:17AM +0800, Lan Tianyu wrote: On 2013/3/29 2:53, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2 port2-2 port4-3 1-1

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Greg KH
On Thu, Mar 28, 2013 at 03:16:08PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: On Thu, Mar 28, 2013 at 02:44:01PM -0400, Alan Stern wrote: On Thu, 28 Mar 2013, Greg KH wrote: ls /sys/bus/usb/devices 1-0:1.02-0:1.0 port1-1 port1-1.3 port2-1.2

[PATCH v9 1/8] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-28 Thread Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 2 +- 1 file changed, 1

[PATCH v9 7/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-03-28 Thread Michael Grzeschik
The prepared memory for the qhead needs to be contiguos and 2K aligned. We change the code from allocating extra buffer for every ep qhead to one big area. This patch lowers the amount of code to prepare the memory. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de ---

[PATCH v9 8/8] usb: chipidea: udc: add the define TD_PAGE_COUNT and fix all users

2013-03-28 Thread Michael Grzeschik
A static count of transfer descriptors was used everywhere in the driver with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT, and replaces all users of this value. This way its possible to have only one parameter to change and limit the amount of buffer pointers per TD.

[PATCH v9 0/8] usb: chipidea: udc: cleanups and fixes for v3.10

2013-03-28 Thread Michael Grzeschik
Hi, this series contains simples fixes and cleanup patches for the chipidea udc. It is based on Alexander Shishkins ci-for-greg. Regards, Michael Michael Grzeschik (8): usb: chipidea: udc: only clear active and halted bits in qhead usb: chipidea: udc: move ZLT flag change to ep_enable

[PATCH v9 5/8] usb: chipidea: udc: don't truncate requests to single tds

2013-03-28 Thread Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the controller can handle with one td and to keep working. That patch fixes that with proper error handling instead. Reported-by: Felipe Balbi ba...@ti.com Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de ---

[PATCH v9 4/8] usb: chipidea: udc: rework ep_enable cap setting

2013-03-28 Thread Michael Grzeschik
This patch reworks the cap value from several read and write operations to one single operation. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 17 - 1 file changed, 8 insertions(+), 9

[PATCH v9 6/8] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-28 Thread Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We move its functionionality into an unlocked version. This patch removes potential unlocked timeslots inside isr_setup_status_phase and isr_get_status_response, in which the lock got released just before acquired again inside

[PATCH v9 2/8] usb: chipidea: udc: move ZLT flag change to ep_enable

2013-03-28 Thread Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the ZLT flag before every ep_prime. This patch moves this to the ep_enable and applies it only for non configuration endpoints. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Reviewed-by: Felipe Balbi ba...@ti.com

[PATCH v9 3/8] usb: chipidea: udc: read status of td only once in hardware_dequeue

2013-03-28 Thread Michael Grzeschik
This patch changes the read of the td status to one atomic operation to analyse coherent bits. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/udc.c

Re: [PATCH 4/4] usb: register usb port to usb_bus_type

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 03:56:17PM -0700, Greg KH wrote: Has anyone tried this patch with libusb? At this point, I don't know if it has tested with libusb or even lsusb. I didn't see this patch until today, and I have not tested it on the Intel platform that actually implements the port power

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-03-28 Thread Sarah Sharp
On Thu, Mar 28, 2013 at 10:32:53PM +, David Howells wrote: Sarah Sharp sarah.a.sh...@linux.intel.com wrote: I'm a little bit confused about your description for the second one. Did you need to change the #defines names because they could conflict with other drivers when the xHCI

Re: Piggy-backing new hardware using old usb-serial

2013-03-28 Thread Xiaofan Chen
On Thu, Mar 28, 2013 at 10:58 PM, Wesley W. Terpstra w.terps...@gsi.de wrote: In case anyone else cares, I found some nice Dutch folks who resell PIDs under their VID for cheap: http://www.mcselec.com/index.php?page=shop.product_detailsflypage=shop.flypageproduct_id=92option=com_phpshopItemid=1

drivers/usb/musb/tusb6010.c:946:2: error: implicit declaration of function 'irq_set_irq_type'

2013-03-28 Thread Fengguang Wu
Greetings, These *huge number* of *long standing* errors make me wonder whether the below USB driver code should be disabled on s390? tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master head: 9064171268d838b8f283fe111ef086b9479d059a commit:

Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Viresh Kumar
On Fri, Mar 29, 2013 at 3:25 AM, Arnd Bergmann a...@arndb.de wrote: From: Manjunath Goudar manjunath.gou...@linaro.org Separate the SPEAr host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Hi, On Thu, Mar 28, 2013 at 9:27 PM, Felipe Balbi ba...@ti.com wrote: On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote: Hi, On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi ravib...@ti.com wrote: For example, in one

Re: [PATCH 3/4] usb: Add usb port system pm support

2013-03-28 Thread Lan Tianyu
On 2013/3/29 4:47, Sarah Sharp wrote: On Thu, Mar 28, 2013 at 07:58:47AM +0800, Lan Tianyu wrote: On 2013/3/28 2:47, Alan Stern wrote: On Thu, 28 Mar 2013, Lan Tianyu wrote What happens if there's no device plugged in to the port, but the hub is enabled for remote wakeup? How will the hub be

<    1   2