RE: [PATCH] usb: renesas_usbhs: Revise the binding document about the dma-names

2015-04-27 Thread Yoshihiro Shimoda
Hi Felipe, > Sent: Thursday, April 09, 2015 6:06 PM > > On Thu, Apr 09, 2015 at 01:17:44AM +0100, Yoshihiro Shimoda wrote: > > Hi Mark, > > > > > > > > On Wed, Apr 08, 2015 at 11:42:24AM +0100, Yoshihiro Shimoda wrote: > > > > Since the DT should describe the hardware (not the driver limitation)

RE: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-27 Thread Yoshihiro Shimoda
Hi, > Sent: Tuesday, April 28, 2015 4:45 AM > > Hi, > > On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote: > > According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK > > bit location is bit 8, not bits 9 and 8. So, this patch fixes the > > USBHS_UGSTS_LOCK value.

RE: [PATCH] [RFC] usb: xhci: Add to check CRR bit in xhci_suspend()

2015-04-27 Thread Yoshihiro Shimoda
Hi, Thank you for the comments! > Sent: Monday, April 27, 2015 10:15 PM > > On 27.04.2015 11:55, Yoshihiro Shimoda wrote: > Hi > > > According to the xHCI spec "4.23.2 xHCI Power Management", the CRR bit > > of CRCR register should be zero before setting Run/Stop (R/S) = '0'. > > Otherwise, the

Re: [PATCH v4 0/8] add HNP polling support for usb otg fsm

2015-04-27 Thread Felipe Balbi
On Mon, Apr 20, 2015 at 10:00:49PM +0800, Li Jun wrote: > On Thu, Mar 26, 2015 at 05:38:11PM +0800, Peter Chen wrote: > > On Wed, Mar 25, 2015 at 07:25:24PM +0800, Li Jun wrote: > > > On Wed, Mar 25, 2015 at 02:43:43PM +0800, Chen Peter-B29397 wrote: > > > > > > > > > On Wed, Mar 25, 2015 at 02:0

[PATCH V7 1/9] xhci: Set shared HCD's hcd_priv in xhci_gen_setup

2015-04-27 Thread Andrew Bresticker
xhci_gen_setup() sets the hcd_priv field for the primary HCD, but not for the shared HCD, requiring xHCI host-controller drivers to set it between usb_create_shared_hcd() and usb_add_hcd(). There's no reason xhci_gen_setup() can't set the shared HCD's hcd_priv as well, so move that bit out of the

[PATCH V7 3/9] mailbox: Fix up error handling in mbox_request_channel()

2015-04-27 Thread Andrew Bresticker
From: Benson Leung mbox_request_channel() currently returns EBUSY in the event the controller is not present or if of_xlate() fails, but in neither case is EBUSY really appropriate. Return EPROBE_DEFER if the controller is not yet present and change of_xlate() to return an ERR_PTR instead of NUL

[PATCH V7 2/9] mailbox: Make struct mbox_controller's ops field const

2015-04-27 Thread Andrew Bresticker
The mailbox controller's channel ops ought to be read-only. Signed-off-by: Andrew Bresticker Cc: Jassi Brar --- No changes from v5/v6. New for v5. --- include/linux/mailbox_controller.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mailbox_controller.h b/inc

[PATCH V7 8/9] usb: Add NVIDIA Tegra xHCI controller binding

2015-04-27 Thread Andrew Bresticker
Add device-tree binding documentation for the xHCI controller present on Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: Mathias Nyman Cc: Greg Kroah-Hartman --- Changes from v6: - Removed XUSB_D

[PATCH V7 7/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2015-04-27 Thread Andrew Bresticker
The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single physical channel, messages sent by the controller can be divided into two groups: those intended for the PHY driver and those intended for the host-controller

[PATCH V7 4/9] mfd: Add binding document for NVIDIA Tegra XUSB

2015-04-27 Thread Andrew Bresticker
Add a binding document for the XUSB host complex on NVIDIA Tegra124 and later SoCs. The XUSB host complex includes a mailbox for communication with the XUSB micro-controller and an xHCI host-controller. Signed-off-by: Andrew Bresticker Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian C

[PATCH V7 6/9] mailbox: Add NVIDIA Tegra XUSB mailbox binding

2015-04-27 Thread Andrew Bresticker
Add device-tree bindings for the Tegra XUSB mailbox which will be used for communication between the Tegra xHCI controller's firmware and the host processor. Signed-off-by: Andrew Bresticker Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Cc: Jassi Brar --- C

[PATCH V7 5/9] mfd: Add driver for NVIDIA Tegra XUSB

2015-04-27 Thread Andrew Bresticker
Add an MFD driver for the XUSB host complex found on NVIDIA Tegra124 and later SoCs. Signed-off-by: Andrew Bresticker Cc: Samuel Ortiz Cc: Lee Jones --- New for v7. --- drivers/mfd/Kconfig | 7 ++ drivers/mfd/Makefile | 1 + drivers/mfd/tegra-xusb.c | 167 +

[PATCH V7 9/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver

2015-04-27 Thread Andrew Bresticker
Add support for the on-chip xHCI host controller present on Tegra SoCs. The controller requires external firmware which must be loaded before using the controller. This driver loads the firmware, starts the controller, and is able to service host-specific messages sent by the controller's firmware

[PATCH V7 0/9] Tegra xHCI support

2015-04-27 Thread Andrew Bresticker
This series adds support for xHCI on NVIDIA Tegra SoCs. This includes: - patches 1, 2, and 3: minor cleanups for mailbox framework and xHCI, - patches 4 and 5: adding an MFD driver for the XUSB cmoplex, - patches 6 and 7: adding a driver for the mailbox used to communicate with the xHCI cont

Re: [RFC 5/6] usb: gadget: atmel_usba: use atmel_io.h to provide on-chip IO

2015-04-27 Thread Felipe Balbi
On Thu, Mar 26, 2015 at 12:56:47PM +0100, Hans-Christian Egtvedt wrote: > Around Thu 26 Mar 2015 11:45:53 + or thereabout, Ben Dooks wrote: > > Use to provide IO accessors which work on both > > AVR32 and ARM for on-chip peripherals. > > > > Signed-off-by: Ben Dooks > > Acked-by: Hans-Chris

Re: [PATCH v4 14/22] usb: dwc2: host: register handle to the phy

2015-04-27 Thread Felipe Balbi
On Tue, Mar 24, 2015 at 10:01:02AM +0100, Mian Yousaf Kaukab wrote: > If phy driver is present register hcd handle to it. > > Signed-off-by: Mian Yousaf Kaukab > --- > drivers/usb/dwc2/hcd.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2

Re: [PATCH v4 15/22] usb: dwc2: host: add bus_suspend/bus_resume callback

2015-04-27 Thread Felipe Balbi
On Tue, Mar 24, 2015 at 10:01:03AM +0100, Mian Yousaf Kaukab wrote: > From: Gregory Herrero missing commit log. > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/hcd.c | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dw

Re: [PATCH v4 00/22] usb: third series of updates for dwc2 driver

2015-04-27 Thread Felipe Balbi
On Wed, Apr 01, 2015 at 07:03:31PM -0700, John Youn wrote: > On 3/24/2015 2:00 AM, Mian Yousaf Kaukab wrote: > > Hi, > > This patchset consists of some bug fixes and feature enhancements for > > the dwc2 driver. All the patches are verified on dwc2 v3.0a with > > dedicated fifos. Main focus of test

Re: [PATCH v4 12/22] usb: dwc2: gadget: enable otg flag in dual role configuration

2015-04-27 Thread Felipe Balbi
On Tue, Mar 24, 2015 at 10:01:00AM +0100, Mian Yousaf Kaukab wrote: > From: Gregory Herrero missing commit log. > Signed-off-by: Gregory Herrero > --- > drivers/usb/dwc2/gadget.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >

Re: [PATCH v4 18/22] usb: dwc2: host: don't use dma_alloc_coherent with irqs disabled

2015-04-27 Thread Felipe Balbi
Hi, On Tue, Mar 24, 2015 at 10:01:06AM +0100, Mian Yousaf Kaukab wrote: > diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c > index 63207dc..3735ae6 100644 > --- a/drivers/usb/dwc2/hcd_queue.c > +++ b/drivers/usb/dwc2/hcd_queue.c > @@ -231,9 +231,10 @@ void dwc2_hcd_qh_free(

Re: [PATCH] usb: gadget: xudc: fix return value check in xudc_probe()

2015-04-27 Thread Felipe Balbi
Hi, On Thu, Apr 16, 2015 at 08:17:30PM +0800, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns > ERR_PTR() and never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yon

Re: [PATCH] usb: phy: rcar-gen2-usb: Fix USBHS_UGSTS_LOCK value

2015-04-27 Thread Felipe Balbi
Hi, On Thu, Apr 02, 2015 at 08:22:34PM +0900, Yoshihiro Shimoda wrote: > According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK > bit location is bit 8, not bits 9 and 8. So, this patch fixes the > USBHS_UGSTS_LOCK value. > > Signed-off-by: Yoshihiro Shimoda this doesn't apply t

Re: [PATCH 1/1] drivers/usb/chipidea/debuc.c: avoid out of bound read

2015-04-27 Thread Heinrich Schuchardt
On 22.04.2015 03:26, Peter Chen wrote: > On Tue, Apr 21, 2015 at 09:25:41PM +0200, Heinrich Schuchardt wrote: >> Hello Peter, >> >> thanks for reviewing. >> >> On 21.04.2015 03:32, Peter Chen wrote: >>> On Fri, Apr 17, 2015 at 08:04:13AM +0200, Heinrich Schuchardt wrote: A string written by th

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

2015-04-27 Thread Felipe Balbi
On Mon, Apr 27, 2015 at 07:55:58AM -0700, David Cohen wrote: > On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote: > > Hi, > > Hi Felipe, > > > > > On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote: > > > > > > > When going into bus suspend/resume we _must_ > > > > > > > call

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Joao Pinto
Hi, On 4/27/2015 4:49 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 27, 2015 at 04:04:08PM +0100, Joao Pinto wrote: >> Hi Filipe, > > that's Felipe (and yes, I know it's João, but you spelled it without ~) > > :-) > >> On 4/27/2015 3:56 PM, Felipe Balbi wrote: >>> Hi Joao, >>> >>> On Mon, Apr

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Felipe Balbi
Hi, On Mon, Apr 27, 2015 at 04:04:08PM +0100, Joao Pinto wrote: > Hi Filipe, that's Felipe (and yes, I know it's João, but you spelled it without ~) :-) > On 4/27/2015 3:56 PM, Felipe Balbi wrote: > > Hi Joao, > > > > On Mon, Apr 27, 2015 at 03:48:48PM +0100, Joao Pinto wrote: > My name i

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Joao Pinto
Hi Filipe, On 4/27/2015 3:56 PM, Felipe Balbi wrote: > Hi Joao, > > On Mon, Apr 27, 2015 at 03:48:48PM +0100, Joao Pinto wrote: My name is Joao Pinto and I am working at Synopsys as a Software Engineer mainly in the USB Subsystem. I am sending you this email in order to

Re: ZLP sending request from gadget

2015-04-27 Thread Peter Stuge
Felipe Balbi wrote: > On Mon, Apr 27, 2015 at 10:57:24AM +0530, Anjana V Kumar wrote: > > But we see that the serial gadget driver does not set req->zero. But > > others like u_ether and f_massstorage are setting the same. > > > > Is there any specific reason why this is not done in gadget serial

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Felipe Balbi
Hi Joao, On Mon, Apr 27, 2015 at 03:48:48PM +0100, Joao Pinto wrote: > >> My name is Joao Pinto and I am working at Synopsys as a Software Engineer > >> mainly > >> in the USB Subsystem. > >> > >> I am sending you this email in order to know if someone is already working > >> in > >> the driver'

Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume

2015-04-27 Thread David Cohen
On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote: > Hi, Hi Felipe, > > On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote: > > > > > > When going into bus suspend/resume we _must_ > > > > > > call gadget driver's ->suspend/->resume callbacks > > > > > > accordingly. This pat

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Joao Pinto
Hi Greg, On 4/27/2015 3:27 PM, Greg KH wrote: > On Mon, Apr 27, 2015 at 09:59:19AM +0100, Joao Pinto wrote: >> Hi, >> >> My name is Joao Pinto and I am working at Synopsys as a Software Engineer >> mainly >> in the USB Subsystem. >> >> I am sending you this email in order to know if someone is al

Re: ZLP sending request from gadget

2015-04-27 Thread Felipe Balbi
On Mon, Apr 27, 2015 at 10:57:24AM +0530, Anjana V Kumar wrote: > Hi Balbi, > > This is regarding the gadget serial (serial.c) deciding to send the > ZLP by setting req->zero to 1/0. > > The udc driver in our case decides to send the ZLP based on the > req->zero value set by the gadget. > > But

Re: [PATCH v2] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-27 Thread Alan Stern
On Mon, 27 Apr 2015, Ivan T. Ivanov wrote: > This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use > devm_ioremap_resource instead of devm_ioremap") and commit > e507bf577e5a ("host: ehci-msm: remove duplicate check on resource"), > because msm_otg and this driver are using same address spac

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-27 Thread Sasha Levin
On 04/27/2015 05:44 AM, Johan Hovold wrote: >>> Could you try updating to 3.19 (or later) or to cherry pick aa8e22128b40 >>> > > ("usb: serial: silence all non-critical read errors") and see if that >>> > > helps? >>> > > >>> > > We should backport that one to stable either way. > You may want to

Re: Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 09:59:19AM +0100, Joao Pinto wrote: > Hi, > > My name is Joao Pinto and I am working at Synopsys as a Software Engineer > mainly > in the USB Subsystem. > > I am sending you this email in order to know if someone is already working in > the driver' development for Synopsy

Re: [PATCH] [RFC] usb: xhci: Add to check CRR bit in xhci_suspend()

2015-04-27 Thread Mathias Nyman
On 27.04.2015 11:55, Yoshihiro Shimoda wrote: Hi > According to the xHCI spec "4.23.2 xHCI Power Management", the CRR bit > of CRCR register should be zero before setting Run/Stop (R/S) = '0'. > Otherwise, the STS_HALT is not set until the CRR is cleared on specific > xHCI controllers. In case of

[PATCH v2] Revert "usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap"

2015-04-27 Thread Ivan T. Ivanov
This reverts commit 70843f623b58 ("usb: host: ehci-msm: Use devm_ioremap_resource instead of devm_ioremap") and commit e507bf577e5a ("host: ehci-msm: remove duplicate check on resource"), because msm_otg and this driver are using same address space to access AHB mode and USB command registers. Cc:

Re: [PATCH] libusbg: print leading zero for MAC address bytes

2015-04-27 Thread Krzysztof Opasiak
Hello Stefan, On 04/24/2015 09:27 PM, Stefan Agner wrote: The ethernet gadget driver requires the hex formatted MAC address bytes with leading zero, in other words each byte needs to be two characters in length (see get_ether_addr in u_ether.c). The libc implementation ether_ntoa does not print

Re: [BUG] xhci_hcd: intermittent bug with VL812 hub: Bad Slot ID 2 Could not allocate xHCI USB device data structures

2015-04-27 Thread Mathias Nyman
On 27.04.2015 12:30, Johan Hovold wrote: > On Sat, Apr 25, 2015 at 10:39:23PM +0100, Chris Bainbridge wrote: >> Kernel: v4.0-10710-g27cf3a1 >> >> Hardware: >> >> IvyBridge Macbook (Panther Point PCH), 2 external USB3 ports >> AmazonBasics 10 Port USB 3.0 Hub (3x VIA VL812 hub controllers) >> >> Bug

Re: cdc_mbim with Huawei E3372, nothing works

2015-04-27 Thread Bjørn Mork
Sami Farin writes: > Now with kernel 4.0.0+ModemManager 1.4.8: > > wwp5s0u1c2: flags=4291 mtu 1500 > inet 46.132.185.141 netmask 255.255.255.252 broadcast 46.132.185.143 > ether 4a:2a:90:69:e7:ad txqueuelen 1000 (Ethernet) > RX packets 0 bytes 0 (0.0 B) > RX

Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()

2015-04-27 Thread Johan Hovold
Hi Sasha, On Wed, Apr 08, 2015 at 05:29:16PM +, Mark Enstone wrote: > Everyone, thank you for your attention and suggestions. > > Johan, perfect, thank you, that did indeed help and has fixed the > issue I was seeing. > > The change replaced dev_err() with dev_dbg() -- thus not logging (by

[PATCH] usb: gadget: ether: Fix MAC address parsing

2015-04-27 Thread Krzysztof Opasiak
MAC address is often written without leading zeros. Example: 00:14:3d:0f:ff:fe can be written as 0:14:3d:f:ff:fe Convention of skipping leading zeros is used in libc. enther_ntoa_r() generates MAC address without leading zeros. Fix get_ether_addr() to correctly parse MAC address with and without

Re: [BUG] xhci_hcd: intermittent bug with VL812 hub: Bad Slot ID 2 Could not allocate xHCI USB device data structures

2015-04-27 Thread Johan Hovold
On Sat, Apr 25, 2015 at 10:39:23PM +0100, Chris Bainbridge wrote: > Kernel: v4.0-10710-g27cf3a1 > > Hardware: > > IvyBridge Macbook (Panther Point PCH), 2 external USB3 ports > AmazonBasics 10 Port USB 3.0 Hub (3x VIA VL812 hub controllers) > > Bug: > > In ~7%-10% of boots there is an error: >

Re: [PATCH,v2] usbhid: Add a quirk for raphnet multi-gamepad adapters

2015-04-27 Thread Jiri Kosina
On Sat, 25 Apr 2015, Raphael Assenat wrote: > The raphnet.net 4nes4snes and 2nes2snes multi-joystick adapters use a > single HID report descriptor with one report ID per controller. This > has the effect that the inputs of otherwise independent game controllers > get packed in one large joystick d

Synopsys IPs: USB 3.1 Device & Host and USB 2.0 OTG

2015-04-27 Thread Joao Pinto
Hi, My name is Joao Pinto and I am working at Synopsys as a Software Engineer mainly in the USB Subsystem. I am sending you this email in order to know if someone is already working in the driver' development for Synopsys' USB 3.1 Host & Device and USB 2.0 OTG Controllers. a) If no one is workin

[PATCH] [RFC] usb: xhci: Add to check CRR bit in xhci_suspend()

2015-04-27 Thread Yoshihiro Shimoda
According to the xHCI spec "4.23.2 xHCI Power Management", the CRR bit of CRCR register should be zero before setting Run/Stop (R/S) = '0'. Otherwise, the STS_HALT is not set until the CRR is cleared on specific xHCI controllers. In case of R-Car SoCs, it spent about 90 ms to clear the CRR. So, to

Re: cdc_mbim with Huawei E3372, nothing works

2015-04-27 Thread Sami Farin
On Mon, Feb 23, 2015 at 11:59:14 +0100, Bjørn Mork wrote: > Aleksander Morgado writes: > > > On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin > > wrote: > >> ifconfig > >> wwp3s0u1c2: flags=4291 mtu 1500 > >> inet 46.132.188.224 netmask 255.255.255.192 broadcast > >> 46.132.188.255 > >>