RE: [PATCH 1/3][v2] Documentation: dt: dwc3: Add snps,quirk-frame-length-adjustment property

2015-08-31 Thread Badola Nikhil
> -Original Message- > From: Nikhil Badola [mailto:nikhil.bad...@freescale.com] > Sent: Monday, August 17, 2015 9:54 AM > To: linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; linux- > u...@vger.kernel.org > Cc: ba...@ti.com; Badola Nikhil-B46172 > Subject: [PATCH 1/3][v2] Document

[PATCH v2 4/7] usb: misc: usbtest: format the data pattern according to max packet size

2015-08-31 Thread Peter Chen
From: Alan Stern With this change, the host and gadget doesn't need to agree with transfer length for comparing the data, since they doesn't know each other's transfer size, but know max packet size. Signed-off-by: Peter Chen Acked-by: Michal Nazarewicz (Fixed the 'line over 80 characters warn

[PATCH v2 7/7] tools: usb: testusb: change the default value for length from 512 to 1024

2015-08-31 Thread Peter Chen
For ctrl out test, it needs length > vary, so in order to run it with default parameters, we do this change. Acked-by: Michal Nazarewicz Cc: Michal Nazarewicz Signed-off-by: Peter Chen --- tools/usb/testusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/usb/tes

[PATCH v2 2/7] usb: misc: usbtest: delete useless memset for urbs array

2015-08-31 Thread Peter Chen
The element of urbs array will be initialized at below code at once. for (i = 0; i < param->sglen; i++) { urbs[i] = iso_alloc_urb(udev, pipe, desc, param->length, offset); Acked-by: Michal Nazarewicz Signed-off-by: Peter Chen ---

[PATCH v2 5/7] usb: gadget: f_sourcesink: format data pattern according to max packet size

2015-08-31 Thread Peter Chen
Since the host and gadget can't agree with transfer length before each transfer, but they agree with max packet size for each endpoint, we use max packet size to format data pattern. Acked-by: Michal Nazarewicz Signed-off-by: Peter Chen --- drivers/usb/gadget/function/f_sourcesink.c | 6 --

[PATCH v2 3/7] usb: misc: usbtest: using the same data format among write/compare/output

2015-08-31 Thread Peter Chen
Using the same data format "buf[j] = (u8)(i + j)" among write, compare buf, and console output stage. Acked-by: Michal Nazarewicz Signed-off-by: Peter Chen --- drivers/usb/misc/usbtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/usbtest.c b/drive

[PATCH v2 6/7] tools: usb: testusb: change the help text

2015-08-31 Thread Peter Chen
The 'length' is the transfer length, not the packet size, so change the help text. Acked-by: Michal Nazarewicz Cc: Michal Nazarewicz Signed-off-by: Peter Chen --- tools/usb/testusb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/usb/testusb.c b/tools/usb/tes

[PATCH v2 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-08-31 Thread Peter Chen
Allocate the size of urb pointer array according to testusb's parameter sglen, and limits the length of sglen as MAX_SGLEN (128 currently). Acked-by: Michal Nazarewicz Signed-off-by: Peter Chen --- drivers/usb/misc/usbtest.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff -

[PATCH v2 0/7] usb: usbtest misc changes

2015-08-31 Thread Peter Chen
Changes for v2: - Add le16_to_cpu to read descriptor value [Patch 5/7] - Add MAX_SGLEN (128 currently) for maximum sglen [Patch 1/7] - Using local variable to save max macket size value, in case some compiler create more code for dereferences all the pointers at every iteration. [Patch 5/7] H

RE: [RESEND PATCH v2] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-08-31 Thread Du, Changbin
I am sorry, I forget to remove them. It is generated by git and I send the patch with outlook. I will use git-send-email instead next time if my email account work. Regards Du, Changbin > -Original Message- > From: 'Greg Kroah-Hartman' [mailto:gre...@linuxfoundation.org] > Sent: Monday,

Re: [PATCH v2 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-31 Thread Peter Chen
On Mon, Aug 31, 2015 at 09:49:51AM -0500, Nathan Sullivan wrote: > Due to having hardware tx buffers less than 512 bytes in size, streaming > must be enabled on the Zynq for the udc to work at all. Add platform data > specific to the Zynq udc, which does not set the CI_HDRC_DISABLE_STREAMING > fla

Re: [PATCH 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-08-31 Thread Peter Chen
On Mon, Aug 31, 2015 at 03:17:06PM +0200, Oliver Neukum wrote: > On Mon, 2015-08-31 at 13:01 +0200, Michal Nazarewicz wrote: > > On Fri, Aug 28 2015, Peter Chen wrote: > > > Allocate the size of urb pointer array according to testusb's > > > parameter sglen. > > > > > > Signed-off-by: Peter Chen >

[PATCH] xhci: fix warning when CONFIG_PM disabled.

2015-08-31 Thread Dave Hansen
From: Dave Hansen I have a .config with CONFIG_PM disabled. I get the following whenever compiling the xhci driver: drivers/usb/host/xhci-pci.c:192:13: warning: ‘xhci_pme_quirk’ defined but not used [-Wunused-function] Looks like we just need to move xhci_pme_quirk() to be underneath the

qcserial: AT unsolicited response codes missing with Dell Wireless 5808e

2015-08-31 Thread Ward, David - 0665 - MITLL
On 01/06/2015 03:58 AM, Bjørn Mork wrote: > Johan Hovold writes: > >> Ok, let's move the PID to option and if it turns out that more of these >> devices require the modem-control signals (e.g. with more recent >> firmware) we can consider moving it back after adding such support to >> qcserial. >>

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread Sergei Shtylyov
Hello. On 08/31/2015 07:48 PM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out fine, but after a bit of data has been transferred it just stops flowi

Re: [PATCH v7 1/2] usb: make xhci platform driver use 64 bit or 32 bit DMA

2015-08-31 Thread Duc Dang
On Thu, Aug 20, 2015 at 12:38 PM, Duc Dang wrote: > The xhci platform driver needs to work on systems that > either only support 64-bit DMA or only support 32-bit DMA. > Attempt to set a coherent dma mask for 64-bit DMA, and > attempt again with 32-bit DMA if that fails. > > [dhdang: regenerate th

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread Felipe Balbi
Hi, On Mon, Aug 31, 2015 at 01:50:10PM -0500, Felipe Balbi wrote: > > > > From: Ville Syrjälä > > > > > > > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. > > > > > > > > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out > > > > fine, but after a bit of da

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread Felipe Balbi
Hi, On Mon, Aug 31, 2015 at 08:25:10PM +0300, Ville Syrjälä wrote: > On Mon, Aug 31, 2015 at 11:54:13AM -0500, Felipe Balbi wrote: > > On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > This reverts commit 8f2c9544aba63613430

[PATCH] USB: option: Sierra Wireless MC73xx -> Sierra Wireless MC7304/MC7354

2015-08-31 Thread David Ward
Other Sierra Wireless MC73xx devices exist, with different USB IDs. Cc: Bjørn Mork Signed-off-by: David Ward --- drivers/usb/serial/option.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 876423b..cc3e1c7

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread Ville Syrjälä
On Mon, Aug 31, 2015 at 11:54:13AM -0500, Felipe Balbi wrote: > On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. > > > > As it breaks g_ether on my Baytrail FFRD8 device. E

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread Felipe Balbi
On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. > > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out > fine, but after a bit of data has been transferred

[PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-08-31 Thread ville . syrjala
From: Ville Syrjälä This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. As it breaks g_ether on my Baytrail FFRD8 device. Everything starts out fine, but after a bit of data has been transferred it just stops flowing. Note that I do get a bunch of these "NOHZ: local_softirq_pending 08

[PATCH v2 0/1] USB DWC2 parity fix in isochronous mode

2015-08-31 Thread Scott Branden
This patch contains a fix for a real world interop problem found when using the Synopsis DWC2 USB controller with isochronous audio as detailed in the commit message. Changes from v1: - Address code review comments as per previous responses: - renamed parity_set to has_correct_parity and reorder

[PATCH v2 1/1] usb: dwc2: gadget: parity fix in isochronous mode

2015-08-31 Thread Scott Branden
From: Roman Bacik USB OTG driver in isochronous mode has to set the parity of the receiving microframe. The parity is set to even by default. This causes problems for an audio gadget, if the host starts transmitting on odd microframes. This fix uses Incomplete Periodic Transfer interrupt to togg

Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case

2015-08-31 Thread Gregory CLEMENT
Hi Felipe, On ven., août 21 2015, Gregory CLEMENT wrote: >> According to the OTG specification after a timeout of >> OTG_TIME_A_WAIT_VRISE (the maximum value is 100ms) the driver must >> move from the state a_wait_vrise to the state a_wait_bcon. However, >> the dsps version of musb does not ha

[PATCH 0/2] AM437x: USB DWC3: save power during system sleep

2015-08-31 Thread Sekhar Nori
Hi, This series add support to DWC3 core to conserve power during system sleep by setting the USB DRVVBUS line to a lower power consuming state. Tested to make sure USB host and device works on AM437x with v4.2. Tested for power savings on v4.1 kernel where there is an implementation of suspend-

[PATCH 1/2] usb: dwc3: support for pinctrl state change during system sleep

2015-08-31 Thread Sekhar Nori
Add support for USB DRVVBUS pinctrl state change during suspend/resume. This helps is conserving power during system sleep. Signed-off-by: Sekhar Nori --- drivers/usb/dwc3/core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index ff577

[PATCH 2/2] ARM: dts: am437x-gp-evm: Add pinctrl states for usb

2015-08-31 Thread Sekhar Nori
From: Dave Gerlach Add pinctrl default and sleep states for each usb device. The only pin that can be controlled is USB_DRVVBUS, this must be set to MUX_MODE7 (gpio) during sleep to conserve power. Signed-off-by: Dave Gerlach [nsek...@ti.com: move pins to core dwc3] Signed-off-by: Sekhar Nori

Re: xHCI reports “ERROR Unknown event condition 20, HC probably busted”

2015-08-31 Thread Steinar H. Gunderson
On Mon, Aug 31, 2015 at 06:03:17PM +0300, Mathias Nyman wrote: > It's in 4.2-rc6. > I understood you were running 4.2-rc8, so it should be there. Yes, the error was with 4.2-rc8. /* Steinar */ -- Homepage: http://www.sesse.net/ -- To unsubscribe from this list: send the line "unsubscribe linux-u

Re: xHCI reports “ERROR Unknown event condition 20, HC probably busted”

2015-08-31 Thread Mathias Nyman
The "ERROR Transfer event TRB DMA ptr not part of curren..." errors are a bit worrying. I was hoping these would no longer occur after the last off by one fix: commit 7895086afde2a05fa24a0e410d8e6b75ca7c8fdd xhci: fix off by one error in TRB DMA address boundary check That's in 3.12? Th

[PATCH v2 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-31 Thread Nathan Sullivan
Due to having hardware tx buffers less than 512 bytes in size, streaming must be enabled on the Zynq for the udc to work at all. Add platform data specific to the Zynq udc, which does not set the CI_HDRC_DISABLE_STREAMING flag. Based on a patch by the same name from the Xilinx vendor tree. Signe

[PATCH v2 2/2] Documentation: bindings: add doc for zynq USB

2015-08-31 Thread Nathan Sullivan
Document the binding for the zynq specific chipidea UDC binding. Signed-off-by: Nathan Sullivan --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt |1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bin

RE: [PATCH 00/32] usb: dwc2: various bug fixes

2015-08-31 Thread Kaukab, Yousaf
> -Original Message- > From: Robert Baldyga [mailto:r.bald...@samsung.com] > Sent: Monday, August 31, 2015 4:46 PM > To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; > john.y...@synopsys.com > Cc: Herrero, Gregory; he...@sntech.de; diand...@chromium.org; > dingu...@opensource.al

Re: [PATCH 00/32] usb: dwc2: various bug fixes

2015-08-31 Thread Robert Baldyga
On 08/28/2015 12:27 PM, Mian Yousaf Kaukab wrote: > Hi, > This series consists of various bug fixes for both host and gadget > sides. All patches are verified on dwc2 v3.0a with dedicated fifos. > It would be good to get some Tested-bys for other platforms. > > It is based on testing/next branch i

Re: xHCI reports “ERROR Unknown event condition 20, HC probably busted”

2015-08-31 Thread Steinar H. Gunderson
On Mon, Aug 31, 2015 at 05:28:10PM +0300, Mathias Nyman wrote: > The max exit latency should tell how long it can maximum take for the entire > link between host > and device to wake up and be fully functional. Isoc transfer will send a PING > TP max exit > latency before the first data transfer

RE: [PATCH 05/32] usb: dwc2: host: update hcd and lx_state during start/stop callbacks

2015-08-31 Thread Kaukab, Yousaf
> -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Friday, August 28, 2015 11:50 PM > To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; > john.y...@synopsys.com > Cc: Herrero, Gregory; he...@sntech.de; diand...@chromium.org; > r.bald

Re: xHCI reports “ERROR Unknown event condition 20, HC probably busted”

2015-08-31 Thread Mathias Nyman
On 29.08.2015 17:06, Steinar H. Gunderson wrote: On Sat, Aug 29, 2015 at 12:17:25AM +0200, Steinar H. Gunderson wrote: I've noticed (with the CONFIG_PM=y kernel) that sometimes this comes up when inserting the device: [ 136.370917] usb 3-2: Set SEL for device-initiated U2 failed. I don't know

Re: [PATCH 5/7] usb: gadget: f_sourcesink: format data pattern according to max packet size

2015-08-31 Thread Alan Stern
On Fri, 28 Aug 2015, Peter Chen wrote: > Since the host and gadget can't agree with transfer length before > each transfer, but they agree with max packet size for each > endpoint, we use max packet size to format data pattern. > > Signed-off-by: Peter Chen > --- > drivers/usb/gadget/function/f

Re: [RESEND PATCH v2] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-08-31 Thread 'Greg Kroah-Hartman'
On Mon, Aug 31, 2015 at 04:51:22AM +, Du, Changbin wrote: > >From 08df419517694c4dd9ff328f5644b46a99c2999e Mon Sep 17 00:00:00 2001 > From: "Du, Changbin" > Date: Thu, 23 Jul 2015 20:08:04 +0800 > Subject: [PATCH v2] usb/gadget: make composite gadget meet usb compliance for > vbus draw What

Re: [PATCH 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-08-31 Thread Oliver Neukum
On Mon, 2015-08-31 at 13:01 +0200, Michal Nazarewicz wrote: > On Fri, Aug 28 2015, Peter Chen wrote: > > Allocate the size of urb pointer array according to testusb's > > parameter sglen. > > > > Signed-off-by: Peter Chen > > Acked-by: Michal Nazarewicz > > I vaguely recall that LLVM fans got m

Re: [PATCH 4/7] usb: misc: usbtest: format the data pattern according to max packet size

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > From: Alan Stern > > With this change, the host and gadget doesn't need to agree with transfer > length for comparing the data, since they doesn't know each other's > transfer size, but know max packet size. > > (Fixed the 'line over 80 characters warning'

Re: [PATCH 7/7] tools: usb: testusb: change the default value for length from 512 to 1024

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > For ctrl out test, it needs length > vary, so in order to run it with > default parameters, we do this change. > > Cc: Michal Nazarewicz Acked-by: Michal Nazarewicz > Signed-off-by: Peter Chen > --- > tools/usb/testusb.c | 4 ++-- > 1 file changed, 2 i

Re: [PATCH 6/7] tools: usb: testusb: change the help text

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > The 'length' is the transfer length, not the packet size, so > change the help text. > > Cc: Michal Nazarewicz I sure touched weird things when I was young. :P Anyway: Acked-by: Michal Nazarewicz > Signed-off-by: Peter Chen > --- > tools/usb/testusb.

Re: [PATCH 5/7] usb: gadget: f_sourcesink: format data pattern according to max packet size

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > Since the host and gadget can't agree with transfer length before > each transfer, but they agree with max packet size for each > endpoint, we use max packet size to format data pattern. > > Signed-off-by: Peter Chen Acked-by: Michal Nazarewicz > --- >

Re: [PATCH 3/7] usb: misc: usbtest: using the same data format among write/compare/output

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > Using the same data format "buf[j] = (u8)(i + j)" among > write, compare buf, and console output stage. > > Signed-off-by: Peter Chen Acked-by: Michal Nazarewicz > --- > drivers/usb/misc/usbtest.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletio

Re: [PATCH 2/7] usb: misc: usbtest: delete useless memset for urbs array

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > The element of urbs array will be initialized at below code > at once. > > for (i = 0; i < param->sglen; i++) { > urbs[i] = iso_alloc_urb(udev, pipe, desc, > param->length, offset); > > Signed-off-by:

Re: [PATCH 1/7] usb: misc: usbtest: allocate size of urb array according to user parameter

2015-08-31 Thread Michal Nazarewicz
On Fri, Aug 28 2015, Peter Chen wrote: > Allocate the size of urb pointer array according to testusb's > parameter sglen. > > Signed-off-by: Peter Chen Acked-by: Michal Nazarewicz I vaguely recall that LLVM fans got mad last time I used dynamically sized local arrays though. Not sure though, I

RE: [PATCH v2 1/1] usb: otg: don't set a_alt_hnp_support feature for OTG 2.0 device

2015-08-31 Thread Peter Chen
> > Since a_alt_hnp_support is obsolete in OTG 2.0, HNP capable host should send > this set feature request only if the otg device is connecting to a non-HNP > port > and it's compliant with OTG 1.x revision. This is done by checking its otg > descriptor length, OTG 2.0 uses usb_otg20_descripto

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-31 Thread Eugene Shatokhin
31.08.2015 10:32, Bjørn Mork пишет: Eugene Shatokhin writes: 28.08.2015 11:55, Bjørn Mork пишет: I guess you are right. At least I cannot prove that you are not :) There is a bit too much complexity involved here for me... :-) Yes, it is quite complex. I admit, it was easier for me to f

Re: [Bug 103461] i.MX USB runtime power management breaks the boot

2015-08-31 Thread Vincent Stehlé
On 08/28/2015 10:29 AM, Peter Chen wrote: .. > Would you supply below: > 1. The u-boot.bin which you use to reproduce it Hi Peter, Thank you for looking into this issue. I attached u-boot.imx to the ticket for you [1]. Due to the environment boot paths being tuned to my setup I can only recomme

[PATCH v2 1/1] usb: otg: don't set a_alt_hnp_support feature for OTG 2.0 device

2015-08-31 Thread Li Jun
Since a_alt_hnp_support is obsolete in OTG 2.0, HNP capable host should send this set feature request only if the otg device is connecting to a non-HNP port and it's compliant with OTG 1.x revision. This is done by checking its otg descriptor length, OTG 2.0 uses usb_otg20_descriptor which has diff

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-31 Thread Bjørn Mork
Eugene Shatokhin writes: > 28.08.2015 11:55, Bjørn Mork пишет: > >> I guess you are right. At least I cannot prove that you are not :) >> >> There is a bit too much complexity involved here for me... > > :-) > > Yes, it is quite complex. > > I admit, it was easier for me to find the races in usbn