Re: [PATCH v2] usb: chipidea: reuse the platform_data to store the ci info

2015-09-28 Thread Peter Chen
On Thu, Sep 17, 2015 at 07:48:46AM +, Barry Song wrote: > From: Rong Wang > > Chipidea puts ci information to drvdata, but this overwrites the drvdata > placed by EHCI core. EHCI core thinks drvdata is ehci_hcd. We can find this > from codes like ehci-sysfs.c: > > static

Re: [PATCH v3 0/4] Exynos4412-based Trats2 USB gadget (DWC2) fixes

2015-09-28 Thread John Youn
On 9/21/2015 3:16 AM, Marek Szyprowski wrote: > Hello, > > This is an updated DWC2 related part of initial patchset posted here: > https://lkml.org/lkml/2015/8/21/306 > Only DWC2 related patches have been modified since the initial > submission. > > Changelog: > v3: > - rebased onto latest

Re: [PATCH v12 1/7] usb: interface authorization: Declare authorized attribute

2015-09-28 Thread Krzysztof Opasiak
On 09/28/2015 09:26 PM, Stefan Koch wrote: The attribute authorized shows the authorization state for an interface. Signed-off-by: Stefan Koch --- include/linux/usb.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/usb.h b/include/linux/usb.h

[PATCH v12 1/7] usb: interface authorization: Declare authorized attribute

2015-09-28 Thread Stefan Koch
The attribute authorized shows the authorization state for an interface. Signed-off-by: Stefan Koch --- include/linux/usb.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/usb.h b/include/linux/usb.h index 447fe29..a2068d7 100644 ---

[PATCH v12 5/7] usb: interface authorization: SysFS part of USB interface authorization

2015-09-28 Thread Stefan Koch
This introduces an attribute for each interface to authorize (1) or deauthorize (0) it: /sys/bus/usb/devices/INTERFACE/authorized Signed-off-by: Stefan Koch --- drivers/usb/core/sysfs.c | 36 1 file changed, 36 insertions(+) diff

[PATCH v12 2/7] usb: interface authorization: Introduces the default interface authorization

2015-09-28 Thread Stefan Koch
Interfaces are allowed per default. This can disabled or enabled (again) by writing 0 or 1 to /sys/bus/usb/devices/usbX/interface_authorized_default Signed-off-by: Stefan Koch --- drivers/usb/core/hcd.c | 47 ++

[PATCH v12 3/7] usb: interface authorization: Control interface probing and claiming

2015-09-28 Thread Stefan Koch
Driver probings and interface claims get rejected if an interface is not authorized. Signed-off-by: Stefan Koch --- drivers/usb/core/driver.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index

[PATCH v12 4/7] usb: interface authorization: Introduces the USB interface authorization

2015-09-28 Thread Stefan Koch
The kernel supports the device authorization because of wireless USB. These is usable for wired USB devices, too. These new interface authorization allows to enable or disable individual interfaces instead a whole device. If a deauthorized interface will be authorized so the driver probing must

[PATCH v12 7/7] usb: interface authorization: Use a flag for the default device authorization

2015-09-28 Thread Stefan Koch
With this patch a flag instead of a variable is used for the default device authorization. Signed-off-by: Stefan Koch --- drivers/usb/core/hcd.c | 31 +-- drivers/usb/core/usb.c | 2 +- include/linux/usb/hcd.h | 16 +--- 3

[PATCH v12 0/7] usb: interface authorization

2015-09-28 Thread Stefan Koch
This patch introduces an interface authorization for USB devices. The kernel supports a device authorization because of wireless USB. But the new interface authorization allows to authorize or deauthorize individual interfaces instead authorization or deauthorize a whole device. Therefore the

[PATCH v12 6/7] usb: interface authorization: Documentation part

2015-09-28 Thread Stefan Koch
This part adds the documentation for the interface authorization. Signed-off-by: Stefan Koch --- Documentation/ABI/testing/sysfs-bus-usb | 20 Documentation/usb/authorization.txt | 31 +++ 2 files changed, 51

Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs"

2015-09-28 Thread Ville Syrjälä
On Mon, Sep 07, 2015 at 09:56:06AM +0300, Heikki Krogerus wrote: > Hi, > > On Tue, Sep 01, 2015 at 06:37:54PM +0300, Ville Syrjälä wrote: > > On Tue, Sep 01, 2015 at 10:17:59AM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Sep 01, 2015 at 05:39:28PM +0300, Ville Syrjälä wrote: > > > >

[PATCH] usb: host: fotg210: remove unreachable code

2015-09-28 Thread Luis de Bethencourt
Before running the platform_driver_unregister() the code will either return retval or jump to clean. Removing this line that is unreachable. Signed-off-by: Luis de Bethencourt --- drivers/usb/host/fotg210-hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 3/3] usb: dwc3: gadget: remove unnecessary _irqsave()

2015-09-28 Thread Felipe Balbi
We *know* our threads executes with our IRQs disabled. We really don't need to use the _irqsave() variant of spin_lock(). Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c

[PATCH 2/3] usb: dwc3: gadget: use Update Transfer from Xfer In Progress

2015-09-28 Thread Felipe Balbi
Instead of limiting __dwc3_gadget_kick_transfer() to Xfer Complete, we can try to issue Update Transfer command from Xfer In Progress too. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/3] usb: dwc3: gadget: use update transfer command

2015-09-28 Thread Felipe Balbi
If we get a Xfer Not Ready event with reason "Transfer Active" it means endpoint is still transferring data and we can use that to issue update transfer for this particular endpoint in case we have pending requests in our queue. Signed-off-by: Felipe Balbi ---

Re: [PATCH v12 0/7] usb: interface authorization

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 09:26:47PM +0200, Stefan Koch wrote: > This patch introduces an interface authorization for USB devices. > The kernel supports a device authorization because of wireless USB. > > But the new interface authorization allows to authorize or deauthorize > individual interfaces

Re: [PATCH v2 20/32] usb: dwc2: force dr_mode in case of configuration mismatch

2015-09-28 Thread Felipe Balbi
On Tue, Sep 22, 2015 at 03:16:56PM +0200, Mian Yousaf Kaukab wrote: > If dual role configuration is not selected, check and force dr_mode > based on the selected configuration. > > Signed-off-by: Mian Yousaf Kaukab > Tested-by: Robert Baldyga

Re: [Cluster-devel] [PATCH 17/23] dlm: use per-attribute show and store methods

2015-09-28 Thread David Teigland
On Fri, Sep 25, 2015 at 06:49:54AM -0700, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/dlm/config.c | 288 > +++- > 1 file changed, 74 insertions(+), 214 deletions(-) Looks good to me. Dave -- To

[PATCH] usb: gadget: pch-udc: fix lock

2015-09-28 Thread Felipe Balbi
gadget methods should be called without spinlocks held. Reported-by: Alexey Khoroshilov Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc/pch_udc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: 28 September 2015 15:27 > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > From: Rafael J. Wysocki > > > Sent: 27 September 2015 15:09 > > ... > > > > > Say you have three adjacent fields in a structure, x, y,

Re: question about potential integer truncation in r8a66597_hub_descriptor

2015-09-28 Thread PaX Team
On 28 Sep 2015 at 10:31, David Laight wrote: > From: PaX Team > > Sent: 26 September 2015 14:47 > > hi all, > > > > drivers/usb/host/r8a66597-hcd.c:r8a66597_hub_descriptor can truncate > > r8a66597.max_root_hub (of type unsigned int) to an unsigned char: > > > > desc->bNbrPorts =

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 14:50 +, David Laight wrote: > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > > Sent: 28 September 2015 15:27 > > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > > From: Rafael J. Wysocki > > > > Sent: 27 September 2015 15:09 > > > ... >

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: James Bottomley > Sent: 28 September 2015 16:12 > > > > The x86 cpus will also do 32bit wide rmw cycles for the 'bit' > > > > operations. > > > > > > That's different: it's an atomic RMW operation. The problem with the > > > alpha was that the operation wasn't atomic (meaning that it

Re: [PATCH 2/2] tcm_usb_gadget: Fix nexus leak + enabled attribute failure

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 27.09.2015 o 05:16, Nicholas A. Bellinger pisze: From: Nicholas Bellinger This patch adds the missing tcm_usbg_drop_nexus() to properly release tcm_usbg_nexus memory during typical ->fabric_drop_tpg() callback shutdown. Also, fix up

[PATCH] usb: dwc3: gadget: start transfer on XFER_COMPLETE

2015-09-28 Thread Felipe Balbi
if by the time we get to XFER_COMPLETE we have pending requests to be processed, instead of waiting for a following XFER_NOT_READY, let's start the request right away and, maybe, save the time of a few NAKs due to lack of started transfers. Signed-off-by: Felipe Balbi ---

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > From: Rafael J. Wysocki > > Sent: 27 September 2015 15:09 > ... > > > > Say you have three adjacent fields in a structure, x, y, z, each one > > > > byte long. > > > > Initially, all of them are equal to 0. > > > > > > > > CPU A writes 1 to

RE: [PATCH v3 0/1] USB DWC2 parity fix in isochronous mode

2015-09-28 Thread Roman Bacik
> -Original Message- > From: John Youn [mailto:john.y...@synopsys.com] > Sent: September-24-15 8:16 PM > To: Roman Bacik; John Youn; Scott Branden; Greg Kroah-Hartman; linux- > u...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; bcm-kernel-feedback-list > Subject: Re: [PATCH v3 0/1]

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Arnd Bergmann
On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > On 25 September 2015 at 15:19, Rafael J. Wysocki > > > wrote: > > > > So if you

Re: [PATCH 04/23] usb-gadget/f_hid: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_hid.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-)

Re: [PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_ecm.c| 8 ++--- drivers/usb/gadget/function/f_eem.c| 8 ++---

Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, Please see comments inline. With the issue addressed you can add Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/function/f_loopback.c | 32

Re: [PATCH 08/23] usb-gadget/f_midi: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_midi.c | 37 1 file changed, 16 insertions(+), 21

Re: [PATCH 09/23] usb-gadget/f_printer: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig ---

Re: [PATCH 11/23] usb-gadget/f_mass_storage: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig ---

Re: [PATCH 12/23] usb-gadget/f_ac1: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, The commit title should be " usb-gadget/f_uac1 ..." instead of " f_ac1 ..." Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig ---

Re: [PATCH 23/23] configfs: remove old API

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, Please see inline. W dniu 25.09.2015 o 15:50, Christoph Hellwig pisze: Remove the old show_attribute and store_attribute methods and update the documentation. Also replace the two C samples with a single new one in the proper samples directory where people expect to find it.

Deadlock in pch_udc_svc_ur_interrupt()

2015-09-28 Thread Alexey Khoroshilov
Dear colleagus, It seems code handling USB_RESET interrupt contains unavoidable deadlock. pch_udc_isr() locks dev->lock, then calls to pch_udc_dev_isr(dev, dev_intr) that seems to have a couple of locks dev->lock itself: pch_udc_isr() spin_lock(>lock); pch_udc_dev_isr(dev, dev_intr);

Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, please see my comments inline. With the issues addressed you can add Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: UVC is a little different from other configfs consumers in that it wants different function and

Re: [PATCH 05/23] usb-gadget/f_acm: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_acm.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff

RE: [PATCH] usb: renesas_usbhs: Add support for R-Car H3

2015-09-28 Thread Yoshihiro Shimoda
Hi Morimoto-san, Thank you for the comment. And, I'm sorry for the delayed response. > Sent: Friday, September 18, 2015 5:25 PM > > Hi Shimoda-san > > > This patch adds a compatible string to support for R-Car H3. > > > > Since the HS-USB controller of R-Car H3 is almost the same specification

Re: [PATCH 10/23] usb-gadget/f_sourcesink: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, The same remark as for f_loopback (__CONFIGFS_ATTR location vs CONFIGFS_ATTR location after applying) If addressed Reviewed-by: Andrzej Pietrasiewicz W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig ---

Re: [PATCH 13/23] usb-gadget/f_uac2: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_uac2.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff

Re: [PATCH 14/23] usb-gadget/f_obex: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_obex.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff

Re: [PATCH 16/23] usb-gadget/f_serial: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_serial.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff

Re: [PATCH 15/23] usb-gadget/f_phonet: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/function/f_phonet.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff

Re: simplify configfs attributes

2015-09-28 Thread Andrzej Pietrasiewicz
Hi Christoph, W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: This series consolidates the code to implement configfs attributes by providing the ->show and ->store method in common code and using container_of in the methods to access the containing structure. This reduces source and

Re: Overly conservative xHCI bandwidth estimation

2015-09-28 Thread Mathias Nyman
On 26.09.2015 23:13, Steinar H. Gunderson wrote: On Fri, Sep 25, 2015 at 10:12:51PM +0200, Steinar H. Gunderson wrote: I have no idea whatsoever how this breaks bandwidth management, but seemingly it does. To verify; I built 4.3rc-2 with CONFIG_PM=n, and it can drive both cards without

Re: Overly conservative xHCI bandwidth estimation

2015-09-28 Thread Steinar H. Gunderson
On Mon, Sep 28, 2015 at 03:24:04PM +0300, Mathias Nyman wrote: > Driver will tell the latency value to the host controller, when a exit > latency time is set the host will know that the link is power managed, and > host will start to schedule additional PING TP transfers to the device to > wake

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Rafael J. Wysocki
On Monday, September 28, 2015 10:24:58 AM Arnd Bergmann wrote: > On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > > On 25 September 2015 at

RE: question about potential integer truncation in r8a66597_hub_descriptor

2015-09-28 Thread David Laight
From: PaX Team > Sent: 26 September 2015 14:47 > hi all, > > drivers/usb/host/r8a66597-hcd.c:r8a66597_hub_descriptor can truncate > r8a66597.max_root_hub (of type unsigned int) to an unsigned char: > > desc->bNbrPorts = r8a66597->max_root_hub; > > based on the surrounding code my guess is

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze: Signed-off-by: Christoph Hellwig Reviewed-by: Andrzej Pietrasiewicz --- drivers/usb/gadget/configfs.c | 295 ++-- include/linux/usb/gadget_configfs.h | 19 +--

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: Rafael J. Wysocki > Sent: 27 September 2015 15:09 ... > > > Say you have three adjacent fields in a structure, x, y, z, each one byte > > > long. > > > Initially, all of them are equal to 0. > > > > > > CPU A writes 1 to x and CPU B writes 2 to y at the same time. > > > > > > What's the

[PATCH v11] Added forgotten parameter description for authorized attribute in usb.h

2015-09-28 Thread Stefan Koch
Signed-off-by: Stefan Koch --- include/linux/usb.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/usb.h b/include/linux/usb.h index 3deccab..2cbcf8d 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -122,6 +122,8 @@ enum

Re: [PATCH v11] Added forgotten parameter description for authorized attribute in usb.h

2015-09-28 Thread kbuild test robot
Hi Stefan, [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] reproduce: make htmldocs All warnings (new ones prefixed by >>): >> include/linux/usb.h:188: warning: Excess struct/union/enum/typedef member >> 'authorized' description in 'usb_interface' vim +188

[PATCH v9 4/5] xhci: mediatek: support MTK xHCI host controller

2015-09-28 Thread Chunfeng Yun
There some vendor quirks for MTK xhci host controller: 1. It defines some extra SW scheduling parameters for HW to minimize the scheduling effort for synchronous and interrupt endpoints. The parameters are put into reseved DWs of slot context and endpoint context. 2. Its IMODI unit for

[PATCH v9 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173

2015-09-28 Thread Chunfeng Yun
add xHCI and phy drivers for MT8173-EVB Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 16 +++ arch/arm64/boot/dts/mediatek/mt8173.dtsi| 43 + 2 files changed, 59 insertions(+) diff --git

[PATCH v9 3/5] phy: add usb3.0 phy driver for mt65xx SoCs

2015-09-28 Thread Chunfeng Yun
support usb3.0 phy of mt65xx SoCs Signed-off-by: Chunfeng Yun --- drivers/phy/Kconfig | 9 + drivers/phy/Makefile | 1 + drivers/phy/phy-mt65xx-usb3.c | 506 ++ 3 files changed, 516 insertions(+) create

[PATCH v9 0/5] Mediatek xHCI support

2015-09-28 Thread Chunfeng Yun
The patch supports MediaTek's xHCI controller. There are some differences from xHCI spec: 1. The interval is specified in 250 * 8ns increments for Interrupt Moderation Interval(IMODI) of the Interrupter Moderation(IMOD) register, it is 8 times as much as that defined in xHCI spec. 2. For the

[PATCH v9 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller

2015-09-28 Thread Chunfeng Yun
add a DT binding documentation of xHCI host controller for the MT8173 SoC from Mediatek. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/usb/mt8173-xhci.txt| 52 ++ 1 file changed, 52 insertions(+) create mode 100644

[PATCH v9 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-09-28 Thread Chunfeng Yun
add a DT binding documentation of usb3.0 phy for MT65xx SoCs from Mediatek. Acked-by: Rob Herring Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 68 ++ 1 file changed, 68 insertions(+) create

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-28 Thread Christoph Hellwig
The Subject line is part of the commit log. If you have a useful suggestion for improving the logs please feel free to suggest it. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 02/23] usb-gadget: use per-attribute show and store methods

2015-09-28 Thread Christoph Hellwig
On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote: > this (and the other helper below) could be macros just fine. They could, but they shouldn't. Inlines are always preferable over function-like macros. > Are you 100% compiler > will *always* inline these helpers. With gcc you can't

Re: [PATCH 03/23] usb-gadget/uvc: use per-attribute show and store methods

2015-09-28 Thread Christoph Hellwig
On Mon, Sep 28, 2015 at 01:35:38PM +0200, Andrzej Pietrasiewicz wrote: >> -#define UVCG_STREAMING_CONTROL_SIZE 1 > > Moving this define seems an unrelated change to me. I can move it back - this one wasn't intentional. >> +#define identity_conv(x) (x) > > What is this needed for here? > > This

Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

2015-09-28 Thread Christoph Hellwig
On Mon, Sep 28, 2015 at 01:46:57PM +0200, Andrzej Pietrasiewicz wrote: >> } >> >> -static struct f_lb_opts_attribute f_lb_opts_qlen = >> -__CONFIGFS_ATTR(qlen, S_IRUGO | S_IWUSR, >> -f_lb_opts_qlen_show, >> -f_lb_opts_qlen_store); >> - > In my opinion

Re: [PATCH 23/23] configfs: remove old API

2015-09-28 Thread Christoph Hellwig
> Haven't you just removed show_attribute() and store_attribute() from > configfs_item_operations? Oops, looks like the old text manage to slip back in. I'll fix it up. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 07/23] usb-gadget/f_loopback: use per-attribute show and store methods

2015-09-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.09.2015 o 15:41, Christoph Hellwig pisze: On Mon, Sep 28, 2015 at 01:46:57PM +0200, Andrzej Pietrasiewicz wrote: } -static struct f_lb_opts_attribute f_lb_opts_qlen = - __CONFIGFS_ATTR(qlen, S_IRUGO | S_IWUSR, - f_lb_opts_qlen_show, -