Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 19:24, Felipe Balbi wrote: >>> >> >> > >>> >> >> > Seems you don't want to guarantee charger type detection is done >>> >> >> > before gadget connection(pullup DP), right? >>> >> >> > I see you call usb_charger_detect_type() in each gadget usb >>> >> >> >

musb: kernel 3.18.29 build issue

2016-03-30 Thread Yegor Yefremov
Hello Greg, 3.18.x is missing this patch [1] in order to perform a successful build. The reason: following patch [2] in 3.18.x uses a macro name introduced in the missing patch [1]. Could you queue it for 3.18.30? [1] http://marc.info/?l=git-commits-head=142403040503570=2 [2]

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 18:58, Jun Li wrote: >> >> >> > Seems you don't want to guarantee charger type detection is done >> >> >> > before gadget connection(pullup DP), right? >> >> >> > I see you call usb_charger_detect_type() in each gadget usb >> >> >> > state >> >> >> changes. >>

Re: [GIT PULL] USB fixes for v4.6-rc2

2016-03-30 Thread Greg Kroah-Hartman
On Wed, Mar 30, 2016 at 01:48:28PM +0300, Felipe Balbi wrote: > > Hi Greg, > > here's the first set of fixes for v4.6-rc cycle. Let me know if you want > anything to be changed ;-) > > The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca: > > Linux 4.6-rc1 (2016-03-26

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-30 Thread Rajesh Bhagat
> -Original Message- > From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > Sent: Tuesday, March 29, 2016 10:51 PM > To: Rajesh Bhagat > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org; Sriram Dash

Re: [PATCH] usb: dwc2: do not override forced dr_mode in gadget setup

2016-03-30 Thread John Youn
On 3/30/2016 8:08 AM, Przemek Rudy wrote: > On 03/30/2016 12:15 PM, Felipe Balbi wrote: >> John Youn writes: >>> [ text/plain ] >>> On 3/16/2016 3:10 PM, Przemek Rudy wrote: The host/device mode set with dr_mode should be kept all the time, not being changed to

Re: [PATCH] usb: dwc2: gadget: avoid null dereference on incomplete transfer

2016-03-30 Thread John Youn
On 3/30/2016 6:22 AM, Felipe Balbi wrote: > > Hi, > > John Keeping writes: >> Setting up a gadget with the uac2 function results in: >> >> Unable to handle kernel NULL pointer dereference at virtual address >> 0058 >> ... >> PC is at dwc2_hsotg_irq+0x7f0/0x908 >>

Re: [PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-03-30 Thread Ruslan Bilovol
Hi, On Thu, Mar 31, 2016 at 1:08 AM, Bin Liu wrote: > Hi, > > On Fri, Aug 15, 2014 at 2:37 AM, Dirk Gouders wrote: >> Bin Liu writes: >> >>> Dirk, >>> >>> On Thu, Aug 14, 2014 at 1:52 AM, Dirk Gouders wrote: Bin

Re: [PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-03-30 Thread Bin Liu
Hi, On Fri, Aug 15, 2014 at 2:37 AM, Dirk Gouders wrote: > Bin Liu writes: > >> Dirk, >> >> On Thu, Aug 14, 2014 at 1:52 AM, Dirk Gouders wrote: >>> Bin Liu writes: >>> All, On Mon, Nov 18, 2013 at

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Tony Lindgren
* Alan Stern [160330 12:26]: > On Wed, 30 Mar 2016, Ivaylo Dimitrov wrote: > > > >>> seems to be created twice :). Maybe the problem is that the first time > > >>> musb-hdrc is probed it fails with -EPROBE_DEFER, however that failure is > > >>> after gadget drivers got

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Alan Stern
On Wed, 30 Mar 2016, Ivaylo Dimitrov wrote: > >>> seems to be created twice :). Maybe the problem is that the first time > >>> musb-hdrc is probed it fails with -EPROBE_DEFER, however that failure is > >>> after gadget drivers got loaded and noone unloads them. > >> > >> gadget drivers will get

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Ivaylo Dimitrov
On 30.03.2016 21:50, Ivaylo Dimitrov wrote: On 30.03.2016 17:01, Ivaylo Dimitrov wrote: On 30.03.2016 16:38, Felipe Balbi wrote: Hi, Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: Ivaylo Dimitrov

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

2016-03-30 Thread John Youn
On 3/23/2016 11:52 PM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> [ text/plain ] >> On 3/21/2016 11:40 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> John Youn writes: [ text/plain ] On 3/18/2016 12:17 PM, John Youn wrote: >

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 01:09:00PM +0300, Felipe Balbi wrote: > Baolin Wang writes: > > +#include > > +#include > > +#include > > +#include > not very nice to depend on either of or platform_device here. What about > PCI-based devices ? The header inclusion

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

2016-03-30 Thread Bin Liu
Hi, On Wed, Mar 30, 2016 at 10:23:31AM -0500, Bin Liu wrote: > Hi, > > > On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote: > > I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and > > had found and corrected this on my local build tree. > > > >

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

2016-03-30 Thread Bin Liu
Hi, On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote: > I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had > found and corrected this on my local build tree. > > Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is > built,

Re: [PATCH] usb: dwc2: do not override forced dr_mode in gadget setup

2016-03-30 Thread Przemek Rudy
On 03/30/2016 12:15 PM, Felipe Balbi wrote: > John Youn writes: >> [ text/plain ] >> On 3/16/2016 3:10 PM, Przemek Rudy wrote: >>> The host/device mode set with dr_mode should be kept all the time, >>> not being changed to OTG in gadget setup (by overriding

RE: ehci and ohci reset number doubt

2016-03-30 Thread Alan Stern
On Wed, 30 Mar 2016, Lipengcheng wrote: > Hi, > > The ohci-platform and ehci-platform drivers already perform their own > root-hub and bus resets. > I don't understand the sentence clearly. > > Synopsis control VERSION: DesignWare Cores USB2.0 Host-AHB Controller, > Version 2.98a > The

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Pali Rohár
On Wednesday 30 March 2016 16:01:53 Ivaylo Dimitrov wrote: > On 30.03.2016 16:38, Felipe Balbi wrote: > > Hi, > > > > Ivaylo Dimitrov writes: > >>> Ivaylo Dimitrov writes: > > Ivaylo Dimitrov writes: >

Re: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-30 Thread Bin Liu
Hi, On Wed, Mar 30, 2016 at 09:14:18AM +0300, Felipe Balbi wrote: > > Hi again, > > Felipe Balbi writes: > > Bin Liu writes: > >> On Fri, Mar 18, 2016 at 08:59:48AM +0200, Felipe Balbi wrote: > >>> > >>> Hi, > >>> > >>> Bin Liu

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Ivaylo Dimitrov
On 30.03.2016 16:38, Felipe Balbi wrote: Hi, Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: On 16.01.2016 12:40, Ivaylo

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

2016-03-30 Thread Heiner Kallweit
On Wed, Mar 30, 2016 at 3:03 PM, Pavel Machek wrote: > Hi! > >> >Ok, so: >> > >> >a) Do we want RGB leds to be handled by existing subsystem, or do we >> >need separate layer on top of that? >> > >> >b) Does RGB make sense, or HSV? RGB is quite widely used in graphics, >> >and it is

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

2016-03-30 Thread Felipe Balbi
Arnd Bergmann writes: > [ text/plain ] > On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote: >> Arnd Bergmann writes: >> > [ text/plain ] >> > The phy-am335x driver selects 'USB_COMMON', but all other drivers >> > use 'depends on' for that symbol, and it

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-03-30 Thread Felipe Balbi
Grygorii Strashko writes: > [ text/plain ] > On 03/30/2016 04:10 PM, Felipe Balbi wrote: >> "Thang Q. Nguyen" writes: >> >>> [ text/plain ] >>> From: "Thang Q. Nguyen" >>> >>> The xhci-hcd child node needs to inherit archdata

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

2016-03-30 Thread Arnd Bergmann
On Wednesday 30 March 2016 13:31:01 Felipe Balbi wrote: > Arnd Bergmann writes: > > [ text/plain ] > > The phy-am335x driver selects 'USB_COMMON', but all other drivers > > use 'depends on' for that symbol, and it depends on USB || USB_GADGET > > itself, which causes a Kconfig

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-03-30 Thread Grygorii Strashko
On 03/30/2016 04:10 PM, Felipe Balbi wrote: > "Thang Q. Nguyen" writes: > >> [ text/plain ] >> From: "Thang Q. Nguyen" >> >> The xhci-hcd child node needs to inherit archdata attribute to use >> dma_ops functions and attributes. This patch enables the USB

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Felipe Balbi
Hi, Ivaylo Dimitrov writes: >> Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: >> Ivaylo Dimitrov writes: >>> On 16.01.2016 12:40, Ivaylo Dimitrov wrote:

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Ivaylo Dimitrov
Hi, On 30.03.2016 13:22, Felipe Balbi wrote: Hi, Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: On 16.01.2016 12:40, Ivaylo Dimitrov wrote: Hi, On 16.01.2016 00:48, Tony

Re: [PATCH] usb: dwc2: gadget: avoid null dereference on incomplete transfer

2016-03-30 Thread Felipe Balbi
Hi, John Keeping writes: > Setting up a gadget with the uac2 function results in: > > Unable to handle kernel NULL pointer dereference at virtual address 0058 > ... > PC is at dwc2_hsotg_irq+0x7f0/0x908 > LR is at dwc2_hsotg_irq+0x4c/0x908 > Backtrace: > []

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

2016-03-30 Thread Felipe Balbi
"Thang Q. Nguyen" writes: > [ text/plain ] > From: "Thang Q. Nguyen" > > The xhci-hcd child node needs to inherit archdata attribute to use > dma_ops functions and attributes. This patch enables the USB DWC3 > driver to pass archdata attributes to its

Re: [PATCH v3 1/2] usb:dwc3: Enable support for 64-bit system

2016-03-30 Thread Felipe Balbi
Hi, "Thang Q. Nguyen" writes: > From: "Thang Q. Nguyen" > > Add 64-bit DMA operation support to the USB DWC3 driver. > First attempt to set the coherent DMA mask for 64-bit DMA. > If that failed, attempt again with 32-bit DMA. > > Changes from v2: > -

RE: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread Felipe Balbi
Hi Gil, Gil Weber writes: >>> To make sure, I have also performed some additional tests. The problem >>> seems unrelated to the gadget being used: I have tried various >>> combinations (zero, ethernet, etc.), even setting up an ACM device >>> using configfs,

RE: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread Gil Weber
Hi, >> To make sure, I have also performed some additional tests. The problem >> seems unrelated to the gadget being used: I have tried various >> combinations (zero, ethernet, etc.), even setting up an ACM device >> using configfs, and the result is the same: a host detects the device >> for a

[PATCH] usb: gadget: f_fs: Fix EFAULT generation for async read operations

2016-03-30 Thread Lars-Peter Clausen
In the current implementation functionfs generates a EFAULT for async read operations if the read buffer size is larger than the URB data size. Since a application does not necessarily know how much data the host side is going to send it typically supplies a buffer larger than the actual data,

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

2016-03-30 Thread Antonio Victor Hilario
Hi, Sergei, You are correct. I had only thought to submit the least number of changes to eliminate the problem. A better fix is to make the leading part of the names EP_MODE_AUTOREQ consistent for the [mode] parameter to cppi41_set_autoreq_mode( struct cppi41_dma_channel *cppi41_channel,

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread JB
Hello, >> To make sure, I have also performed some additional tests. The problem >> seems unrelated to the gadget being used: I have tried various >> combinations (zero, ethernet, etc.), even setting up an ACM device >> using configfs, and the result is the same: a host detects the device >> for

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread Felipe Balbi
Hi, JB writes: >> did you check that getty is still running ? That "deactivated" message >> means that whatever had /dev/ttyGS0 opened, decided to close it. This >> could mean that getty got a SIGHUP and just decided to close that fd. > > I have only briefly

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread JB
Hello, > did you check that getty is still running ? That "deactivated" message > means that whatever had /dev/ttyGS0 opened, decided to close it. This > could mean that getty got a SIGHUP and just decided to close that fd. I have only briefly experimented with getty (I also tried opening the

Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

2016-03-30 Thread Sergei Shtylyov
Hello. On 3/30/2016 1:56 AM, Antonio Victor Hilario wrote: I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had found and corrected this on my local build tree. Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Felipe Balbi
Hi, Jun Li writes: >> -Original Message- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Wednesday, March 30, 2016 5:31 PM >> To: Jun Li >> Cc: Peter Chen ; Felipe Balbi ; >> Greg KH

RE: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb

2016-03-30 Thread Du, Changbin
> > @@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct > dwc3 *dwc) > > > > /* > > -- > > */ > > > > -static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep > *dep, > > +static int

Re: [PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb

2016-03-30 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > [ text/plain ] > From: "Du, Changbin" > > Actually, the function only clean one trb. So rename the function. > > Signed-off-by: Du, Changbin okay :-) > --- > drivers/usb/dwc3/gadget.c | 4 ++-- > 1 file

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Jun Li
> -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Wednesday, March 30, 2016 5:31 PM > To: Jun Li > Cc: Peter Chen ; Felipe Balbi ; > Greg KH ; Sebastian Reichel

Re: [PATCH] usb: phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-03-30 Thread Felipe Balbi
Rafał Miłecki writes: > [ text/plain ] > On 30 March 2016 at 12:13, Felipe Balbi wrote: >> Rafał Miłecki writes: >>> Northstar is a family of SoCs used in home routers. They have USB 2.0 >>> and 3.0 controllers with PHYs that need to be

Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize

2016-03-30 Thread Felipe Balbi
Michal Nazarewicz writes: > [ text/plain ] > On Wed, Mar 09 2016, Felipe F. Tonello wrote: >> buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed >> devices. >> >> That caused the OUT endpoint to freeze if the host send any data packet of >> length

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-30 Thread Marcel Ziswiler
On Tue, 2016-03-29 at 19:08 +0200, Thierry Reding wrote: > On Tue, Mar 29, 2016 at 05:24:59PM +0200, Marcel Ziswiler wrote: > > > > Hi Thierry > > > > On Fri, 2016-03-04 at 17:19 +0100, Thierry Reding wrote: > > > > > > From: Thierry Reding > >

[GIT PULL] USB fixes for v4.6-rc2

2016-03-30 Thread Felipe Balbi
Hi Greg, here's the first set of fixes for v4.6-rc cycle. Let me know if you want anything to be changed ;-) The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca: Linux 4.6-rc1 (2016-03-26 16:03:24 -0700) are available in the git repository at:

Re: [PATCH] usb: rework CONFIG_USB_COMMON logic

2016-03-30 Thread Felipe Balbi
Arnd Bergmann writes: > [ text/plain ] > The phy-am335x driver selects 'USB_COMMON', but all other drivers > use 'depends on' for that symbol, and it depends on USB || USB_GADGET > itself, which causes a Kconfig warning: > > warning: (AM335X_PHY_USB) selects USB_COMMON which has

Re: [PATCH v3] usb: phy: mxs: Add DT bindings to configure TX settings

2016-03-30 Thread Felipe Balbi
Hi, Peter Chen writes: > [ text/plain ] > On Wed, Mar 23, 2016 at 02:17:27PM -0400, Jaret Cantu wrote: >> On 03/23/2016 01:37 PM, Jaret Cantu wrote: >> >On 03/23/2016 12:36 AM, Peter Chen wrote: >> >>On Mon, Mar 21, 2016 at 12:32:27PM -0400, Jaret Cantu wrote: >> >>>The

[PATCH] usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb

2016-03-30 Thread changbin . du
From: "Du, Changbin" Actually, the function only clean one trb. So rename the function. Signed-off-by: Du, Changbin --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c

Re: USB gadgets with configfs hang reboot

2016-03-30 Thread Felipe Balbi
Hi, Ivaylo Dimitrov writes: >> Ivaylo Dimitrov writes: Ivaylo Dimitrov writes: > On 16.01.2016 12:40, Ivaylo Dimitrov wrote: >> Hi, >> >> On 16.01.2016 00:48, Tony Lindgren wrote:

Re: [PATCH] usb: phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-03-30 Thread Rafał Miłecki
On 30 March 2016 at 12:13, Felipe Balbi wrote: > Rafał Miłecki writes: >> Northstar is a family of SoCs used in home routers. They have USB 2.0 >> and 3.0 controllers with PHYs that need to be properly initialized. >> This driver provides PHY init support in a

Re: [PATCH] usb: dwc2: do not override forced dr_mode in gadget setup

2016-03-30 Thread Felipe Balbi
John Youn writes: > [ text/plain ] > On 3/16/2016 3:10 PM, Przemek Rudy wrote: >> The host/device mode set with dr_mode should be kept all the time, >> not being changed to OTG in gadget setup (by overriding CFGUSB_FORCEDEVMODE >> and CFGUSB_FORCEHOSTMODE bits). >> >>

Re: [PATCH] usb: phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-03-30 Thread Felipe Balbi
Rafał Miłecki writes: > Northstar is a family of SoCs used in home routers. They have USB 2.0 > and 3.0 controllers with PHYs that need to be properly initialized. > This driver provides PHY init support in a generic way and can be bound > with XHCI controller driver. > >

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

2016-03-30 Thread Felipe Balbi
Hi, Baolin Wang writes: > This patch introduces the usb charger driver based on usb gadget that > makes an enhancement to a power driver. It works well in practice but > that requires a system with suitable hardware. > > The basic conception of the usb charger is that,

[PATCH v6 0/3] usb: otg-fsm: Add documentation and some trivial cleanups

2016-03-30 Thread Roger Quadros
Hi, Add documentation for struct otg_fsm with some trivial cleanups. All patches have been Acked by otg-fsm maintainer (Peter Chen). cheers, -roger Roger Quadros (3): usb: otg-fsm: Add documentation for struct otg_fsm usb: otg-fsm: support multiple instances usb: otg-fsm: Prevent build

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 17:19, Peter Chen wrote: > On Wed, Mar 30, 2016 at 04:40:31PM +0800, Baolin Wang wrote: >> >> > - Third, since composite driver covers 500mA (and more for CDP) after >> >> > set >> >> > configuration and 2mA after suspend, and vbus handler covers

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 16:07, Jun Li wrote: > Hi >> On 30 March 2016 at 10:54, Jun Li wrote: >> >> >> It is not for udc driver but for power users who want to negotiate >> >> >> with USB subsystem. >> >> >> >> >> > >> >> > Seems you don't want to guarantee charger

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread Felipe Balbi
Hi, JB writes: > [ text/plain ] >> IIRC ACM will only do anything after you open /dev/ttyGS0 on the >> peripheral side. Are you running getty on ttyGS0 ? > > I did try that, that would explain why it appears only once. did you check that getty is still running ? That

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Peter Chen
On Wed, Mar 30, 2016 at 04:40:31PM +0800, Baolin Wang wrote: > >> > - Third, since composite driver covers 500mA (and more for CDP) after set > >> > configuration and 2mA after suspend, and vbus handler covers connect > >> > and disconnect. I can't see any reasons we need to notify gadget state >

[PATCH] xhci: Detect out-of-bounds access to usb2_ports

2016-03-30 Thread Christian M . Amsüss
Out-of-bounds access was triggered on a Thinkpad Yoga during suspend or by rmmod'ing the xhci-pci module, sometimes leading to a general protection fault. This is a defensive symptom fix; the error proper must occur somewhere else, eg. when the udev with its portnum is left lingering around even

[PATCH 001/001] MUSB Fix trivial typo in constant name EP_MODE_AUTOREG_NONE

2016-03-30 Thread Antonio Victor Hilario
Kernel build for an ARM target (Beaglebone Black) fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel options enabled: CONFIG_USB_MUSB_HDRC=y CONFIG_USB_TI_CPPI41_DMA=y The build fails with these errors, due to a misspelled constant name EP_MODE_AUTOREQ_NONE:

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread JB
> IIRC ACM will only do anything after you open /dev/ttyGS0 on the > peripheral side. Are you running getty on ttyGS0 ? I did try that, that would explain why it appears only once. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

RE: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Jun Li
Hi > -Original Message- > From: Baolin Wang [mailto:baolin.w...@linaro.org] > Sent: Wednesday, March 30, 2016 2:15 PM > To: Jun Li > Cc: Peter Chen ; Felipe Balbi ; > Greg KH ; Sebastian Reichel

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 15:42, Peter Chen wrote: > On Wed, Mar 30, 2016 at 03:07:49PM +0800, Baolin Wang wrote: >> On 30 March 2016 at 10:05, Peter Chen wrote: >> > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: >> >> On Mon, Mar 28, 2016 at

RE: [RFC PATCH 0/4] Implement USB device/host switch for Vybrid

2016-03-30 Thread Peter Chen
> > On 16-03-29 00:24:46, Peter Chen wrote: > > > > > > > > On 2016-03-25 00:40, Peter Chen wrote: > > > > On Tue, Mar 15, 2016 at 02:08:26PM +0530, Sanchayan Maity wrote: > > > >> Hello Peter, > > > >> > > > >> The existing usage of extcon in Chipidea driver relies on OTG > > > >> registers.

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

2016-03-30 Thread Jacek Anaszewski
On 03/29/2016 11:43 PM, Pavel Machek wrote: Hi! First, please Cc me on RGB color support. Add generic support for RGB Color LED's. Basic idea is to use enum led_brightness also for the hue and saturation color components.This allows to implement the color extension w/o changes to struct

Re: [PATCH v5 4/4] leds: core: add support for RGB LED's

2016-03-30 Thread Jacek Anaszewski
On 03/29/2016 10:42 PM, Heiner Kallweit wrote: Am 29.03.2016 um 12:05 schrieb Pavel Machek: On Tue 2016-03-01 22:36:12, Heiner Kallweit wrote: Export a function to convert HSV color values to RGB. It's intended to be called by drivers for RGB LEDs. Signed-off-by: Heiner Kallweit

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

2016-03-30 Thread Jacek Anaszewski
Hi Heiner and Pavel, On 03/29/2016 10:38 PM, Heiner Kallweit wrote: Am 29.03.2016 um 12:02 schrieb Pavel Machek: Hi! First, please Cc me on RGB color support. Add generic support for RGB Color LED's. Basic idea is to use enum led_brightness also for the hue and saturation color

Re: [PATCH v2] USB: whci-hcd: add more checks for dma mapping error

2016-03-30 Thread Vladimir Zapolskiy
Hi Alexey, On 26.03.2016 21:42, Alexey Khoroshilov wrote: > Fixing checks for dma mapping error in qset_fill_page_list(), > I have missed two similar problems in qset_add_urb_sg() and > in qset_add_urb_sg_linearize(). > > v2: check validity of dma_addr with dma_mapping_error() > in

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Peter Chen
On Wed, Mar 30, 2016 at 03:07:49PM +0800, Baolin Wang wrote: > On 30 March 2016 at 10:05, Peter Chen wrote: > > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: > >> On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: > >> > On Mon, Mar 28, 2016 at

Re: Usb point of sale keyboard shows err 19 of hub has too many ports

2016-03-30 Thread Oliver Neukum
On Tue, 2016-03-29 at 17:58 -0700, Greg KH wrote: > On Tue, Mar 29, 2016 at 05:42:50PM +0100, reggie macdonald wrote: > > Hi I made a bug report on bugzilla and was told to forward it to this email. > > > > Please see this thread: https://bbs.archlinux.org/viewtopic.php?id=210446 > > > > for

[PATCH 1/3] usb: dwc3: remove num_event_buffers

2016-03-30 Thread Felipe Balbi
We never, ever route any of the other event buffers so we might as well drop support for them. Until someone has a real, proper benefit for multiple event buffers, we will rely on a single one. This also helps reduce memory footprint of dwc3.ko which won't allocate memory for the extra event

[PATCH 2/3] usb: dwc3: drop ev_buffs array

2016-03-30 Thread Felipe Balbi
we will be using a single event buffer and that renders ev_buffs array unnecessary. Let's remove it in favor of a single pointer to a single event buffer. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c | 13 - drivers/usb/dwc3/core.h | 2

[PATCH 3/3] usb: dwc3: gadget: pass ev_buff as cookie to irq handler

2016-03-30 Thread Felipe Balbi
we don't plan on using multiple event buffers, but if we find a good use case for it, this little trick will help us avoid a loop in hardirq handler looping for each and every event buffer. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 28

RE: [PATCH v2 5/6] usb: host: xhci: plat: make use of new methods in xhci_plat_priv

2016-03-30 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi, > >> Sent: Wednesday, March 30, 2016 2:59 PM >> >> Yoshihiro Shimoda writes: >> > [ text/plain ] >> > Hi Felipe, >> > >> > Thank you for the patch! >> >> hey, no problem :-) >> >> >>

RE: [PATCH v2 5/6] usb: host: xhci: plat: make use of new methods in xhci_plat_priv

2016-03-30 Thread Yoshihiro Shimoda
Hi, > Sent: Wednesday, March 30, 2016 2:59 PM > > Yoshihiro Shimoda writes: > > [ text/plain ] > > Hi Felipe, > > > > Thank you for the patch! > > hey, no problem :-) > > >> Sent: Tuesday, March 29, 2016 7:11 PM > > < snip > > >> static const struct

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 10:05, Peter Chen wrote: > On Tue, Mar 29, 2016 at 10:23:14AM -0700, Mark Brown wrote: >> On Mon, Mar 28, 2016 at 03:13:51PM +0800, Peter Chen wrote: >> > On Mon, Mar 28, 2016 at 02:51:40PM +0800, Baolin Wang wrote: >> >> > > > I am afraid I still not

Re: Getting a gadget serial device working on Atmel SAMA5D31

2016-03-30 Thread Felipe Balbi
JB writes: > Hello, > >> 4.5.0+, which patches do you have on top of 4.5 vanilla ? > > No code patches, just the configuration and dts file for the board. > >> Also, can you try this patch: > > I tried it, but the result is the same. > > Sometimes I can see another

Re: [RFC PATCH 0/4] Implement USB device/host switch for Vybrid

2016-03-30 Thread maitysanchayan
Hello Peter, On 16-03-29 00:24:46, Peter Chen wrote: > > > > > On 2016-03-25 00:40, Peter Chen wrote: > > > On Tue, Mar 15, 2016 at 02:08:26PM +0530, Sanchayan Maity wrote: > > >> Hello Peter, > > >> > > >> The existing usage of extcon in Chipidea driver relies on OTG > > >> registers. In case

Re: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-30 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > Bin Liu writes: >> On Fri, Mar 18, 2016 at 08:59:48AM +0200, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Bin Liu writes: >>> > [ text/plain ] >>> > Hi, >>> > >>> > On Fri, Mar 11, 2016 at 6:54 AM,

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-30 Thread Baolin Wang
On 30 March 2016 at 10:54, Jun Li wrote: >> >> It is not for udc driver but for power users who want to negotiate >> >> with USB subsystem. >> >> >> > >> > Seems you don't want to guarantee charger type detection is done >> > before gadget connection(pullup DP), right? >> > I see

Re: [PATCH 2/3] usb: dwc3: increase maximum number of TRBs per endpoint

2016-03-30 Thread Felipe Balbi
Hi, Bin Liu writes: > On Fri, Mar 18, 2016 at 08:59:48AM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu writes: >> > [ text/plain ] >> > Hi, >> > >> > On Fri, Mar 11, 2016 at 6:54 AM, Felipe Balbi >> > wrote: >> >>

RE: [PATCH v2 5/6] usb: host: xhci: plat: make use of new methods in xhci_plat_priv

2016-03-30 Thread Felipe Balbi
Yoshihiro Shimoda writes: > [ text/plain ] > Hi Felipe, > > Thank you for the patch! hey, no problem :-) >> Sent: Tuesday, March 29, 2016 7:11 PM > < snip > >> static const struct xhci_plat_priv xhci_plat_renesas_rcar_gen2 = { >> .type =