[PATCH v7 2/2] usbip: vhci extension: dynamic extension

2016-11-21 Thread Nobuo Iwata
Modification for dynamic device registration and unregistration. 1. kernel config Followings are added. USBIP_VHCI_HC_PORTS: Number of ports per USB/IP virtual host controller. The default is 8 - same as current VHCI_NPORTS. USBIP_VHCI_MAX_HCS: Muximum number of USB/IP virtual host

[PATCH v7 1/2] usbip: vhci extension: modifications to userspace

2016-11-21 Thread Nobuo Iwata
Modification to the userspace tools including usbip/libsrc and usbip/src. Changed corresponding to new vhci_sysfs.c. nports in sysfs is used to get total number of ports. Old get_nports() ignores the last status line because udev_device_get_sysattr_value() drops last new line. New version

[PATCH v7 0/2] usbip: vhci number of ports extension

2016-11-21 Thread Nobuo Iwata
This series of patches extends number of ports limitaion in application (vhci) side. Driver portion of static extension has been merged at 4.9-rc1. 1/2 modifies userspace tools. It's effective not only for static extension but also for dynamic. 2/2 modifies driver for dynamic extenstion. 1.

[PATCH v13 07/10] usbip: exporting devices: new application-side daemon

2016-11-21 Thread Nobuo Iwata
This patch is the new application(vhci)-side daemon specific code. The daemons are consisting three files. usbip.c : common code. usbip_dev.c: device(stub)-side specific code. usbip_app.c: application(vhci)-side specific code - this patch. Here, device-side daemon is EXISTING-1 and

[PATCH v13 10/10] usbip: exporting devices: modifications to protocol text

2016-11-21 Thread Nobuo Iwata
This patch adds export and un-export request/response to Documentation/usb/usbip_protocol.txt. The definition of the structs has been defined in original code of tools/usb/usbip/usbip_network.h but not described in the document. Adding the request and response, words 'server' and 'client' are

[PATCH v13 09/10] usbip: exporting devices: chage to documenattion

2016-11-21 Thread Nobuo Iwata
This patch adds function and usage of new connect operation, disconnect operation and application(vhci)-side daemon to README and manuals. At this point, the wording, 'server' and 'client' are ambiguous in several place. For existing attach command, the daemon runs device side machine and

[PATCH v13 08/10] usbip: exporting devices: change to usbip_list.c

2016-11-21 Thread Nobuo Iwata
Correction to wording inconsistency around import and export in usbip_list.c regarding output title, help and function names. 'exported' was used for devices bound in remote and to be attached with 'import' request. This patch set uses pre-defined 'export' request to connect device. To avoid

[PATCH v13 06/10] usbip: exporting devices: modifications to attach and detach

2016-11-21 Thread Nobuo Iwata
Refactoring to attach and detach operation to reuse common portion to application(vhci)-side daemon. The new application(vhci)-side daemon executes same procedures as attach and detach. Most of common code to access vhci has been implemented in VHCI userspace wrapper(libsrc/vhci_driver.c) but

[PATCH v13 03/10] usbip: exporting devices: new connect operation

2016-11-21 Thread Nobuo Iwata
Implementation of new connect operation. This is linked as a part of usbip commnad. With this patch, usbip command has following operations. bind unbind list (local/remote) attach detach port connect ... this patch In device side node, this binds a device internally, sends an export

[PATCH v13 04/10] usbip: exporting devices: new disconnect operation

2016-11-21 Thread Nobuo Iwata
Implementation of new disconnect operation. This is linked as a part of usbip commnad. With this patch, usbip command has following operations. bind unbind list (local/remote) attach detach port connect ... previous patch disconnect ... this patch In device side node, this sends an

[PATCH v13 05/10] usbip: exporting devices: modifications to daemon

2016-11-21 Thread Nobuo Iwata
Refactoring to the daemon to reuse common portion for new application side daemon. It's divided into two portions. usbipd.c : common code for both device and application side daemon. usbipd_dev.c : device-side specific code extracted from usbipd.c. In following diagram, usbipd EXISTING-1 is the

[PATCH v13 01/10] usbip: exporting devices: modifications to network header

2016-11-21 Thread Nobuo Iwata
Modification to export and un-export response in tools/usb/usbip/src/usbip_network.h. It just changes return code type from int to uint32_t as same as other responses. Signed-off-by: Nobuo Iwata --- tools/usb/usbip/src/usbip_network.h | 4 ++-- 1 file changed, 2

[PATCH v13 00/10] usbip: exporting devices

2016-11-21 Thread Nobuo Iwata
Dear all, This series of patches adds exporting device operation to USB/IP. NOTE: This patch set modifies only userspace codes in tools/usb/usbip. 1. Goal 1-1) To give flexibility to direction of connection Using USB/IP in internet, there can be two cases. a) an application is inside firewall

[PATCH v13 02/10] usbip: exporting devices: modifications to host side libraries

2016-11-21 Thread Nobuo Iwata
usbip_get_device() method in usbip_host_driver_ops was not used. It is modified as a function to find an exported device for new operations 'connect' and 'disconnect'. bind and unbind function are exported to reuse by new connect and disconnect operation. Here, connect and disconnect is NEW-3

Re: [RFC][PATCH 3/3] usb: dwc2: Make sure we disconnect the gadget state

2016-11-21 Thread John Stultz
On Mon, Nov 21, 2016 at 7:23 PM, John Youn wrote: > On 11/15/2016 1:47 PM, John Stultz wrote: >> I had seen some odd behavior with HiKey's usb-gadget interface >> that I finally seemed to have chased down. Basically every other >> time I pluged in the OTG port, the gadget

Re: [PATCH v10 2/8] power: add power sequence library

2016-11-21 Thread Peter Chen
On Tue, Nov 22, 2016 at 03:23:12AM +0100, Rafael J. Wysocki wrote: > > @@ -0,0 +1,237 @@ > > +/* > > + * core.c power sequence core file > > + * > > + * Copyright (C) 2016 Freescale Semiconductor, Inc. > > + * Author: Peter Chen > > + * > > + * This program is free

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-21 Thread John Youn
On 11/21/2016 1:10 PM, Christian Lamparter wrote: > Hello John, > > On Monday, November 21, 2016 12:16:31 PM CET John Youn wrote: >> On 11/18/2016 12:18 PM, Christian Lamparter wrote: >>> On Friday, November 18, 2016 8:16:08 AM CET Rob Herring wrote: On Thu, Nov 17, 2016 at 04:35:10PM +0100,

Re: [RFC][PATCH 3/3] usb: dwc2: Make sure we disconnect the gadget state

2016-11-21 Thread John Youn
On 11/15/2016 1:47 PM, John Stultz wrote: > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I pluged in the OTG port, the gadget interface would > properly initialize. The other times, I'd get a big WARN_ON >

Re: [PATCH v10 2/8] power: add power sequence library

2016-11-21 Thread Rafael J. Wysocki
On Mon, Nov 14, 2016 at 2:35 AM, Peter Chen wrote: > We have an well-known problem that the device needs to do some power > sequence before it can be recognized by related host, the typical > example like hard-wired mmc devices and usb devices. > > This power sequence is hard

Re: [PATCH v10 2/8] power: add power sequence library

2016-11-21 Thread Peter Chen
On Mon, Nov 14, 2016 at 09:35:53AM +0800, Peter Chen wrote: > We have an well-known problem that the device needs to do some power > sequence before it can be recognized by related host, the typical > example like hard-wired mmc devices and usb devices. > > This power sequence is hard to be

Re: [PATCH 0/5] usb: dwc2: fix parameter handling

2016-11-21 Thread John Youn
On 11/20/2016 1:26 PM, Stefan Wahren wrote: > This patch series fixes several parameter handling issues > found on bcm2835 in gadget mode. It's based on Felipe's USB next. > > Stefan Wahren (5): > usb: dwc2: Do not set host parameter in peripheral mode > usb: dwc2: fix

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-21 Thread poma
On 21.11.2016 21:23, Wim Osterholt wrote: > On Mon, Nov 21, 2016 at 04:58:25PM +0100, Wim Osterholt wrote: >> >> I didn't find traces of kernel-4.9-rc5 being ran on any of my laptops, so I >> can't have seen a crash on rc5. It seems rc5 and rc6 is safe now. > > Neither 4.8.10, nor 4.8.9 show the

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread NeilBrown
On Tue, Nov 22 2016, Mark Brown wrote: > [ Unknown signature status ] > On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: >> On Thu, Nov 17 2016, Mark Brown wrote: > >> > To me that's pretty much what's being done here, the code just happens >> > to sit in USB instead but fundamentally

Flood of hub_ext_port_status failed (err = -71) messages

2016-11-21 Thread Simon Arlott
I have a 5-port USB 2.0 hub attached to a USB 3.0 host by a long length of Cat 5e cable (via a pair of cheap USB<->Cat5e adapters from eBay) that only works at full speed and doesn't stay connected all the time. This wouldn't be a problem except that the kernel can get stuck in a loop with the

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-21 Thread Christian Lamparter
Hello John, On Monday, November 21, 2016 12:16:31 PM CET John Youn wrote: > On 11/18/2016 12:18 PM, Christian Lamparter wrote: > > On Friday, November 18, 2016 8:16:08 AM CET Rob Herring wrote: > >> On Thu, Nov 17, 2016 at 04:35:10PM +0100, Stefan Wahren wrote: > >>> Hi John, > >>> > >>> Am

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-21 Thread Wim Osterholt
On Mon, Nov 21, 2016 at 04:58:25PM +0100, Wim Osterholt wrote: > > I didn't find traces of kernel-4.9-rc5 being ran on any of my laptops, so I > can't have seen a crash on rc5. It seems rc5 and rc6 is safe now. Neither 4.8.10, nor 4.8.9 show the bug. It must be a bug ouside cdc_acm that they

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-21 Thread John Youn
On 11/18/2016 12:18 PM, Christian Lamparter wrote: > On Friday, November 18, 2016 8:16:08 AM CET Rob Herring wrote: >> On Thu, Nov 17, 2016 at 04:35:10PM +0100, Stefan Wahren wrote: >>> Hi John, >>> >>> Am 17.11.2016 um 00:47 schrieb John Youn: Add the "snps,ahb-burst" binding and read it in.

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread Mark Brown
On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: > On Thu, Nov 17 2016, Mark Brown wrote: > > To me that's pretty much what's being done here, the code just happens > > to sit in USB instead but fundamentally it's just a blob of helper code, > > you could replace the notifier with a

Re: [PATCH v2 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

2016-11-21 Thread Axel Haslam
Hi Greg, On Thu, Nov 3, 2016 at 5:03 PM, Axel Haslam wrote: > The davinci ohci driver name (currently "ohci") is too generic. > To be consistent with other usb dirvers, append the "-da8xx" postfix > to the name. > if there are no objections, would it be possible to pick up

Re: [PATCH v6] USB hub_probe: rework ugly goto-into-compound-statement

2016-11-21 Thread Greg Kroah-Hartman
On Sat, Nov 19, 2016 at 09:55:45AM +0300, Eugene Korenevsky wrote: > Rework smelling code (goto inside compound statement). Perhaps this is > legacy. Anyway such code is not appropriate for Linux kernel. > > Signed-off-by: Eugene Korenevsky > --- > Changes in v6: more

[PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-21 Thread Axel Haslam
Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be moved on a later patch. Signed-off-by: Axel Haslam

[PATCH v6 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-21 Thread Axel Haslam
Using a regulator to handle VBUS will eliminate the need for platform data and callbacks, and make the driver more generic allowing different types of regulators to handle VBUS. The regulator equivalents to the platform callbacks are: set_power -> regulator_enable/regulator_disable

[PATCH v6 5/5] USB: ohci: da8xx: Allow probing from DT

2016-11-21 Thread Axel Haslam
This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index

[PATCH v6 0/5] USB: ohci-da8xx: Add device tree support

2016-11-21 Thread Axel Haslam
When booting using device tree, we can not make use of platform callbacks to handle vbus and over current gpios. This series allows the ohci-da8xx driver to use a regulator instead of the platform callbacks to control vbus and adds the device tree bindings to be able to probe using DT. Once all

[PATCH v6 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks

2016-11-21 Thread Axel Haslam
To migrate to a DT based boot, we will remove the use of platform callbacks, in favor of using the regulator framework to handle vbus and over current. In preparation to use a regulator instead of callbacks, move the platform data callbacks into separate functions. This provides well defined

[PATCH v6 4/5] USB: ohci: da8xx: Add devicetree bindings

2016-11-21 Thread Axel Haslam
This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: robh...@kernel.org Cc: mark.rutl...@arm.com Cc: devicet...@vger.kernel.org Acked-by: Rob Herring Signed-off-by: Axel Haslam ---

Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-21 Thread David Lechner
On 11/21/2016 04:22 AM, Axel Haslam wrote: Hi David, Thanks for the review, You're welcome. @@ -160,15 +212,41 @@ static void ohci_da8xx_ocic_handler(struct da8xx_ohci_root_hub *hub, hub->set_power(port, 0); } +static int ohci_da8xx_regulator_event(struct notifier_block

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-21 Thread Wim Osterholt
On Mon, Nov 21, 2016 at 02:19:32PM +0100, Oliver Neukum wrote: > On Thu, 2016-11-17 at 17:11 +0100, Wim Osterholt wrote: > > > Nov 17 15:07:51 localhost kernel: Check point 10 > > Nov 17 15:07:51 localhost kernel: BUG: unable to handle kernel NULL pointer > > dereference at 0249 > > Nov 17

Re: [PATCH V2] usb: xhci: add support for performing fake doorbell

2016-11-21 Thread Mathias Nyman
On 21.11.2016 09:57, Rafał Miłecki wrote: Hi Mathias, On 17 October 2016 at 22:30, Rafał Miłecki wrote: From: Rafał Miłecki Broadcom's Northstar XHCI controllers seem to need a special start procedure to work correctly. There isn't any official

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Guenter Roeck
On 11/21/2016 06:23 AM, Heikki Krogerus wrote: On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote: Hi Greg, On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: +static void typec_partner_release(struct device *dev) +{ + struct typec_port *port =

[PATCH 11/11] usb: musb: da8xx: Set phy in OTG mode by default

2016-11-21 Thread Bin Liu
From: Alexandre Bailon The DA8xx OTG PHY has some issues when it is forced in host or peripheral mode. Actually, most of the time, OTG is the best mode because host or peripheral mode are only required for hardware that miss some circuitry. Init the PHY mode OTG mode by

[PATCH 05/11] usb: musb: omap2430: use dev_err

2016-11-21 Thread Bin Liu
From: Ladislav Michl Replace pr_err with dev_err to print also device name. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Signed-off-by: Bin Liu --- drivers/usb/musb/omap2430.c | 6 +++--- 1 file changed, 3

[PATCH 09/11] usb: musb: da8xx: Add DT support for the DA8xx driver

2016-11-21 Thread Bin Liu
From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon Tested-by: David Lechner Signed-off-by: Bin Liu ---

[PATCH 07/11] dt/bindings: Add binding for the DA8xx MUSB driver

2016-11-21 Thread Bin Liu
From: Petr Kulhavy DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon Acked-by: Rob Herring Signed-off-by: Bin Liu ---

[PATCH 08/11] usb: musb: core: added helper function for parsing DT

2016-11-21 Thread Bin Liu
From: Petr Kulhavy This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Alexandre Bailon Tested-by: David Lechner

[PATCH 10/11] usb: musb: da8xx: Call earlier clk_prepare_enable()

2016-11-21 Thread Bin Liu
From: Alexandre Bailon The first attempt to read a register may fail because the clock may not be enabled, and then the probe of musb driver will fail. Call clk_prepare_enable() before the first register read. Signed-off-by: Alexandre Bailon

[PATCH 06/11] usb: musb: omap2430: make complain on -EPROBE_DEFER dev_dbg

2016-11-21 Thread Bin Liu
From: Ladislav Michl There is no point having this complaint to be dev_err as it is just adding noise to bootlog. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Signed-off-by: Bin Liu ---

[PATCH 04/11] usb: musb: don't complain on -EPROBE_DEFER when initializing controller

2016-11-21 Thread Bin Liu
From: Ladislav Michl Don't complain on -EPROBE_DEFER when initializing controller, the driver probe will be retried later. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Signed-off-by: Bin Liu ---

[PATCH 03/11] musb: sunxi: Force session end on babble errors in host-mode

2016-11-21 Thread Bin Liu
From: Hans de Goede The sunxi musb has a bug where sometimes it will generate a babble error on device disconnect instead of a disconnect irq. When this happens the musb-controller switches from host mode to device mode (it clears MUSB_DEVCTL_SESSION and sets

[PATCH 01/11] USB: musb: remove obsolete resume-signalling comments

2016-11-21 Thread Bin Liu
From: Johan Hovold Remove comments about resume signalling being stopped from GetPortStatus, something which is no longer the case. Fixes: 8ed1fb790ea2 ("usb: musb: finish suspend/reset work...") Signed-off-by: Johan Hovold Signed-off-by: Bin Liu

Re: [PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible pointer type

2016-11-21 Thread Johan Hovold
On Mon, Nov 21, 2016 at 01:19:31PM +0100, Geert Uytterhoeven wrote: > On sparc32, tcflag_t is unsigned long, unlike all other architectures: > > drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios': > drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of >

[PATCH 02/11] musb: sunxi: Remove custom babble handling

2016-11-21 Thread Bin Liu
From: Hans de Goede The musb core already handles babble interrupts, so the sunxi glue having its own custom handling is redundant. Signed-off-by: Hans de Goede Signed-off-by: Bin Liu --- drivers/usb/musb/sunxi.c | 10 -- 1 file

[PATCH 00/11] musb patches for v4.10-rc1

2016-11-21 Thread Bin Liu
Hi Greg, This musb set is for next v4.10-rc. It adds DA8xx DT support, fixes babble handling in sunxi driver. The rest of the patches are cleanup in comments or log messages. Please let me know if any change is needed. Thanks, -Bin. --- Alexandre Bailon (2): usb: musb: da8xx: Call earlier

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: > > > +static void typec_partner_release(struct device *dev) > > > +{ > > > + struct typec_port *port = to_typec_port(dev->parent); > > > + > > > +

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:27:41PM +0200, Heikki Krogerus wrote: > On Mon, Nov 21, 2016 at 11:33:11AM +0100, Greg KH wrote: > > On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > > > The purpose of USB Type-C connector class is to provide > > > unified interface for the user space

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Heikki Krogerus
On Mon, Nov 21, 2016 at 03:11:03PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: > > > +static void typec_partner_release(struct device *dev) > > > +{ > > > + struct typec_port *port = to_typec_port(dev->parent); > > > + > > > +

Re: [PATCH 13/82] media: usbtv: core: make use of new usb_endpoint_maxp_mult()

2016-11-21 Thread Mauro Carvalho Chehab
Em Mon, 31 Oct 2016 12:48:05 +0200 Felipe Balbi escreveu: > We have introduced a helper to calculate multiplier > value from wMaxPacketSize. Start using it. Good idea! Btw, we have something similar at em28xx, stk1160-core.c and tm6000 drivers. On them, we have

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Heikki Krogerus
On Mon, Nov 21, 2016 at 11:33:11AM +0100, Greg KH wrote: > On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C connectors

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

2016-11-21 Thread Oliver Neukum
On Thu, 2016-11-17 at 17:11 +0100, Wim Osterholt wrote: > Nov 17 15:07:51 localhost kernel: Check point 10 > Nov 17 15:07:51 localhost kernel: BUG: unable to handle kernel NULL pointer > dereference at 0249 > Nov 17 15:07:51 localhost kernel: IP: [] acm_probe+0x559/0xe53 > [cdc_acm] > Nov

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Heikki Krogerus
Hi Greg, On Mon, Nov 21, 2016 at 11:35:28AM +0100, Greg KH wrote: > > +static void typec_partner_release(struct device *dev) > > +{ > > + struct typec_port *port = to_typec_port(dev->parent); > > + > > + typec_unregister_altmodes(dev); > > + port->partner = NULL; > > +} > > This doesn't

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
On 21/11/16 13:56, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index f945380..6553903 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1656,6 +1656,9 @@ struct xhci_hcd {

[PATCH v3 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
From: Felipe Balbi Some devices from Texas Instruments [1] suffer from a silicon bug where Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an IRQ for device removal (or attachment) will never fire.

[PATCH] USB: serial: cp210x: Use tcflag_t to fix incompatible pointer type

2016-11-21 Thread Geert Uytterhoeven
On sparc32, tcflag_t is unsigned long, unlike all other architectures: drivers/usb/serial/cp210x.c: In function 'cp210x_get_termios': drivers/usb/serial/cp210x.c:717:3: warning: passing argument 2 of 'cp210x_get_termios_port' from incompatible pointer type

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Felipe Balbi
Hi, Roger Quadros writes: > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index f945380..6553903 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1656,6 +1656,9 @@ struct xhci_hcd { > #define XHCI_SSIC_PORT_UNUSED(1 << 22) >

Re: [PATCH 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
On 18/11/16 12:49, Sergei Shtylyov wrote: > Hello. > > On 11/17/2016 6:01 PM, Roger Quadros wrote: > >> From: Felipe Balbi >> >> Some devices from Texas Instruments [1] suffer from >> a silicon bug where Port Enabled/Disabled bit >> should not be used to silence an erroneous

[PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

2016-11-21 Thread Roger Quadros
From: Felipe Balbi Some devices from Texas Instruments [1] suffer from a silicon bug where Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an IRQ for device removal (or attachment) will never fire.

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Axel Haslam
On Mon, Nov 21, 2016 at 11:49 AM, Sekhar Nori wrote: > On Monday 21 November 2016 04:16 PM, Sekhar Nori wrote: In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci >> tree, the alias for the musb device is usb0. So, I think we should use >> usb1

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Sekhar Nori
On Monday 21 November 2016 04:16 PM, Sekhar Nori wrote: >>> In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci >>> >> tree, the alias for the musb device is usb0. So, I think we should use >>> >> usb1 >>> >> here instead of ohci - or change the usb0 alias to musb. >>> >> >>>

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Sekhar Nori
On Monday 21 November 2016 03:57 PM, Axel Haslam wrote: > On Mon, Nov 21, 2016 at 3:42 AM, David Lechner wrote: >> On 11/07/2016 02:39 PM, Axel Haslam wrote: >>> >>> This adds the ohci device node for the da850 soc. >>> It also enables it for the omapl138 hawk board. >>> >>>

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCHv11 2/3] usb: USB Type-C connector class

2016-11-21 Thread Greg KH
On Thu, Nov 17, 2016 at 12:50:35PM +0200, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node

2016-11-21 Thread Axel Haslam
On Mon, Nov 21, 2016 at 3:42 AM, David Lechner wrote: > On 11/07/2016 02:39 PM, Axel Haslam wrote: >> >> This adds the ohci device node for the da850 soc. >> It also enables it for the omapl138 hawk board. >> >> Signed-off-by: Axel Haslam >> --- >>

Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

2016-11-21 Thread Axel Haslam
Hi David, Thanks for the review, On Sun, Nov 20, 2016 at 4:31 AM, David Lechner wrote: > On 11/14/2016 08:41 AM, ahas...@baylibre.com wrote: >> >> Using a regulator to handle VBUS will eliminate the need for >> platform data and callbacks, and make the driver more generic

Re: Issue with Telit LE922 and cdc_mbim

2016-11-21 Thread Bjørn Mork
Daniele Palmas writes: > it turned out that resetting the interface in cdc_ncm_init after > getting the NTB parameters removes the need for the sleep, making the > modem to work fine. Sounds very good, although I must admit that it isn't perfectly clear to me what kind of

Re: [v5,1/5] USB: ohci: da8xx: use ohci priv data instead of globals

2016-11-21 Thread Axel Haslam
On Sun, Nov 20, 2016 at 3:58 AM, David Lechner wrote: > On 11/14/2016 08:40 AM, ahas...@baylibre.com wrote: >> >> Instead of global variables, use the extra_priv_size of >> the ohci driver. >> >> We cannot yet move the ocic mask because this is used on >> the interrupt

[BUG 4.9] New led trigger usbport gets the kernel to panic

2016-11-21 Thread Ralph Sennhauser
Hi Rafał, I tried your new usbport trigger in Linux 4.9 with little luck as can be seen in the following output of the serial console. root@wrt1900acs:/# cd /sys/class/leds/pca963x\:shelby\:white\:usb2/