RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-07 Thread Jun Li
> -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年5月7日 23:59 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; cw00.c...@samsung.com; > shufan_...@richtek.com; Peter Chen

Re: [PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-05-07 Thread Doug Anderson
Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > If isoc split in transfer with no data (the length of DATA0 > packet is zero), we can't simply return immediately. Because > the DATA0 can be the first transaction or the second transaction > for the isoc split in

Re: [PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread Doug Anderson
Hi, On Mon, May 7, 2018 at 8:07 PM, William Wu wrote: > +static int dwc2_alloc_split_dma_aligned_buf(struct dwc2_hsotg *hsotg, > + struct dwc2_qh *qh, > + struct dwc2_host_chan *chan) >

Re: [PATCH v3 2/3] usb: dwc3: Add Qualcomm DWC3 glue driver

2018-05-07 Thread Manu Gautam
On 5/5/2018 12:18 AM, Manu Gautam wrote: > DWC3 controller on Qualcomm SOCs has a Qscratch wrapper. > Some of its uses are described below resulting in need to > have a separate glue driver instead of using dwc3-of-simple: > - It exposes register interface to override vbus-override >and

Re: [PATCH v2 1/2] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

2018-05-07 Thread Jianguo Sun
Hi Rob, On 05/08/2018 01:09 AM, Rob Herring wrote: On Sat, May 05, 2018 at 06:09:49PM +0800, sunj...@163.com wrote: From: Jianguo Sun This commit adds bindings doc for HiSilicon STB xHCI host controller. Signed-off-by: Jianguo Sun ---

[PATCH v3 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread William Wu
The commit 3bc04e28a030 ("usb: dwc2: host: Get aligned DMA in a more supported way") rips out a lot of code to simply the allocation of aligned DMA. However, it also introduces a new issue when use isoc split in transfer. In my test case, I connect the dwc2 controller with an usb hs Hub

[PATCH v3 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-05-07 Thread William Wu
If isoc split in transfer with no data (the length of DATA0 packet is zero), we can't simply return immediately. Because the DATA0 can be the first transaction or the second transaction for the isoc split in transaction. If the DATA0 packet with no data is in the first transaction, we can return

[PATCH v3 0/2] usb: dwc2: fix isoc split in transfer issue

2018-05-07 Thread William Wu
This patch fix dma unaligned problem and data lost problem for isoc split in transfer. Test on rk3288 platform, use an usb hs Hub (GL852G-12) and an usb fs audio device (Plantronics headset) to capture and playback. William Wu (2): usb: dwc2: alloc dma aligned buffer for isoc split in usb:

RE: [PATCH/RFC v2 1/6] dt-bindings: usb: add Renesas R-Car USB 3.0 role switch

2018-05-07 Thread Yoshihiro Shimoda
Hi Rob, Sorry for the delayed response. I had a vacation in last week. > From: Rob Herring, Sent: Saturday, April 28, 2018 5:06 AM > > On Thu, Apr 26, 2018 at 08:26:41PM +0900, Yoshihiro Shimoda wrote: > > This patch adds a new documentation for Renesas R-Car USB 3.0 role > > switch that can

Re: [PATCH v2 1/2] dt-bindings: add MediaTek XS-PHY binding

2018-05-07 Thread Chunfeng Yun
On Mon, 2018-05-07 at 12:04 -0500, Rob Herring wrote: > On Sat, May 05, 2018 at 10:15:05AM +0800, Chunfeng Yun wrote: > > Add a DT binding documentation of XS-PHY for MediaTek SoCs > > with USB3.1 GEN2 controller > > > > Signed-off-by: Chunfeng Yun > > --- > >

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-07 Thread Mats Karrman
Hi Heikki, On 05/07/2018 03:39 PM, Heikki Krogerus wrote: > Hi Mats, > > On Fri, May 04, 2018 at 06:57:31PM +0200, Mats Karrman wrote: >> On 2018-05-04 16:56, Heikki Krogerus wrote: >> >>> On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: Hi Heikki, On 2018-05-02

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

2018-05-07 Thread Rob Herring
On Mon, May 7, 2018 at 10:57 AM, Doug Anderson wrote: > Rob, > > On Mon, May 7, 2018 at 8:53 AM, Rob Herring wrote: >> On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: >>> To improve eye diagram for PHYs on different boards of same SOC, >>>

USB, Help, Keyboard being dropped

2018-05-07 Thread ant
(no need to CC I'm subscribed to list), Hello, My USB keyboard is being dropped by the kernel at various times and I cannot figure out how to fix this. Maybe I have messed up somewhere but I think I'm reading the documents right. :) I'm using a recent Debian kernel and running Debian

Re: Non-BCD bcdDevice values

2018-05-07 Thread Alan Stern
On Mon, 7 May 2018, Mark Knibbs wrote: > Some devices have a non-BCD value in bcdDevice. For example some card > readers based on an ICSI chip have bcdDevice 0x016F. (They put "1.6F" > in bytes 32-35 of their INQUIRY data.) > > For devices which need US_FL_FIX_INQUIRY, fill_inquiry_response() >

Non-BCD bcdDevice values

2018-05-07 Thread Mark Knibbs
Some devices have a non-BCD value in bcdDevice. For example some card readers based on an ICSI chip have bcdDevice 0x016F. (They put "1.6F" in bytes 32-35 of their INQUIRY data.) For devices which need US_FL_FIX_INQUIRY, fill_inquiry_response() doesn't appear to handle non-BCD values correctly

Re: [PATCH v2 1/2] dt-bindings: usb: add bindings doc for HiSilicon STB xHCI host controller

2018-05-07 Thread Rob Herring
On Sat, May 05, 2018 at 06:09:49PM +0800, sunj...@163.com wrote: > From: Jianguo Sun > > This commit adds bindings doc for HiSilicon STB xHCI host controller. > > Signed-off-by: Jianguo Sun > --- > .../bindings/usb/hisilicon,histb-xhci.txt

Re: [PATCH v2 1/2] dt-bindings: add MediaTek XS-PHY binding

2018-05-07 Thread Rob Herring
On Sat, May 05, 2018 at 10:15:05AM +0800, Chunfeng Yun wrote: > Add a DT binding documentation of XS-PHY for MediaTek SoCs > with USB3.1 GEN2 controller > > Signed-off-by: Chunfeng Yun > --- > .../devicetree/bindings/phy/phy-mtk-xsphy.txt | 110 >

Re: USB regression for Android phone and sound card in 4.14

2018-05-07 Thread Nazar Mokrynskyi
07.05.18 18:20, Alan Stern пише: > Hmmm. Earlier you said that if you unplugged the hub after the system > was booted and running, and then plugged it back in, the sound card > would connect at high speed. Have you tried leaving the hub plugged > in, but unplugging and reconnecting just the

Re: [PATCH v3 1/3] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver

2018-05-07 Thread Rob Herring
On Sat, May 05, 2018 at 12:18:07AM +0530, Manu Gautam wrote: > Existing documentation has lot of incorrect information as it > was originally added for a driver that no longer exists. > > Signed-off-by: Manu Gautam > --- > .../devicetree/bindings/usb/qcom,dwc3.txt

Re: [PATCH v5 02/14] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-05-07 Thread Rob Herring
On Thu, May 03, 2018 at 08:24:42AM +0800, Li Jun wrote: > TCPCI stands for typec port controller interface, its implementation > has full typec port control with power delivery support, it's a > standard i2c slave with GPIO input as irq interface, detail see spec > "Universal Serial Bus Type-C

Re: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

2018-05-07 Thread Rob Herring
On Thu, May 03, 2018 at 08:24:41AM +0800, Li Jun wrote: > Add bingdings supported by current typec driver, so user can pass > all those properties via dt. > > Signed-off-by: Li Jun > --- > .../bindings/connector/usb-connector.txt | 44 +++ >

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

2018-05-07 Thread Doug Anderson
Rob, On Mon, May 7, 2018 at 8:53 AM, Rob Herring wrote: > On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: >> To improve eye diagram for PHYs on different boards of same SOC, >> some parameters may need to be changed. Provide device tree >> properties to override

Re: [PATCH v5 6/7] dt-bindings: phy-qcom-usb2: Add support to override tuning values

2018-05-07 Thread Rob Herring
On Thu, May 03, 2018 at 02:36:13AM +0530, Manu Gautam wrote: > To improve eye diagram for PHYs on different boards of same SOC, > some parameters may need to be changed. Provide device tree > properties to override these from board specific device tree > files. While at it, replace

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-07 Thread Alan Stern
On Mon, 7 May 2018, Sebastian Andrzej Siewior wrote: > On 2018-05-04 16:07:22 [-0400], Alan Stern wrote: > > On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote: > > > > > Hi Alan, > > > > > > I posted a RFC [0] to let the HCD complete the URB in threaded-IRQ > > > context to avoid the

[PATCH 5/5] arm64: allwinner: h6: enable USB3 port on Pine H64

2018-05-07 Thread Icenowy Zheng
Pine H64 board have a USB3 port, which is connected to the USB3 pins of the H6 SoC, and the 5V power supply is controlled via GPIO (shared with the power USB ports). Enable this port. Signed-off-by: Icenowy Zheng --- .../boot/dts/allwinner/sun50i-h6-pine-h64.dts | 23

[PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes

2018-05-07 Thread Icenowy Zheng
Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and a custom PHY. Add device tree nodes for them. Signed-off-by: Icenowy Zheng --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 1 file changed, 38 insertions(+) diff --git

[PATCH 3/5] usb: dwc3: of-simple: Add compatible for Allwinner H6 platform

2018-05-07 Thread Icenowy Zheng
Add compatible string to use this generic glue layer to support Allwinner H6 platform's dwc3 controller. Signed-off-by: Icenowy Zheng --- drivers/usb/dwc3/dwc3-of-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c

[PATCH 2/5] dt-bindings: usb: add binding for the DWC3 controller on Allwinner SoC

2018-05-07 Thread Icenowy Zheng
The Allwinner H6 SoC uses DWC3 controller for USB3. Add its device tree binding document. Signed-off-by: Icenowy Zheng --- .../bindings/usb/allwinner,dwc3.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644

[PATCH 1/5] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC

2018-05-07 Thread Icenowy Zheng
Allwinner H6 SoC contains a USB3 PHY (with USB2 DP/DM lines also controlled). Add a driver for it. The register operations in this driver is mainly extracted from the BSP USB3 driver. Signed-off-by: Icenowy Zheng --- .../bindings/phy/sun50i-usb3-phy.txt | 24 +++

Re: USB regression for Android phone and sound card in 4.14

2018-05-07 Thread Alan Stern
On Sat, 5 May 2018, Nazar Mokrynskyi wrote: > 04.05.18 18:47, Alan Stern пише: > > > On Fri, 4 May 2018, Alan Stern wrote: > > > >> You can try using the usbreset program from here: > >> > >>https://marc.info/?l=linux-usb=144820655510812=2 > >> > >> That program wants the usbfs pathname of

[PATCH 0/5] Allwinner H6 USB3 support

2018-05-07 Thread Icenowy Zheng
This patchset contains USB3 support for Allwinner H6 SoC (DWC3 with a custom PHY). The first patch adds the PHY driver, and the second/third patch adds compatible to adapt DWC3 platform glue to Allwinner platform. The last two patches are DT changes. Icenowy Zheng (5): phy: allwinner: add phy

RE: EXTERNAL: [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM

2018-05-07 Thread Jeremy Boone
Hi there, I have some feedback. A few months ago, I disclosed a series of bugs to this list that could be triggered by an interposer that sits on the serial bus between the TPM chip and the kernel. These patches can be found here [1], and the tool/whitepaper to go with my research can be

Re: Bug - USB ports remain suspended after suspend/resume

2018-05-07 Thread Oliver Neukum
Am Freitag, den 04.05.2018, 19:00 + schrieb Vasil Vasilev: > ASUS UX305UA user. USB ports function normally after system boot. After the > first and any subsequent suspend/resume, the USB ports remain suspended. In > order for a newly plugged in USB device to be recognized, any autosuspended >

Re: [PATCH v5 4/7] dt-bindings: phy-qcom-qmp: Update bindings for sdm845

2018-05-07 Thread Rob Herring
On Thu, May 03, 2018 at 02:36:11AM +0530, Manu Gautam wrote: > Update compatible strings for USB3 PHYs on SDM845. > One is QMPv3 DisplayPort-USB combo PHY and other one > is USB UNI PHY which is single lane USB3 PHY without > DP capability. While at it also remove "qcom,qmp-v3-usb3-phy" >

Re: [RFC PATCH 1/7] usb: typec: Generalize mux mode names

2018-05-07 Thread Heikki Krogerus
Hi Mats, On Fri, May 04, 2018 at 06:57:31PM +0200, Mats Karrman wrote: > > On 2018-05-04 16:56, Heikki Krogerus wrote: > > > On Wed, May 02, 2018 at 03:13:44PM +0200, Mats Karrman wrote: > > > Hi Heikki, > > > > > > On 2018-05-02 10:25, Heikki Krogerus wrote: > > > > > > > On Wed, May 02,

Re: [PATCH v2 1/2] usb: dwc2: alloc dma aligned buffer for isoc split in

2018-05-07 Thread wlf
Dear Doug, 在 2018年05月07日 15:19, Allen Hsu (許嘉銘) 写道: Add more: Best regards, BU4 EE Allen Hsu QCI 886-3-327-2345 ext 15410 -Original Message- From: Doug Anderson [mailto:diand...@google.com] Sent: Friday, May 4, 2018 11:58 PM To: wlf Cc: William Wu

Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card

2018-05-07 Thread David R. Bild
On Mon, May 7, 2018 at 4:58 AM, Oliver Neukum wrote: > > Am Freitag, den 04.05.2018, 08:00 -0500 schrieb David R. Bild : > > > > +config USB_XAPEA00X > > + tristate "Xaptum ENF Access card support (XAP-EA-00x)" > > + depends on USB_SUPPORT && SPI && TCG_TPM > > You'd

Re: dwc2 (on Meson8b) doesn't detect "hot-plugged" USB devices

2018-05-07 Thread Minas Harutyunyan
Hi Martin, On 5/7/2018 12:28 AM, Martin Blumenstingl wrote: > Hello, > > I was a bit surprised to see that hot-plugging USB devices on Amlogic > Meson8b (for example: Odroid-C1) is broken. > to be fair: I *think* it worked before, but I cannot guarantee it nor > can I say when it broke > > all

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-05-07 Thread Stefan Wahren
Hi Simon, Am 07.05.2018 um 14:48 schrieb Simon Shields: Hi Grigor, On Wed, May 02, 2018 at 10:12:27AM +, Grigor Tovmasyan wrote: Hi Simon, On 4/21/2018 4:52 PM, Simon Shields wrote: Hi Grigor, On Fri, Apr 20, 2018 at 01:00:16PM +, Grigor Tovmasyan wrote: Hi Simon, On 4/19/2018

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-05-07 Thread Simon Shields
Hi Grigor, On Wed, May 02, 2018 at 10:12:27AM +, Grigor Tovmasyan wrote: > Hi Simon, > > On 4/21/2018 4:52 PM, Simon Shields wrote: > > Hi Grigor, > > > > On Fri, Apr 20, 2018 at 01:00:16PM +, Grigor Tovmasyan wrote: > >> Hi Simon, > >> > >> On 4/19/2018 8:31 PM, Simon Shields wrote: >

[PATCH 3/4] usb: dwc2: replace ioread32/iowrite32_rep with dwc2_readl/writel_rep

2018-05-07 Thread Gevorg Sahakya
From: Gevorg Sahakyan dwc2_readl_rep/dwc2_writel_rep functions using readl/writel in a loop. Signed-off-by: Gevorg Sahakyan Signed-off-by: Gevorg Sahakya --- drivers/usb/dwc2/core.h | 61

[PATCH 4/4] usb: dwc2: Make dwc2_readl/writel functions endianness-agnostic.

2018-05-07 Thread Gevorg Sahakya
From: Gevorg Sahakyan Declared dwc2_check_core_endianness() function for dynamicly check core endianness. Added needs_byte_swap flag to hsotg structure, and depending on flag swap value inside dwc2_readl/writel functions. Signed-off-by: Gevorg Sahakyan

[PATCH 1/4] usb: dwc2: Move dwc2_readl/writel functions after hsotg structure

2018-05-07 Thread Gevorg Sahakya
From: Gevorg Sahakyan Moved dwc2_readl/writel functions after hsotg declaration for adding hsotg structure to dwc2_readl/writel function prototypes. Signed-off-by: Gevorg Sahakyan Signed-off-by: Gevorg Sahakya ---

[PATCH 0/4] usb: dwc2: Make dwc2 endianness agnostic

2018-05-07 Thread Gevorg Sahakya
This pachs series makes dwc2 driver working with opposite endianness Gevorg Sahakyan (4): usb: dwc2: Move dwc2_readl/writel functions after hsotg structure usb: dwc2: Modify dwc2_readl/writel functions prototype usb: dwc2: replace ioread32/iowrite32_rep with dwc2_readl/writel_rep usb:

[PATCH] usb: dwc3: gadget: init req->{direction,epnum} from alloc_request()

2018-05-07 Thread Felipe Balbi
We dont' need to touch req->direction or req->epnum from ep_queue(). It's enough that we initialize both fields from alloc_request() and just keep them for the entire lifetime of the request. No functional changes. Signed-off-by: Felipe Balbi ---

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-07 Thread Sebastian Andrzej Siewior
On 2018-05-04 16:07:22 [-0400], Alan Stern wrote: > On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote: > > > Hi Alan, > > > > I posted a RFC [0] to let the HCD complete the URB in threaded-IRQ > > context to avoid the softirq/tasklet. Mauro reported that this does not > > help him and never

Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card

2018-05-07 Thread Oliver Neukum
Am Freitag, den 04.05.2018, 08:00 -0500 schrieb David R. Bild : > > +config USB_XAPEA00X > + tristate "Xaptum ENF Access card support (XAP-EA-00x)" > + depends on USB_SUPPORT && SPI && TCG_TPM You'd have to know how the device internally works. It would be better to select SPI. >

Re: patch 8466489ef5ba48272ba4fa4ea9f8f403306de4c7 breaks Renesas USB3 controller functionality

2018-05-07 Thread Marc Zyngier
On Mon, 07 May 2018 06:00:56 +0100, Bockholdt Arne wrote: > > > > On Thu, 2018-05-03 at 10:41 +0100, Marc Zyngier wrote: > > I'm talking about making the whole workaround dependent on the USB > > controller being behind an iommu. No iommu, no workaround (because it > > is > > likely that there