RE: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread Peter Chen
> Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on peter.chen-usb/ci-for-usb-next] [also build test > ERROR > on v4.19-rc8 next-20181012] [if your patch is applied to the wrong git tree, > please > drop us a note to help improve the system] > > url: >

Re: [PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread kbuild test robot
Hi Peter, I love your patch! Yet something to improve: [auto build test ERROR on peter.chen-usb/ci-for-usb-next] [also build test ERROR on v4.19-rc8 next-20181012] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

2018-10-15 Thread Peter Chen
For USB HSIC, the data and strobe pin needs to be pulled down at default, we consider it as "idle" state. When the USB host is ready to be used, the strobe pin needs to be pulled up, we consider it as "active" state. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb

[PATCH 3/4] usb: chipidea: host: override ehci->hub_control

2018-10-15 Thread Peter Chen
The chipidea controller has some special requirements during suspend/resume, override common ehci->hub_control to implement it. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 74 + 1 file changed, 74 insertions(+) diff --git a/drivers/usb

[PATCH 2/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread Peter Chen
To support imx HSIC, there are some special requirement: - The HSIC pad is 1.2v, it may need to supply from external - The data/strobe pin needs to be pulled down first, and after host mode is initialized, the strobe pin needs to be pulled up - During the USB suspend/resume, special setting is ne

[PATCH 1/4] usb: chipidea: add flag for imx hsic implementation

2018-10-15 Thread Peter Chen
NXP (Freecale) imx HSIC design has some special requirements, add some flags at host code to handle them. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 24 include/linux/usb/chipidea.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/usb/c

[PATCH 0/4] usb: chipidea: imx: add HSIC support

2018-10-15 Thread Peter Chen
Most of NXP (Freescale) i.mx USB part has HSIC support, in this series, we add support for them, it should cover all imx6 and imx7d. I have no HSIC interface board which is supported by upstream kernel, so this patches are only compiled ok, Frieder Schrempf, would you please help me test it on your

[PATCH] xhci: remove the unused sw_lpm_support

2018-10-15 Thread Zeng Tao
It is introduced for the pre-0.96 xHC controllers, and the driver only support HW LPM for 1.0 and later controllers.It's not actually used now and is thought not to be used in the future any more, so just remove it. Acked-by: Mathias Nyman Signed-off-by: Zeng Tao --- drivers/usb/host/xhci-mem.c

RE: Can we just remove the sw_lpm_support from current xhci driver?

2018-10-15 Thread Zengtao (B)
Hi Mathias: >-Original Message- >From: Mathias Nyman [mailto:mathias.ny...@intel.com] >Sent: Monday, October 15, 2018 8:11 PM >To: Zengtao (B) ; Greg KH > >Cc: linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org >Subject: Re: Can we just remove the sw_lpm_support from current xhci >dri

Working test 5

2018-10-15 Thread Judy
Did you get my email from last week? Let me know if you have photos for cutting out or retouching? We are an image team who can do editing for your the web store photos, industry photos or portrait photos. Send photos, we will do testing for you to check quality. Waiting for your reply soon. Th

[PATCH RESEND] usb: gadget: udc: atmel: handle at91sam9rl PMC

2018-10-15 Thread Alexandre Belloni
The at91sam9rl PMC is not quite the same as the at91sam9g45 one and now has its own compatible string. Add support for that. Fixes: 217bace8e548 ("ARM: dts: fix PMC compatible") Signed-off-by: Alexandre Belloni Acked-by: Cristian Birsan --- Hello Greg, This is an urgent fix that was sent on s

[PATCH] USB: fix the usbfs flag sanitization for control transfers

2018-10-15 Thread Alan Stern
Commit 7a68d9fb8510 ("USB: usbdevfs: sanitize flags more") checks the transfer flags for URBs submitted from userspace via usbfs. However, the check for whether the USBDEVFS_URB_SHORT_NOT_OK flag should be allowed for a control transfer was added in the wrong place, before the code has properly de

Re: WARNING in usb_submit_urb (3)

2018-10-15 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+24a30223a4b609bb8...@syzkaller.appspotmail.com Tested on: commit: f0a7d1883d9f afs: Fix clearance of reply git tree: upstream kernel config: https://syzkall

Re: [PATCH 1/5] dt-bindings: Add Broadcom STB OHCI, EHCI and XHCI binding document

2018-10-15 Thread Rob Herring
On Wed, Sep 26, 2018 at 06:20:10PM -0400, Al Cooper wrote: > Add DT bindings document for Broadcom STB USB OHCI, EHCI and > XHCI drivers. > > Signed-off-by: Al Cooper > --- > .../devicetree/bindings/usb/brcm,ehci-brcm.txt | 22 + > .../devicetree/bindings/usb/brcm,ohci-br

Re: WARNING in usb_submit_urb (3)

2018-10-15 Thread Andrey Konovalov
On Mon, Oct 15, 2018 at 7:12 PM, Alan Stern wrote: > Ah, I see the problem. In fact it is the same issue, but the commit > mentioned above contains an error (is_in gets tested too soon). The > fix is below; can you check it? You can ask syzbot to do this: #syz test: git://git.kernel.org/pub/sc

Re: WARNING in usb_submit_urb (3)

2018-10-15 Thread Alan Stern
On Mon, 15 Oct 2018, Andrey Konovalov wrote: > On Mon, Oct 15, 2018 at 5:22 PM, Alan Stern wrote: > > On Fri, 12 Oct 2018, syzbot wrote: > > > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:9dcd936c5312 Merge tag 'for-4.19/dm-fixes-4' of > >> git://git... > >>

usb: dwc3: dwc3 errors while video streaming with uvc-gadget

2018-10-15 Thread Terence Neill
Hi Felipe,   I am having some issues when attempting to stream 1280x720 uncompressed video @ 10fps over a USB 2.0 High-Speed link.   The system setup is:   WebCam --- USB 2.0 link --->  x86 Linux Machine running uvc-gadget USB 2.0 link ---> x86 Host Machine running Windows 10.   When run

Re: usbip_vudc: BUG kmalloc-2048 (Not tainted): Poison overwritten

2018-10-15 Thread Shuah Khan
On 10/13/2018 11:37 AM, Randy Dunlap wrote: > Kernel 4.19-rc7, on x86_64: > > Load usbip_vudc module, then unload (rmmod) it. > Load it again: > Thanks Randy. I am debugging another problem in this path and I will take a look at this one as well. Just quick ack that I saw this. Thanks for repor

Re: WARNING in usb_submit_urb (3)

2018-10-15 Thread Andrey Konovalov
On Mon, Oct 15, 2018 at 5:22 PM, Alan Stern wrote: > On Fri, 12 Oct 2018, syzbot wrote: > >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:9dcd936c5312 Merge tag 'for-4.19/dm-fixes-4' of git://git... >> git tree: upstream >> console output: https://syzkaller.appspot

Re: [PATCH v2] usb: host: ohci-at91: fix request of irq for optional gpio

2018-10-15 Thread Alan Stern
On Mon, 15 Oct 2018 tudor.amba...@microchip.com wrote: > atmel,oc-gpio is optional. Request its irq only when atmel,oc is set > in device tree. > > devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its > return value for NULL before error, because it is more probable that > atmel,oc is

Re: WARNING in usb_submit_urb (3)

2018-10-15 Thread Alan Stern
On Fri, 12 Oct 2018, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:9dcd936c5312 Merge tag 'for-4.19/dm-fixes-4' of git://git... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=123b8da140 > kernel config: https://sy

[PATCH v2] phy: phy-pxa-usb: add a new driver

2018-10-15 Thread Lubomir Rintel
Turned from arch/arm/mach-mmp/devices.c into a proper PHY driver, so that in can be instantiated from a DT. Acked-by: Kishon Vijay Abraham I Signed-off-by: Lubomir Rintel --- Greg, please include this in the USB tree. Changes to mv-ehci driver that are already in can utilize this and it got an

[PATCH] usb: gadget: f_fs: add the support for alternate interface setting

2018-10-15 Thread Parikshit Pareek
In FFS the support for multiple alternate interface settings are not present. This patch implements the due support. The user application is required to write interface descriptors to ep0 file of function fs, one for each alternate interface setting of the same interface, with bAlternateSetting set

Re: Query on usb/core/devio.c

2018-10-15 Thread Alan Stern
On Mon, 15 Oct 2018, Oliver Neukum wrote: > On Do, 2018-10-11 at 14:29 -0400, Alan Stern wrote: > > On Thu, 11 Oct 2018, Mayuresh Kulkarni wrote: > [..] > > > We are looking into closing the device instance during normal operation > > > i.e.: only open/close device when needed. > > > > > > Howev

Re: [PATCH 2/8] usbnet: smsc95xx: add kconfig for turbo mode

2018-10-15 Thread Bjørn Mork
Ben Dooks writes: > Add a configuration option for the default state of turbo mode > on the smsc95xx networking driver. Some systems it is better > to default this to off as it causes significant increases in > soft-irq load. So there is already a module option allowing you to change this, usin

Re: Sabrent USB 3.0 to SSD // "UAS is blacklisted for this device, using usb-storage instead"

2018-10-15 Thread Julian Xhokaxhiu
Hi Oliver, I'm currently using the latest 4.18.12 mainline ( on Arch https://www.archlinux.org/packages/core/x86_64/linux/ ), and yes you're right I am NOT using UAS at the moment. The link I left is because I noticed those errors on dmesg, and I thought I had it enabled. This is why I am writing

Re: Can we just remove the sw_lpm_support from current xhci driver?

2018-10-15 Thread Mathias Nyman
On 15.10.2018 12:35, Zengtao (B) wrote: Hi: I am recently reading the LPM related code in xhci driver, and I find that the xhci->sw_lpm_support is not really used, but I am not sure whether we should remove it or not? Any ideas, Thanks. I think it was used to prevent LPM in pre-0.96 xHC con

Re: Sabrent USB 3.0 to SSD // "UAS is blacklisted for this device, using usb-storage instead"

2018-10-15 Thread Oliver Neukum
On So, 2018-10-14 at 13:40 +0200, Julian Xhokaxhiu wrote: > Dear USB Driver module maintainers, Hi, thank you for the report > Although sometimes, the system "hangs" very rarely, but in an annoying > fashion that makes a bit sluggish the experience, which translates to > weird dmesg errors like

Re: [RFC] usb: chipidea: Add minimal support for HSIC interface on i.MX6QDL

2018-10-15 Thread Frieder Schrempf
On 12.10.2018 03:19, Peter Chen wrote: Thanks, I should do it earlier, I could not find a suitable board with HSIC support at mainline kernel. It is very kind that you could help on it and test function at real board. My suggestion is follow all flows in Link [2] since we need to cover sus

Can we just remove the sw_lpm_support from current xhci driver?

2018-10-15 Thread Zengtao (B)
Hi: I am recently reading the LPM related code in xhci driver, and I find that the xhci->sw_lpm_support is not really used, but I am not sure whether we should remove it or not? Any ideas, Thanks. Regards Zengtao

Re: [PATCH v2] usb: host: ohci-at91: fix request of irq for optional gpio

2018-10-15 Thread Nicolas Ferre
On 15/10/2018 at 11:00, Tudor Ambarus - M18064 wrote: atmel,oc-gpio is optional. Request its irq only when atmel,oc is set in device tree. devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its return value for NULL before error, because it is more probable that atmel,oc is not set. T

Re: Query on usb/core/devio.c

2018-10-15 Thread Oliver Neukum
On Do, 2018-10-11 at 14:29 -0400, Alan Stern wrote: > On Thu, 11 Oct 2018, Mayuresh Kulkarni wrote: [..] > > We are looking into closing the device instance during normal operation > > i.e.: only open/close device when needed. > > > > However, we still have one particular use-case where our USB d

[PATCH v2] usb: host: ohci-at91: fix request of irq for optional gpio

2018-10-15 Thread Tudor.Ambarus
atmel,oc-gpio is optional. Request its irq only when atmel,oc is set in device tree. devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its return value for NULL before error, because it is more probable that atmel,oc is not set. This fixes the following errors on boards where atmel,oc

Re: [PATCH] usb: host: ohci-at91: fix request of irq for optional gpio

2018-10-15 Thread Nicolas Ferre
On 15/10/2018 at 10:34, Tudor Ambarus - M18064 wrote: atmel,oc-gpio is optional. Request it's irq only when atmel,oc is set in device tree. devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its return value for NULL before error, because it is more probably that atmel,oc is not set.

[PATCH] usb: host: ohci-at91: fix request of irq for optional gpio

2018-10-15 Thread Tudor.Ambarus
atmel,oc-gpio is optional. Request it's irq only when atmel,oc is set in device tree. devm_gpiod_get_index_optional returns NULL if -ENOENT. Check its return value for NULL before error, because it is more probably that atmel,oc is not set. This fixes the following errors on boards where atmel,oc