Re: [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver

2018-11-06 Thread Felipe Balbi
Thinh Nguyen writes: > ++ linux-usb > ++ Greg > > On 11/2/2018 6:47 PM, Thinh Nguyen wrote: >> Synopsys USB 3.x host HAPS platform has a class code of >> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these >> devices should use dwc3-haps driver. Set driver_override to dwc3-hap

Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver

2018-11-06 Thread Anatolij Gustschin
On Tue, 6 Nov 2018 13:07:13 +0800 kbuild test robot l...@intel.com wrote: ... >from drivers/spi/spi-ftdi-mpsse.c:11: >>> arch/x86/include/uapi/asm/ptrace-abi.h:20:13: error: expected identifier >>> before numeric constant >#define CS 13 >^ >>> drivers/spi

Re: [PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-06 Thread Felipe Balbi
hi, Thinh Nguyen writes: > Add two new device properties to program the reference clock period and > to enable low power management using the reference clock. This allows a > higher demand to go in low power for Audio Device Class devices. This > feature is currently only valid for DWC_usb31 per

[PATCH] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-06 Thread Andrzej Pietrasiewicz
Some protocols implemented in userspace with FunctionFS might require large buffers, e.g. 64kB or more. Currently the said memory is allocated with kmalloc, which might fail should system memory be highly fragmented. On the other hand, some UDC hardware allows scatter-gather operation and this pat

[PATCH] usb: gadget: f_fs: Allow scatter-gather buffers

2018-11-06 Thread Andrzej Pietrasiewicz
Some protocols implemented in userspace with FunctionFS might require large buffers, e.g. 64kB or more. Currently the said memory is allocated with kmalloc, which might fail should system memory be highly fragmented. On the other hand, some UDC hardware allows scatter-gather operation and this pat

WARNING: CPU: 0 PID: 0 at ../drivers/usb/dwc2/gadget.c:300 dwc2_hsotg_init_fifo+0x34/0x1b4

2018-11-06 Thread Maynard CABIENTE
Hi John, Sorry re-sending as it was detected as spam before (due to HTML subpart). I’m not certain if you are the correct person that maintains the drivers/usb/dwc2 for Linux kernel 4.14. I noticed that 4.20 is a different person. We are using an Altera Cyclone V SoC FPGA on our board with lin

Re: [PATCH] usb: dwc3: debugfs: Dump internal states

2018-11-06 Thread Thinh Nguyen
Hi Felipe, On 11/5/2018 11:35 PM, Felipe Balbi wrote: > Hi, > > Thinh Nguyen writes: +static int dwc3_internal_states_show(struct seq_file *s, void *unused) +{ + struct dwc3 *dwc = s->private; + unsigned intcurrent_mode; + unsigned long

Re: [PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-06 Thread Thinh Nguyen
Hi Felipe, On 11/6/2018 3:26 AM, Felipe Balbi wrote: > hi, > > Thinh Nguyen writes: >> Add two new device properties to program the reference clock period and >> to enable low power management using the reference clock. This allows a >> higher demand to go in low power for Audio Device Class devi

Re: USB Bluetooth dongle stop response with timeout error

2018-11-06 Thread Morikazu Fumita
On 31/10/2018 4:49 PM, Oliver Neukum wrote: On Mi, 2018-10-31 at 12:32 +0800, Morikazu Fumita wrote: My test procedure is below (assuming Bluetooth devices are already paired). 1. Adding a network bridge for PAN using "brctl". 2. Link the bridge up. 3. Run "hciconfig hci0 up" to power the USB B

Re: [PATCH 1/3] usb: dwc3: Add reference clock properties

2018-11-06 Thread Felipe Balbi
Hi, Thinh Nguyen writes: >> Thinh Nguyen writes: >>> Add two new device properties to program the reference clock period and >>> to enable low power management using the reference clock. This allows a >>> higher demand to go in low power for Audio Device Class devices. This >>> feature is curre

Re: WARNING: CPU: 0 PID: 0 at ../drivers/usb/dwc2/gadget.c:300 dwc2_hsotg_init_fifo+0x34/0x1b4

2018-11-06 Thread Minas Harutyunyan
Hi Maynard, On 11/7/2018 2:07 AM, Maynard CABIENTE wrote: > Hi John, > > Sorry re-sending as it was detected as spam before (due to HTML subpart). > > I’m not certain if you are the correct person that maintains the > drivers/usb/dwc2 for Linux kernel 4.14. I noticed that 4.20 is a different >

Re: [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset

2018-11-06 Thread Heikki Krogerus
On Mon, Nov 05, 2018 at 04:15:24PM -0800, Badhri Jagan Sridharan wrote: > Hi Heikki, Rob, > > Thanks for reviewing ! > Should I update the patchset with the Reviewed-by tag and bumpup the > patchset version ? > Or is that not necessary? No it's not necessary. Greg will eventually pick these to hi

Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-06 Thread Arnd Bergmann
On 11/5/18, Al Cooper wrote: > + > +config USB_BRCM > + tristate "Broadcom STB USB support" > + depends on ARCH_BRCMSTB > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > + select USB_EHCI_BRCM if USB_EHCI_HCD > + select USB_XHCI_BRCM if USB_XHCI_HCD > + select USB_XHCI_PL

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Felipe Balbi
Hi, Laurent Pinchart writes: >> Furthermore, we have found that USB_GADGET_DELAYED_STATUS is racey, >> which has already been observed in the UVC gadget driver previously >> [0]. The raceiness stems from the fact that things can happen in >> between returning USB_GADGET_DELAY

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Felipe Balbi
Hi, Alan Stern writes: > There's a similar race at the hardware level. What happens if the > controller receives a new SETUP packet and concurrently the driver is > setting up the controller registers for a response to an earlier > SETUP? I don't know how real controllers handle this. That's

Re: [RFC PATCH v1 01/14] usb:cdns3: add pci to platform driver wrapper.

2018-11-06 Thread Roger Quadros
Hi Pawel, On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds PCI specific glue drivier that creaties and registers in s/drivier/driver s/creaties/creates s/in system/in-system > system cdns-usb3 platform device. Thanks to that we will be able to use > the cdns-usb3 platform driver for USBSS-D

Re: [RFC PATCH v1 03/14] usb:cdns3: Driver initialization code.

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Patch also adds gadget.c, host.c, gadget-export.h, host-export.

Re: [RFC PATCH v1 04/14] usb:cdns3: Added DRD support

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds supports for detecting Host/Device mode. > Controller has additional OTG register that allow > implement even whole OTG functionality. > At this moment patch adds support only for detecting > the appropriate mode based on strap pins and ID pi

Re: [RFC PATCH v1 03/14] usb:cdns3: Driver initialization code.

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds core.c and core.h file that implements initialization > of platform driver and adds function responsible for selecting, > switching and running appropriate Device/Host mode. > > Patch also adds gadget.c, host.c, gadget-export.h, host-export.

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Alan Stern
On Tue, 6 Nov 2018, Felipe Balbi wrote: > DATA stage always depends on a usb_ep_queue() from gadget driver. So > it's always "delayed" in that sense. However, it's conceivable that some UDC drivers might behave differently depending on whether the usb_ep_queue call occurs within the setup callb

Re: [RFC PATCH v1 14/14] usb:cdns3: Feature for changing role

2018-11-06 Thread Roger Quadros
On 03/11/18 19:51, Pawel Laszczak wrote: > Patch adds feature that allow to change role from user space. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/Makefile | 2 +- > drivers/usb/cdns3/core.c| 2 + > drivers/usb/cdns3/debugfs.c | 94 + >

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Alan Stern
On Tue, 6 Nov 2018, Felipe Balbi wrote: > > Hi, > > Alan Stern writes: > > There's a similar race at the hardware level. What happens if the > > controller receives a new SETUP packet and concurrently the driver is > > setting up the controller registers for a response to an earlier > > SETUP?

Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-06 Thread Alan Cooper
On Tue, Nov 6, 2018 at 6:09 AM Arnd Bergmann wrote: > > On 11/5/18, Al Cooper wrote: > > > + > > +config USB_BRCM > > + tristate "Broadcom STB USB support" > > + depends on ARCH_BRCMSTB > > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > > + select USB_EHCI_BRCM if USB_EHCI_HCD >

Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's

2018-11-06 Thread Alan Stern
On Mon, 5 Nov 2018, Al Cooper wrote: > Add support for Broadcom STB SoC's to the ohci platform driver. > > Signed-off-by: Al Cooper > --- > @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct platform_device > *dev) > ohci->flags |= OHCI_QUIRK_FRAME_NO; > if (pdata->n

[PATCH] USB: Disable USB2 LPM at shutdown

2018-11-06 Thread Kai-Heng Feng
The QCA Rome USB Bluetooth controller has several issues once LPM gets enabled: - Fails to get enumerated in coldboot. [1] - Drains more power (~ 0.2W) when the system is in S5. [2] - Disappears after a warmboot. [2] The issue happens because the device lingers at LPM L1 in S5, so device can't get

Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-06 Thread Arnd Bergmann
On 11/6/18, Alan Cooper wrote: > On Tue, Nov 6, 2018 at 6:09 AM Arnd Bergmann wrote: >> >> On 11/5/18, Al Cooper wrote: >> >> > + >> > +config USB_BRCM >> > + tristate "Broadcom STB USB support" >> > + depends on ARCH_BRCMSTB >> > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD >> > +

Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

2018-11-06 Thread Alan Cooper
On Tue, Nov 6, 2018 at 1:22 PM Arnd Bergmann wrote: > > On 11/6/18, Alan Cooper wrote: > > On Tue, Nov 6, 2018 at 6:09 AM Arnd Bergmann wrote: > >> > >> On 11/5/18, Al Cooper wrote: > >> > >> > + > >> > +config USB_BRCM > >> > + tristate "Broadcom STB USB support" > >> > + depends on AR

Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's

2018-11-06 Thread Al Cooper
On 11/6/18 11:08 AM, Alan Stern wrote: On Mon, 5 Nov 2018, Al Cooper wrote: Add support for Broadcom STB SoC's to the ohci platform driver. Signed-off-by: Al Cooper --- @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct platform_device *dev) ohci->flags |= OHCI_QUIRK

Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's

2018-11-06 Thread Florian Fainelli
On 11/6/18 1:40 PM, Al Cooper wrote: > On 11/6/18 11:08 AM, Alan Stern wrote: >> On Mon, 5 Nov 2018, Al Cooper wrote: >> >>> Add support for Broadcom STB SoC's to the ohci platform driver. >>> >>> Signed-off-by: Al Cooper >>> --- >> >>> @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct >>>

WARNING in usb_submit_urb (4)

2018-11-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:163c8d54a997 compiler: remove __no_sanitize_address_or_inl.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11af34b940 kernel config: https://syzkaller.appspot.com/x/.config?x=8f559fee2fc3375a da

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Felipe Balbi
Hi, Alan Stern writes: >> Alan Stern writes: >> > There's a similar race at the hardware level. What happens if the >> > controller receives a new SETUP packet and concurrently the driver is >> > setting up the controller registers for a response to an earlier >> > SETUP? I don't know how rea

Re: [PATCH 4/6] usb: gadget: add functions to signal udc driver to delay status stage

2018-11-06 Thread Felipe Balbi
Hi, Alan Stern writes: >> DATA stage always depends on a usb_ep_queue() from gadget driver. So >> it's always "delayed" in that sense. > > However, it's conceivable that some UDC drivers might behave > differently depending on whether the usb_ep_queue call occurs within > the setup callback or