even submitted a
patch for the same and there were discussions over it.
http://www.spinics.net/lists/linux-usb/msg117962.html
However, things were never concluded. Using module parameters should get
it working but that isn't a clean solution.
What do you suggest?
Regards
Amit Virdi
)
requires 'int' but the argument type is 'unsigned int'
Signed-off-by: Asaf Vertzasaf.ve...@tandemg.com
---
drivers/usb/gadget/function/f_sourcesink.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Amit Virdi amit.vi...@st.com
--
To unsubscribe
Alright, I just applied your patches to testing/fixes. I'll start
testing today and should be able to send a pull request to Greg by the
end of the week, hopefully.
Thanks! Just a small clarification - git failed to send patches to
stable kernel list again (unfortunately I used the older
.
Amit Virdi (2):
usb: dwc3: gadget: Fix TRB preparation during SG
usb: dwc3: gadget: Stop TRB preparation after limit is reached
drivers/usb/dwc3/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--
1.8.0
--
To unsubscribe from this list: send the line unsubscribe
:
- Outer loop over the request_list
- Inner loop over the SG list
The code was missing break to get out of the outer loop.
Signed-off-by: Amit Virdi amit.vi...@st.com
Cc: sta...@vger.kernel.org # v3.9+
---
drivers/usb/dwc3/gadget.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb
, list_is_last always returns false no
matter what.
The correct way is not to access the modified pointers of dwc3_request but to
use list_empty macro instead.
Fixes: e5ba5ec833aa4a76980b512d6a6779643516b850 (usb: dwc3: gadget: fix scatter
gather implementation
Signed-off-by: Amit Virdi amit.vi
On 1/13/2015 12:10 PM, Amit VIRDI wrote:
This is a re-submission of patches [1/4] and [2/4] from:
http://www.spinics.net/lists/linux-usb/msg118841.html
Commit log of both these patches has been modified for aided clarity. These
patches have been rebased on Balbi's testing/next.
Patches
On 1/13/2015 12:04 AM, Felipe Balbi wrote:
Hi,
On Tue, Jan 06, 2015 at 11:44:23AM +0530, Amit Virdi wrote:
I can certainly provide the dwc3 specific kernel bootup logs, full
regdump and any loglevel you want me to, if that helps
Yeah, if you can provide those, then that'll help me verifying
, list_is_last always returns false no
matter what.
The correct way is not to access the modified pointers of dwc3_request but to
use list_empty macro instead.
Fixes: e5ba5ec833aa4a76980b512d6a6779643516b850 (usb: dwc3: gadget: fix scatter
gather implementation
Signed-off-by: Amit Virdi amit.vi
:
- Outer loop over the request_list
- Inner loop over the SG list
The code was missing break to get out of the outer loop.
Signed-off-by: Amit Virdi amit.vi...@st.com
Cc: sta...@vger.kernel.org # v3.9+
---
drivers/usb/dwc3/gadget.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb
.
Amit Virdi (2):
usb: dwc3: gadget: Fix TRB preparation during SG
usb: dwc3: gadget: Stop TRB preparation after limit is reached
drivers/usb/dwc3/gadget.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
--
1.8.0
--
To unsubscribe from this list: send the line unsubscribe
I can certainly provide the dwc3 specific kernel bootup logs, full
regdump and any loglevel you want me to, if that helps
Yeah, if you can provide those, then that'll help me verifying. Full
logs from boot to failure point with VERBOSE_DEBUG enabled (considering
you're not running on anything
The only reason why I have not been able to test these fixes on the
latest is because the customized webcam gadget is not ported on the
latest kernel. There have been a lot of changes in the video framework
lately and that is not my area of expertise. So porting the customized
webcam gadget
On Sat, Dec 27, 2014 at 11:14 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Dec 27, 2014 at 12:39:23PM +0530, Amit Virdi wrote:
On Mon, Dec 22, 2014 at 9:34 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Dec 19, 2014 at 12:40:15PM +0530, Amit Virdi wrote:
When scatter gather is used
On Sat, Dec 27, 2014 at 11:16 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Dec 27, 2014 at 01:24:03PM +0530, Amit Virdi wrote:
On Mon, Dec 22, 2014 at 9:36 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Dec 19, 2014 at 12:40:16PM +0530, Amit Virdi wrote:
When SG is used, there are two
On Mon, Dec 22, 2014 at 9:34 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Dec 19, 2014 at 12:40:15PM +0530, Amit Virdi wrote:
When scatter gather is used, multiple TRBs are prepared from one DWC3
request.
Hence, we must set the 'last' flag when the SG is last as well as the TRB is
last
On Mon, Dec 22, 2014 at 9:36 PM, Felipe Balbi ba...@ti.com wrote:
On Fri, Dec 19, 2014 at 12:40:16PM +0530, Amit Virdi wrote:
When SG is used, there are two loops iterating to prepare TRBs:
- Outer loop over the request_list
- Inner loop over the SG list
The driver must stop preparing TRBs
The first two patches are bug fixes in TRB preparation when scatter gather is
used. The next two patches are basically trivial and part of code cleanup.
The patches are rebased on Balbi's testing/next branch.
Amit Virdi (4):
usb: dwc3: gadget: Fix TRB preparation during SG
usb: dwc3: gadget
the modified pointers of dwc3_request but to use list_empty macro
instead.
Fixes: e5ba5ec833aa4a76980b512d6a6779643516b850 (usb: dwc3: gadget: fix scatter
gather implementation
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/dwc3/gadget.c | 3 +--
1 file changed, 1 insertion(+), 2
This field was introduced but never used. So, remove it.
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/dwc3/core.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4bb9aa696ede..0842aa80976f 100644
--- a/drivers/usb/dwc3
dwc3_gadget_init_hw_endpoints calls dwc3_alloc_trb_pool only if epnum is not
equal to 0 or 1. Hence, rechecking it in the called function is redundant.
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/dwc3/gadget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc3
When SG is used, there are two loops iterating to prepare TRBs:
- Outer loop over the request_list
- Inner loop over the SG list
The driver must stop preparing TRBs when the max TRBs have been prepared. The
code was missing break to get out of the outer loop.
Signed-off-by: Amit Virdi amit.vi
parameters for musb?
If I force MPP to 64 (as Paul suggested more or less) then it works.
But this means I know about the upcoming problem.
What's the upcoming problem here? Do you mean the code isn't generic
enough in case you have to use module_params?
Regards
Amit Virdi
--
To unsubscribe from
;
hs_sink_desc.bEndpointAddress = fs_sink_desc.bEndpointAddress;
Things might be working for you but this is not the correct fix, IMO.
Looking into the patch I feel it shall introduce other regressions.
Did you try inserting g_zero with module parameters for musb?
Regards
Amit Virdi
Parameter for INT says max packet size is 0…1023 for FS.
Yes, I'll send a patch to rectify this.
This is clearly a copy/paste bug.
Amit could you please look at this and fix it?
Sebastian
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
required.
Thanks
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Dan,
On 9/9/2014 2:32 PM, Dan Carpenter wrote:
Hello Amit Virdi,
The patch ef11982dd7a6: usb: gadget: zero: Add support for interrupt
EP from Aug 22, 2014, leads to the following static checker warning:
drivers/usb/gadget/function/f_sourcesink.c:1498
On 9/8/2014 7:18 PM, Felipe Balbi wrote:
Hi,
On Mon, Sep 08, 2014 at 04:05:33PM +0530, Amit Virdi wrote:
The kbuild test bot generated the warning:
drivers/usb/gadget/function/f_sourcesink.c:1498: warning: comparison is
always false due to limited range of data type
This patch
The kbuild test bot generated the warning:
drivers/usb/gadget/function/f_sourcesink.c:1498: warning: comparison is
always false due to limited range of data type
This patch fixes it.
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Amit Virdi amit.vi...@st.com
The kbuild test bot generated the warning:
drivers/usb/gadget/function/f_sourcesink.c:1498: warning: comparison is
always false due to limited range of data type
This patch fixes it.
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: Amit Virdi amit.vi...@st.com
Felipe,
I just checked your testing/next branch. 'git log' of that branch
doesn't show the complete commit log of this patch.
On 8/22/2014 2:36 PM, Amit VIRDI wrote:
Two simple test cases for interrupt endpoints are added to the usbtest.c file.
These are simple non-queued interrupt
- Interrupt, 2 Bulk, 2
Isoc) to 2 EPs (Interrupt only)
RFC - V1
- Added support for configuring interrupt EP attributes from configfs interface
Amit Virdi (2):
usb: gadget: zero: Add support for interrupt EP
usbtest: Add interrupt EP testcases
drivers/usb/gadget/function/f_loopback.c | 3
for configuring interrupt EP attributes from configfs interface
Amit Virdi (2):
usb: gadget: zero: Add support for interrupt EP
usbtest: Add interrupt EP testcases
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 511 --
drivers/usb
been tested only with gadget zero and care has been taken so as to
not break the existing functionality. However, if anyone can test with other
gadgets then that would be great!
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/misc/usbtest.c | 113
is tested for HS and SS on a platform having DWC3 controller.
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 511 --
drivers/usb/gadget/g_zero.h | 13 +-
drivers/usb/gadget/zero.c
On 7/18/2014 8:09 PM, Alan Stern wrote:
On Fri, 18 Jul 2014, Amit Virdi wrote:
On 7/17/2014 8:25 PM, Alan Stern wrote:
I can't say this is actually wrong, but have you ever encountered a
situation where this would be needed? How often does anyone need to do
a multi-packet transfer over
warning of BOGUS transfer flags.
Signed-off-by: Amit Virdi amit.vi...@st.com
Acked-by: Hans de Goede hdego...@redhat.com
---
drivers/usb/core/urb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index 991386ceb4ec..c9e8ee81b6b7 100644
--- a/drivers
as v3.16-rc5 is the latest). Pardon my ignorance otherwise...
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
}
allowed = urb-transfer_flags;
---
Otherwise, it sets zero packet flag for control out transfers too.
I'll send a V2 with this change if you agree to setting of the zero
packet flag for interrupt transfers.
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb
17 11:11:30 dlhl1014 kernel: [74473.348959] usb 7-1: test26 failed,
iterations left 999, status -75 (not 0)
---
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/core/urb.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index 991386c..a136246 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -460,6 +460,10 @@ int usb_submit_urb(struct urb
On 7/1/2014 12:01 AM, Felipe Balbi wrote:
Hi,
On Mon, Jun 09, 2014 at 10:44:38AM +0530, Amit Virdi wrote:
Felipe, Alan,
On 5/23/2014 12:01 PM, Amit VIRDI wrote:
This patchset adds support for interrupt EP and the corresponding test cases to
gadget zero. The code has been rebased and tested
Felipe, Alan,
On 5/23/2014 12:01 PM, Amit VIRDI wrote:
This patchset adds support for interrupt EP and the corresponding test cases to
gadget zero. The code has been rebased and tested on Kernel v3.15-rc5
V2 - V3
- Rectified wMaxPacketSize for FS from 1023 to 64
- Modified default value
On 5/23/2014 8:14 PM, Daniele Forsi wrote:
2014-05-23 8:32 GMT+02:00 Amit Virdi:
@@ -124,6 +130,9 @@ get_endpoints(struct usbtest_dev *dev, struct usb_interface
*intf)
switch (usb_endpoint_type(e-desc)) {
case USB_ENDPOINT_XFER_BULK
the alternate interface from having 6 EPs (2 - Interrupt, 2 Bulk, 2
Isoc) to 2 EPs (Interrupt only)
RFC - V1
- Added support for configuring interrupt EP attributes from configfs interface
Amit Virdi (2):
usb: gadget: zero: Add support for interrupt EP
usbtest: Add interrupt EP testcases
is tested for HS and SS on a platform having DWC3 controller.
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 511 --
drivers/usb/gadget/g_zero.h | 13 +-
drivers/usb/gadget/zero.c
and can be done
on-demand.
This code has been tested only with gadget zero and care has been taken so as to
not break the existing functionality. However, if anyone can test with other
gadgets then that would be great!
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/misc/usbtest.c | 113
On 5/10/2014 1:04 AM, Alan Stern wrote:
On Mon, 5 May 2014, Amit Virdi wrote:
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals till the whole data has not been transmitted
and can be done
on-demand.
This code has been tested only with gadget zero and care has been taken so as to
not break the existing functionality. However, if anyone can test with other
gadgets then that would be great!
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/misc/usbtest.c | 113
support for configuring interrupt EP attributes from configfs interface
Amit Virdi (2):
usb: gadget: zero: Add support for interrupt EP
usbtest: Add interrupt EP testcases
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 507
added. It has 2 interrupt endpoints. The default parameters are set as:
bInterval: 4
wMaxPacketSize: 1024
However, the same can be overridden through the module parameter interface.
The code is tested for HS and SS on a platform having DWC3 controller.
Signed-off-by: Amit Virdi
On 4/30/2014 9:36 PM, Felipe Balbi wrote:
On Fri, Mar 14, 2014 at 11:41:47AM -0400, Alan Stern wrote:
On Fri, 14 Mar 2014, Amit Virdi wrote:
Felipe, Alan,
On 2/25/2014 10:43 AM, Amit Virdi wrote:
ccing: Felipe Balbi, Alen Stern
On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Interrupt endpoints
Felipe, Alan,
On 2/25/2014 10:43 AM, Amit Virdi wrote:
ccing: Felipe Balbi, Alen Stern
On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals
Felipe/Alan,
On 2/25/2014 10:44 AM, Amit Virdi wrote:
ccing: Felipe Balbi, Alan Stern
On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Two simple test cases for interrupt endpoints are added to the
usbtest.c file.
These are simple non-queued interrupt IN and interrupt OUT transfers.
Currently,
only
This patchset adds support for interrupt EP and the corresponding test cases to
gadget zero. The code has been rebased and tested on Kernel v3.14-rc3
RFC - V1
- Added support for configuring interrupt EP attributes from configfs interface
Amit Virdi (2):
usb: gadget: zero: Add support
-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 519 --
drivers/usb/gadget/g_zero.h | 13 +-
drivers/usb/gadget/zero.c | 21 ++
4 files changed, 533 insertions(+), 23
and can be done
on-demand.
This code has been tested only with gadget zero and care has been taken so as to
not break the existing functionality. However, if anyone can test with other
gadgets then that would be great!
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/misc/usbtest.c | 112
ccing: Felipe Balbi, Alan Stern
On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Two simple test cases for interrupt endpoints are added to the usbtest.c file.
These are simple non-queued interrupt IN and interrupt OUT transfers. Currently,
only gadget zero is capable of executing the interrupt EP test
ccing: Felipe Balbi, Alen Stern
On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals till the whole data has not been transmitted
Dear Andrezej,
On 2/10/2014 7:15 PM, Andrzej Pietrasiewicz wrote:
W dniu 10.02.2014 14:16, Amit Virdi pisze:
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals till the whole data
-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/gadget/f_loopback.c | 3 +-
drivers/usb/gadget/f_sourcesink.c | 339 +++---
drivers/usb/gadget/g_zero.h | 13 +-
drivers/usb/gadget/zero.c | 21 +++
4 files changed, 353 insertions(+), 23
and can be done
on-demand.
This code has been tested only with gadget zero and care has been taken so as to
not break the existing functionality. However, if anyone can test with other
gadgets then that would be great!
Signed-off-by: Amit Virdi amit.vi...@st.com
---
drivers/usb/misc/usbtest.c | 112
.
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Regards
Amit Virdi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
64 matches
Mail list logo
