[PATCH v5 resend 0/2] ?hci-platform: Add support for controllers with more then one reset line

Here is a resend of my last version of the patch set to support usb controllers which have multiple resets. The shared reset controller support this depends on has landed in 4.7-rc1, so this patch-set should be ready for merging now. Changes in v2: -Switch to now shared reset_[de]assert

[PATCH v5 resend 1/2] ehci-platform: Add support for controllers with multiple reset lines

ed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Use the new reset_control_[de]assert_shared reset-controller functions --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/ho

[PATCH v5 resend 2/2] ohci-platform: Add support for controllers with multiple reset lines

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work. Signed-off-by: Hans de Goede <hdego...@redhat.

Re: [PATCH] USB: xhci: Add broken streams quirk for Frescologic device id 1009

Hi, On 01-06-16 21:03, Greg Kroah-Hartman wrote: On Wed, Jun 01, 2016 at 09:01:29PM +0200, Hans de Goede wrote: I got one of these cards for testing uas with, it seems that with streams it dma-s all over the place, corrupting memory. On my first tests it managed to dma over the BIOS

[PATCH] USB: xhci: Add broken streams quirk for Frescologic device id 1009

disabled. Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/host/xhci-pci.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index 48672fa..c10972f 100644 --- a/drivers/usb/host/xhci-pci.c

[PATCH resend] USB: uas: Fix slave queue_depth not being set

.t...@gmail.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/storage/uas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 16bc679..ecc7d4b 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/us

[PATCH resend 0/1] USB: uas: Fix slave queue_depth not being set

Hi Greg, There was some discussion about this patch during its initial posting, but the concensus seems to be that this patch, which is in essence a partial revert of the patch causing the problem, is the best way to fix this. So I'm resending this to make sure it does not fall through the

Re: [PATCH] reset: Put back *_optional variants

Hi, On 30-05-16 12:18, Philipp Zabel wrote: Hi, Am Freitag, den 27.05.2016, 09:06 +0200 schrieb Hans de Goede: [...] So IMHO the following change would be a better way to fix this: --- a/include/linux/reset.h +++ b/include/linux/reset.h @@ -65,14 +65,14 @@ static inline struct reset_control

Re: [PATCH] reset: Put back *_optional variants

Hi, On 26-05-16 23:44, John Youn wrote: On 5/26/2016 1:25 PM, Hans de Goede wrote: Hi, On 26-05-16 03:15, John Youn wrote: Prior to commit 6c96f05c8bb8 ("reset: Make [of_]reset_control_get[_foo] functions wrappers"), the optional variants returned -ENOTSUPP when CONFIG_RESET_

Re: [PATCH] reset: Put back *_optional variants

Hi, On 26-05-16 03:15, John Youn wrote: Prior to commit 6c96f05c8bb8 ("reset: Make [of_]reset_control_get[_foo] functions wrappers"), the optional variants returned -ENOTSUPP when CONFIG_RESET_CONTROLLER was not set. This patch reverts to this behavior. Otherwise those calls will return -EINVAL

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

Hi, On 24-05-16 14:44, James Bottomley wrote: On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote: Hi, On 23-05-16 19:36, James Bottomley wrote: On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level"

Re: [uas/scsi] untagged commands?

Hi, On 24-05-16 10:18, Tom Yan wrote: In this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb There is the following comment: 1 tag is reserved for untagged commands So my question is, what

Re: [PATCH v2 1/1] uas: remove can_queue set in host template

: Tom Yan <tom.t...@gmail.com> I agree removing this is good: Acked-by: Hans de Goede <hdego...@redhat.com> Regards, Hans diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 4d49fce..e03c490 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/st

[PATCH] USB: uas: Fix slave queue_depth not being set

.t...@gmail.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/storage/uas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 16bc679..ecc7d4b 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/us

Re: [regression] uas no longer queues commands since v4.5.2

Hi, On 22-05-16 12:39, Tom Yan wrote: With commit 198de51dbc3454d95b015ca0a055b673f85f01bb, uas no longer set `queue_depth` with scsi_change_queue_depth(), so now `queue_depth` of UAS drives are 1. Even though `can_queue` is set to `devinfo->qdepth - 2`, but apparently that does not help, since

[PATCH v2 2/2] usb: quirks: Add no-lpm quirk for Acer C120 LED Projector

The Acer C120 LED Projector is a USB-3 connected pico projector which takes both its power and video data from USB-3. In combination with some hubs this device does not play well with lpm, so disable lpm for it. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Properl

[PATCH v2 1/2] usb: quirks: Fix sorting

Properly sort all the entries by vendor id. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -This is a new patch in v2 of this patch-set --- drivers/usb/core/quirks.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/us

[PATCH] usb: quirks: Add no-lpm quirk for Acer C120 LED Projector

The Acer C120 LED Projector is a USB-3 connected pico projector which takes both its power and video data from USB-3. In combination with some hubs this device does not play well with lpm, so disable lpm for it. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/core/qu

[PATCH v2 2/2] musb: sunxi: Set state to A_WAIT_VRISE when enabling Vbus

the otg state to A_WAIT_VRISE upon enabling Vbus making musb_stage0_irq() ignore the first VBUSERR_RETRY_COUNT VBUSERROR interrupts, fixing connection issues in these cases. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Use curly-braces in both branches of i

[PATCH v2 1/2] musb: sunxi: Add set_mode platform function

Move the mode handling to the platform_set_mode callback. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -No changes --- drivers/usb/musb/sunxi.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/usb/musb/sun

Re: [linux-sunxi] Re: [PATCH 2/2] musb: sunxi: Set state to A_WAIT_VRISE when enabling VBus

Hi, On 13-05-16 20:35, Bin Liu wrote: Hi, On Thu, May 12, 2016 at 08:31:09PM +0200, Hans de Goede wrote: When the board is powering attached usb devices via the otg port sometimes / on some devices it takes slightly too long for the VBus detection code in phy-sun4i-usb.c to signal that VBus

[PATCH 2/2] musb: sunxi: Set state to A_WAIT_VRISE when enabling VBus

the otg state to A_WAIT_VRISE upon enabling Vbus making musb_stage0_irq() ignore the first VBUSERR_RETRY_COUNT VBUSERROR interrupts, fixing connection issues in these cases. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/musb/sunxi.c | 8 +--- 1 file changed, 5 inse

[PATCH 1/2] musb: sunxi: Add set_mode platform function

Move the mode handling to the platform_set_mode callback. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/musb/sunxi.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

Hi, On 05-05-16 18:00, Stephen Warren wrote: On 05/05/2016 02:05 AM, Hans de Goede wrote: Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding <tred...@nvidia.

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a

Re: uas: order 7 page allocation failure in init_tag_map()

Hi, On 23-04-16 23:10, Johannes Stezenbach wrote: Hi, I bought a new backup disk which turned out to be UAS capable, but when I plugged it in I got an order 7 page allocation failure. My hunch is that the .can_queue = 65536 in drivers/usb/storage/uas.c is much too large. Maybe 256 would be a

[PATCH v2 2/2] USB: uas: Add a new NO_REPORT_LUNS quirk

Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2:331a, as these will fail to respond to a REPORT_LUNS command. Cc: sta...@vger.kernel.org Reported-and-tested-by: David Webb <d...@noc.ac.uk> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- C

[PATCH v2 1/2] USB: uas: Limit qdepth at the scsi-host level

1315013 Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Fix some spelling issues in the commit message and in a comment --- drivers/usb/storage/uas.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v5 1/2] ehci-platform: Add support for controllers with multiple reset lines

, these 2 patches depend on this stable-tag: git://git.pengutronix.de/git/pza/linux.git tags/reset-for-4.7 Being merged into the tree where they get applied first. Regards, Hans url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/hci-platform-Add-support-for-controllers-with-more

[PATCH v5 2/2] ohci-platform: Add support for controllers with multiple reset lines

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work. Signed-off-by: Hans de Goede <hdego...@redhat.

[PATCH v5 0/2] ?hci-platform: Add support for controllers with more then one reset line

Hi Greg, et al, Here is a resend of my last version of the patch set to support usb controllers which have multiple resets. Unfortunately the shared reset controller support this depends on did not make it into 4.6. Philipp Zabel, the reset maintainer (in the Cc) has put these patches in a

[PATCH v5 1/2] ehci-platform: Add support for controllers with multiple reset lines

ed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Use the new reset_control_[de]assert_shared reset-controller functions --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/ho

[PATCH v2] uas: Add a new NO_REPORT_LUNS quirk

Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2:331a, as these will fail to respond to a REPORT_LUNS command. Cc: sta...@vger.kernel.org Reported-and-tested-by: David Webb <d...@noc.ac.uk> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- C

Re: [PATCH] uas: Add a new NO_REPORT_LUNS quirk

Hi, On 31-03-16 17:11, James Bottomley wrote: On Thu, 2016-03-31 at 17:03 +0200, Hans de Goede wrote: Hi, On 31-03-16 16:48, James Bottomley wrote: On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote: Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2

Re: [PATCH] uas: Add a new NO_REPORT_LUNS quirk

Hi, On 31-03-16 16:48, James Bottomley wrote: On Thu, 2016-03-31 at 14:22 +0200, Hans de Goede wrote: Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2:331a, as these will fail to respond to a REPORT_LUNS command. Actually, if we're sending them a report

[PATCH] uas: Add a new NO_REPORT_LUNS quirk

Add a new NO_REPORT_LUNS quirk and set it for Seagate drives with an usb-id of: 0bc2:331a, as these will fail to respond to a REPORT_LUNS command. Cc: sta...@vger.kernel.org Reported-and-tested-by: David Webb <d...@noc.ac.uk> Signed-off-by: Hans de Goede <hdego...@redhat.com> ---

Re: [linux-sunxi] Re: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

Hi, On 22-03-16 21:12, Andreas Färber wrote: Hi Hans, Am 21.03.2016 um 23:13 schrieb Hans de Goede: Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module. "built" Thanks. Should this get a Fixes: header for b

[PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading

Add a missing MODULE_DEVICE_TABLE() line which was causing the sunxi-musb glue to not auto-load when build as a module. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/musb/sunxi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/sunxi.c b/drivers/us

Re: [PATCH] uas: Limit qdepth at the scsi-host level

Hi, On 19-03-16 18:06, James Bottomley wrote: On Sat, 2016-03-19 at 09:59 +0100, Hans de Goede wrote: Commit 64d513ac31bd ("scsi: use host wide tags by default") causes the scsi-core to queue more cmnds then we can handle on devices with multiple LUNs, limit the qdepth at the scsi-

[PATCH] uas: Limit qdepth at the scsi-host level

13 Cc: sta...@vger.kernel.org # 4.4.x and 4.5.x Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/storage/uas.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index c90a7e4..b5cb7ab 100644 --- a/dri

Re: [linux-sunxi] Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 05-03-16 21:02, Greg Kroah-Hartman wrote: On Fri, Mar 04, 2016 at 08:27:26AM +0100, Hans de Goede wrote: Hi, On 04-03-16 05:35, Greg Kroah-Hartman wrote: On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least th

[PATCH] uas: Reduce can_queue to MAX_CMNDS

with a "Page allocation failure (order 7)" error on systems which have been running for a while and thus have fragmented memory. Cc: sta...@vger.kernel.org Reported-and-tested-by: Yves-Alexis Perez <cor...@corsac.net> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers

Re: [linux-sunxi] Re: [PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 04-03-16 05:35, Greg Kroah-Hartman wrote: On Sat, Feb 27, 2016 at 05:58:58PM +0100, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the

Re: Page allocation failure (order 7) in UAS code

Hi, On 04-03-16 08:13, Yves-Alexis Perez wrote: On mar., 2016-03-01 at 11:49 +0100, Hans de Goede wrote: Hi, On 01-03-16 10:42, Yves-Alexis Perez wrote: Hi, [sorry if this is not the right point for reporting bugs, I took the email addresses from MAINTAINERS but please point me

Re: Page allocation failure (order 7) in UAS code

Hi, On 01-03-16 10:42, Yves-Alexis Perez wrote: Hi, [sorry if this is not the right point for reporting bugs, I took the email addresses from MAINTAINERS but please point me to the correct place if needed] I have an external USB drive (Samsung M3), which apparently uses the UAS code. Starting

Re: [PATCH 14/14] uas: fix race with TMF performing an abort and regular finish

Hi, On 17-02-16 16:50, Oliver Neukum wrote: A successful TMF means that the URBs for a command must be killed. Also fixes sleeping with a spinlock. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 35 --- 1 file changed, 16

[PATCH v4 2/2] ohci-platform: Add support for controllers with multiple reset lines

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work. Signed-off-by: Hans de Goede <hdego...@redhat.com>

[PATCH v4 0/2] ?hci-platform: Add support for controllers with more then one reset line

Hi All, Here is a new version of my patch-set to support usb controllers which have multiple resets. These patches apply on top of the related reset-controller patches which have just been merged here: git://git.pengutronix.de/git/pza/linux.git reset/next Changes in v2: -Switch to now shared

[PATCH v4 1/2] ehci-platform: Add support for controllers with multiple reset lines

ed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Acked-by: Alan Stern <st...@rowland.harvard.edu> --- Changes in v2: -Use the new reset_control_[de]assert_shared reset-controller functions Changes in v3: -Adjust for chang

Re: [linux-sunxi] [PATCH v3 1/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 24-02-16 15:30, Andre Przywara wrote: Hi Hans, On 24/02/16 14:07, Hans de Goede wrote: Hi, On 24-02-16 14:59, Andre Przywara wrote: Hi, (dropping some lists and people) On 24/02/16 11:15, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least the EHC

Re: [linux-sunxi] [PATCH v3 1/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 24-02-16 14:59, Andre Przywara wrote: Hi, (dropping some lists and people) On 24/02/16 11:15, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize

Re: [PATCH v3 1/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 24-02-16 12:37, Roger Quadros wrote: Hi, On 24/02/16 13:15, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is

[PATCH v3 2/2] ohci-platform: Add support for controllers with multiple reset lines

At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset for its companion is still asserted, which means we need to de-assert 2 resets for the controller to work. Signed-off-by: Hans de Goede <hdego...@redhat.

[PATCH v3 1/2] ehci-platform: Add support for controllers with multiple reset lines

ed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Use the new reset_control_[de]assert_shared reset-controller functions Changes in v3: -Adjust for changes to shared-reset reset-controller functions --- Docume

[PATCH v3 0/2] ?hci-platform: Add support for controllers with more then one reset line

Hi All, Here is a new version of my patch-set to support usb controllers which have multiple resets. These patches apply on top of the related reset-controller patches which have just been merged here: git://git.pengutronix.de/git/pza/linux.git reset/next Changes in v2: -Switch to now shared

Re: [PATCH 07/13] uas: handle errors in transmitting a TMF

Hi, On 08-02-16 10:54, Oliver Neukum wrote: On Thu, 2016-02-04 at 15:41 +0100, Hans de Goede wrote: Hi, @@ -754,9 +798,18 @@ static int uas_eh_abort_handler(struct scsi_cmnd *cmnd) if (err < 0) /* unkillable */ goto give_up; - wait_for_completion_time

Re: [PATCH 07/13] uas: handle errors in transmitting a TMF

Hi, I've some comments inline, not I've mainly focussed on the TMF bits, and not looked so much at the changes in reset handling. On 04-02-16 10:54, Oliver Neukum wrote: We need to give up on this TMF to have a free tag again. Signed-off-by: Oliver Neukum ---

Re: [PATCH 05/14] uas: actually use TASK_ABORT iu

Hi, On 19-01-16 11:39, Oliver Neukum wrote: Issue a TASK_ABORT iu to the device and wait for it to complete. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/storage/uas.c

Re: [PATCH 02/14] uas: reserve a tag for management

Hi, Thanks for working on this. I've not done much work (if any) on uas lately) Are you interested in becoming a co-maintainer for the uas driver, or even taking it over completely ? On 19-01-16 11:39, Oliver Neukum wrote: UAS uses a shared tag space. We reserve tag #1 for management. That

Re: [PATCH 04/14] uas: lock the abort handler

Hi, On 19-01-16 11:39, Oliver Neukum wrote: We have exactly one TMF. It must be locked against reuse. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c

Re: Introducing the use of TMF in the UAS driver

Hi, On 19-01-16 11:39, Oliver Neukum wrote: This set introduces the TMF functions of SAM in the UAS driver to handle abort() and device_reset(). That allows to do an abort() without resetting the whole adapter and just one of the devices in case multiple devices are connected to the host. One

Re: [linux-sunxi] Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

Maxime Ripard: Hi, On Fri, Dec 11, 2015 at 04:41:58PM +0100, Hans de Goede wrote: diff --git a/include/linux/reset.h b/include/linux/reset.h index c4c097d..1cca8ce 100644 --- a/include/linux/reset.h +++ b/include/linux/reset.h @@ -11,6 +11,8 @@ int reset_control_reset(struct reset_control *rstc

[PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

ed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Use the new reset_control_[de]assert_shared reset-controller functions --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 2 +- drivers/usb/ho

[PATCH v4 2/2] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Chan

[PATCH v4 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

Use of_match_node instead of calling of_device_is_compatible a ton of times to get model specific config data. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v3: -New patch in v3 of this patch-set Changes in v4: -Use of_device_get_match_data() -Add phyctl_

[PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

deassert_shared / assert_shared have been called and keep the line deasserted as long as deassert has been called more times than assert. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -This is a new patch in v2 of this patch-set --- drivers/reset/core.c

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

schrieb Hans de Goede: Add reset_control_deassert_shared / reset_control_assert_shared functions which are intended for use by drivers for hw blocks which (may) share a reset line with another driver / hw block. Unlike the regular reset_control_[de]assert functions these functions keep track of how

Re: [PATCH v2 2/3] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 11-12-15 18:13, Philipp Zabel wrote: Am Freitag, den 11.12.2015, 16:41 +0100 schrieb Hans de Goede: From: Reinder de Haan <patches...@mveas.com> At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple reset lines, the controller will not initialize while the reset f

Re: [linux-sunxi] Re: [PATCH v3 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

Hi, On 27-11-15 09:53, Maxime Ripard wrote: On Thu, Nov 26, 2015 at 01:11:32PM +0100, Hans de Goede wrote: +enum sun4i_usb_phy_type { + sun4i_a10_phy, + sun8i_a33_phy, +}; + +struct sun4i_usb_phy_cfg { + int num_phys; + u32 disc_thresh; + enum sun4i_usb_phy_type

Re: [linux-sunxi] Re: [PATCH v3 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

Hi, On 27-11-15 11:37, Hans de Goede wrote: Hi, On 27-11-15 09:53, Maxime Ripard wrote: On Thu, Nov 26, 2015 at 01:11:32PM +0100, Hans de Goede wrote: +enum sun4i_usb_phy_type { + sun4i_a10_phy, + sun8i_a33_phy, +}; + +struct sun4i_usb_phy_cfg { + int num_phys; + u32

Re: [linux-sunxi] Re: [PATCH v3 2/2] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

Hi, On 25-11-15 23:11, Rob Herring wrote: On Wed, Nov 25, 2015 at 05:50:02PM +0100, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. Shouldn't the O

Re: [linux-sunxi] Re: [PATCH v3 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

Hi, On 26-11-15 05:22, Chen-Yu Tsai wrote: On Thu, Nov 26, 2015 at 12:50 AM, Hans de Goede <hdego...@redhat.com> wrote: Use of_match_node instead of calling of_device_is_compatible a ton of times to get model specific config data. Signed-off-by: Hans de Goede <hdego...@redhat.com>

[PATCH v3 1/2] phy-sun4i-usb: Use of_match_node to get model specific config data

Use of_match_node instead of calling of_device_is_compatible a ton of times to get model specific config data. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v3: -New patch in v3 of this patch-set --- drivers/phy/phy-sun4i-usb.c

[PATCH v3 2/2] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Chan

Re: [linux-sunxi] Re: [PATCH] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers

Hi, On 23-11-15 23:20, Troy Dack wrote: On Wednesday, 18 November 2015 03:12:11 UTC+11, Jens Kuske wrote: Enable the 2 USB host controllers used on the Orange Pi Plus and add the necessary regulators. Signed-off-by: Reinder de Haan <patch...@mveas.com > Signed-off-by: Hans de Goede

Re: [linux-sunxi] [PATCH 2/5] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

Hi, On 11/20/2015 08:49 PM, Priit Laes wrote: On Sun, 2015-11-15 at 20:46 +0100, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. This patch

[PATCH v2] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Chan

Re: [PATCH] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers

Hi, On 17-11-15 17:12, Jens Kuske wrote: Enable the 2 USB host controllers used on the Orange Pi Plus and add the necessary regulators. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> Signed-off-by: Jens Kuske <jens

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 18-11-15 10:46, Philipp Zabel wrote: Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: On 16-11-15 18:01, Philipp Zabel wrote: If there are two devices sharing the same reset line that is initially held asserted, do the two drivers somehow have to synchronize

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: On 16-11-15 18:01, Philipp Zabel wrote: If there are two devices sharing the same reset line that is initially held asserted, do the two drivers somehow have to synchronize before releasing the reset together? Not to my knowledge, I s

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 18-11-15 11:38, Hans de Goede wrote: Hi, On 18-11-15 10:46, Philipp Zabel wrote: Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: On 16-11-15 18:01, Philipp Zabel wrote: If there are two devices sharing the same reset line that is initially held asserted, do

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 18-11-15 12:59, Philipp Zabel wrote: Hi Hans, Am Mittwoch, den 18.11.2015, 11:38 +0100 schrieb Hans de Goede: Hi, On 18-11-15 10:46, Philipp Zabel wrote: Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: On 16-11-15 18:01, Philipp Zabel wrote: If there are two

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 18-11-15 13:32, Julian Calaby wrote: Hi, On Wed, Nov 18, 2015 at 9:38 PM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 18-11-15 10:46, Philipp Zabel wrote: Hi Hans, Am Montag, den 16.11.2015, 18:13 +0100 schrieb Hans de Goede: On 16-11-15 18:01, Philipp Zabel

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 16-11-15 17:04, Chen-Yu Tsai wrote: On Mon, Nov 16, 2015 at 11:42 PM, Alan Stern <st...@rowland.harvard.edu> wrote: On Sun, 15 Nov 2015, Hans de Goede wrote: From: Reinder de Haan <patches...@mveas.com> At least the EHCI found on the Allwinnner H3 SoC needs multiple

Re: [Workaround] ASM1153E : ASM 174c:55aa problems re-loaded [quirk needed]

Hi, On 13-11-15 20:12, Manfred_Knick wrote: First of all: A big "Thank You!" especially to Sarah Sharp and Hans de Goede. Finding their contributions finally led my way. Second: Please, keep me CC'ed on this subject - I am not subscribed to the

Re: [linux-sunxi] Re: [PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

Hi, On 16-11-15 18:01, Philipp Zabel wrote: Am Montag, den 16.11.2015, 17:49 +0100 schrieb Hans de Goede: Hi, On 16-11-15 17:04, Chen-Yu Tsai wrote: On Mon, Nov 16, 2015 at 11:42 PM, Alan Stern <st...@rowland.harvard.edu> wrote: On Sun, 15 Nov 2015, Hans de Goede wrote: From: Rein

Re: [linux-sunxi] [PATCH 5/5] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers

Hi, On 16-11-15 04:00, Chen-Yu Tsai wrote: Hi, On Mon, Nov 16, 2015 at 3:46 AM, Hans de Goede <hdego...@redhat.com> wrote: From: Reinder de Haan <patches...@mveas.com> Enable the 3 pairs of USB host controllers used on the Orange Pi Plus. Signed-off-by: Reinder de Haan <patch

[PATCH 2/2] ehci-platform: Add support for controllers with multiple reset lines

roller to work. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/host/ehci-platform.c | 47 +--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/drivers/usb/host

[PATCH 0/2] ehci-platform: Add support for controllers with multiple reset lines

Hi All, Note the second patch in this set obviously depends on the first patch. Perhaps it is best to merge both through Greg's tree with Philipp's ack ? Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

[PATCH 1/2] reset: Add of_reset_control_get_by_index

lines (as that would make it non generic). Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/reset/core.c | 23 +++ include/linux/reset.h | 8 2 files changed, 27 insertions(+), 4 deleti

[PATCH 2/5] phy-sun4i-usb: Add support for the host usb-phys found on the H3 SoC

From: Reinder de Haan <patches...@mveas.com> Note this commit only adds support for phys 1-3, phy 0, the otg phy, is not yet (fully) supported after this commit. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- .../d

[PATCH 4/5] ARM: dts: sun8i: Add usbphy and usb host controller nodes

From: Reinder de Haan <patches...@mveas.com> Add nodes describing the H3's usbphy and usb host controller nodes. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- arch/arm/boot/dts/s

[PATCH 5/5] ARM: dts: sun8i-h3-orangepi-plus: Enable USB host controllers

From: Reinder de Haan <patches...@mveas.com> Enable the 3 pairs of USB host controllers used on the Orange Pi Plus. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- arch/arm/boot/dts/sun8i-h3-oran

[PATCH 3/5] ARM: dts: sun8i: Add support for H3 usb clocks

From: Reinder de Haan <patches...@mveas.com> Add a node describing the usb-clks found on the H3. Signed-off-by: Reinder de Haan <patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- arch/arm/boot/dts/sun8i-h3.dtsi | 12 1 file changed, 12 i

[PATCH 1/5] clk: sunxi: Add support for the H3 usb phy clocks

t;patches...@mveas.com> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Documentation/devicetree/bindings/clock/sunxi.txt | 1 + drivers/clk/sunxi/clk-usb.c | 12 2 files changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/

Re: question on uas_stat_cmplt()

Hi, On 11/10/2015 05:25 PM, Oliver Neukum wrote: Hi, we have a report about a device returning IU_ID_RESPONSE to uas_stat_cmplt(). It seems to me that this is in principle a valid response to a command. Ugh, it has been a while since I last worked on this. IIRC IU_ID_RESPONSE is only used

Re: [PATCH] uas: use the BIT() macro

Hi, On 05-11-15 16:20, Oliver Neukum wrote: Use this macro to make the driver more readable. Signed-off-by: Oliver Neukum <oneu...@suse.com> Looks good to me: Reviewed-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- drivers/usb/storag

Re: [PATCH] uas: no gfp argument to uas_submit_urbs()

Hi, On 03-11-15 16:43, Oliver Neukum wrote: This function must be called with a spinlock held. Memory can be allocated only with GFP_ATOMIC. Passing a gfp_t argument is a waste. Signed-off-by: Oliver Neukum <oneu...@suse.com> Patch looks good to me: Reviewed-by: Hans de Goede

Re: [PATCH] uas: blacklist ASUSTek External Drive

ported-by: Oliver Neukum <oneu...@suse.com> */ +UNUSUAL_DEV(0x174c, 0x55aa, 0x, 0x, + "ASUSTek", + "External Drive", + USB_SC_DEVICE, USB_PR_DEVICE, NULL, + US_FL_IGNORE_UAS), + /* Reported-by: Ha

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 23-09-15 22:59, Bin Liu wrote: Hi, On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon

<    1   2   3   4   5   6   7   8   9   10   >