Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

2015-09-23 Thread Hans de Goede
Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: Some USB phy drivers have different

Re: [PATCH v4 resend 0/2] power: Add an axp20x-usb-power driver

2015-09-22 Thread Hans de Goede
Hi, On 22-09-15 15:12, Sebastian Reichel wrote: Hi, On Sun, Sep 20, 2015 at 08:39:31AM -0400, Hans de Goede wrote: This is a resend of v4 of the axp20x-usb-power power-supply driver, after v4 there have been no further comments, so I assume that this version is ready for merging, yet for some

Re: [PATCH v2 1/3] usb: of: add an api to get dr_mode by the phy node

2015-09-21 Thread Hans de Goede
Hi, On 21-09-15 09:20, Peter Chen wrote: On Tue, Sep 15, 2015 at 01:58:16PM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. But the phy driver does not have visibility to the dr_mode of the controller. This adds an api to return the

[PATCH v4 resend 0/2] power: Add an axp20x-usb-power driver

2015-09-20 Thread Hans de Goede
Hi, This is a resend of v4 of the axp20x-usb-power power-supply driver, after v4 there have been no further comments, so I assume that this version is ready for merging, yet for some reason it has not been merged yet. Can we please get this driver merged (preferably into 4.3, but if not at least

[PATCH v4 resend 1/2] ARM: dts: Add binding documentation for AXP20x pmic usb power supply

2015-09-20 Thread Hans de Goede
Add binding documentation for the usb power supply part of the AXP20x pmic. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Split out into a separate patch from the actual driver commit Changes in v4: -s/usb_power_supply/usb-power-supply/ in the dts exampl

[PATCH v4 resend 2/2] power: Add an axp20x-usb-power driver

2015-09-20 Thread Hans de Goede
and platform-driver. Cc: Bruno Prémont <bonb...@linux-vserver.org> Acked-by: Lee Jones <lee.jo...@linaro.org> Signed-off-by: Bruno Prémont <bonb...@linux-vserver.org> Signed-off-by: Hans de Goede <hdego...@redhat.com> --- Changes in v2: -Split out the dt-bindings documentation into a

[PATCH 0/1] musb: sunxi: Make sunxi musb glue work without MUSB_PIO_ONLY

2015-09-20 Thread Hans de Goede
Hi, Here is a patch to fix the sunxi musb glue not working when MUSB_PIO_ONLY is not set in the kernel config. Since the sunxi musb glue was just merged for 4.3, it would be nice if this bugfix could be added to 4.3 too, without this distro's will be unable to enable dma with musb and have

[PATCH] musb: sunxi: Make sunxi musb glue work without MUSB_PIO_ONLY

2015-09-20 Thread Hans de Goede
. The Allwinnner Android kernels have some dma code, but it is disabled as Allwinner never managed to get it to work. Signed-off-by: Hans de Goede <hdego...@redhat.com> --- drivers/usb/musb/sunxi.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/musb/sunxi.c b/drive

Re: [PATCH v3] usb: of: add an api to get dr_mode by the phy node

2015-09-19 Thread Hans de Goede
Hi, On 09/18/2015 10:41 PM, Felipe Balbi wrote: Hi, On Fri, Sep 18, 2015 at 03:27:58PM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. But the phy driver does not have visibility to the dr_mode of the controller. This adds an api to

Re: [PATCH v3] usb: of: add an api to get dr_mode by the phy node

2015-09-19 Thread Hans de Goede
. Signed-off-by: Bin Liu <b-...@ti.com> Looks good to me, and this will be useful for the sunxi usb-phy code too: Acked-by: Hans de Goede <hdego...@redhat.com> Regards, Hans --- v3: search controller node from dt root, as the phy and controller nodes might not have the

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 16:44, Bin Liu wrote: Hi, On Thu, Sep 10, 2015 at 1:38 PM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 10-09-15 20:30, Maxime Ripard wrote: On Thu, Sep 10, 2015 at 08:23:23PM +0200, Hans de Goede wrote: Hi, On 04-09-15 08:43, Olliver Schinagl wrote: He

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 18:58, Bin Liu wrote: Hi, On Mon, Sep 14, 2015 at 9:59 AM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 14-09-15 16:44, Bin Liu wrote: Hi, On Thu, Sep 10, 2015 at 1:38 PM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 10-09-15 20:30, Maxime

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 19:14, Bin Liu wrote: Hi, On Mon, Sep 14, 2015 at 12:08 PM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 14-09-15 18:58, Bin Liu wrote: Hi, On Mon, Sep 14, 2015 at 9:59 AM, Hans de Goede <hdego...@redhat.com> wrote: Hi, On 14-09-15 16:44, Bin Liu

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-14 Thread Hans de Goede
Hi, On 09/14/2015 10:25 PM, Maxime Ripard wrote: On Thu, Sep 10, 2015 at 08:38:38PM +0200, Hans de Goede wrote: Hi, On 10-09-15 20:30, Maxime Ripard wrote: On Thu, Sep 10, 2015 at 08:23:23PM +0200, Hans de Goede wrote: Hi, On 04-09-15 08:43, Olliver Schinagl wrote: Hey Hans, On 07-08-15

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-14 Thread Hans de Goede
Hi, On 14-09-15 19:53, Bin Liu wrote: This is my first time looking at dts handling in drivers, so I might be completely wrong, but I am thinking that since the controller node links to the phy node, so the controller node is the parent of the phy node, so if there is an of api can look it

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-10 Thread Hans de Goede
Hi, On 04-09-15 08:43, Olliver Schinagl wrote: Hey Hans, On 07-08-15 10:45, Olliver Schinagl wrote: If you change the dr_mode to host then you _must_ also remove any id_det and vbus_det gpio settings from the usb_phy node in the dts, as the sun4i phy code detects host vs otg mode by

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-09-10 Thread Hans de Goede
Hi, On 10-09-15 20:30, Maxime Ripard wrote: On Thu, Sep 10, 2015 at 08:23:23PM +0200, Hans de Goede wrote: Hi, On 04-09-15 08:43, Olliver Schinagl wrote: Hey Hans, On 07-08-15 10:45, Olliver Schinagl wrote: If you change the dr_mode to host then you _must_ also remove any id_det

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-09 Thread Hans de Goede
Hi, On 08-09-15 16:36, Alan Stern wrote: On Tue, 8 Sep 2015, Hans de Goede wrote: Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion

Re: [PATCH v1] media: uvcvideo: handle urb completion in a work queue

2015-09-08 Thread Hans de Goede
Hi, On 09/07/2015 06:23 PM, Mian Yousaf Kaukab wrote: urb completion callback is executed in host controllers interrupt context. To keep preempt disable time short, add urbs to a list on completion and schedule work to process the list. Moreover, save timestamp and sof number in the urb

Re: [PATCH] UAS: also check for ESHUTDOWN in error reporting

2015-08-20 Thread Hans de Goede
Hi, On 08/20/2015 11:16 AM, Oliver Neukum wrote: -ESHUTDOWN means that the HC has been unplugged. Reporting an error in that case makes no sense. Signed-off-by: Oliver Neukum oneu...@suse.com Looks good to me: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb

Re: [linux-sunxi] [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-06 Thread Hans de Goede
Hi, On 06-08-15 10:22, Olliver Schinagl wrote: Hey Hans, I've tried getting your musb stuff working on a cubietruck, but i don't seem to see this patch on your linux-sunxi/sunxi-wip branch on github? Is your github branch fully functional at the moment? What I have done so far, is build the

Re: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-05 Thread Hans de Goede
Hi, On 05-08-15 00:57, Felipe Balbi wrote: Hi, On Wed, Aug 05, 2015 at 12:05:02AM +0200, Hans de Goede wrote: Hi, On 08/04/2015 11:35 PM, Felipe Balbi wrote: On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote: For some unclear reason sometimes we get VBus errors in host-only

[PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Hans de Goede
For some unclear reason sometimes we get VBus errors in host-only mode, even though we do not have any vbus-detection then. Ignore these. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb/sunxi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/musb/sunxi.c

Re: [PATCH] musb: sunxi: Ignore VBus errors in host-only mode

2015-08-04 Thread Hans de Goede
Hi, On 08/04/2015 11:35 PM, Felipe Balbi wrote: On Tue, Aug 04, 2015 at 11:25:53PM +0200, Hans de Goede wrote: For some unclear reason sometimes we get VBus errors in host-only mode, even though we do not have any vbus-detection then. Ignore these. Signed-off-by: Hans de Goede hdego

Re: [linux-sunxi] [PATCH v5 2/7] phy-sun4i-usb: Add extcon support for the otg phy (phy0)

2015-07-31 Thread Hans de Goede
Hi, On 31-07-15 16:23, Jonathan Liu wrote: Hi Hans, On 13/06/2015 10:37 PM, Hans de Goede wrote: The sunxi musb glue needs to know if a host or normal usb cable is plugged in, add extcon support so that the musb glue can monitor the host status. Signed-off-by: Hans de Goede hdego

[PATCH 3/3] phy-sun4i-usb: Only check vbus-det on power-on on boards with vbus-det

2015-07-31 Thread Hans de Goede
data-vbus_det is always 1 on boards without a (working) vbus-det, skip the vbus_det test on such boards. This fixes the sun4i usb phy code never turning on Vbus on such boards. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 3 ++- 1 file changed, 2 insertions

[PATCH 0/3] phy-sun4i-usb: 3 misc. fixes

2015-07-31 Thread Hans de Goede
Hi Kishon, Here are 3 small patches for the phy-sun4i-usb code. The first patch is a small bugfix for building the sun4i musb code as module which seems to have fallen through the cracks. The second patch is a preparation patch for the third patch which fixes the case of boards with a working

[PATCH 1/3] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-31 Thread Hans de Goede
sun4i_usb_phy_set_squelch_detect is used by other code, which may be built as a module, so it should be exported. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v6: -New patch in v6 of the sunxi musb support series --- drivers/phy/phy-sun4i-usb.c | 1 + 1 file changed, 1

[PATCH 2/3] phy-sun4i-sub: Move vbus-detect helper functions up in the file

2015-07-31 Thread Hans de Goede
Move vbus-detect helper functions up in the file, just moving some code around, no functional changes what so ever. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 48 ++--- 1 file changed, 24 insertions(+), 24 deletions

Re: [PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-19 Thread Hans de Goede
Hi, On 15-07-15 14:35, Kishon Vijay Abraham I wrote: Hi, On Wednesday 08 July 2015 08:11 PM, Hans de Goede wrote: sun4i_usb_phy_set_squelch_detect is used by other code, which may be built as a module, so it should be exported. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes

[PATCH] usb-storage: Add ignore-device quirk for gm12u320 based usb mini projectors

2015-07-08 Thread Hans de Goede
make sure that the usb-storage driver does not bind to it. Signed-off-by: Hans de Goede hdego...@redhat.com --- I've a working kms driver for these devices here: http://cgit.freedesktop.org/~jwrdegoede/gm12u320-kms/ I will be submitting this upstream shortly. --- drivers/usb/storage/unusual_devs.h

[PATCH v6 3/4] musb: sunxi: Add support for musb controller in A31 SoC

2015-07-08 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- .../bindings/usb/allwinner,sun4i-a10-musb.txt | 3 +- drivers/usb/musb/sunxi.c | 50 +++--- 2 files changed, 46 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/allwinner,sun4i

[PATCH v6 1/4] phy-sun4i-usb: Add missing EXPORT_SYMBOL for sun4i_usb_phy_set_squelch_detect

2015-07-08 Thread Hans de Goede
sun4i_usb_phy_set_squelch_detect is used by other code, which may be built as a module, so it should be exported. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v6: -New patch in v6 of the sunxi musb support series --- drivers/phy/phy-sun4i-usb.c | 1 + 1 file changed, 1

[PATCH v6 4/4] musb: sunxi: Add support for musb controller in A33 SoC

2015-07-08 Thread Hans de Goede
The A33 SoC uses the same musb controller as found on the A31 and later, but allwinner has removed the configdata register, this commit adds special handling for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/usb/allwinner,sun4i-a10-musb.txt | 3 ++- drivers

[PATCH v6 2/4] musb: sunxi: Add support for the Allwinner sunxi musb controller

2015-07-08 Thread Hans de Goede
on a cubietruck (A20 SoC) and an UTOO P66 tablet (A13 SoC) with a variety of devices in host mode and with the g_serial gadget driver in peripheral mode, plugging otg / host cables in/out a lot of times in all possible imaginable plug orders. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes

[PATCH v6 0/4] musb: sunxi: Add support for the Allwinner sunxi musb

2015-07-08 Thread Hans de Goede
Hi Felipe, As requested here is a new version of my musb: sunxi: Add support for the Allwinner sunxi musb controller patch, fixing the Should it be static? compiler warning. While working on this I noticed that sun4i_usb_phy_set_squelch_detect() from phy-sun4i-usb.c is missing an EXPORT_SYMBOL,

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-08 Thread Hans de Goede
Hi, On 07-07-15 18:47, Jeremy White wrote: Well, the checkpatch.pl reports were all style (and mostly whitespace); roughly 3000 of them against 3000 lines of code :-/. I did review the code, looking for areas where I thought it would badly cram into the kernel, and I adjusted the few I

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-02 Thread Hans de Goede
Hi, On 02-07-15 10:45, Oliver Neukum wrote: On Wed, 2015-07-01 at 10:06 +0100, Daniel P. Berrange wrote: I don't really think it is sensible to be defining implementing new network services which can't support strong encryption and authentication. Rather than passing the file descriptor to

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-01 Thread Hans de Goede
Hi, On 01-07-15 20:31, Jeremy White wrote: Assuming that's correct, then this seems to imply that the socket has raw plain text data being sent/received, and thus precludes the possibility of running any security protocol like TLS unless the kernel wants to have an impl of the TLS protocol.

Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-01 Thread Hans de Goede
Hi, On 01-07-15 18:13, Greg KH wrote: On Wed, Jul 01, 2015 at 10:55:49AM -0500, Jeremy White wrote: On 07/01/2015 12:44 AM, Greg KH wrote: On Tue, Jun 30, 2015 at 10:34:25PM -0500, Jeremy White wrote: 1. Is the basic premise reasonable? Is Hans correct in asserting that an alternate USB

[PATCH v5 7/7] phy-sun4i-usb: Add support for monitoring vbus via a power-supply

2015-06-13 Thread Hans de Goede
On some boards there is no vbus_det gpio pin, instead vbus-detection for otg can be done via the pmic. This commit adds support for monitoring vbus_det via the power_supply exported by the pmic, enabling support for otg on these boards. Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH v5 0/3] musb: sunxi: Add support for the Allwinner sunxi musb

2015-06-13 Thread Hans de Goede
Hi Felipe, Here is a patch series with all my oustanding musb-sunxi changes pending for merging into 4.3. This includes the 5th iteration of the patch for adding the basic sunxi-glue, the major change in v5 is that it has been ported to the extcon API changes which are queued up for 4.2 from :

[PATCH v5 1/3] musb: sunxi: Add support for the Allwinner sunxi musb controller

2015-06-13 Thread Hans de Goede
on a cubietruck (A20 SoC) and an UTOO P66 tablet (A13 SoC) with a variety of devices in host mode and with the g_serial gadget driver in peripheral mode, plugging otg / host cables in/out a lot of times in all possible imaginable plug orders. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes

[PATCH v5 3/3] musb: sunxi: Add support for musb controller in A33 SoC

2015-06-13 Thread Hans de Goede
The A33 SoC uses the same musb controller as found on the A31 and later, but allwinner has removed the configdata register, this commit adds special handling for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/usb/allwinner,sun4i-a10-musb.txt | 3 ++- drivers

[PATCH v5 2/3] musb: sunxi: Add support for musb controller in A31 SoC

2015-06-13 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- .../bindings/usb/allwinner,sun4i-a10-musb.txt | 3 +- drivers/usb/musb/sunxi.c | 50 +++--- 2 files changed, 46 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/allwinner,sun4i

[PATCH v5 3/7] phy-sun4i-usb: Swap check for disconnect threshold

2015-06-13 Thread Hans de Goede
-off-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c index 86d9ce1..d78a071 100644 --- a/drivers/phy/phy-sun4i-usb.c +++ b/drivers/phy/phy-sun4i

[PATCH v5 1/7] phy-sun4i-usb: Add id and vbus detection support for the otg phy (phy0)

2015-06-13 Thread Hans de Goede
for all 3 phys. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Removed the sunxi specific phy functions, instead the id / vbus gpio polling has been moved to the phy-sun4i-usb driver and their status is exported through extcon for the sunxi-musb glue Changes in v3: -No changes

[PATCH v5 0/7] phy-sun4i-usb: Add OTG and newer SoC support

2015-06-13 Thread Hans de Goede
Hi Kishon, Here is a patch series with all my oustanding phy-sun4i-usb changes pending for merging into 4.3. This includes the 5th iteration of the OTG support addition, now with the extcon provider support addition split-out into a new patch and ported to the extcon API changes which are queued

[PATCH v5 5/7] phy-sun4i-usb: Add support for the usb-phys on the sun8i-a33 SoC

2015-06-13 Thread Hans de Goede
The usb-phys on the sun8i-a33 SoC are mostly the same as sun8i-a23 but for some reason (hw bug?) the phyctl register was moved to a different address and is not initialized to 0 on reset. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/phy/sun4i-usb-phy.txt | 1

[PATCH v5 2/7] phy-sun4i-usb: Add extcon support for the otg phy (phy0)

2015-06-13 Thread Hans de Goede
The sunxi musb glue needs to know if a host or normal usb cable is plugged in, add extcon support so that the musb glue can monitor the host status. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v5: -Split out of the Add id and vbus detection support commit -Ported to the new

[PATCH v5 6/7] phy-sun4i-usb: Add support for boards with broken Vusb-detection

2015-06-13 Thread Hans de Goede
On some boards we cannot detect the presence of an external Vusb, because e.g. the 5V of the otg connector is directly connected to the 5V of the board, and thus is always high. This commit adds support for using such boards by only looking at the id-detection pin. Signed-off-by: Hans de Goede

[PATCH v5 4/7] phy-sun4i-usb: Add support for the usb-phys on the sun8i-a23 SoC

2015-06-13 Thread Hans de Goede
The usb-phys on the sun8i-a23 SoC have the same setup wrt clocks as on the sun6i-a31 SoC, but there are only 2 instead of 3 like on the sun5i-a13 SoC. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 2 ++ drivers/phy/phy-sun4i-usb.c

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 10:29, Chanwoo Choi wrote: Hi Hans, On 06/11/2015 05:21 PM, Hans de Goede wrote: Hi Chanwoo, Thanks for the quick review. On 11-06-15 10:07, Chanwoo Choi wrote: Hi Hans, I add the comment about extcon-related code. Firstly, I'd like you to implment the extcon driver

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init and disable them

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 13:16, Kishon Vijay Abraham I wrote: Hi, On Thursday 11 June 2015 03:23 PM, Hans de Goede wrote: Hi, On 11-06-15 11:42, Kishon Vijay Abraham I wrote: Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 07:48, Kishon Vijay Abraham I wrote: +Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over the pullups, enable these on phy_init

Re: [linux-sunxi] Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
directory, e.g. input and hwmon devices are often also found outside of the input and hwmon driver directories. On 06/11/2015 02:48 PM, Kishon Vijay Abraham I wrote: +Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-11 Thread Hans de Goede
Hi, On 11-06-15 09:56, Hans de Goede wrote: Hi, On 11-06-15 07:48, Kishon Vijay Abraham I wrote: +Chanwoo Hi, On Sunday 31 May 2015 09:40 PM, Hans de Goede wrote: The usb0 phy is connected to an OTG controller, and as such needs some special handling: 1) It allows explicit control over

[PATCH 7/7] musb: sunxi: Add support for musb controller in A33 SoC

2015-06-05 Thread Hans de Goede
The A33 SoC uses the same musb controller as found on the A31 and later, but allwinner has removed the configdata register, this commit adds special handling for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/usb/allwinner,sun4i-a10-musb.txt | 3 ++- drivers

[PATCH 5/7] musb: sunxi: Remove special MUSB_SUN4I flag for clearing ep0 addr on disconnect

2015-06-05 Thread Hans de Goede
We can cleanly handle this inside the sunxi glue, instead of adding special casing to the core, but setting ep0 addr to 0 on a reset interrupt. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb/musb_core.h| 1 - drivers/usb/musb/musb_gadget.c | 6 -- drivers/usb/musb

[PATCH 0/7] musb-sunxi / phy-sun4i-usb: Add suppor for new SoCs

2015-06-05 Thread Hans de Goede
Hi Felipe and Kishon, This musb-sunxi / phy-sun4i-usb series adds supports for the otg and host usb-phys found on newer sunxi SoCs and for the musb ip found on newer sunxi SoCs. This series sits on top of the 2 still outstanding musb-sunxi / phy-sun4i-usb patches. These patches (and the 2 still

[PATCH 6/7] musb: sunxi: Add support for musb controller in A31 SoC

2015-06-05 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- .../bindings/usb/allwinner,sun4i-a10-musb.txt | 3 +- drivers/usb/musb/sunxi.c | 50 +++--- 2 files changed, 46 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/allwinner,sun4i

[PATCH 1/7] phy-sun4i-usb: Swap check for disconnect threshold

2015-06-05 Thread Hans de Goede
-off-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c index b45d707..0df1c4f 100644 --- a/drivers/phy/phy-sun4i-usb.c +++ b/drivers/phy/phy-sun4i

[PATCH 2/7] phy-sun4i-usb: Add support for the usb-phys on the sun8i-a23 SoC

2015-06-05 Thread Hans de Goede
The usb-phys on the sun8i-a23 SoC have the same setup wrt clocks as on the sun6i-a31 SoC, but there are only 2 instead of 3 like on the sun5i-a13 SoC. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 2 ++ drivers/phy/phy-sun4i-usb.c

[PATCH 3/7] phy-sun4i-usb: Add support for the usb-phys on the sun8i-a33 SoC

2015-06-05 Thread Hans de Goede
The usb-phys on the sun8i-a33 SoC are mostly the same as sun8i-a23 but for some reason (hw bug?) the phyctl register was moved to a different address and is not initialized to 0 on reset. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/phy/sun4i-usb-phy.txt | 1

[PATCH 4/7] phy-sun4i-usb: Add support for boards with broken Vusb-detection

2015-06-05 Thread Hans de Goede
On some boards we cannot detect the presence of an external Vusb, because e.g. the 5V of the otg connector is directly connected to the 5V of the board, and thus is always high. This commit adds support for using such boards by only looking at the id-detection pin. Signed-off-by: Hans de Goede

Re: [PATCH v4 0/2] Remaining sunxi musb patches

2015-06-02 Thread Hans de Goede
Hi, On 01-06-15 20:34, Felipe Balbi wrote: On Mon, Jun 01, 2015 at 11:30:45AM -0700, Hans de Goede wrote: Hi, On Sunday, May 31, 2015 at 6:10:32 PM UTC+2, Hans de Goede wrote: Hi Kishon Felipe, Here is an updated version of the remaining (not yet merged in Felipe's tree) sunxi musb

Re: [PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-06-01 Thread Hans de Goede
Hi, On 01-06-15 11:22, Maxime Ripard wrote: On Sun, May 31, 2015 at 06:10:25PM +0200, Hans de Goede wrote: + /* We either want both gpio pins or neither (when in host mode) */ + if (!data-id_det_gpio != !data-vbus_det_gpio) { + dev_err(dev, failed to get id or vbus

[PATCH v4 0/2] Remaining sunxi musb patches

2015-05-31 Thread Hans de Goede
Hi Kishon Felipe, Here is an updated version of the remaining (not yet merged in Felipe's tree) sunxi musb patches. The phy-sun4i-usb: Add full support for usb0 phy / OTG patch has been updated with a small bug-fix and is ready for merging. The musb: Add support for the Allwinner sunxi musb

[PATCH v4 1/2] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-05-31 Thread Hans de Goede
register an extcon. While updating the devicetree binding documentation also add documentation for the sofar undocumented usage of regulators for vbus for all 3 phys. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Removed the sunxi specific phy functions, instead the id / vbus gpio

[PATCH v4 2/2] musb: Add support for the Allwinner sunxi musb controller

2015-05-31 Thread Hans de Goede
on a cubietruck (A20 SoC) and an UTOO P66 tablet (A13 SoC) with a variety of devices in host mode and with the g_serial gadget driver in peripheral mode, plugging otg / host cables in/out a lot of times in all possible imaginable plug orders. Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes

Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller

2015-05-26 Thread Hans de Goede
Hi, On 05/26/2015 05:48 PM, Felipe Balbi wrote: On Fri, Mar 20, 2015 at 08:11:15PM +0100, Hans de Goede wrote: This is based on initial code to get the Allwinner sunxi musb controller supported by Chen-Yu Tsai and Roman Byshko. This adds support for the Allwinner sunxi musb controller in both

Re: [linux-sunxi] Re: [PATCH 1/3] phy-sun4i-usb: Add a sunxi specific function for setting squelch-detect

2015-05-11 Thread Hans de Goede
Hi, On 11-05-15 17:55, Felipe Balbi wrote: Hi, On Sun, May 10, 2015 at 12:02:54PM +0200, Hans de Goede wrote: Hi, On 08-05-15 18:06, Felipe Balbi wrote: Hi, On Sun, Mar 29, 2015 at 12:50:46PM +0200, Hans de Goede wrote: The sunxi otg phy has a bug where it wrongly detects a high speed

Re: [PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

2015-04-23 Thread Hans de Goede
(+), 98 deletions(-) Patch set looks good to me: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH v2 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-21 Thread Hans de Goede
...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Add Cc stable@vger --- drivers/usb/storage/uas-detect.h | 6 +- drivers/usb/storage/uas.c| 6 +++--- drivers/usb/storage/usb.c| 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git

[PATCH v2 2/3] uas: Add US_FL_MAX_SECTORS_240 flag

2015-04-21 Thread Hans de Goede
adds support for US_FL_MAX_SECTORS_64 to uas.c. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Document new 'g' flag in kernel-parameters.txt -Add Cc stable@vger --- Documentation/kernel-parameters.txt | 2 ++ drivers/usb/storage/uas.c

[PATCH v2 3/3] uas: Set max_sectors_240 quirk for ASM1053 devices

2015-04-21 Thread Hans de Goede
Testing has shown that ASM1053 devices do not work properly with transfers larger than 240 sectors, so set max_sectors to 240 on these. Cc: sta...@vger.kernel.org # 3.16 Reported-by: Steve Bangert sbang...@frontier.com Signed-off-by: Hans de Goede hdego...@redhat.com Tested-by: Steve Bangert

[PATCH 1/3] uas: Allow uas_use_uas_driver to return usb-storage flags

2015-04-16 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 6 +- drivers/usb/storage/uas.c| 6 +++--- drivers/usb/storage/usb.c| 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h

[PATCH 2/3] uas: Add US_FL_MAX_SECTORS_240 flag

2015-04-16 Thread Hans de Goede
adds support for US_FL_MAX_SECTORS_64 to uas.c. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas.c | 10 +- drivers/usb/storage/usb.c | 6 +- include/linux/usb_usual.h | 2 ++ 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/usb

[PATCH 3/3] uas: Set max_sectors_240 quirk for ASM1053 devices

2015-04-16 Thread Hans de Goede
Testing has shown that ASM1053 devices do not work properly with transfers larger than 240 sectors, so set max_sectors to 240 on these. Reported-by: Steve Bangert sbang...@frontier.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 5 - 1 file changed

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-16 Thread Hans de Goede
Hi, On 09-04-15 20:30, Steve Bangert wrote: On Thu, 2015-04-09 at 16:49 +0200, Hans de Goede wrote: Hi, On 09-04-15 15:27, Steve Bangert wrote: On Wed, 2015-04-08 at 10:56 -0400, Alan Stern wrote: On Wed, 8 Apr 2015, Steve Bangert wrote: What i did was not correct, usb-storage.quirks=174c

Re: [PATCH] drivers/usb/core: devio.c: Removed various errors and warnings generated by checkpatch.pl

2015-04-11 Thread Hans de Goede
...@gmail.com Looks good to me: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb/core/devio.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 1163553..62c0be6 100644

Re: Unable to access USB mass storage device with xhci. okay with ehci

2015-04-09 Thread Hans de Goede
Hi, On 09-04-15 15:27, Steve Bangert wrote: On Wed, 2015-04-08 at 10:56 -0400, Alan Stern wrote: On Wed, 8 Apr 2015, Steve Bangert wrote: What i did was not correct, usb-storage.quirks=174c:55aa:u was added to /etc/default/grub file after GRUB_CMDLINE_LINUX=rhgb quiet, using the

[PATCH 1/3] phy-sun4i-usb: Add a sunxi specific function for setting squelch-detect

2015-03-29 Thread Hans de Goede
phy function to allow the sunxi-musb glue to do this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 9 + include/linux/phy/phy-sun4i-usb.h | 26 ++ 2 files changed, 35 insertions(+) create mode 100644 include/linux/phy

[PATCH 2/3] musb: Add pre and post root port reset end callbacks

2015-03-29 Thread Hans de Goede
de Goede hdego...@redhat.com --- drivers/usb/musb/musb_core.h| 16 drivers/usb/musb/musb_virthub.c | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h index 444b936..19d7b8c 100644 --- a/drivers/usb/musb

[PATCH 3/3] msub: sunxi: Add pre/post root reset end platform functions

2015-03-29 Thread Hans de Goede
Add pre/post root reset end platform functions and make them call sun4i_usb_phy_set_squelch_detect() to work around the sunxi usb otg phy workaround. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb/sunxi.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH 0/3] Work around sunxi otg usb phy bug which causes lo-speed devices to not work

2015-03-29 Thread Hans de Goede
Hi All, Here is a patch-set to work around sunxi otg usb phy bug which causes some lo-speed devices to not work (they get disconnected at there first reset). This patch set uses a private sunxi phy function, I know that this is not ideal, but given the rather perculiar nature of this bug / the

Re: Need a phy function to enable / disable usb squelch detection

2015-03-27 Thread Hans de Goede
Hi, On 27-03-15 02:21, Peter Chen wrote: Hi Kishon, I've been debugging why some devices do not work with the musb otg controller found on Allwinner SoC-s, and the conclusion is not good, the Android kernel does a poke to the phy before releasing the usb reset. Now you did not want me to

Need a phy function to enable / disable usb squelch detection

2015-03-26 Thread Hans de Goede
Hi Kishon, I've been debugging why some devices do not work with the musb otg controller found on Allwinner SoC-s, and the conclusion is not good, the Android kernel does a poke to the phy before releasing the usb reset. Now you did not want me to introduce any sunxi specific / private phy

Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller

2015-03-21 Thread Hans de Goede
Hi, On 21-03-15 03:04, Chen-Yu Tsai wrote: Hi, On Sat, Mar 21, 2015 at 3:11 AM, Hans de Goede hdego...@redhat.com wrote: This is based on initial code to get the Allwinner sunxi musb controller supported by Chen-Yu Tsai and Roman Byshko. This adds support for the Allwinner sunxi musb

[PATCH v2 04/13] musb: Do not use musb_read[b|w] / _write[b|w] wrappers in generic fifo functions

2015-03-20 Thread Hans de Goede
the fifo access functions. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb/musb_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index 01ed3a6..016b5b9 100644 --- a/drivers/usb/musb

[PATCH v2 05/13] musb: Fix platform code being unable to override ep access ops

2015-03-20 Thread Hans de Goede
musb-core was setting the ops to the default indexed or flat handlers after checking for platform overrides. Reverse the order of this so that platform overrides actually work. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/musb/musb_core.c | 13 ++--- 1 file changed, 6

[PATCH v2 03/13] musb: Make busctl_offset an io-op rather then a define

2015-03-20 Thread Hans de Goede
The Allwinner (sunxi) implementation of the musb has its busctl registers indexed by the MUSB_INDEX register rather then in a flat address space. This commit turns MUSB_BUSCTL_OFFSET from a macro into an io-op which can be overridden from the platform ops. Signed-off-by: Hans de Goede hdego

[PATCH v2 01/13] phy-sun4i-usb: Add full support for usb0 phy / OTG

2015-03-20 Thread Hans de Goede
register an extcon. While updating the devicetree binding documentation also add documentation for the sofar undocumented usage of regulators for vbus for all 3 phys. Signed-off-by: Hans de Goede hdego...@redhat.com --- .../devicetree/bindings/phy/sun4i-usb-phy.txt | 18 +- drivers/phy/Kconfig

[PATCH v2 13/13] ARM: dts: sun7i: Enable USB DRC on A20-OLinuxIno-Lime

2015-03-20 Thread Hans de Goede
Enable the otg/drc usb controller on the A20-OLinuxIno-Lime. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 28 ++ 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts b/arch

[PATCH v2 12/13] ARM: dts: sun7i: Enable USB DRC on Cubietruck

2015-03-20 Thread Hans de Goede
From: Roman Byshko rbys...@gmail.com Enable the otg/drc usb controller on the cubietruck. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20

[PATCH v2 07/13] ARM: dts: sun4i: Add USB Dual Role Controller

2015-03-20 Thread Hans de Goede
Add a node for the otg/drc usb controller to sun4i-a10.dtsi. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun4i-a10.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index a932c1c

[PATCH v2 09/13] ARM: dts: sun7i: Add USB Dual Role Controller

2015-03-20 Thread Hans de Goede
From: Roman Byshko rbys...@gmail.com Add a node for the otg/drc usb controller to sun7i-a20.dtsi Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm

[PATCH v2 02/13] musb: Make musb_write_rxfun* and musb_write_rxhub* work like their tx versions

2015-03-20 Thread Hans de Goede
For some reason the musb_write_rxfun* and musb_write_rxhub* functions had a different function prototype and some extra magic needed on the caller side compared to their tx counterparts, this commit makes them work the same as their tx counterparts. Signed-off-by: Hans de Goede hdego

[PATCH v2 11/13] ARM: dts: sun5i: Enable USB DRC on UTOO P66

2015-03-20 Thread Hans de Goede
Enable the OTG controller on the UTOO P66 tablet. Signed-off-by: Hans de Goede hdego...@redhat.com --- arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/sun5i-a13-utoo-p66.dts b/arch/arm/boot/dts/sun5i-a13

<    1   2   3   4   5   6   7   8   9   10   >