Re: [PATCH 03/11] xhci: Log extra info on ERROR Transfer event TRB DMA ptr not part of current TD

2014-08-04 Thread Hans de Goede
Hi, On 08/04/2014 06:19 PM, Mathias Nyman wrote: On 08/04/2014 06:56 PM, Hans de Goede wrote: Hi, On 08/02/2014 10:41 AM, Hans de Goede wrote: Hi, On 08/02/2014 12:58 AM, Greg Kroah-Hartman wrote: On Fri, Jul 25, 2014 at 10:01:20PM +0200, Hans de Goede wrote: Lately (with the use of uas

Re: UAS errors with Jmicron

2014-08-04 Thread Hans de Goede
Hi Laszlo, On 08/03/2014 12:40 AM, Laszlo T. wrote: *) usb devices return different descriptors at different speeds All tests were on usb2. I don't have usb3 ports but I will try that at weekend. I'm curious now, am I the first one who has ever tested uas on usb2? Ni, I've tested it

Re: [PATCH 03/11] xhci: Log extra info on ERROR Transfer event TRB DMA ptr not part of current TD

2014-08-02 Thread Hans de Goede
Hi, On 08/02/2014 12:58 AM, Greg Kroah-Hartman wrote: On Fri, Jul 25, 2014 at 10:01:20PM +0200, Hans de Goede wrote: Lately (with the use of uas / bulk-streams) we have been seeing several cases where this error triggers (which should never happen). Add some extra logging to make debugging

[PATCH] uas: Limit qdepth to 32 when connected over usb-2

2014-08-01 Thread Hans de Goede
to keep things close to maximum possible throughput on usb-2. Cc: sta...@vger.kernel.org Tested-and-reported-by: Laszlo T. tla...@gmail.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

Re: UAS errors with Jmicron

2014-07-31 Thread Hans de Goede
Hi, On 07/31/2014 12:39 AM, Laszlo T. wrote: Disconnection issues like you are seeing are typical for drawing too much power from the port. Using uas as the dmesg shows you are will allow us to send more commands to the disk at once (which is a good thing, it is faster) and as such will

Re: UAS errors with Jmicron

2014-07-31 Thread Hans de Goede
Hi, On 07/31/2014 01:37 PM, Laszlo T. wrote: 2014-07-31 12:53 GMT+02:00 Hans de Goede hdego...@redhat.com: Hi, On 07/31/2014 12:39 AM, Laszlo T. wrote: Disconnection issues like you are seeing are typical for drawing too much power from the port. Using uas as the dmesg shows you

Re: UAS errors with Jmicron

2014-07-31 Thread Hans de Goede
Hi, On 07/31/2014 03:51 PM, Laszlo T. wrote: I tested with lot of values. I'm not totally sure but it looks the 31 is max number where it is still stable to create an ext4 filesystem. Thanks, that is good to know. Can you try the following patch instead of changing can_queue ? : diff

Re: can_queue parameter of uas.c

2014-07-30 Thread Hans de Goede
Hi, On 07/30/2014 12:00 PM, Oliver Neukum wrote: Hi, looking at this code made me think whether there actually is a limit on the host. It seems to me that we should not have more concurrent commands than the host controller supports streams. What do you think? AFAIK this is already

Re: can_queue parameter of uas.c

2014-07-30 Thread Hans de Goede
Hi, On 07/30/2014 02:21 PM, Oliver Neukum wrote: On Wed, 2014-07-30 at 12:58 +0200, Hans de Goede wrote: Hi, On 07/30/2014 12:00 PM, Oliver Neukum wrote: Hi, looking at this code made me think whether there actually is a limit on the host. It seems to me that we should not have more

Re: UAS errors with Jmicron

2014-07-30 Thread Hans de Goede
Hi, On 07/30/2014 04:48 PM, Alan Stern wrote: On Tue, 29 Jul 2014, Laszlo T. wrote: Hello, I ran some commands and recorded them: -checking with cfdisk -mounting the ntfs partition -some reading on it -unmounting -and the unsuccessful ext4 filesystem creating

Re: UAS errors with Jmicron

2014-07-28 Thread Hans de Goede
Hi, On 07/28/2014 04:50 PM, Oliver Neukum wrote: On Mon, 2014-07-28 at 10:48 -0400, Alan Stern wrote: On Mon, 28 Jul 2014, Laszlo T. wrote: Hello, I have some problems with Jmicron JMS567 (Sata 6 Gb/s - USB3.0) mobile rack. I tried on different kernels: 3.15.5 3.16.rc6 I got the

Re: UAS errors with Jmicron

2014-07-28 Thread Hans de Goede
Hi, On 07/28/2014 10:31 PM, Laszlo T. wrote: I have some problems with Jmicron JMS567 (Sata 6 Gb/s - USB3.0) mobile rack. I tried on different kernels: 3.15.5 3.16.rc6 I got the following errors when I ran a mkfs.ext4 command and then the device disappeared. Jul 26 19:54:37 debian

[PATCH 00/11] Misc. xhci + uas fixes / cleanups

2014-07-25 Thread Hans de Goede
Hi All, I've just spend 3 days trying to get bulk streams / uas to work on an Etron controller, and failed. So the first patch in this set is the most important one (and has a CC stable, and should be added to 3.16 if still possible). It simply outright disables streams on the Etron model in

[PATCH 08/11] xhci: Always ring the doorbell for active eps when a Set TR deq ptr cmd completes

2014-07-25 Thread Hans de Goede
Even if the stream for which the command was intended has been freed in the mean time. This ensures that things start rolling again after an unlink / halt. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 03/11] xhci: Log extra info on ERROR Transfer event TRB DMA ptr not part of current TD

2014-07-25 Thread Hans de Goede
Lately (with the use of uas / bulk-streams) we have been seeing several cases where this error triggers (which should never happen). Add some extra logging to make debugging these errors easier. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-mem.c | 4 +++- drivers

[PATCH 11/11] xhci: xhci_ring_device: Ring stream ring bells for endpoints with streams

2014-07-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-hub.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index aa79e87..bb54783 100644 --- a/drivers/usb/host/xhci-hub.c +++ b

[PATCH 02/11] xhci: Rename Asrock P67 pci product-id to EJ168

2014-07-25 Thread Hans de Goede
The 7023 product id is the generic product id for the Etron EJ168, it is not specific to the version found on the Asrock P67 motherboard. The same id is e.g. also used on Gigabyte motherboards and on no-name pci-e usb-3 addon cards. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers

[PATCH 09/11] uas: Only complain about missing sg if all other checks succeed

2014-07-25 Thread Hans de Goede
Don't complain about controllers without sg support if there are other reasons why uas cannot be used anyways. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/uas-detect.h | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git

[PATCH 04/11] xhci: Add missing checks for xhci_alloc_command failure

2014-07-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 4 drivers/usb/host/xhci.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 213b28a..2e19986 100644 --- a/drivers/usb/host/xhci

[PATCH 06/11] xhci: Fold queue_set_tr_deq into xhci_queue_new_dequeue_state

2014-07-25 Thread Hans de Goede
xhci_queue_new_dequeue_state is the only caller of queue_set_tr_deq and queue_set_tr_deq checks for SET_DEQ_PENDING, where as xhci_queue_new_dequeue_state sets it which is inconsistent. Simply fold the 2 into one is a nice cleanup and fixes the inconsistency. Signed-off-by: Hans de Goede hdego

[PATCH 05/11] xhci: Move allocating of command for new_dequeue_state to queue_set_tr_deq()

2014-07-25 Thread Hans de Goede
checks in queue_set_tr_deq(), avoiding leaking the command if those fail 4) Since queue_set_tr_deq now owns the command it can free it if queue_command fails 5) It reduces code duplication Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 35

Re: xhci error: Transfer event TRB DMA ptr not part of current TD

2014-07-18 Thread Hans de Goede
Hi, On 07/10/2014 01:17 PM, Hans de Goede wrote: Hi Sarah, Matthias, et al, I've been running a full Linux distro from an uas enclosure with a ssd for testing purposes (mostly for testing the distro on different hardware but also for uas testing). While testing this on a Thinkpad T440s I

Re: xhci throws EPROTO errors under load with CONFIG_DMA_API_DEBUG=Y

2014-07-18 Thread Hans de Goede
Hi, On 07/17/2014 06:08 PM, Hans de Goede wrote: Hi all, It has cost me quite some time to get to the bottom of this (which is not even the real bottom). When I generate heavy-io (make -j4 modules or cp -pr a git clone of the kernel), urbs start completing with EPROTO errors when using

[PATCH 0/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

2014-07-18 Thread Hans de Goede
Hi All, Here is a small patch-set fixing the following error: xhci error: Transfer event TRB DMA ptr not part of current TD Being logged when using uas on a Haswell chipset xhci controller. The first 2 patches just add some debugging output which I've found to be helpful to solve this bug and

[PATCH 1/3] xhci: Print hcc params, version and quirks on init

2014-07-18 Thread Hans de Goede
To help debugging xhci problems. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci.c | 4 drivers/usb/host/xhci.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 7436d5f..7d02e1b 100644 --- a/drivers/usb

[PATCH 3/3] xhci: Treat not finding the event_seg on COMP_STOP the same as COMP_STOP_INVAL

2014-07-18 Thread Hans de Goede
) The following error gets logged to dmesg: xhci error: Transfer event TRB DMA ptr not part of current TD Treating COMP_STOP the same as COMP_STOP_INVAL when no event_seg gets found fixes this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 3 ++- 1 file

[PATCH 2/3] xhci: Log ep-index and comp-code on TRB DMA ptr not part of current TD

2014-07-18 Thread Hans de Goede
These errors should never happen, so lets add some extra info when they happen to make figuring out what is going on easier. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/xhci-ring.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host

Re: [PATCH] usb: core: allow zero packet flag for interrupt urbs

2014-07-17 Thread Hans de Goede
error of BOGUS transfer flags. Signed-off-by: Amit Virdi amit.vi...@st.com Seems sensible to me: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb/core/urb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/core/urb.c b/drivers/usb/core

xhci throws EPROTO errors under load with CONFIG_DMA_API_DEBUG=Y

2014-07-17 Thread Hans de Goede
Hi all, It has cost me quite some time to get to the bottom of this (which is not even the real bottom). When I generate heavy-io (make -j4 modules or cp -pr a git clone of the kernel), urbs start completing with EPROTO errors when using a Renesas uPD720231 chipset usb-3 uas to sata bridge with

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 08:45 AM, Oliver Neukum wrote: On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA [ 54.018119] sd 6:0:0:0: uas_sense_old: urb length 26 disagrees with IU sense

Re: uas regression in 3.15 with Lacie Rugged USB3 and NEC uPD720200

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 11:42 AM, Oliver Neukum wrote: On Wed, 2014-07-16 at 10:44 +0200, Hans de Goede wrote: Hi, On 07/16/2014 08:45 AM, Oliver Neukum wrote: On Tue, 2014-07-15 at 22:23 +0200, Julian Sikorski wrote: [ 54.017997] sd 6:0:0:0: [sdb] Write cache: enabled, read cache: enabled

xhci error: Transfer event TRB DMA ptr not part of current TD

2014-07-10 Thread Hans de Goede
Hi Sarah, Matthias, et al, I've been running a full Linux distro from an uas enclosure with a ssd for testing purposes (mostly for testing the distro on different hardware but also for uas testing). While testing this on a Thinkpad T440s I noticed the error from $subject happening exactly once

Announce libusb-1.0.19

2014-06-13 Thread Hans de Goede
Hi All, I'm happy to announce the libusb-1.0.19 final release. The big feature of this release is support for bulk-streams on Mac OS X and Linux (using the new usbfs API for this from 3.15). Changelog: * Add support for USB bulk streams on Linux and Mac OS X (#11) * Windows: Add AMD and Intel

Announce libusb-1.0.19-rc2

2014-05-30 Thread Hans de Goede
Hi All, I'm happy to announce the libusb-1.0.19-rc2 release. The big feature of this release is support for bulk-streams on Mac OS X and Linux (using the new usbfs API for this from 3.15). Changelog: * Add support for USB bulk streams on Linux and Mac OS X (#11) * Windows: Add AMD and Intel

Announce libusb-1.0.19-rc1

2014-05-19 Thread Hans de Goede
Hi All, I'm happy to announce the libusb-1.0.19-rc1 release. The big feature of this release is support for bulk-streams on Mac OS X and Linux (using the new usbfs API for this from 3.15). Changelog: * Add support for USB bulk streams on Linux and Mac OS X (#11) * Windows: Add AMD and Intel

Re: [PATCH v3 3/8] phy: sunxi: Rework phy initialization

2014-05-13 Thread Hans de Goede
); + } else { + phy-pmu = NULL; } data is kzalloced, so there is no need for this else branch. Other then that this patch is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans - phy = devm_phy_create(dev, sun4i_usb_phy_ops, NULL

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Hans de Goede
having a single clock for all the phys. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Reviewed-by: Hans de Goede hdego...@redhat.com --- drivers/phy/phy-sun4i-usb.c | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git

Re: [linux-sunxi] [PATCH v2 3/7] phy: usb: sunxi: Introduce Allwinner A31 USB PHY support

2014-05-12 Thread Hans de Goede
Hi, On 05/12/2014 02:24 PM, Kishon Vijay Abraham I wrote: Hi, On Monday 12 May 2014 05:29 PM, Hans de Goede wrote: Hi, On 05/12/2014 11:14 AM, Chen-Yu Tsai wrote: Hi, On Sat, May 10, 2014 at 8:56 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: The USB phy controller

Re: [PATCH 4/7] usb: ehci-platform: add optional reset controller retrieval

2014-05-08 Thread Hans de Goede
Hi, On 05/08/2014 12:00 AM, Maxime Ripard wrote: On Wed, May 07, 2014 at 10:25:55AM -0400, Alan Stern wrote: On Tue, 6 May 2014, Maxime Ripard wrote: From: Boris BREZILLON boris.brezil...@free-electrons.com On the Allwinner's A31 SoC the reset line connected to the EHCI IP has to be

Re: [linux-sunxi] [PATCH 7/7] ARM: sunxi: dt: add APP4-EVB1 board support

2014-05-07 Thread Hans de Goede
Hi, On 05/07/2014 07:10 AM, Koen Kooi wrote: Op 7 mei 2014, om 05:50 heeft Maxime Ripard maxime.rip...@free-electrons.com het volgende geschreven: From: Boris BREZILLON boris.brezil...@free-electrons.com The APP4 EVB1 development boards embeds an A31, together with some NAND, one SD

Re: [PATCH 0/7] Add Allwinner A31 USB support

2014-05-07 Thread Hans de Goede
that the PHYs now have one clock per phy, while it used to be only one for all the PHYs. Thanks, Maxime Thanks for working on this. Looks good, the entire series is: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans Boris BREZILLON (2): usb: ehci-platform: add optional reset

Re: [PATCH v3 00/20] USB support for Armada 38x and Armada 375

2014-05-07 Thread Hans de Goede
Hi, On 05/07/2014 11:21 AM, Sebastian Hesselbarth wrote: [Adding back the original Cc-List] On 05/07/2014 10:33 AM, Hans de Goede wrote: Hi Gregory, Gregory CLEMENT gregory.clement at free-electrons.com writes: This patch set adds the USB support for the Armada 38x Armada 375

Re: [PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

2014-04-15 Thread Hans de Goede
Hi, On 04/15/2014 09:42 PM, Julius Werner wrote: +hdegoede I tried to apply this patch on top of 3.15-rc1, but it fails because of the streams support added to xhci_find_new_dequeue_state() After some manual editing the interesting parts of xhci_find_new_dequeue_state() looks like this: @@

Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices

2014-04-13 Thread Hans de Goede
must migrate all the users of these devices to the gspca_sonixb driver now, so that it gets sufficient testing before the sn9c102 driver is finally phased out. Signed-off-by: Jean Delvare jdelv...@suse.de Cc: Hans de Goede hdego...@redhat.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc

Re: [PATCH] uas: fix GFP_NOIO under spinlock

2014-03-28 Thread Hans de Goede
please add this to usb-next? It fixes a regression my uas set has introduced there. Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb/storage/uas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb

Re: [PATCH] uas: fix deadlocky memory allocations

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 10:27 AM, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de There is an allocation with GFP_NOIO with a spinlock held that the checker didn't catch. ACK, my bad. When I wrote this commit:

Re: uas_do_work() and flush_work()

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 10:45 AM, Oliver Neukum wrote: Hans, it seems to me that there is a problem. uas_pre_reset() calls flush_work(). uas_do_work(), however can reschedule itself if usb_submit_urb() fails. That opens up the possibility that there's a permanent problem with the device which

Re: [PATCH] uas: fix GFP_NOIO under spinlock

2014-03-28 Thread Hans de Goede
...@oracle.com Thanks! Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb/storage/uas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index

Re: [PATCH] uas: fix deadlocky memory allocations

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 11:14 AM, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de There is an allocation with GFP_NOIO with a spinlock held that the checker didn't catch. I hate to be a PITA, but this above part of the commit message is no longer correct, can you amend the commit

Re: [PATCH] uas: fix error handling during scsi_scan()

2014-03-28 Thread Hans de Goede
is registered and undone in the error case. Signed-off-by: Oliver Neukum oli...@neukum.org Good catch, thanks: Reviewed-by: Hans de Goede hdego...@redhat.com Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans --- drivers/usb/storage/uas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: uas_disconnect() and morphed devices after resumption

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 01:53 PM, Oliver Neukum wrote: Hi, I am looking at uas_disconnect() calling uas_free_streams() unconditionally. I wonder what this does if a device has morphed. It seems to me we'd try to free streams of endpoints that might not even exist. If a device morphs we will get

Re: [PATCH] uas: fix GFP_NOIO under spinlock

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 05:42 PM, Greg KH wrote: On Fri, Mar 28, 2014 at 09:48:00AM +0100, Hans de Goede wrote: Hi, On 03/28/2014 09:45 AM, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de Quote Dan: The patch e36e64930cff: uas: Use GFP_NOIO rather then GFP_ATOMIC where possible

Re: [PATCH] USB: disable reset-resume when USB_QUIRK_RESET is set

2014-03-18 Thread Hans de Goede
st...@rowland.harvard.edu CC: Oliver Neukum oli...@neukum.org Looks good to me: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 33/76] uas: Pack iu struct definitions

2014-03-07 Thread Hans de Goede
Hi, On 03/07/2014 04:41 PM, David Laight wrote: From: Of Sarah Sharp From: Hans de Goede hdego...@redhat.com The iu struct definitions are usb packet definitions, so no alignment should happen. Notice that assuming 32 bit alignment this does not make any difference at all. Signed-off

Re: [PATCH v9 2/4] ehci-platform: Add support for clks and phy passed through devicetree

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 10:12 AM, Roger Quadros wrote: Hi Hans, On 02/07/2014 05:36 PM, Hans de Goede wrote: Currently ehci-platform is only used in combination with devicetree when used with some Via socs. By extending it to (optionally) get clks and a phy from devicetree, and enabling

Re: [PATCH v9 2/4] ehci-platform: Add support for clks and phy passed through devicetree

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 11:00 AM, Roger Quadros wrote: On 02/11/2014 11:31 AM, Hans de Goede wrote: Hi, On 02/11/2014 10:12 AM, Roger Quadros wrote: Hi Hans, On 02/07/2014 05:36 PM, Hans de Goede wrote: Currently ehci-platform is only used in combination with devicetree when used with some

[PATCH 1/2] ohci-platform: Change compatible string from usb-ohci to ohci-platform

2014-02-11 Thread Hans de Goede
/ module loading ordering problems. Note that there already is a precedent for using ?hci-platform, in the form of xhci-platform.c using xhci-platfrom as compatible string. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 4 ++-- drivers/usb

ohci-/ehci-platform: Change compatible string to ?hci-platform

2014-02-11 Thread Hans de Goede
Hi Greg, Can you please add these 2 patches to usb-next, to unbreak usb on various ARM platforms? These 2 patches can either be squashed into the first 2 patches of my previous set or added as is to preserve history, either way is fine with me. The 2nd patch also fixes one of the Kconfig issues

[PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform

2014-02-11 Thread Hans de Goede
string. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 4 ++-- drivers/usb/host/Kconfig | 1 - drivers/usb/host/ehci-platform.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 1/2] ohci-platform: Change compatible string from usb-ohci to ohci-platform

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 04:06 PM, Kumar Gala wrote: On Feb 11, 2014, at 8:10 AM, Hans De Goede hdego...@redhat.com wrote: The initial versions of the devicetree enablement patches for ohci-platform used ohci-platform as compatible string. However this was disliked by various reviewers because

Re: [PATCH 2/2] ehci-platform: Change compatible string from usb-ehci to ehci-platform

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 04:00 PM, Roger Quadros wrote: Hi Hans, On 02/11/2014 04:10 PM, Hans de Goede wrote: The initial versions of the devicetree enablement patches for ehci-platform used ehci-platform as compatible string. However this was disliked by various reviewers because the platform

Re: ohci-/ehci-platform: Change compatible string to ?hci-platform

2014-02-11 Thread Hans de Goede
Hi, On 02/11/2014 04:43 PM, Arnd Bergmann wrote: On Tuesday 11 February 2014 10:27:12 Alan Stern wrote: It might even be a good idea to change the xhci-platform string to match, it that doesn't cause too much trouble. The original xhci binding was contributed by Al Cooper, but I don't

[PATCH v2 1/2] ohci-platform: Change compatible string from usb-ohci to generic-ohci

2014-02-11 Thread Hans de Goede
loading ordering problems. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 4 ++-- drivers/usb/host/ohci-platform.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 0/2] ohci-/ehci-platform: Change compatible string to generic-?hci

2014-02-11 Thread Hans de Goede
Hi Greg, And here is v2 of my ohci-/ehci-platform fixes for the regression of USB support on various ARM boards I caused in linux-next. As expected some people still did not like the ?hci-platform compatible string I went for in v1, hence this v2. The good news is it seems everyone seems to be

[PATCH v2 2/2] ehci-platform: Change compatible string from usb-ehci to generic-ehci

2014-02-11 Thread Hans de Goede
string claimed by ehci-platform to generic-ehci, avoiding the driver registration / module loading ordering problems, and removes the depends on !PPC_OF workaround. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ehci.txt | 4 ++-- drivers/usb/host

[PATCH 1/2] uhci-platform: Change compatible string from platform-uhci to generic-uhci

2014-02-11 Thread Hans de Goede
compatible string is kept around for, well, compatibility reasons. While at it rename the bindings txt file to match the name of all the other ?hci-platform bindings docs. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/platform-uhci.txt | 15

[PATCH 2/2] xhci-platform: Change compatible string from xhci-platform to generic-xhci

2014-02-11 Thread Hans de Goede
compatible string is kept around for, well, compatibility reasons. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 ++-- drivers/usb/host/xhci-plat.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff

Re: [PATCH 1/2] USB: ohci-platform: check for platform data misconfiguration

2014-02-11 Thread Hans de Goede
of the error messages in an attempt to make the nature of the error more clear. Signed-off-by: Alan Stern st...@rowland.harvard.edu Reported-by: Jonas Gorski j...@openwrt.org CC: Hans de Goede hdego...@redhat.com Thanks for doing this, looks good: Acked-by: Hans de Goede hdego...@redhat.com Regards

Re: [PATCH 1/2] usb/host/Kconfig: ohci- / ehci-platform make sure PHY_GENERIC is available

2014-02-11 Thread Hans de Goede
Hi Alan, On 02/11/2014 05:56 PM, Alan Stern wrote: On Mon, 10 Feb 2014, Hans de Goede wrote: Disallow ohci- / ehci-platform being built-in, when the phy core is build as a module. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/Kconfig | 3 ++- 1 file changed, 2

Re: ohci-/ehci-platform: Change compatible string to ?hci-platform

2014-02-11 Thread Hans de Goede
Hi Florian, On 02/11/2014 06:01 PM, Florian Fainelli wrote: Le mardi 11 février 2014, 16:43:37 Arnd Bergmann a écrit : On Tuesday 11 February 2014 10:27:12 Alan Stern wrote: It might even be a good idea to change the xhci-platform string to match, it that doesn't cause too much trouble. The

Re: [PATCH 2/2] USB: ehci-platform: check for platform data misconfiguration

2014-02-11 Thread Hans de Goede
of the error messages in an attempt to make the nature of the error more clear. Signed-off-by: Alan Stern st...@rowland.harvard.edu Reported-by: Jonas Gorski j...@openwrt.org CC: Hans de Goede hdego...@redhat.com Thanks for doing this, looks good: Acked-by: Hans de Goede hdego...@redhat.com Regards

Re: [PATCH] UAS: fallback to storage if no streams are available

2014-02-10 Thread Hans de Goede
Hi, On 02/10/2014 07:32 AM, Oliver Neukum wrote: On Fri, 2014-02-07 at 10:18 -0500, Alan Stern wrote: On Fri, 7 Feb 2014, Oliver Neukum wrote: Hi, something like this? Patches in attachments are hard to review in email replies. Sorry. Isn't this overkill? All you want to know is

Re: [PATCH] UAS: fallback to storage if no streams are available

2014-02-10 Thread Hans de Goede
Hi, On 02/10/2014 01:26 PM, Oliver Neukum wrote: On Mon, 2014-02-10 at 12:58 +0100, Hans de Goede wrote: Hi, On 02/10/2014 07:32 AM, Oliver Neukum wrote: On Fri, 2014-02-07 at 10:18 -0500, Alan Stern wrote: On Fri, 7 Feb 2014, Oliver Neukum wrote: Hi, something like this? Patches

Re: [PATCH 2/2] storage: accept some UAS devices if streams are unavailable

2014-02-10 Thread Hans de Goede
and evaluates it. Signed-off-by: Oliver Neukum oneu...@suse.de Looks good: Acked-by: Hans de Goede hdego...@redhat.com Sarah can you add this to the bulk-stream + uas patch-series for 3.15 please ? Thanks Regards, Hans --- drivers/usb/host/xhci-pci.c | 3 +++ drivers/usb/host

[PATCH 1/2] usb/host/Kconfig: ohci- / ehci-platform make sure PHY_GENERIC is available

2014-02-10 Thread Hans de Goede
Disallow ohci- / ehci-platform being built-in, when the phy core is build as a module. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index

[PATCH 0/2] usb/host/Kconfig: Fix issues caused by recent ?hci-platform changes

2014-02-10 Thread Hans de Goede
Hi Greg et al, Here are 2 patches fixing Kconfig issues introduced by my ?hci-platform changes and found by the kbuild test robot. Note Kconfig is not my forte, so these patches may benefit from a review before you apply them. Thanks Regards, Hans -- To unsubscribe from this list: send the

[PATCH 2/2] usb/host/Kconfig: Ensure all deps are met when selecting USB_HCD_?HCI_PLATFORM

2014-02-10 Thread Hans de Goede
) Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/Kconfig | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 1dd73e3..0df261a 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig

Re: [PATCH] UAS: fallback to storage if no streams are available

2014-02-07 Thread Hans de Goede
Hi, On 02/07/2014 11:03 AM, Oliver Neukum wrote: On Wed, 2014-02-05 at 22:08 +0100, Hans de Goede wrote: Hi Oliver, On 02/05/2014 09:13 PM, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de uas_probe() calls usb_alloc_streams(). That can fail on XHCI with -ENOSYS

[PATCH v9 2/4] ehci-platform: Add support for clks and phy passed through devicetree

2014-02-07 Thread Hans de Goede
, even though it mostly is ibm,usb-ehci-440epx specific. ehci-platform.c is not needed on ppc platforms, so add a !PPC_OF dependency to it to avoid 2 drivers claiming the same compatibility string getting build on ppc. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Alan Stern st

[PATCH v9 0/4] ohci-platform and ehci-plaform patches rebased on 3.14-rc1

2014-02-07 Thread Hans de Goede
Hi Greg, Here is v9 of my ohci-platform and ehci-platform patchset, It is just a rebase (with some manual conflict resolution), to make it easier for you to throw this into usb-next, there are no other changes. Thanks Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH v9 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-02-07 Thread Hans de Goede
Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 3 +++ drivers/usb

[PATCH v9 1/4] ohci-platform: Add support for devicetree instantiation

2014-02-07 Thread Hans de Goede
for the ohci controller found on Allwinner sunxi SoCs. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Alan Stern st...@rowland.harvard.edu --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 22 +++ drivers/usb/host/ohci-platform.c | 162 ++--- 2 files

[PATCH v9 4/4] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-02-07 Thread Hans de Goede
This uses the already documented devicetree booleans for this, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/ehci-platform.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions

Re: [PATCH] ARM: sunxi: Add driver for sunxi usb phy

2014-02-07 Thread Hans de Goede
Hi, On 01/15/2014 04:00 PM, Kishon Vijay Abraham I wrote: On Wednesday 15 January 2014 04:28 AM, Hans de Goede wrote: The Allwinner A1x / A2x SoCs have 2 or 3 usb phys which are all accessed through a single set of registers. Besides this there are also some other phy related bits which need

Re: [PATCH] ARM: sunxi: Add driver for sunxi usb phy

2014-02-07 Thread Hans de Goede
Hi, On 01/15/2014 11:52 PM, Maxime Ripard wrote: Hi Hans, Please keep me in CC for all the Allwinner-related patches. Ok will do. On Tue, Jan 14, 2014 at 11:58:25PM +0100, Hans de Goede wrote: The Allwinner A1x / A2x SoCs have 2 or 3 usb phys which are all accessed through a single set

Re: [PATCH v9 0/4] ohci-platform and ehci-plaform patches rebased on 3.14-rc1

2014-02-07 Thread Hans de Goede
Hi, On 02/07/2014 11:31 PM, Greg Kroah-Hartman wrote: On Fri, Feb 07, 2014 at 04:36:39PM +0100, Hans de Goede wrote: Hi Greg, Here is v9 of my ohci-platform and ehci-platform patchset, It is just a rebase (with some manual conflict resolution), to make it easier for you to throw this into usb

Re: [PATCH] UAS: fallback to storage if no streams are available

2014-02-05 Thread Hans de Goede
Hi Oliver, On 02/05/2014 09:13 PM, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de uas_probe() calls usb_alloc_streams(). That can fail on XHCI with -ENOSYS if the controller doesn't support streams. In that case devices should be handed over to storage. Thus the driver needs to

[PATCH v8 4/4] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
This uses the already documented devicetree booleans for this, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/ehci-platform.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions

[PATCH v8 2/4] ehci-platform: Add support for clks and phy passed through devicetree

2014-01-22 Thread Hans de Goede
, even though it mostly is ibm,usb-ehci-440epx specific. ehci-platform.c is not needed on ppc platforms, so add a !PPC_OF dependency to it to avoid 2 drivers claiming the same compatibility string getting build on ppc. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Alan Stern st

[PATCH v8 0/4] ohci and ehci-platform clks, phy, be and dt support

2014-01-22 Thread Hans de Goede
Hi All, Although v7 was intended as the final version here is a v8, compared to v7 this contains 2 small fixes to the dt-bindings documentation so that the examples there match the dt-node naming rules. Besides that I've also rolled v2 of my patches to also add support for specifying controller

[PATCH v8 1/4] ohci-platform: Add support for devicetree instantiation

2014-01-22 Thread Hans de Goede
for the ohci controller found on Allwinner sunxi SoCs. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Alan Stern st...@rowland.harvard.edu --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 22 +++ drivers/usb/host/ohci-platform.c | 164 ++--- 2 files

[PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 3 +++ drivers/usb

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 09:34 PM, Jonas Gorski wrote: Hi, On Wed, 22 Jan 2014 20:28:26 +0100 Hans de Goede hdego...@redhat.com wrote: Hi, On 01/21/2014 08:39 PM, Florian Fainelli wrote: 2014/1/21 Hans de Goede hdego...@redhat.com: This uses the already documented devicetree booleans

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 09:52 PM, Hans de Goede wrote: Hi, On 01/22/2014 09:34 PM, Jonas Gorski wrote: Hi, On Wed, 22 Jan 2014 20:28:26 +0100 Hans de Goede hdego...@redhat.com wrote: Hi, On 01/21/2014 08:39 PM, Florian Fainelli wrote: 2014/1/21 Hans de Goede hdego...@redhat.com: This uses

[PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-21 Thread Hans de Goede
This uses the already documented devicetree booleans for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/host/Kconfig | 3 +++ drivers/usb/host/ehci-platform.c | 33 +++-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-21 Thread Hans de Goede
Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 3 +++ drivers/usb/host/Kconfig | 4

Re: [PATCH 1/2] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 05:40 PM, Alan Stern wrote: On Tue, 21 Jan 2014, Hans de Goede wrote: Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings. Signed-off-by: Hans de Goede hdego...@redhat.com --- a/drivers/usb/host/Kconfig +++ b

Re: [PATCH v7 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-21 Thread Hans de Goede
Hi, On 01/21/2014 06:59 PM, Sergei Shtylyov wrote: Hello. On 01/15/2014 10:24 PM, Hans de Goede wrote: Add support for ohci-platform instantiation from devicetree, including optionally getting clks and a phy from devicetree, and enabling / disabling those on power_on / off. This should

Re: [PATCH v7 0/2] ohci and ehci-platform clks, phy and dt support

2014-01-18 Thread Hans de Goede
Hi, On 01/17/2014 06:12 PM, Alan Stern wrote: On Thu, 16 Jan 2014, Florian Fainelli wrote: Le mercredi 15 janvier 2014, 15:26:21 Alan Stern a �crit : On Wed, 15 Jan 2014, Hans de Goede wrote: Hi All, This version of my ohci and ehci-platform clks, phy and dt support patch-set, really fixes

Re: [linux-sunxi] Re: [PATCH] ARM: sunxi: Add driver for sunxi usb phy

2014-01-16 Thread Hans de Goede
Hi, On 01/16/2014 08:07 AM, Chen-Yu Tsai wrote: Hi Hans, On Wed, Jan 15, 2014 at 11:48 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 01/15/2014 04:00 PM, Kishon Vijay Abraham I wrote: On Wednesday 15 January 2014 04:28 AM, Hans de Goede wrote: [...] +static int sun4i_usb_phy_init

<    4   5   6   7   8   9   10   11   12   >