Re: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

2012-09-18 Thread Richard Zhao
On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote: > Dear Richard Zhao, > > You know, commit message would be nice to have. Yes, but for this one, the title shows obviously what it changed, doesn't it? Thanks Richard > > > Signed-off-by: Richard Zhao > &g

Re: [PATCH v2 10/11] USB: chipidea: add set_vbus_power support

2012-09-18 Thread Richard Zhao
Alex, I find you dropped this too. Did you mean to add it after otg driver or any other reason? Thanks Richard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

[PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

2012-09-18 Thread Richard Zhao
Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 307651b..0942b9b 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

Re: [PATCH] USB: chipidea: use OTGSC_BSV to detect vbus valid

2012-09-18 Thread Richard Zhao
On Mon, Sep 17, 2012 at 04:52:59PM +0800, Chen Peter-B29397 wrote: > > > > > > > OTGSC_AVVIS cannot be set when vbus voltage goes valid or invalid on > > imx, so convert to use OTGSC_BSV. > > > > Not just on imx, from the IC guys, it is chipidea's feature. > the AVVIS will not go to 1 when

Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-18 Thread Richard Zhao
On Mon, Sep 17, 2012 at 01:06:21PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > Signed-off-by: Richard Zhao > > Acked-by: Felipe Balbi > > Felipe said, > > > if you add a commit log you can add my: > > > > Acked-by: Felip

[PATCH v3] USB: mxs-phy: add basic otg support

2012-09-17 Thread Richard Zhao
Signed-off-by: Richard Zhao Acked-by: Felipe Balbi --- Changes from v2: - assign host/gadget in mxs_phy_set_host/mxs_phy_set_peripheral drivers/usb/otg/mxs-phy.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-17 Thread Richard Zhao
On Fri, Sep 14, 2012 at 01:25:25PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Sep 12, 2012 at 01:47:54PM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Tue, Sep 11, 2012 at 10:23:55AM +0300, Alex

[PATCH] USB: chipidea: use OTGSC_BSV to detect vbus valid

2012-09-17 Thread Richard Zhao
OTGSC_AVVIS cannot be set when vbus voltage goes valid or invalid on imx, so convert to use OTGSC_BSV. OTGSC_BSVIE and OTGSC_BSVIS is not cleared when hw_device_reset, so we don't need to call hw_enable_vbus_intr after hw_device_reset. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Richard Zhao
On Fri, Sep 14, 2012 at 04:56:13PM +0800, Chen Peter-B29397 wrote: > > > diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c > > index c1a67cb..6a03e97 100644 > > --- a/drivers/usb/otg/mxs-phy.c > > +++ b/drivers/usb/otg/mxs-phy.c > > @@ -97,12 +97,24 @@ static int mxs_phy_on_disco

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-14 Thread Richard Zhao
On Wed, Sep 12, 2012 at 01:47:54PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, Sep 11, 2012 at 10:23:55AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alex

Re: [PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-09-14 Thread Richard Zhao
On Wed, Sep 12, 2012 at 01:39:01PM +0300, Heikki Krogerus wrote: > Hi, > > On Tue, Aug 28, 2012 at 03:03:12PM +0800, Richard Zhao wrote: > > +static int mxs_phy_set_host(struct usb_otg *otg, struct usb_bus *host) > > +{ > > Shouldn't you at least save the host po

Re: [patch] USB: chipidea: fix & vs | bug

2012-09-13 Thread Richard Zhao
On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > There is a '&' vs '|' typo in the original code so the condition is > never true and we don't queue the work. > > Signed-off-by: Dan Carpenter > --- > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 2

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-11 Thread Richard Zhao
On Tue, Sep 11, 2012 at 10:23:55AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alex

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-07 Thread Richard Zhao
On Thu, Sep 06, 2012 at 05:18:29PM +0200, Marc Kleine-Budde wrote: > On 09/06/2012 05:15 PM, Richard Zhao wrote: > > Hi Marc, > > > > usbmisc_imx6q.c is only for imx6x. And for a certain running kernel, > > there will be always one driver instance. > > It

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-06 Thread Richard Zhao
Hi Marc, usbmisc_imx6q.c is only for imx6x. And for a certain running kernel, there will be always one driver instance. Thanks Richard On Thu, Sep 06, 2012 at 02:37:59PM +0200, Marc Kleine-Budde wrote: > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx6q.c |9 +

Re: [PATCH 1/2] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-09-06 Thread Richard Zhao
Hi Marc, Thanks for your patch. It's good. Richard On Thu, Sep 06, 2012 at 02:37:58PM +0200, Marc Kleine-Budde wrote: > While there fix a potential race condition, first set usbmisc, then call > usbmisc_set_ops(). > > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx6q

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Richard Zhao
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: > On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: > > On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: > > >>> Since it's already a common function, we may give phandler > > >>> property > > >>

Re: [PATCH v3 4/5] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-09-06 Thread Richard Zhao
> > Cc: Richard Zhao > Signed-off-by: Marc Kleine-Budde Reviewed-by: Richard Zhao > --- > drivers/usb/chipidea/udc.c | 23 +++ > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipi

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-09-04 Thread Richard Zhao
On Wed, Aug 29, 2012 at 06:46:00PM +0800, Richard Zhao wrote: > On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alexander Shishkin wrote: > > Richard Zhao writes: > > > > > On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote: > > >> Richard Zhao wri

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-09-04 Thread Richard Zhao
50:08AM +0300, Alexander Shishkin wrote: > >>>> Richard Zhao writes: > >>>> > >>>>> i.MX usb controllers shares non-core registers, which may include > >>>>> SoC specific controls. We take it as a usbmisc device and usbmisc > >>

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-04 Thread Richard Zhao
On Tue, Sep 04, 2012 at 03:58:50PM +0200, Marc Kleine-Budde wrote: > On 09/04/2012 03:45 PM, Felipe Balbi wrote: > > On Tue, Sep 04, 2012 at 12:31:14PM +0200, Marc Kleine-Budde wrote: > >> On 08/29/2012 10:11 PM, Marc Kleine-Budde wrote: > >> [...] > >> > +struct usb_phy *devm_usb_get_phy_

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 01:18:10PM +0300, Alexander Shishkin wrote: > Sascha Hauer writes: > > > On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > i.MX usb controllers shares non-core regist

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alex

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 12:44:40PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alex

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > One role failed, but the other role will possibll

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: > >> Richard Zhao writes: > >> > >> > States in gadget are not needed any more, set it

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-29 Thread Richard Zhao
On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver set operations need

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 03:42:07PM +0200, Marc Kleine-Budde wrote: > On 08/27/2012 12:36 PM, Marc Kleine-Budde wrote: > [...] > > +return usb_add_phy(&mxs_phy->phy, USB_PHY_TYPE_USB2); > >>> Why is it usb2? It's kind of USB_PHY_TYPE_DT. > >> > >> For now there is USB_PHY_T

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 07:43:11PM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde > wrote: > > On 08/24/2012 08:46 AM, Richard Zhao wrote: > > [...] > >>> /** > >>> + * devm_usb_get_phy_by_phan

Re: [PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 04:51:51PM +0200, Michael Grzeschik wrote: > Hi, > > On Tue, Aug 28, 2012 at 02:58:27PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and u

Re: [PATCH] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 12:52:19PM +0200, Marc Kleine-Budde wrote: > On 08/28/2012 12:46 PM, Richard Zhao wrote: > > On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote: > >> If udc_start() fails the qh_pool dma-pool cannot be closed because > >> it's

Re: [PATCH] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 12:31:25PM +0200, Marc Kleine-Budde wrote: > If udc_start() fails the qh_pool dma-pool cannot be closed because > it's still in use. This patch factors out the dma_pool_free() loop > into destroy_eps() and calls it in the error path of udc_start(), > too.

Re: [PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > One role failed, but the other role will possiblly still work. > > For example, when udc start failed, if plug in a host device, > > it works. > > If you're a host

Re: [PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-28 Thread Richard Zhao
On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > States in gadget are not needed any more, set it to zero. > > It's generally a good practice to mention in the commit message what is > it that you are fixing with this pat

[PATCH v2 11/11] USB: chipidea: re-order irq handling to avoid unhandled irq

2012-08-28 Thread Richard Zhao
- let role driver handle irq before ID change check. It give the role driver a chance to handle disconnect. - disable irq during switch role. No role driver to handle irq in the period. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c | 21 + 1 file changed

[PATCH v2 10/11] USB: chipidea: add set_vbus_power support

2012-08-28 Thread Richard Zhao
set_vbus_power is used to enable or disable vbus power for usb host. [Marc Kleine-Budde : fix regulator unbalance disable] Signed-off-by: Richard Zhao --- drivers/usb/chipidea/ci13xxx_imx.c | 44 +--- drivers/usb/chipidea/host.c|8 +++ include

[PATCH v2 09/11] USB: chipidea: add -DDEBUG if CONFIG_USB_CHIPIDEA_DEBUG

2012-08-28 Thread Richard Zhao
Signed-off-by: Richard Zhao --- drivers/usb/chipidea/Makefile |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile index 57e510f..d92ca32 100644 --- a/drivers/usb/chipidea/Makefile +++ b/drivers/usb/chipidea/Makefile @@ -1,3 +1,5

[PATCH v2 08/11] USB: chipidea: convert to use devm_request_irq

2012-08-28 Thread Richard Zhao
Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 8fd390a..7485c84 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c

[PATCH v2 07/11] USB: chipidea: add vbus detect for udc

2012-08-28 Thread Richard Zhao
Using vbus valid interrupt to detect vbus. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/ci.h |1 + drivers/usb/chipidea/udc.c | 39 ++- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb

[PATCH v2 06/11] USB: mxs-phy: add basic otg support

2012-08-28 Thread Richard Zhao
Signed-off-by: Richard Zhao --- drivers/usb/otg/mxs-phy.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c index c1a67cb..6a03e97 100644 --- a/drivers/usb/otg/mxs-phy.c +++ b/drivers/usb/otg/mxs-phy.c @@ -97,12

[PATCH v2 05/11] USB: chipidea: don't let probe fail if otg controller start one role failed

2012-08-28 Thread Richard Zhao
One role failed, but the other role will possiblly still work. For example, when udc start failed, if plug in a host device, it works. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH v2 04/11] USB: chipidea: clear gadget struct at udc_start fail path

2012-08-28 Thread Richard Zhao
States in gadget are not needed any more, set it to zero. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/udc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index c7a032a..9fb6394 100644 --- a/drivers/usb/chipidea/udc.c

[PATCH v2 03/11] USB: chipidea: move OTGSC_IDIS clearing from ci_role_work to irq handler

2012-08-28 Thread Richard Zhao
OTGSC_IDIS must be cleared in irq handler to avoid re-queue the work. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 3c3ed77..19ef324 100644

[PATCH v2 02/11] USB: chipidea: delay 2ms before read ID status at probe time

2012-08-28 Thread Richard Zhao
The ID pin needs 1ms debounce time, event at probe time. We delay 2ms for safe. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 1083585..3c3ed77 100644 --- a

[PATCH v2 01/11] USB: chipidea: imx: add pinctrl support

2012-08-28 Thread Richard Zhao
Some controllers may not need to setup pinctrl, so we don't fail the probe if pinctrl get/select failed. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/ci13xxx_imx.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chi

[PATCH v2 00/11] chipidea/imx: add otg support and some bug fix

2012-08-28 Thread Richard Zhao
patch series. - remove regulater_disable and old comments in ci13xxx_imx. Richard Zhao (11): USB: chipidea: imx: add pinctrl support USB: chipidea: delay 2ms before read ID status at probe time USB: chipidea: move OTGSC_IDIS clearing from ci_role_work to irq handler USB: chipidea: clear

[PATCH v6 2/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-08-27 Thread Richard Zhao
Signed-off-by: Richard Zhao Acked-by: Sascha Hauer --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk

[PATCH v6 3/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-08-27 Thread Richard Zhao
- add usbmisc device - set property fsl,usbmisc for usb controllers - set disable-over-current for imx6q-sabrelite usb otg Signed-off-by: Richard Zhao Acked-by: Sascha Hauer --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 10 ++ 2 files

[PATCH v6 1/3] USB: chipidea: add imx usbmisc support

2012-08-27 Thread Richard Zhao
-off-by: Richard Zhao Acked-by: Sascha Hauer --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 + .../devicetree/bindings/usb/usbmisc-imx.txt| 14 ++ drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci13xxx_imx.c | 64

[PATCH v6 0/3] imx: add usbmisc support

2012-08-27 Thread Richard Zhao
usbmisc driver handles the SoC specific non-core usb registers. Changes since last version: goto err when usbmisc_ops->init failed rather than return directly. Richard Zhao (3): USB: chipidea: add imx usbmisc support ARM: imx6q: clk_register_clkdev usbmisc clock ARM: dts: imx6q-sabrel

Re: [PATCH] usb: chipidea: ci13xxx_imx: fix regulator unbalance disable

2012-08-27 Thread Richard Zhao
oves the leftover > regulator_disable(). > > Cc: Richard Zhao > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/ci13xxx_imx.c |6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/usb/chipidea/ci13xxx_imx.c > b/drivers/usb/chipide

Re: chipidea driver

2012-08-27 Thread Richard Zhao
On Fri, Aug 24, 2012 at 10:34:37AM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: > >> Hello, > > Hi, > > >> Michael and I have a bunch of updates and improvement for

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread Richard Zhao
On Mon, Aug 27, 2012 at 03:01:43PM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Aug 27, 2012 at 12:55 PM, Richard Zhao > wrote: > > On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: > >> Hi, > >> > >> On Sat, Aug 25, 20

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-27 Thread Richard Zhao
On Mon, Aug 27, 2012 at 11:04:58AM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Sat, Aug 25, 2012 at 3:33 PM, Marc Kleine-Budde > wrote: > > On 08/24/2012 08:51 AM, Richard Zhao wrote: > >> On Thu, Aug 23, 2012 at 07:22:54PM +0200, Marc Kleine-Budde wrote: > &g

Re: [PATCH 1/4] usb: chipidea: udc: fix error path in udc_start()

2012-08-24 Thread Richard Zhao
On Thu, Aug 23, 2012 at 07:30:44PM +0200, Marc Kleine-Budde wrote: > This patch fixes the error path of udc_start(). Now NULL is used to > unset the peripheral with otg_set_peripheral(). > > Signed-off-by: Marc Kleine-Budde Reviewed-by: Richard Zhao > --- > drivers/usb/chi

Re: [PATCH 3/3] usb: mxs-phy: register phy as USB_PHY_TYPE_USB2

2012-08-23 Thread Richard Zhao
On Thu, Aug 23, 2012 at 07:22:54PM +0200, Marc Kleine-Budde wrote: > This patch registers the msx-phy as an USB_PHY_TYPE_USB2. This is needed to > get > reference to the phy with devm_usb_get_phy_by_phandle(), which will be added > in > a later patch. > > Signed-off-by: Marc Kleine-Budde > ---

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-08-23 Thread Richard Zhao
valid phy type is removed (now it's just a debug message if a user tries to > add a phy with undefined type). This also allows to add multiple phys of same > type. > > Cc: Richard Zhao > Cc: Marek Vasut > Signed-off-by: Kishon Vijay Abraham I > Signed-off-b

Re: chipidea driver

2012-08-23 Thread Richard Zhao
On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: > Hello, > > Michael and I have a bunch of updates and improvement for the chipidea > driver. They apply to Richard's tree: > > https://github.com/riczhao/kernel-imx/commits/topics/usb-driver > > What's the status of these patche

Re: [PATCH 1/3] usb: otg: Improve phy handling

2012-08-23 Thread Richard Zhao
On Thu, Aug 23, 2012 at 07:22:51PM +0200, Marc Kleine-Budde wrote: > This patch series improves the phy handling. > > The first patch fixes the problem that the phy driver, when build as module, > can be unloaded when the phy is in use. ci13xxx_imx also have a try_module_get. Thanks Richard > The

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Richard Zhao
On Tue, Aug 14, 2012 at 11:11:53AM +0800, Chen Peter-B29397 wrote: > > > > > > > > It is the same with i.mx28. > > If they're same, imx23 should be ok. The mxs_phy driver pass test > > on mx28. > > > I think Richard's patch should not > > > violate point 2. Richard, can you confirm it? > > You me

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Richard Zhao
On Tue, Aug 14, 2012 at 10:40:21AM +0800, Chen Peter-B29397 wrote: > > > > > > According to IC guys, the logic of handling HOSTDISCONDETECT is the > > same > > > between i.mx28 and i.mx23. > > > > As pointed out by Sean, on mx23 reference manual we have the following > > text describing HOSTDIS

[PATCH v5 1/3] USB: chipidea: add imx usbmisc support

2012-08-01 Thread Richard Zhao
-off-by: Richard Zhao --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 + .../devicetree/bindings/usb/usbmisc-imx.txt| 14 ++ drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci13xxx_imx.c | 64 drivers/usb/chipidea

[PATCH v5 3/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-08-01 Thread Richard Zhao
- add usbmisc device - set property fsl,usbmisc for usb controllers - set disable-over-current for imx6q-sabrelite usb otg Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 10 ++ 2 files changed, 11 insertions

[PATCH v5 2/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-08-01 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-imx6q.c @@ -405,6

[PATCH v5 0/3] imx: add usbmisc support

2012-08-01 Thread Richard Zhao
les. Richard Zhao (3): USB: chipidea: add imx usbmisc support ARM: imx6q: clk_register_clkdev usbmisc clock ARM: dts: imx6q-sabrelite: add usbmisc device .../devicetree/bindings/usb/ci13xxx-imx.txt|5 + .../devicetree/bindings/usb/usbmisc-imx.txt| 14 ++ arch/arm/boot/

Re: [PATCH v4 1/3] USB: chipidea: add imx usbmisc support

2012-07-31 Thread Richard Zhao
> Could it be that something is missing in this patch? I don't see struct > usbmisc_usb_device defined anywhere in this patch. ah, Sorry I missed the header file. I'll send a new version. Thanks Richard > > Sascha > > -- > Pengutronix e.K. |

[PATCH v4 3/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-31 Thread Richard Zhao
- add usbmisc device - set property fsl,usbmisc for usb controllers Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 10 ++ 2 files changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b

[PATCH v4 2/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-07-31 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-imx6q.c @@ -405,6

[PATCH v4 1/3] USB: chipidea: add imx usbmisc support

2012-07-31 Thread Richard Zhao
-off-by: Richard Zhao --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 + .../devicetree/bindings/usb/usbmisc-imx.txt| 14 ++ drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci13xxx_imx.c | 64 drivers/usb/chipidea

[PATCH v4 0/3] imx: add usbmisc support

2012-07-31 Thread Richard Zhao
usbmisc driver handles the SoC specific non-core usb registers. Changes since last version: - rebase onto torvalds latest git tree - use phandle linke usb controllers and usbmisc device. It also make usbmisc driver possible to be kernel modules. Richard Zhao (3): USB: chipidea: add imx

Re: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-31 Thread Richard Zhao
On Tue, Jul 31, 2012 at 09:06:33AM +0800, Chen Peter-B29397 wrote: > > > > > > > <&usbmisc 0> would then mean port 0 of the usbmisc device. > > I didn't add the restriction that a usbmisc driver must have a usbmisc > > device. I'm not sure whether all SoC and future SoC can be look as > > a devic

Re: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-30 Thread Richard Zhao
On Mon, Jul 30, 2012 at 11:32:44AM +0200, Sascha Hauer wrote: > On Thu, Jul 26, 2012 at 06:35:14PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-30 Thread Richard Zhao
On Thu, Jul 26, 2012 at 06:59:48PM +0800, Richard Zhao wrote: > On Thu, Jul 19, 2012 at 10:05:54AM +0800, Richard Zhao wrote: > > On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > > > On Thu, Jul 12, 2012 at 03:01:40PM +0800, Richard Zhao wrote: > > > &

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-26 Thread Richard Zhao
On Thu, Jul 19, 2012 at 10:05:54AM +0800, Richard Zhao wrote: > On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > > On Thu, Jul 12, 2012 at 03:01:40PM +0800, Richard Zhao wrote: > > > The patch set is tested on imx6q_sabrelite board. > > > > > > The pa

[PATCH v3 3/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-07-26 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-imx6q.c @@ -405,6

[PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-26 Thread Richard Zhao
-off-by: Richard Zhao --- .../devicetree/bindings/usb/ci13xxx-imx.txt|2 + .../devicetree/bindings/usb/usbmisc-imx.txt| 12 ++ drivers/usb/chipidea/Makefile |3 +- drivers/usb/chipidea/ci13xxx_imx.c | 72 - drivers/usb

[PATCH v3 2/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-26 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 18 ++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts index

[PATCH v3 0/3] imx: add usbmisc support

2012-07-26 Thread Richard Zhao
es as a seperate patch Richard Zhao (3): USB: chipidea: add imx usbmisc support ARM: dts: imx6q-sabrelite: add usbmisc device ARM: imx6q: clk_register_clkdev usbmisc clock .../devicetree/bindings/usb/ci13xxx-imx.txt|2 + .../devicetree/bindings/usb/usbmisc-imx.txt|

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
On Mon, Jul 23, 2012 at 02:21:06PM +0300, Felipe Balbi wrote: > On Mon, Jul 23, 2012 at 07:13:52PM +0800, Richard Zhao wrote: > > On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote: > > > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > > &g

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote: > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > > On 07/23/2012 11:27 AM, Richard Zhao wrote: > > >> This patch looks like a recipe for disaster IMHO, but it's Alex's call. > >

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
> > This patch looks like a recipe for disaster IMHO, but it's Alex's call. Well, if there's any better place to hold it, I'd like to move there. Another place is arch/arm/mach-imx. Sascha/Shawn who are maintainers of imx are also in cc list. Thanks Richard > > -- > balbi -- To unsubscribe f

Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios

2012-07-18 Thread Richard Zhao
On Tue, Jul 17, 2012 at 02:30:17PM +0200, Dirk Behme wrote: > On 13.06.2012 14:34, Richard Zhao wrote: > >Sometimes, boards have gpios that don't own by any driver or owner > >by a generic driver that don't like hacks. Such gpios is normally > >output and need set

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-18 Thread Richard Zhao
On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > On Thu, Jul 12, 2012 at 03:01:40PM +0800, Richard Zhao wrote: > > The patch set is tested on imx6q_sabrelite board. > > > > The patch can also be found at > > https://github.com/riczhao/kernel-imx/commits/top

Re: [PATCH v2 2/2] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 11:00:38PM +0800, Shawn Guo wrote: > On Wed, Jul 18, 2012 at 06:29:07PM +0800, Richard Zhao wrote: > > Signed-off-by: Richard Zhao > > --- > > arch/arm/boot/dts/imx6q-sabrelite.dts |4 > > arch/arm/boot/dts/imx6q.dtsi | 19 ++

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 03:43:00PM +0200, Marc Kleine-Budde wrote: > On 07/18/2012 03:39 PM, Richard Zhao wrote: > > [snip] > >>>> static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata > >>>> = { > >>>> .name

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
[snip] > > > static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata > > > = { > > > .name = "ci13xxx_imx", > > > .flags = CI13XXX_REQUIRE_TRANSCEIVER | > > > @@ -120,6 +140,9 @@ static int __devinit ci13xxx_imx_probe(struct > > > platform_d

Re: [PATCH v2 2/2] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 12:54:31PM +0200, Sascha Hauer wrote: > On Wed, Jul 18, 2012 at 06:29:07PM +0800, Richard Zhao wrote: > > Signed-off-by: Richard Zhao > > --- > > arch/arm/boot/dts/imx6q-sabrelite.dts |4 > > arch/arm/boot/dts

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 12:52:04PM +0200, Sascha Hauer wrote: > On Wed, Jul 18, 2012 at 06:29:06PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver

[PATCH v2 2/2] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-18 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q-sabrelite.dts |4 arch/arm/boot/dts/imx6q.dtsi | 19 +++ arch/arm/mach-imx/clk-imx6q.c |1 + 3 files changed, 20 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6q

[PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
-off-by: Richard Zhao --- .../devicetree/bindings/usb/ci13xxx-imx.txt|2 + .../devicetree/bindings/usb/usbmisc-imx.txt| 12 ++ drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci13xxx_imx.c | 23 +++ drivers/usb/chipidea

[PATCH v2 0/2] imx: add usbmisc support

2012-07-18 Thread Richard Zhao
usbmisc driver handles the SoC specific non-core usb registers. It's based on Greg's usb-next. Changes since last version: - rework to let usb-imxXXX drivers register ops callbacks Richard Zhao (2): USB: chipidea: add imx usbmisc support ARM: dts: imx6q-sabrelite: add usbm

Re: [PATCH] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-07-16 Thread Richard Zhao
Hi Alex, Could you please also review & ack this patch? Thanks Richard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/12] USB: chipidea: add set_vbus_power support

2012-07-16 Thread Richard Zhao
On Mon, Jul 16, 2012 at 02:10:23PM +0200, Marc Kleine-Budde wrote: > On 07/12/2012 09:01 AM, Richard Zhao wrote: > > set_vbus_power is used to enable or disable vbus power for usb host. > > > > Signed-off-by: Richard Zhao > > --- > > drivers/

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-16 Thread Richard Zhao
On Mon, Jul 16, 2012 at 10:25:20AM +0200, Sascha Hauer wrote: > On Thu, Jul 12, 2012 at 03:01:52PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > dr

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-15 Thread Richard Zhao
t in discrete files. - Where to put it Option 1: arch/arm/mach-imx/ehci-imxXXX.c Option 2: drivers/usb/chipidea/imx/ , yes, we may need a folder. Both is fine for me. On Fri, Jul 13, 2012 at 04:14:27PM +0200, Marc Kleine-Budde wrote: > On 07/13/2012 04:02 PM, Richard Zhao wrote: > > On F

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-13 Thread Richard Zhao
On Fri, Jul 13, 2012 at 02:25:45PM +0200, Michael Grzeschik wrote: > On Thu, Jul 12, 2012 at 03:01:52PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > dr

Re: [PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-12 Thread Richard Zhao
[snip] > --- /dev/null > +++ b/drivers/usb/chipidea/imx_usbmisc.c > @@ -0,0 +1,144 @@ > +/* > + * Copyright 2012 Freescale Semiconductor, Inc. > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + *

[PATCH 11/12] USB: chipidea: re-order irq handling to avoid unhandled irq

2012-07-12 Thread Richard Zhao
- let role driver handle irq before ID change check. It give the role driver a chance to handle disconnect. - disable irq during switch role. No role driver to handle irq in the period. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/core.c | 21 + 1 file changed

[PATCH 12/12] USB: chipidea: add imx usbmisc support

2012-07-12 Thread Richard Zhao
. Signed-off-by: Richard Zhao --- .../devicetree/bindings/usb/imx-usbmisc.txt| 15 ++ drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci13xxx_imx.c |4 + drivers/usb/chipidea/imx_usbmisc.c | 144 4

[PATCH 10/12] USB: chipidea: add set_vbus_power support

2012-07-12 Thread Richard Zhao
set_vbus_power is used to enable or disable vbus power for usb host. Signed-off-by: Richard Zhao --- drivers/usb/chipidea/ci13xxx_imx.c | 39 +--- drivers/usb/chipidea/host.c|8 include/linux/usb/chipidea.h |2 ++ 3 files changed

  1   2   >