[PATCH v2 0/2] ARM: shmobile: lager: USBHS callback elimination

2014-07-10 Thread Ulrich Hecht
Changes in v2: - move phy handle to struct usbhs_priv - add new default pipe type to driver - remove pipe type from Lager board code Ulrich Hecht (2): usb: renesas_usbhs: add R-Car Gen. 2 init and power control ARM: shmobile: lager: remove USBHS callbacks arch/arm/mach-shmobile/board

[PATCH v2 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control

2014-07-10 Thread Ulrich Hecht
In preparation for DT conversion to reduce reliance on platform device callbacks. Signed-off-by: Ulrich Hecht ulrich.hecht+rene...@gmail.com --- drivers/usb/renesas_usbhs/Makefile | 2 +- drivers/usb/renesas_usbhs/common.c | 66 ++--- drivers/usb/renesas_usbhs

[PATCH v2 2/2] ARM: shmobile: lager: remove USBHS callbacks

2014-07-10 Thread Ulrich Hecht
Let the driver handle initialization and power control. Signed-off-by: Ulrich Hecht ulrich.hecht+rene...@gmail.com --- arch/arm/mach-shmobile/board-lager.c | 126 --- 1 file changed, 13 insertions(+), 113 deletions(-) diff --git a/arch/arm/mach-shmobile/board

Re: [PATCH 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control

2014-07-09 Thread Ulrich Hecht
On Wed, Jul 9, 2014 at 2:08 AM, Kuninori Morimoto kuninori.morimoto...@gmail.com wrote: Hi Ulrich Thank you for your patch Thank you for your review. @@ -186,6 +192,8 @@ struct renesas_usbhs_platform_info { * driver use these param for some register */ struct

[PATCH 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control

2014-07-08 Thread Ulrich Hecht
In preparation for DT conversion to reduce reliance on platform device callbacks. Signed-off-by: Ulrich Hecht ulrich.hecht+rene...@gmail.com --- drivers/usb/renesas_usbhs/Makefile | 2 +- drivers/usb/renesas_usbhs/common.c | 39 --- drivers/usb/renesas_usbhs/rcar2.c | 76

[PATCH 2/2] ARM: shmobile: lager: remove USBHS callbacks

2014-07-08 Thread Ulrich Hecht
Let the driver handle initialization and power control. Signed-off-by: Ulrich Hecht ulrich.hecht+rene...@gmail.com --- arch/arm/mach-shmobile/board-lager.c | 109 +-- 1 file changed, 15 insertions(+), 94 deletions(-) diff --git a/arch/arm/mach-shmobile/board

Re: [PATCH 0/9] USB 2.0 host on Lager

2013-11-21 Thread Ulrich Hecht
On Wed, Nov 20, 2013 at 10:07 PM, Valentine valentine.bars...@cogentembedded.com wrote: On 11/20/2013 09:37 PM, Ulrich Hecht wrote: I chose to do incremental patches on top of Valentine's stuff because his patches are already in various states of upstream acceptance; Why re-post them

Re: [PATCH 7/9] ARM: shmobile: r8a7790: add internal PCI clock

2013-11-21 Thread Ulrich Hecht
On Wed, Nov 20, 2013 at 10:18 PM, Valentine valentine.bars...@cogentembedded.com wrote: On 11/20/2013 09:38 PM, Ulrich Hecht wrote: + [MSTP703] = SH_CLK_MSTP32(mp_clk, SMSTPCR7, 3, 0), /* EHCI */ The comment to the above line is a bit misleading. The comments reflect the labels given

Re: [PATCH 9/9] ARM: shmobile: lager: add PCI USB host controllers

2013-11-21 Thread Ulrich Hecht
On Wed, Nov 20, 2013 at 10:24 PM, Valentine valentine.bars...@cogentembedded.com wrote: On 11/20/2013 09:38 PM, Ulrich Hecht wrote: + usb_bind_phy(:00:01.0, 0, usb_phy_rcar_gen2); + usb_bind_phy(:00:02.0, 0, usb_phy_rcar_gen2); You don't seem to register PCI controller 0

[PATCH 0/9] USB 2.0 host on Lager

2013-11-20 Thread Ulrich Hecht
to do incremental patches on top of Valentine's stuff because his patches are already in various states of upstream acceptance; please tell me if you need this packaged differently. CU Uli Ulrich Hecht (4): pci: rcar-gen2: enable clock ARM: shmobile: r8a7790: add internal PCI clock usb: phy

[PATCH 1/9] pci: Add R-Car Gen2 internal PCI support

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak valentine.bars...@cogentembedded.com This adds internal PCI controller driver for R-Car Gen2 SoC. There are three PCI controllers available with only a single EHCI/OHCI device built-in on each PCI bus. This gives us three USB channels. Channel 0 is shared with the USBHS

[PATCH 2/9] usb: hcd: Remove USB phy if needed

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak valentine.bars...@cogentembedded.com This adds remove_phy flag to the HCD structure. If the flag is set and if hcd-phy is valid, the phy is shutdown and released whenever usb_add_hcd fails or usb_hcd_remove is called. This can be used by the HCD drivers to auto-remove the

[PATCH 3/9] usb: hcd: Initialize USB phy if needed

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak valentine.bars...@cogentembedded.com This adds external USB phy support to USB HCD driver that allows to find and initialize external USB phy, bound to the HCD, when the HCD is added. The usb_add_hcd function returns -EPROBE_DEFER if the USB phy, bound to the HCD, is not

[PATCH 6/9] pci: rcar-gen2: enable clock

2013-11-20 Thread Ulrich Hecht
Makes the PCI host controllers come alive. Signed-off-by: Ulrich Hecht ulrich.he...@gmail.com --- drivers/pci/host/pci-rcar-gen2.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c index cbaa5c4..568ff8e 100644

[PATCH 8/9] usb: phy: rcar-gen2: register using usb_add_phy_dev()

2013-11-20 Thread Ulrich Hecht
Allows binding of PCI USB host controllers to this phy. Signed-off-by: Ulrich Hecht ulrich.he...@gmail.com --- drivers/usb/phy/phy-rcar-gen2-usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c

[PATCH 7/9] ARM: shmobile: r8a7790: add internal PCI clock

2013-11-20 Thread Ulrich Hecht
Adds clock for internal PCI host controllers. Signed-off-by: Ulrich Hecht ulrich.he...@gmail.com --- arch/arm/mach-shmobile/clock-r8a7790.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c

[PATCH 4/9] usb: phy: Add RCAR Gen2 USB phy

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak valentine.bars...@cogentembedded.com This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and USBHS/USBSS devices. It also controls internal USBHS phy. Signed-off-by: Valentine Barshak

[PATCH 5/9] arm: shmobile: lager: Add USBHS support

2013-11-20 Thread Ulrich Hecht
From: Valentine Barshak valentine.bars...@cogentembedded.com This adds USBHS PHY and registers USBHS device if the driver is enabled. Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com Acked-by: Kuninori Morimoto kuninori.morimoto...@renesas.com ---

[PATCH 9/9] ARM: shmobile: lager: add PCI USB host controllers

2013-11-20 Thread Ulrich Hecht
Adds USB1 and 2 as hosts and binds them to the USB phy. Signed-off-by: Ulrich Hecht ulrich.he...@gmail.com --- arch/arm/mach-shmobile/Kconfig | 1 + arch/arm/mach-shmobile/board-lager.c | 23 +++ 2 files changed, 24 insertions(+) diff --git a/arch/arm/mach-shmobile

Re: [PATCH] usb: phy: Move R-Car Gen2 driver registration to postcore_inictall

2013-10-31 Thread Ulrich Hecht
On Thu, Oct 31, 2013 at 12:43 PM, Valentine valentine.bars...@cogentembedded.com wrote: Please, let me know if you see better options. How about disregarding the whole PCI aspect? I mean, yes, those are PCI busses, but they are internal, with a fixed set of devices attached, and as far as I can