Re: About wakeup IRQ support in USB core

2014-11-17 Thread Wang, Yu
On Mon, Nov 17, 2014 at 10:46:25AM +0100, Oliver Neukum wrote: On Mon, 2014-11-17 at 13:51 +0800, Wang, Yu wrote: Hi Roger, I saw one old thread about your patch for wakeup IRQ support in USB core. We need it for Intel platform. And it is work well on intel platform. May I know why

Re: About wakeup IRQ support in USB core

2014-11-17 Thread Wang, Yu
On Mon, Nov 17, 2014 at 11:20:01AM +0100, Oliver Neukum wrote: On Mon, 2014-11-17 at 17:47 +0800, Wang, Yu wrote: On Mon, Nov 17, 2014 at 10:46:25AM +0100, Oliver Neukum wrote: On Mon, 2014-11-17 at 13:51 +0800, Wang, Yu wrote: Hi Roger, I saw one old thread about your patch for wakeup

Re: About wakeup IRQ support in USB core

2014-11-17 Thread Wang, Yu
On Mon, Nov 17, 2014 at 01:36:19PM +0200, Roger Quadros wrote: Hi Roger, Hi Yu, On 11/17/2014 07:51 AM, Wang, Yu wrote: Hi Roger, I saw one old thread about your patch for wakeup IRQ support in USB core. We need it for Intel platform. And it is work well on intel platform. May I know

About wakeup IRQ support in USB core

2014-11-16 Thread Wang, Yu
Hi Roger, I saw one old thread about your patch for wakeup IRQ support in USB core. We need it for Intel platform. And it is work well on intel platform. May I know why this patch haven't get merged so far? I saw everything was smooth during the discussion, and you had already fixed all comments

[RFC] xhci: free legacy irq in xhci driver.

2014-07-31 Thread Wang, Yu
From: Wang, Yu yu.y.w...@intel.com By current xhci ISR request/release flow, the IRQ request be done by xhci driver(xhci_run) whatever it is legacy irq or MSI. But the IRQ release flow is a little mess, MSI release be handled by xhci driver(xhci_stop), and legacy IRQ release be handled by USB

RE: [RFC] xhci: free legacy irq in xhci driver.

2014-07-31 Thread Wang, Yu Y
On Fri, Aug 01, 2014 at 11:00:08AM +0800, Wang, Yu wrote: From: Wang, Yu yu.y.w...@intel.com By current xhci ISR request/release flow, the IRQ request be done by xhci driver(xhci_run) whatever it is legacy irq or MSI. But the IRQ release flow is a little mess, MSI release be handled

[RFC] xhci: free legacy irq in xhci driver.

2014-07-31 Thread Wang, Yu
From: Wang, Yu yu.y.w...@intel.com By current xhci ISR request/release flow, the IRQ request be done by xhci driver(xhci_run) whatever it is legacy irq or MSI. But the IRQ release flow is a little mess, MSI release be handled by xhci driver(xhci_stop), and legacy IRQ release be handled by USB

[RFC] xhci: Fix xhci block system enter system suspend state.

2014-06-21 Thread Wang, Yu
From: Wang, Yu yu.y.w...@intel.com The system suspend flow as following: 1, Freeze all user processes and kenrel threads. 2, Trying to suspend all devices. 2.1, If pci device under RPM suspended state, then pci driver will try to resume it to RPM active state in prepare stage. 2.2, xhci_resume

RE: [Intel-linux-usb] RE: One question about Linux xHCI driver

2014-06-19 Thread Wang, Yu Y
On Thu, 19 Jun 2014, Wang, Yu Y wrote: I'm not sure of the right way to solve this problem. Probably xhci_resume() should check the root-hub statuses to see if either root hub really needs to be resumed before calling usb_hcd_resume_root_hub(); I think that will work. [Yu:] I

RE: [Intel-linux-usb] RE: One question about Linux xHCI driver

2014-06-18 Thread Wang, Yu Y
On Wed, 18 Jun 2014, Mathias Nyman wrote: On 06/17/2014 05:17 AM, Wang, Yu Y wrote: Hi All, I have one question about Linux xHCI driver. Need your help to introduce more backgrounds. About the S3 flow: 1, Freeze all user processes. 2, Freeze all kernel threads (including

Re: About the DRD mode implementation of DWC3 driver]

2014-04-15 Thread Wang, Yu
On Fri, Apr 11, 2014 at 06:19:57PM -0500, Felipe Balbi wrote: Hi, On Fri, Apr 11, 2014 at 10:23:38AM +0800, Wang, Yu wrote: Hi Balbi, At first, thank you to help give the response in patience. Hi, On Wed, Apr 09, 2014 at 02:08:32PM +0800, Wang, Yu wrote: Glad to see the OTG mode

Re: About the DRD mode implementation of DWC3 driver]

2014-04-15 Thread Wang, Yu
On Tue, Apr 15, 2014 at 09:53:49AM -0500, Felipe Balbi wrote: Hi, On Tue, Apr 15, 2014 at 06:29:20PM +0800, Wang, Yu wrote: On Fri, Apr 11, 2014 at 06:19:57PM -0500, Felipe Balbi wrote: Hi, On Fri, Apr 11, 2014 at 10:23:38AM +0800, Wang, Yu wrote: Hi Balbi, At first, thank you to help

About the DRD mode implementation of DWC3 driver]

2014-04-10 Thread Wang, Yu
Hi Balbi, At first, thank you to help give the response in patience. Hi, On Wed, Apr 09, 2014 at 02:08:32PM +0800, Wang, Yu wrote: Glad to see the OTG mode is prepare to support in your dwc3-role-switch branch. But it is not fit for intel Merrfield/Moorfield platforms. :( that's

About the DRD mode implementation of DWC3 driver

2014-04-09 Thread Wang, Yu
Hi Balbi, Glad to see the OTG mode is prepare to support in your dwc3-role-switch branch. But it is not fit for intel Merrfield/Moorfield platforms. :( The reason is we implemented DRD mode instead of OTG mode. So the GCTL.PortCapDir will be set as 01 for host mode, and 10 for device mode. And

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device. It does not want the xHCI generic driver to register an interrupt for it at all. The original code did that by setting the

RE: About the hibernation feature implementation in dwc3 driver

2013-08-15 Thread Wang, Yu Y
From: Wang, Yu Y [mailto:yu.y.w...@intel.com] Sent: Wednesday, August 14, 2013 8:09 PM From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, August 13, 2013 1:30 PM On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote: From: Felipe Balbi Sent: Tuesday

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
On Fri, Aug 16, 2013 at 02:22:43AM +, Wang, Yu Y wrote: On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device. It does not want the xHCI generic driver to register an interrupt

RE: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-15 Thread Wang, Yu Y
On Fri, Aug 16, 2013 at 04:01:50AM +, Wang, Yu Y wrote: On Fri, Aug 16, 2013 at 02:22:43AM +, Wang, Yu Y wrote: On Thu, Aug 15, 2013 at 06:43:59PM -0700, Sarah Sharp wrote: The xHCI platform driver calls into usb_add_hcd to register the irq for its platform device

RE: About the hibernation feature implementation in dwc3 driver

2013-08-14 Thread Wang, Yu Y
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, August 13, 2013 1:30 PM On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote: From: Felipe Balbi Sent: Tuesday, August 13, 2013 12:20 PM On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote: Hi

RE: About the hibernation feature implementation in dwc3 driver

2013-08-13 Thread Wang, Yu Y
Hi, On Tue, Aug 13, 2013 at 08:04:26PM +, Paul Zimmerman wrote: From: Felipe Balbi Sent: Tuesday, August 13, 2013 12:20 PM On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote: Hi Balbi, Please check the attached logs. The kernel base one kernel3.10

RE: DWC3 role switch cause IRQ request failed

2013-08-12 Thread Wang, Yu Y
On Fri, Aug 09, 2013 at 03:16:20PM +, Wang, Yu Y wrote: On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT

RE: DWC3 role switch cause IRQ request failed

2013-08-09 Thread Wang, Yu Y
On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: Hi Balbi, Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT and IRQF_SHARED. But xHCI driver will not set IRQF_ONESHOT. Then will met IRQ

RE: xHCI ISR be registered twice

2013-08-07 Thread Wang, Yu Y
they need to apply the patch. [Yu:] Get it. I will provide more details in the comment. Comments on the patch below. On Tue, Aug 06, 2013 at 11:08:04PM -0700, Wang, Yu Y wrote: Hi Balbi, Sarah, I found that when CONFIG_PCI is set, and xHCI driver register as platform device driver

RE: About the hibernation feature implementation in dwc3 driver

2013-08-05 Thread Wang, Yu Y
Hi Balbi, Please check the attached logs. The kernel base one kernel3.10. Thanks, Yu On Fri, Aug 02, 2013 at 03:42:20PM +, Wang, Yu Y wrote: Hi, On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: Check my comments as follows. weird, you sent plain text

RE: About the hibernation feature implementation in dwc3 driver

2013-08-03 Thread Wang, Yu Y
Hi, On Fri, Aug 02, 2013 at 03:42:20PM +, Wang, Yu Y wrote: Hi, On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: Check my comments as follows. weird, you sent plain text email, but there are no quotation marks... it makes it very difficult to read. Please

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
. And just use GCTL.PORTCAP to do the role switch. I haven't try this solution on intel platform. And not sure if is working with hibernation feature. Thanks, Regards, Yu -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, August 02, 2013 3:07 PM To: Wang, Yu Y Cc: ba

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
Hi Balibi, Check my comments as follows. Thanks, Regards, Yu -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, August 02, 2013 6:34 PM To: Wang, Yu Y Cc: ba...@ti.com; Li, Jiebing; Linux USB Mailing List; Zhuang, Jin Can; Wu, Hao; Yuan, Hang Subject: Re

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
Hi, On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: Check my comments as follows. weird, you sent plain text email, but there are no quotation marks... it makes it very difficult to read. Please go through our netiquette, there is a copy of that at [1] and also lots