Re: [PATCH] extcon: add MAX3355 driver

2015-11-10 Thread Sergei Shtylyov
Hello. On 11/10/2015 2:52 AM, Chanwoo Choi wrote: I received the reply from you after too long time (17~18day). You better to reply it more a little more quickly if you have the question or new patches. I've replied as soon as I had my new idea. MAX3355E chip integrates a charge pump

Re: [PATCH] extcon: add MAX3355 driver

2015-11-09 Thread Sergei Shtylyov
Hello. On 10/23/2015 08:56 AM, Chanwoo Choi wrote: MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID

Re: [PATCH] extcon: add MAX3355 driver

2015-11-09 Thread Chanwoo Choi
Hello, I received the reply from you after too long time (17~18day). You better to reply it more a little more quickly if you have the question or new patches. On 2015년 11월 10일 03:24, Sergei Shtylyov wrote: > Hello. > > On 10/23/2015 08:56 AM, Chanwoo Choi wrote: > >> MAX3355E chip

Re: [PATCH] extcon: add MAX3355 driver

2015-10-22 Thread Sergei Shtylyov
Hello. On 10/21/2015 05:57 AM, Chanwoo Choi wrote: I think this patch is too much delay. I recommend you better to develop this driver based on latest extcon-next branch[1]. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next I would really appreciate

Re: [PATCH] extcon: add MAX3355 driver

2015-10-22 Thread Chanwoo Choi
On 2015년 10월 21일 03:20, Sergei Shtylyov wrote: > Hello. > > On 12/18/2014 12:58 AM, Sergei Shtylyov wrote: > MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role

Re: [PATCH] extcon: add MAX3355 driver

2015-10-20 Thread Sergei Shtylyov
Hello. On 12/18/2014 12:58 AM, Sergei Shtylyov wrote: MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID

Re: [PATCH] extcon: add MAX3355 driver

2015-10-20 Thread Chanwoo Choi
Hi Sergei, I think this patch is too much delay. I recommend you better to develop this driver based on latest extcon-next branch[1]. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next Thanks, Chanwoo Choi On 2015년 10월 21일 03:20, Sergei Shtylyov wrote: >

Re: [PATCH] extcon: add MAX3355 driver

2014-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2014 03:31 AM, Chanwoo Choi wrote: MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID

Re: [PATCH] extcon: add MAX3355 driver

2014-12-16 Thread Chanwoo Choi
On 12/11/2014 08:28 AM, Sergei Shtylyov wrote: MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID signal

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Geert Uytterhoeven
On Thu, Dec 11, 2014 at 2:46 AM, Chanwoo Choi cw00.c...@samsung.com wrote: Could you send the datasheet of MAX3355E to me? First Google hit: http://datasheets.maximintegrated.com/en/ds/MAX3355E.pdf Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2014 4:46 AM, Chanwoo Choi wrote: I reviewed this patch quickly. This driver has just two gpio without any registers for IP. Because there are no registers. I wonder whether MAX3355E is separate chip to detect external connector Yes. I thought my description has

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Chanwoo Choi
On 12/11/2014 09:47 PM, Sergei Shtylyov wrote: Hello. On 12/11/2014 4:46 AM, Chanwoo Choi wrote: I reviewed this patch quickly. This driver has just two gpio without any registers for IP. Because there are no registers. I wonder whether MAX3355E is separate chip to detect

[PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Sergei Shtylyov
MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID signal from the USB OTG connector. On some Renesas

Re: [PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Chanwoo Choi
Hi Sergei, I reviewed this patch quickly. This driver has just two gpio without any registers for IP. I wonder whether MAX3355E is separate chip to detect external connector or just use gpio of AP. Could you send the datasheet of MAX3355E to me? Thanks, Chanwoo Choi On 12/11/2014 08:28 AM,