RE: [PATCH 02/12] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-28 Thread Alexander Shishkin
Chen Peter-B29397 b29...@freescale.com writes: hw_write(ci, OP_USBINTR, ~0, USBi_UI|USBi_UEI|USBi_PCI|USBi_URI|USBi_SLI); - hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS); } else { - hw_write(ci, OP_USBCMD, USBCMD_RS, 0);

RE: [PATCH 02/12] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-28 Thread Chen Peter-B29397
Hmm, gadget gets zeroed out on every gadget-whatever switch, but it also gets reinitialized on every whatever-gadget transition. And it really shouldn't cause a null dereference. When gadget-host, the call sequence like below: udc_stop - usb_del_gadget_udc - usb_gadget_remove_driver

Re: [PATCH 02/12] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-26 Thread Michael Grzeschik
Hi, On Thu, Sep 20, 2012 at 03:08:15PM +0800, Peter Chen wrote: On Wed, Sep 12, 2012 at 7:58 PM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de Add function to physicaly enable or disable of pullup connection on the

Re: [PATCH 02/12] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-20 Thread Peter Chen
On Wed, Sep 12, 2012 at 7:58 PM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de Add function to physicaly enable or disable of pullup connection on the USB-D+ line. The uvc gaget will fail, if this function is not implemented.

[PATCH 02/12] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-12 Thread Alexander Shishkin
From: Michael Grzeschik m.grzesc...@pengutronix.de Add function to physicaly enable or disable of pullup connection on the USB-D+ line. The uvc gaget will fail, if this function is not implemented. Cc: sta...@vger.kernel.org Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Acked-by: