* Bin Liu [160516 08:24]:
> Hi,
>
> On Mon, May 16, 2016 at 07:57:57AM -0700, Tony Lindgren wrote:
> > * Bin Liu [160516 07:17]:
> > > Hi,
> > >
> > > On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote:
> > > > On 5/14/2016 12:03 AM, Bin Liu wrote:
> > > >
> > > > >>At least 2430
Hi,
On Mon, May 16, 2016 at 07:57:57AM -0700, Tony Lindgren wrote:
> * Bin Liu [160516 07:17]:
> > Hi,
> >
> > On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote:
> > > On 5/14/2016 12:03 AM, Bin Liu wrote:
> > >
> > > >>At least 2430 glue layer pulls d+ high on start up even if th
* Bin Liu [160514 21:44]:
> Hi,
>
> On Fri, May 13, 2016 at 03:25:17PM -0700, Tony Lindgren wrote:
> > * Bin Liu [160513 15:04]:
> > >
> > > But what would be in musb_default_set_mode()? Currently only am35x,
> > > da8xx, dsps, and omap2430 glues implement _set_mode(), but they don't
> > > have
* Bin Liu [160516 07:17]:
> Hi,
>
> On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote:
> > On 5/14/2016 12:03 AM, Bin Liu wrote:
> >
> > >>At least 2430 glue layer pulls d+ high on start up even if there are
> > >>no gadgets configured. This is bad at least for anything using a sep
Hi,
On Sat, May 14, 2016 at 04:30:32PM +0300, Sergei Shtylyov wrote:
> On 5/14/2016 12:03 AM, Bin Liu wrote:
>
> >>At least 2430 glue layer pulls d+ high on start up even if there are
> >>no gadgets configured. This is bad at least for anything using a separate
> >>battery charger chip as it can
Hi,
On Fri, May 13, 2016 at 03:35:40PM -0700, Tony Lindgren wrote:
> * Tony Lindgren [160513 14:19]:
> > * Bin Liu [160513 14:05]:
> > > In stead of removing it, session bit should only be set when musb_mode
> > > == MUSB_HOST, will this fix the D+ pullup problem?
> >
> > Good point, I forgot a
Hi,
On Fri, May 13, 2016 at 03:25:17PM -0700, Tony Lindgren wrote:
> * Bin Liu [160513 15:04]:
> >
> > But what would be in musb_default_set_mode()? Currently only am35x,
> > da8xx, dsps, and omap2430 glues implement _set_mode(), but they don't
> > have any in common. Only omap2430 sets session
On 5/14/2016 12:03 AM, Bin Liu wrote:
At least 2430 glue layer pulls d+ high on start up even if there are
no gadgets configured. This is bad at least for anything using a separate
battery charger chip as it can confuse the charger detection.
Let's fix the issue by getting rid of omap2430_musb_
* Tony Lindgren [160513 14:19]:
> * Bin Liu [160513 14:05]:
> > In stead of removing it, session bit should only be set when musb_mode
> > == MUSB_HOST, will this fix the D+ pullup problem?
>
> Good point, I forgot about it being specific to host mode. I'll check.
Yeah good call, the patch belo
* Bin Liu [160513 15:04]:
>
> But what would be in musb_default_set_mode()? Currently only am35x,
> da8xx, dsps, and omap2430 glues implement _set_mode(), but they don't
> have any in common. Only omap2430 sets session bit in _set_mode(), no
> one else does so.
Well how about the following if no
Hi,
On Fri, May 13, 2016 at 02:39:01PM -0700, Tony Lindgren wrote:
> * Bin Liu [160513 14:24]:
> > Hi,
> >
> > On Fri, May 13, 2016 at 02:17:39PM -0700, Tony Lindgren wrote:
> > > * Bin Liu [160513 14:05]:
> > > > Hi,
> > > >
> > > > On Wed, May 11, 2016 at 05:53:11PM -0700, Tony Lindgren wrot
* Bin Liu [160513 14:24]:
> Hi,
>
> On Fri, May 13, 2016 at 02:17:39PM -0700, Tony Lindgren wrote:
> > * Bin Liu [160513 14:05]:
> > > Hi,
> > >
> > > On Wed, May 11, 2016 at 05:53:11PM -0700, Tony Lindgren wrote:
> > > > At least 2430 glue layer pulls d+ high on start up even if there are
> >
Hi,
On Fri, May 13, 2016 at 02:17:39PM -0700, Tony Lindgren wrote:
> * Bin Liu [160513 14:05]:
> > Hi,
> >
> > On Wed, May 11, 2016 at 05:53:11PM -0700, Tony Lindgren wrote:
> > > At least 2430 glue layer pulls d+ high on start up even if there are
> > > no gadgets configured. This is bad at lea
* Bin Liu [160513 14:05]:
> Hi,
>
> On Wed, May 11, 2016 at 05:53:11PM -0700, Tony Lindgren wrote:
> > At least 2430 glue layer pulls d+ high on start up even if there are
> > no gadgets configured. This is bad at least for anything using a separate
> > battery charger chip as it can confuse the
Hi,
On Wed, May 11, 2016 at 05:53:11PM -0700, Tony Lindgren wrote:
> At least 2430 glue layer pulls d+ high on start up even if there are
> no gadgets configured. This is bad at least for anything using a separate
> battery charger chip as it can confuse the charger detection.
>
> Let's fix the i
At least 2430 glue layer pulls d+ high on start up even if there are
no gadgets configured. This is bad at least for anything using a separate
battery charger chip as it can confuse the charger detection.
Let's fix the issue by getting rid of omap2430_musb_set_mode() and only
write session bit in
16 matches
Mail list logo
