Re: [PATCH 2/3] cdc-wdm: unify error handling in write

2015-03-20 Thread Oliver Neukum
On Fri, 2015-03-20 at 16:11 +0100, Bjørn Mork wrote: > Anyway, the "outnl" is only ever used with rv < 0, and with your > changes > all other cases where rv < 0 will jump to some other label. So I > don't > think it makes much sense to keep the "return rv < 0 ? rv : count" > even > if you don't wa

Re: [PATCH 2/3] cdc-wdm: unify error handling in write

2015-03-20 Thread Bjørn Mork
Oliver Neukum writes: > On Fri, 2015-03-20 at 15:02 +0100, Bjørn Mork wrote: >> Oliver Neukum writes: >> >> > This makes sure the error handling path is the same for >> > all error conditions, thus reducing code duplication. >> >> Great! This looks like I nice cleanup. Will test it out. Jus

Re: [PATCH 2/3] cdc-wdm: unify error handling in write

2015-03-20 Thread Oliver Neukum
On Fri, 2015-03-20 at 15:02 +0100, Bjørn Mork wrote: > Oliver Neukum writes: > > > This makes sure the error handling path is the same for > > all error conditions, thus reducing code duplication. > > Great! This looks like I nice cleanup. Will test it out. Just a quick > comment based on the

Re: [PATCH 2/3] cdc-wdm: unify error handling in write

2015-03-20 Thread Bjørn Mork
Oliver Neukum writes: > This makes sure the error handling path is the same for > all error conditions, thus reducing code duplication. Great! This looks like I nice cleanup. Will test it out. Just a quick comment based on the first glance: > outnl: > return rv < 0 ? rv : count; How

[PATCH 2/3] cdc-wdm: unify error handling in write

2015-03-20 Thread Oliver Neukum
This makes sure the error handling path is the same for all error conditions, thus reducing code duplication. Signed-off-by: Oliver Neukum 0 --- drivers/usb/class/cdc-wdm.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/usb/class/cdc-