Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-28 Thread Yoshihiro Shimoda
Hi, (2014/05/29 5:26), Greg Kroah-Hartman wrote: > On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote: < snip > >> +#define FIRMWARE_NAME "r8a779x_usb3_v1.dlmem" > > Shouldn't you also add a: > MODULE_FIRMWARE(FIRMWARE_NAME); > line to this file so that the auto

Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-28 Thread Yoshihiro Shimoda
Hi, (2014/05/29 5:28), Greg Kroah-Hartman wrote: > On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote: >> The R-Car H2 and M2 SoCs come with an xHCI controller that requires >> some specific initializations related to the firmware downloading and >> some specific registers. This pat

Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote: > The R-Car H2 and M2 SoCs come with an xHCI controller that requires > some specific initializations related to the firmware downloading and > some specific registers. This patch adds the support for this special > configuration as

Re: [PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 08:23:09PM +0900, Yoshihiro Shimoda wrote: > The R-Car H2 and M2 SoCs come with an xHCI controller that requires > some specific initializations related to the firmware downloading and > some specific registers. This patch adds the support for this special > configuration as

[PATCH v2 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-28 Thread Yoshihiro Shimoda
The R-Car H2 and M2 SoCs come with an xHCI controller that requires some specific initializations related to the firmware downloading and some specific registers. This patch adds the support for this special configuration as an xHCI quirk executed during probe and start. Signed-off-by: Yoshihiro S