Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-19 Thread Karl Palsson
Johan Hovold wrote: > > Yes, there shouldn't be a need to store the baud rate in the driver (the > tty layer will keep track of that), but you probably still want to store > the state of the modem-control signals. Sounds right. The modem control signals I'm having a harder time setting up good

Re: Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Johan Hovold
On Wed, Feb 18, 2015 at 07:05:41PM -, Karl Palsson wrote: > I've already got most of this working in my branch overhauling this > driver. I agree, the open call shouldn't be doing all the hard > resetting of settings that it currently does. I've implemented more of > set termios / get termio

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Nicolas PLANEL
On 02/18/2015 02:05 PM, Karl Palsson wrote: Johan Hovold wrote: On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote: On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: I believe the fix should be implemented slightly differently however. Most usb-serial driver call set_t

Re: Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-18 Thread Karl Palsson
Johan Hovold wrote: > On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote: > > On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: > > > I believe the fix should be implemented slightly differently however. > > Most usb-serial driver call set_termios from open to handle this

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-17 Thread Johan Hovold
On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote: > On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: > I believe the fix should be implemented slightly differently however. > Most usb-serial driver call set_termios from open to handle this issue. > It looks like you coul

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-17 Thread Greg KH
On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: > From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001 > From: Nicolas PLANEL > Date: Tue, 17 Feb 2015 00:59:14 -0500 > Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct What is all of this her

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-17 Thread Johan Hovold
On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote: > From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001 > From: Nicolas PLANEL > Date: Tue, 17 Feb 2015 00:59:14 -0500 > Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct Your patch is still wh

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-17 Thread Nicolas PLANEL
From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001 From: Nicolas PLANEL Date: Tue, 17 Feb 2015 00:59:14 -0500 Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct The ch341_set_baudrate() function initialize the device baud speed according to the value on p

Re: usb : serial : ch341 : set tty baud speed according to tty struct

2015-02-17 Thread Greg KH
On Tue, Feb 17, 2015 at 10:11:55AM -0500, Nicolas PLANEL wrote: > Hi, > > > According to git log your are currently the two maintainer of the ch341 usb > serial driver. > > Thanks to pyserial, that did not initialize the serial port speed like > minicom. > Basically pyserial only set the por