Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-13 Thread Peter Chen
On Tue, Aug 13, 2013 at 10:23 PM, Fabio Estevam feste...@gmail.com wrote: On Tue, Aug 13, 2013 at 11:05 AM, Peter Chen hzpeterc...@gmail.com wrote: But what I see is the dwc3_pci_dev_pm_ops is not NULL if CONFIG_PM_SLEEP is not defined. The point of this macro is that we do not need

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-13 Thread Peter Chen
On Mon, Aug 12, 2013 at 09:22:46AM +0800, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after enabling id and vbus detection. This patch are fully tested

Re: [patch] usb: chipidea: fix a NULL dereference on error

2013-08-16 Thread Peter Chen
-platdata-reg_vbus); put_hcd: usb_put_hcd(hcd); -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Peter Chen peter.c

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-18 Thread Peter Chen
the DMA can't be changed to fix this instead of changing every driver? -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] chipidea: ci_hdrc_imx: Fix MODULE_ALIAS()

2013-08-19 Thread Peter Chen
); -- 1.8.1.2 Acked-by: Peter Chen peter.chen@freescale -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB gadget on mx6

2013-08-20 Thread Peter Chen
use server's nfs), both default dts and dr_mode = peripheral are tested. I tested mx6ql sabresd board. Can you post your error log and your otg interrupt numbers? -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: USB gadget on mx6

2013-08-20 Thread Peter Chen
On Wed, Aug 21, 2013 at 12:26:33AM -0300, Fabio Estevam wrote: Hi Peter, On Tue, Aug 20, 2013 at 8:46 PM, Peter Chen peter.c...@freescale.com wrote: On Mon, Aug 19, 2013 at 03:05:28PM -0300, Fabio Estevam wrote: Hi Fabio, I have tried today's linux-next (Linux version 3.11.0-rc6-next

[PATCH 2/5] usb: chipidea: udc: Consolidate the calling of ci-driver-disconnect

2013-08-23 Thread Peter Chen
The udc-core will call gadget's driver-disconnect, so we should avoid calling gadget's disconnect again at ci_udc_stop in case the gadget's unbind free some structs which is still used at gadget's disconnect. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com

[PATCH 3/5] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget

2013-08-23 Thread Peter Chen
f874b2c5533c04bc ]--- Kernel panic - not syncing: Fatal exception in interrupt Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/udc.c

[PATCH 0/5] Chipidea Misc patchset

2013-08-23 Thread Peter Chen
Hi Alex, Below are un-queued chipidea patches, some of them were reviewd. Peter Chen (5): usb: host: delete chipidea dependency usb: chipidea: udc: Consolidate the calling of ci-driver-disconnect usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget usb

[PATCH 1/5] usb: host: delete chipidea dependency

2013-08-23 Thread Peter Chen
Now, chipidea host has already depended on USB_EHCI_HCD Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers

[PATCH 4/5] usb: chipidea: Fix memleak for ci-hw_bank.regmap when driver removal

2013-08-23 Thread Peter Chen
It needs to free ci-hw_bank.regmap explicitly since it is not managed resource. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c

[PATCH 5/5] usb: chipidea: move more platform related things to ci_get_platdata

2013-08-23 Thread Peter Chen
Like vbus, the dr_mode and phy_mode are also got from glue layer's platform data or device node. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea

Re: [PATCH v2 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-08-23 Thread Peter Chen
On Wed, Aug 07, 2013 at 05:18:13AM +0800, Peter Chen wrote: In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-26 Thread Peter Chen
On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: Dear Peter, On 08/12/2013 03:22 AM, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after

[PATCH v2 4/5] usb: chipidea: Fix memleak for ci-hw_bank.regmap when driver removal

2013-08-27 Thread Peter Chen
It needs to free ci-hw_bank.regmap explicitly since it is not managed resource. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c

[PATCH v2 0/5] Chipidea Misc patchset

2013-08-27 Thread Peter Chen
Changed for v2: - Fixed the build error for patch 5/5 Below are un-queued chipidea patches, some of them were reviewed. Peter Chen (5): usb: host: delete chipidea dependency usb: chipidea: udc: Consolidate the calling of ci-driver-disconnect usb: chipidea: udc: fix the oops when plugs

[PATCH v2 5/5] usb: chipidea: move more platform related things to ci_get_platdata

2013-08-27 Thread Peter Chen
Like vbus, the dr_mode and phy_mode are also got from glue layer's platform data or device node. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH v2 3/5] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget

2013-08-27 Thread Peter Chen
f874b2c5533c04bc ]--- Kernel panic - not syncing: Fatal exception in interrupt Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/udc.c

Re: [PATCH v2 0/5] Chipidea Misc patchset

2013-08-29 Thread Peter Chen
On Thu, Aug 29, 2013 at 10:53:50AM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Changed for v2: - Fixed the build error for patch 5/5 Below are un-queued chipidea patches, some of them were reviewed. I'd like to send 1/5, 3/5 and 4/5 now, have a closer

[PATCH 2/2] usb: chipidea: imx: add USB suspend/resume API for system PM

2013-09-03 Thread Peter Chen
Add suspend/resume API for system suspend/resume procedure. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 72 +++- 1 files changed, 71 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b

[PATCH 1/2] usb: chipidea: add ci_hdrc_enter_lpm API

2013-09-03 Thread Peter Chen
It is used to let the PHY enters low power mode at controller suspend routine. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/bits.h |1 + drivers/usb/chipidea/core.c | 14 ++ include/linux/usb/chipidea.h |1 + 3 files changed, 16 insertions

Re: [PATCH 2/2] usb: chipidea: imx: add USB suspend/resume API for system PM

2013-09-03 Thread Peter Chen
On Tue, Sep 03, 2013 at 11:45:44PM -0300, Fabio Estevam wrote: On Tue, Sep 3, 2013 at 10:16 PM, Peter Chen peter.c...@freescale.com wrote: On Tue, Sep 03, 2013 at 08:25:43AM -0300, Fabio Estevam wrote: On Tue, Sep 3, 2013 at 6:26 AM, Peter Chen peter.c...@freescale.com wrote: +static

[PATCH 3/5] usb: chipidea: imx: Add usb_phy_shutdown at probe's error path

2013-09-09 Thread Peter Chen
If not, the PHY will be active even the controller is not in use. We find this issue due to the PHY's clock refcount is not correct due to -EPROBE_DEFER return after phy's init. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c |7 +-- 1 files

[PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-09 Thread Peter Chen
With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Besides, we enable the IC fixes for this PHY at mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 30

[PATCH 1/2] usb: mxs-phy: Add platform judgement code

2013-09-09 Thread Peter Chen
The mxs-phy has three versions, each version has some differences among PHY operation. the 1st version is for mx23/mx28 SoC, The 2nd version is for mx6q and mx6dl, the 3rd version is for mx6sl and later mx6 platform. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs

[RESEND PATCH v2 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-09 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module paramters. Signed-off-by: Peter Chen peter.c

Re: [PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-09 Thread Peter Chen
On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote: Dear Peter Chen, With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Besides, we enable the IC fixes for this PHY at mx6 platform. Signed-off

[PATCH 1/1] chipidea: udc: free pending TD at removal procedure

2013-09-10 Thread Peter Chen
It indicates the buffer at dma pool are still in use. This commit will free the pending TD at driver's removal procedure, it can fix the problem described above. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [PATCH 2/2] usb: phy-mxs: Add auto clock and power setting

2013-09-10 Thread Peter Chen
On Tue, Sep 10, 2013 at 10:18:04AM +0200, Marek Vasut wrote: Dear Peter Chen, On Mon, Sep 09, 2013 at 04:41:15PM +0200, Marek Vasut wrote: Dear Peter Chen, Please see my commit log, the mx6sl-phy has some improvements compared to mx6q-phy. But they're not yet implemented

[PATCH 2/8] usb: chipidea: udc: Consolidate the call of disconnect

2013-09-16 Thread Peter Chen
The udc-core will call gadget's driver-disconnect, so we should avoid calling gadget's disconnect again at ci_udc_stop in case the gadget's unbind free some structs which is still used at gadget's disconnect. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com

[PATCH 1/8] usb: host: delete chipidea dependency

2013-09-16 Thread Peter Chen
Now, chipidea host has already depended on USB_EHCI_HCD Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers

[PATCH 3/8] usb: chipidea: udc: fix the oops after rmmod gadget

2013-09-16 Thread Peter Chen
f874b2c5533c04bc ]--- Kernel panic - not syncing: Fatal exception in interrupt Tested-by: Marek Vasut ma...@denx.de Acked-by: Shawn Guo shawn@linaro.org Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 4/8] usb: chipidea: Fix memleak for ci-hw_bank.regmap when removal

2013-09-16 Thread Peter Chen
It needs to free ci-hw_bank.regmap explicitly since it is not managed resource. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c

[PATCH 5/8] usb: chipidea: move platform related things to ci_get_platdata

2013-09-16 Thread Peter Chen
Like vbus, the dr_mode and phy_mode are also got from glue layer's platform data or device node. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH 8/8] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-09-16 Thread Peter Chen
From: Geert Uytterhoeven ge...@linux-m68k.org If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' Reviewed-and-tested-by: Peter Chen peter.c...@freescale.com Signed-off-by: Geert Uytterhoeven ge...@linux

[PATCH 0/8] Misc peding chipidea patches

2013-09-16 Thread Peter Chen
...@pengutronix.de. Geert Uytterhoeven (1): usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA Peter Chen (7): usb: host: delete chipidea dependency usb: chipidea: udc: Consolidate the call of disconnect usb: chipidea: udc: fix the oops after rmmod gadget usb: chipidea: Fix memleak for ci

[PATCH 7/8] usb: chipidea: udc: free pending TD at removal procedure

2013-09-16 Thread Peter Chen
It indicates the buffer at dma pool are still in use. This commit will free the pending TD at driver's removal procedure, it can fix the problem described above. Acked-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2

[PATCH 6/8] usb: chipidea: imx: Add usb_phy_shutdown at probe's error path

2013-09-16 Thread Peter Chen
If not, the PHY will be active even the controller is not in use. We find this issue due to the PHY's clock refcount is not correct due to -EPROBE_DEFER return after phy's init. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c |7 +-- 1 files

[PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-18 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module parameters. Signed-off-by: Peter Chen peter.c

Re: [PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Peter Chen
On Thu, Sep 19, 2013 at 09:24:15AM +0200, Daniele Forsi wrote: 2013/9/19 Peter Chen: + milliseconds to increase successive wakup delays); there's a typo: s/wakup/wakeup/ Thanks, I think I need check more carefully for typo error -- Best Regards, Peter Chen

[PATCH v4 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined values. This change will no affect current behavior if the user does not use two introduced module parameters. Signed-off-by: Peter Chen peter.c

[PATCH 1/1] usb: gadget: mark init as late_initcall

2013-09-23 Thread Peter Chen
be a moderate solution. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/gadget/acm_ms.c |2 +- drivers/usb/gadget/audio.c|2 +- drivers/usb/gadget/cdc2.c |2 +- drivers/usb/gadget/ether.c|2 +- drivers/usb/gadget/gmidi.c|2

[PATCH 0/3] Chipidea PHY and low power mode change

2013-09-23 Thread Peter Chen
Hi Greg, The this serial includes PHY operation change (move to common code) and low power mode supported, it is based on: http://marc.info/?l=linux-usbm=137939293826025w=2. Peter Chen (3): usb: chipidea: move PHY operation to core usb: chipidea: imx: remove PHY operations usb: chipidea

[PATCH v2 2/5] usb: chipidea: usbmisc_imx: Using regmap to access register

2013-09-23 Thread Peter Chen
Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/usbmisc_imx.c | 71 +--- 1 files changed, 34 insertions(+), 37 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index ac5a461..545efbf

[PATCH v2 1/5] usb: chipidea: imx: rename the DT doc name

2013-09-23 Thread Peter Chen
To reflect source file name change Signed-off-by: Peter Chen peter.c...@freescale.com --- .../devicetree/bindings/usb/ci13xxx-imx.txt| 31 .../devicetree/bindings/usb/ci_hdrc_imx.txt| 31 Documentation/devicetree/bindings/usb/mxs

[PATCH 3/3] usb: chipidea: add ci_hdrc_enter_lpm API

2013-09-23 Thread Peter Chen
-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/bits.h |1 + drivers/usb/chipidea/core.c | 24 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/bits.h b/drivers/usb/chipidea/bits.h index 464584c..a857131 100644

[PATCH 1/3] usb: chipidea: move PHY operation to core

2013-09-23 Thread Peter Chen
PHY operations are common, so move them to core. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 57 ++ drivers/usb/chipidea/udc.c | 39 + 2 files changed, 52 insertions(+), 44 deletions

[PATCH 2/3] usb: chipidea: imx: remove PHY operations

2013-09-23 Thread Peter Chen
Since the PHY operations are moved to core, delete the related code at glue layer. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/usb/chipidea

Re: [PATCH v2 1/5] usb: chipidea: imx: rename the DT doc name

2013-09-23 Thread Peter Chen
On Tue, Sep 24, 2013 at 12:46:52PM +0800, Peter Chen wrote: Sorry, sending wrongly, please skip it -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 2/5] usb: chipidea: usbmisc_imx: Using regmap to access register

2013-09-23 Thread Peter Chen
On Tue, Sep 24, 2013 at 12:46:53PM +0800, Peter Chen wrote: Sorry, sending wrongly, please skip it Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/usbmisc_imx.c | 71 +--- 1 files changed, 34 insertions(+), 37 deletions

Re: [PATCH 0/8] Misc peding chipidea patches

2013-09-25 Thread Peter Chen
On Wed, Sep 25, 2013 at 05:31:43PM -0700, Greg KH wrote: On Tue, Sep 17, 2013 at 12:37:17PM +0800, Peter Chen wrote: Hi Greg, Below are pending misc chipidea patches, some of them have already reviewed. The similiar Geert's patch for gadget has already at usb-next. For mine

[PATCH 1/1] usb: chipidea: udc: Fix calling spin_lock_irqsave at sleep context

2013-10-07 Thread Peter Chen
] (ret_fast_syscall+0x0/0x48) Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 2bb7d18..7bee4a8 100644 --- a/drivers/usb/chipidea/udc.c

[PATCH 1/1] usb: chipidea: udc: Fix spinlock recursion during bus reset

2013-10-09 Thread Peter Chen
-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 7bee4a8..b34c819 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c

Re: [PATCH 1/1] usb: chipidea: udc: Fix calling spin_lock_irqsave at sleep context

2013-10-09 Thread Peter Chen
On Tue, Oct 08, 2013 at 11:58:10PM -0700, Greg KH wrote: On Tue, Oct 08, 2013 at 10:30:17AM +0800, Peter Chen wrote: Fixing the below dump: root@freescale ~$ modprobe g_serial g_serial gadget: Gadget Serial v2.4 g_serial gadget: g_serial ready BUG: sleeping function called from

Re: [PATCH 1/1] usb: chipidea: udc: Fix spinlock recursion during bus reset

2013-10-09 Thread Peter Chen
On Tue, Oct 08, 2013 at 11:58:33PM -0700, Greg KH wrote: On Wed, Oct 09, 2013 at 02:39:52PM +0800, Peter Chen wrote: After configuration, the host also possible sends bus reset at any time, at such situation, it will trigger below spinlock recursion dump. This commit unlocks the spinlock

Re: When USB PHY framework should be used?

2013-10-10 Thread Peter Chen
normally put a common code like [4]. For your situation, you may need to create a controller driver, and call ehci, ohci, and phy init at this probe routine, in that way, your ohci and ehci controller will need to be unloaded together. -- Best Regards, Peter Chen -- To unsubscribe from this list

[PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-10-12 Thread Peter Chen
Add notify_suspend and notify_resume according to different SoCs. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 73 + 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b

[PATCH 08/12] usb: phy-mxs: Add system suspend/resume API

2013-10-12 Thread Peter Chen
We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen peter.c...@freescale.com

[PATCH 01/12] usb: phy-mxs: Add auto clock and power setting

2013-10-12 Thread Peter Chen
With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff

[PATCH 06/12] usb: phy: Add set_wakeup API

2013-10-12 Thread Peter Chen
This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen peter.c...@freescale.com --- include/linux/usb/phy.h | 16 1 files changed

[PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup

2013-10-12 Thread Peter Chen
mxs_phy_disconnect_line, there are unknown wakeups due to dp/dm floating at device mode. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 82 - 1 files changed, 81 insertions(+), 1 deletions(-) diff --git a/drivers/usb/phy/phy

[PATCH 03/12] usb: phy-mxs: Add anatop regmap

2013-10-12 Thread Peter Chen
It is needed by mx6 SoC serial, but not for mx23 and mx28. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c

[PATCH 04/12] usb: phy: add notify suspend and resume callback

2013-10-12 Thread Peter Chen
They are used to notify PHY that the controller enters suspend or finishes resume. Signed-off-by: Peter Chen peter.c...@freescale.com --- include/linux/usb/phy.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/linux/usb/phy.h b/include

[PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-12 Thread Peter Chen
After adding IC fixes bits, some PHY bugs are fixed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c

[PATCH 00/12] Add power management support for MXS PHY

2013-10-12 Thread Peter Chen
are devicetree related patches to support above mxs phy features. Peter Chen (12): usb: phy-mxs: Add auto clock and power setting usb: phy-mxs: Enable IC fixes for mx6 SoC serial usb: phy-mxs: Add anatop regmap usb: phy: add notify suspend and resume callback usb: phy-mxs: Add

[PATCH 10/12] ARM: dts: imx6: add anatop phandle for usbphy

2013-10-12 Thread Peter Chen
Add anatop phandle for usbphy Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index ef51342..145ece2 100644 --- a/arch

[PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

2013-10-12 Thread Peter Chen
Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH 12/12] ARM: dts: imx6: Add disconnect_line_without_vbus property for usbphy

2013-10-12 Thread Peter Chen
When the vbus is not there and the PHY is out of power, we need to disconnect connection between USB PHY and USB controller, otherwise the unexpected USB wakeup will occur due to dp/dm change at device mode. Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl.dtsi

[PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

2013-10-12 Thread Peter Chen
This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/usb

[PATCH 01/11] usb: chipidea: Add power management support

2013-10-12 Thread Peter Chen
This commit adds runtime and system power management support for chipidea core. The runtime pm support is controlled by glue layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci.h|2 + drivers/usb

[PATCH 00/11] Add power management support for chipidea

2013-10-12 Thread Peter Chen
are devicetree related to enable runtime pm. Peter Chen (11): usb: chipidea: Add power management support usb: chipidea: imx: add power management support usb: chipidea: usbmisc_imx: remove the controller's clock information usb: chipidea: add wakeup interrupt handler usb: chipidea

[PATCH 04/11] usb: chipidea: add wakeup interrupt handler

2013-10-12 Thread Peter Chen
interrupts. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci.h |1 + drivers/usb/chipidea/core.c | 22 +- drivers/usb/chipidea/otg.c |5 + 3 files changed, 27 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/ci.h b

[PATCH 03/11] usb: chipidea: usbmisc_imx: remove the controller's clock information

2013-10-12 Thread Peter Chen
, especially at runtime power management situation. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/usbmisc_imx.c | 18 -- 1 files changed, 0 insertions(+), 18 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c

[PATCH 08/11] usb: chipidea: host: add ehci quirk for imx controller

2013-10-12 Thread Peter Chen
When the port goes to suspend or finishes resme, it needs to notify PHY, it is not a standard EHCI operation, so we add a quirk for it. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/host.c | 129 ++ include/linux/usb

[PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-12 Thread Peter Chen
Add property for supporting runtime power management Signed-off-by: Peter Chen peter.c...@freescale.com --- .../devicetree/bindings/usb/ci13xxx-imx.txt|2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b

[PATCH 07/11] usb: chipidea: host: add quirk for ehci operation

2013-10-12 Thread Peter Chen
just after setting run/stop bit, it does not be set in practice, so a software delay is needed. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/host.c | 51 +++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git

[PATCH 06/11] usb: chipidea: imx: call set_wakeup when necessary

2013-10-12 Thread Peter Chen
- Disable wakeup after probe - Enable wakeup during the suspend - Disable wakeup after controller is active Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 36 1 files changed, 36 insertions(+), 0 deletions

[PATCH 09/11] usb: chipidea: imx: Enable CI_HDRC_IMX_EHCI_QUIRK if the phy has notify APIs

2013-10-12 Thread Peter Chen
If the PHY has .notify_suspend and .notify_resume, it means this imx usb controller needs to add quirks for standard ehci routine. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCH 02/11] usb: chipidea: imx: add power management support

2013-10-12 Thread Peter Chen
Add system and runtime power management support for imx gluy layer. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 99 ++- 1 files changed, 96 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH 11/11] ARM: dts: imx6qdl-sabresd: Enable runtime pm for usbotg and usb host 1

2013-10-12 Thread Peter Chen
Enable runtime power management support for usbotg and usb host 1. Signed-off-by: Peter Chen peter.c...@freescale.com --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts

[PATCH 05/11] usb: chipidea: usbmisc_imx: add set_wakup API

2013-10-12 Thread Peter Chen
It is used to enable USB wakeup Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.h |1 + drivers/usb/chipidea/usbmisc_imx.c | 41 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 10:40:37AM -0400, Alan Stern wrote: On Sat, 12 Oct 2013, Peter Chen wrote: Add property for supporting runtime power management Signed-off-by: Peter Chen peter.c...@freescale.com --- .../devicetree/bindings/usb/ci13xxx-imx.txt|2 ++ 1 files

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-13 Thread Peter Chen
at mx6dq and mx6dl, and both of two bugs are fixed at later mx6 (like mx6sololite and later SoCs), but the IC fixes are not enabled by default, it needs software opens it. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-13 Thread Peter Chen
On Mon, Oct 14, 2013 at 03:39:36AM +0200, Marek Vasut wrote: Dear Peter Chen, On Sat, Oct 12, 2013 at 10:40:37AM -0400, Alan Stern wrote: On Sat, 12 Oct 2013, Peter Chen wrote: Add property for supporting runtime power management Signed-off-by: Peter Chen peter.c

Re: [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote: Dear Peter Chen, Add notify_suspend and notify_resume according to different SoCs. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 73 + 1

Re: [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup

2013-10-13 Thread Peter Chen
Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:47:06AM +0200, Marek Vasut wrote: Dear Peter Chen, This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |4 1

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 05:05:23PM +0200, Thomas Petazzoni wrote: Dear Peter Chen, On Sat, 12 Oct 2013 17:09:45 +0800, Peter Chen wrote: This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen peter.c...@freescale.com

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-13 Thread Peter Chen
On Mon, Oct 14, 2013 at 04:07:10AM +0200, Marek Vasut wrote: Dear Peter Chen, On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote: Hi, After adding IC fixes bits, some PHY bugs are fixed by IC logic. Can you please elaborate what those bits do exactly ? They seem

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: Hi, Peter Chen wrote: This commit adds runtime and system power management support for chipidea core. The runtime pm support is controlled by glue layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 10:42:16AM +0200, Sascha Hauer wrote: On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: Hi, Peter Chen wrote: This commit adds runtime and system power management support

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:09:55PM +0800, Shawn Guo wrote: On Sat, Oct 12, 2013 at 05:09:36PM +0800, Peter Chen wrote: After adding IC fixes bits, some PHY bugs are fixed by IC logic. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/phy/phy-mxs-usb.c | 10

Re: [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:22:07PM +0800, Shawn Guo wrote: On Sat, Oct 12, 2013 at 05:09:43PM +0800, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 05:29:21PM +0800, Shawn Guo wrote: On Mon, Oct 14, 2013 at 05:09:56PM +0800, Peter Chen wrote: Oh, sorry. I forget to put below one to this serial. Will do at v2 http://marc.info/?l=linux-usbm=137871552016298w=2 Remember to document the new compatible strings

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 12:01:08PM +0100, Russell King - ARM Linux wrote: On Sat, Oct 12, 2013 at 05:35:03PM +0800, Peter Chen wrote: This commit adds runtime and system power management support for chipidea core. The runtime pm support is controlled by glue layer, it can be enabled by flag

Re: [PATCH] usb/chipidea: fix oops on memory allocation failure

2013-10-17 Thread Peter Chen
== CI_ROLE_HOST) + if (ci-role == CI_ROLE_HOST ci-hcd) host_stop(ci); } -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] usb/chipidea: fix oops on memory allocation failure

2013-10-17 Thread Peter Chen
On Thu, Oct 17, 2013 at 10:43:17AM +0100, Russell King - ARM Linux wrote: On Thu, Oct 17, 2013 at 01:50:17PM +0800, Peter Chen wrote: Below is my proposal fix for this problem: diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 42a0bd4..c1d05c4 100644

[PATCH 1/1] usb: chipidea: host: more enhancement when ci-hcd is NULL

2013-10-21 Thread Peter Chen
-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/host.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 64d7a6d..59e6020 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb

[Patch v2 00/14] Add power management support for MXS PHY

2013-10-22 Thread Peter Chen
-high speed to FS/LS [5/14] - Change the dt property disconnect-line-without-vbus that the separator should be - not the _, meanwhile, related source code has changed. - Using one local variable to get the function return val to avoid long condition statement. [13/14] Peter Chen (14): usb: doc: phy

<    1   2   3   4   5   6   7   8   9   10   >