Re: [linux-usb-devel] (usagi-core 32638) Re: [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Hi, >> Sat, 24 Mar 2007 14:22:53 -0700 >> [Subject: (usagi-core 32638) Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] >> [USB] fixed to skip NULL entry in struct serial usb_serial_port.] >> Greg KH <[EMAIL PROTECTED]> wrote... > This should already be fixed in the -git snapshots that have come out >

Re: [linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-24 Thread Greg KH
On Sun, Mar 25, 2007 at 12:52:27AM +0900, Noriaki TAKAMIYA wrote: > Hi, > > When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB > serial device plugged in, the kernel crashes. > > The reason is struct usb_serial_port is referenced without checking > whether it is NULL or no

Re: [linux-usb-devel] Device failing to enumerate with EHCI

2007-03-24 Thread David Brownell
On Saturday 24 March 2007 11:58 am, Oliver Neukum wrote: > Am Freitag, 23. März 2007 20:08 schrieb David Brownell: > > > ... no, that's a special case. Oddball devices that implement halt > > status on ep0 must allow clear-halt requests for it too. See 8.5.3.4 > > and (especially) the end of 9.4

Re: [linux-usb-devel] Device failing to enumerate with EHCI

2007-03-24 Thread Alan Stern
On Sat, 24 Mar 2007, Oliver Neukum wrote: > Am Samstag, 24. März 2007 04:21 schrieb Alan Stern: > > I don't see any easy way to tell.  The spec doesn't offer any good way to > > tell the difference between one type of stall and the other.  In fact, the > > only way seems to be to send another re

Re: [linux-usb-devel] Question about usb-serial port registration

2007-03-24 Thread Oliver Neukum
Am Samstag, 24. März 2007 04:30 schrieb Alan Stern: > Regular files work like that.  If a program has a file named "foo" open > when you do "rm foo", the open file reference won't prevent you from > creating a new file named "foo" in the same directory.  There will be no > conflict or confusion

Re: [linux-usb-devel] Device failing to enumerate with EHCI

2007-03-24 Thread Oliver Neukum
Am Samstag, 24. März 2007 04:21 schrieb Alan Stern: > I don't see any easy way to tell.  The spec doesn't offer any good way to > tell the difference between one type of stall and the other.  In fact, the > only way seems to be to send another request that _should_ always succeed > and see wheth

Re: [linux-usb-devel] Device failing to enumerate with EHCI

2007-03-24 Thread Oliver Neukum
Am Freitag, 23. März 2007 20:08 schrieb David Brownell: > ... no, that's a special case. Oddball devices that implement halt > status on ep0 must allow clear-halt requests for it too. See 8.5.3.4 > and (especially) the end of 9.4.5 ... So not clearing and retrying is a bug? > Linux "should" ha

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-24 Thread Pete Zaitcev
On Sat, 24 Mar 2007 17:23:55 +0100, René van Paassen <[EMAIL PROTECTED]> wrote: > I will change the del_timer to del_timer_sync, to remove the race where > the timer´s activity is running while the timer is being removed. > > Does that sound reasonable? Yes, it's a good idea, however this is not

[linux-usb-devel] [5/5] 2.6.21-rc4: known regressions (v2)

2007-03-24 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involv

Re: [linux-usb-devel] [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver

2007-03-24 Thread René van Paassen
On Fri, 2007-03-09 at 21:44 -0500, Dmitry Torokhov wrote: > On Friday 09 March 2007 19:29, Pete Zaitcev wrote: > > > +/* Activity checking thread. If a sufficient period of inactivity is > > > detected, > > > + the tablet's proximity is reset. */ > > > +static void activity_check(unsigned long

Re: [linux-usb-devel] (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
Sorry for resending Hi, While booting, this entry is set to NULL in destroy_serial(), but serial->port is referred again in pl2303_shutdown() via serial->type->shutdown. --- drivers/usb/serial/pl2303.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb/se

Re: [linux-usb-devel] (usagi-core 32634) [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Sorry for resending. Hi, This patch fixes to skip serial->port[i] if it is set NULL. Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> --- include/linux/usb/serial.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/usb/serial.h b/include/linux/usb/

Re: [linux-usb-devel] (usagi-core 32633) [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
Sorry for resending. While booting, this entry is set to NULL in destroy_serial(), but serial->port is referred again in pl2303_shutdown() via serial->type->shutdown. Signed-off-by: Noriaki TAKAMIYA <[EMAIL PROTECTED]> --- drivers/usb/serial/pl2303.c |2 ++ 1 files changed, 2 insertio

[linux-usb-devel] [PATCH 2/2] [USB] [SERIAL]: fixed to skip NULL port entry in struct usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Hi, This patch fixes to skip serial->port[i] if it is set NULL. --- include/linux/usb/serial.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h index 32acbae..85ed5ef 100644 --- a/include/linux/usb/serial.h +++

[linux-usb-devel] [PATCH 1/2] [USB] [PL2303]: fixed to skip NULL entry in pl2303_shutdown.

2007-03-24 Thread Noriaki TAKAMIYA
Hi, While booting, this entry is set to NULL in destroy_serial(), but serial->port is referred again in pl2303_shutdown() via serial->type->shutdown. --- drivers/usb/serial/pl2303.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drive

[linux-usb-devel] [PATCH 0/2] [SERIAL] [USB] fixed to skip NULL entry in struct serial usb_serial_port.

2007-03-24 Thread Noriaki TAKAMIYA
Hi, When I boot using linux-2.6.21-rc4 on ThinkPad T41 with pl2303 USB serial device plugged in, the kernel crashes. The reason is struct usb_serial_port is referenced without checking whether it is NULL or not. Regards, -- Noriaki TAKAMIYA --