Re: [linux-usb-devel] [usb-storage] schedule_timeout: wrong timeout value c1a95554

2007-08-09 Thread Rafael J. Wysocki
On Thursday, 9 August 2007 16:43, Alan Stern wrote: On Thu, 9 Aug 2007, Mariusz Kozlowski wrote: Hello, Happens every time I reattach usb pen drive. usb 1-2: new high speed USB device using ehci_hcd and address 10 usb 1-2: configuration #1 chosen from 1 choice scsi6 : SCSI

Re: [linux-usb-devel] [usb-storage] schedule_timeout: wrong timeout value c1a95554

2007-08-09 Thread Rafael J. Wysocki
of it. I think that something like the appended patch is necessary. Mariusz, please see if that helps. Yes - this patch fixes the bug. OK, thanks for the confirmation. Here it goes again with a changelog etc. --- From: Rafael J. Wysocki [EMAIL PROTECTED] Fix a bug in freezer

[linux-usb-devel] [PATCH][RFC] make config vars uniformly SAFE_SERIAL

2007-08-01 Thread Robert P. J. Day
[EMAIL PROTECTED], [EMAIL PROTECTED] -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page

Re: [linux-usb-devel] [PATCH][RFC] make config vars uniformly SAFE_SERIAL

2007-08-01 Thread Robert P. J. Day
On Wed, 1 Aug 2007, Greg KH wrote: On Wed, Aug 01, 2007 at 05:13:51AM -0400, Robert P. J. Day wrote: just a preliminary strike, trying to make some of these names uniform. that includes having to change some of the settings in various defconfig files. not compile tested, i'm just

[linux-usb-devel] [PATCH] Remove dead references to SAFE_SERIAL CONFIG variables.

2007-08-01 Thread Robert P. J. Day
Remove the references to CONFIG_USBD_SAFE_SERIAL_{VENDOR,PRODUCT}, which aren't defined in any Kconfig file. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- this simple deletion takes care of most of what we've been discussing until now. not compile tested, but it's pretty

[linux-usb-devel] [PATCH] USB: Typo: USB_SAFE_PADDED - USB_SERIAL_SAFE_PADDED.

2007-07-30 Thread Robert P. J. Day
Fix typo in safe_serial.c to match the actual CONFIG variable. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c index 86899d5..51669b7 100644 --- a/drivers/usb/serial/safe_serial.c +++ b/drivers/usb/serial

[linux-usb-devel] undefined USB-related CONFIG variables

2007-07-29 Thread Robert P. J. Day
/usb/serial/safe_serial.c:150:(CONFIG_USB_SAFE_SERIAL_VENDOR, CONFIG_USB_SAFE_SERIAL_PRODUCT, CDC_DEVICE_CLASS, rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA

Re: [linux-usb-devel] undefined USB-related CONFIG variables

2007-07-29 Thread Robert P. J. Day
On Sun, 29 Jul 2007, Greg KH wrote: On Sun, Jul 29, 2007 at 04:17:57PM -0400, Robert P. J. Day wrote: the latest output of the dead CONFIG variable script run against the directory drivers/usb (obviously some false positives, but some definitely dead variables): Care to make up some

[linux-usb-devel] SERIAL_SAFE versus SAFE_SERIAL

2007-07-29 Thread Robert P. J. Day
/serial/Kconfig: depends on USB_SERIAL_SAFE i mean, is it *deliberate* to mix both USB_SAFE_SERIAL and USB_SERIAL_SAFE as above? yeesh. rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry

Re: [linux-usb-devel] undefined USB-related CONFIG variables

2007-07-29 Thread Robert P. J. Day
On Sun, 29 Jul 2007, Greg KH wrote: On Sun, Jul 29, 2007 at 05:15:41PM -0400, Robert P. J. Day wrote: On Sun, 29 Jul 2007, Greg KH wrote: On Sun, Jul 29, 2007 at 04:17:57PM -0400, Robert P. J. Day wrote: the latest output of the dead CONFIG variable script run against

Re: [linux-usb-devel] Volunteer to be the new usb.ids maintainer!!

2007-07-28 Thread Stephen J. Gowdy
! -- /+-\ |Stephen J. Gowdy, SLAC | CERN Office: 32-2-A22| |http://www.slac.stanford.edu/~gowdy/ | CH-1211 Geneva 23| | | Switzerland | |EMail: [EMAIL PROTECTED

Re: [linux-usb-devel] Volunteer to be the new usb.ids maintainer!!

2007-07-28 Thread Stephen J. Gowdy
work together to deal with so many requests. Regards Jason Xiao -- Vojtech Pavlik Director SuSE Labs -- /+-\ |Stephen J. Gowdy, SLAC | CERN Office: 32-2-A22| |http://www.slac.stanford.edu/~gowdy/ | CH-1211

Re: [linux-usb-devel] [2.6.22-rc7] khubd NULL deref oops...

2007-07-11 Thread Daniel J Blueman
On 11/07/07, Chuck Ebbert [EMAIL PROTECTED] wrote: On 07/08/2007 05:45 PM, Daniel J Blueman wrote: When plugging in a USB 2 mass-storage device which I've been seeing problems with, I caught a khubd oops [1]. Kernel is 2.6.22-rc7 on ia32 built with Ubuntu's 2.6.22 .config. [ 4769.252000

Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

2007-06-21 Thread Rafael J. Wysocki
On Thursday, 21 June 2007 21:39, Alan Stern wrote: On Thu, 21 Jun 2007, Rafael J. Wysocki wrote: I'll see if I can reproduce your problem here. Yes, I can. It's only necessary to load usb-storage (without any devices actually using it) and it fails device_suspend() immediately (I

Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

2007-06-20 Thread Rafael J. Wysocki
On Wednesday, 20 June 2007 16:01, Alan Stern wrote: On Wed, 20 Jun 2007, Mattia Dongili wrote: On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm2/ Hello, on this vaio sz72b I

Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

2007-06-20 Thread Rafael J. Wysocki
On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote: On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote: On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel

Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

2007-06-20 Thread Rafael J. Wysocki
On Wednesday, 20 June 2007 22:50, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote: On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 07:22, Mattia Dongili wrote: On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew

Re: [linux-usb-devel] can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2]

2007-06-20 Thread Rafael J. Wysocki
On Thursday, 21 June 2007 00:03, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 22:50, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 17:38, Mattia Dongili wrote: On Wed, Jun 20, 2007 at 01:40:18PM +0200, Rafael J. Wysocki wrote: On Wednesday, 20 June 2007 07:22, Mattia Dongili

Re: [linux-usb-devel] ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-13 Thread Rafael J. Wysocki
On Monday, 11 June 2007 22:10, Alan Stern wrote: On Mon, 11 Jun 2007, Rafael J. Wysocki wrote: At that point, does lspci -vv show that the controller is trying to signal a wakeup event? That is, is the PME# signal asserted? (Not that knowing this will help very much -- I'm

Re: [linux-usb-devel] [linux-pm] Re: ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-12 Thread Rafael J. Wysocki
On Tuesday, 12 June 2007 03:50, Zhang Rui wrote: I've tried to suspend with the controller in that state, but it's resumed immediately, as before. Maybe also see what ACPI reports. How can I see that? I wish I knew. Maybe you can try asking on the ACPI

Re: [linux-usb-devel] [linux-pm] Re: ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-12 Thread Rafael J. Wysocki
On Tuesday, 12 June 2007 13:59, Rafael J. Wysocki wrote: On Tuesday, 12 June 2007 03:50, Zhang Rui wrote: I've tried to suspend with the controller in that state, but it's resumed immediately, as before. Maybe also see what ACPI reports. How can I see

[linux-usb-devel] [RFC][PATCH -mm 0/7] PM: Remove unused and unnecessary features from suspend and resume core

2007-06-11 Thread Rafael J. Wysocki
Hi, The following series of patches removes some unused and unnecessary features from the suspend and resume core code. Comments welcome. Greetings, Rafael -- Premature optimization is the root of all evil. - Donald Knuth

[linux-usb-devel] [RFC][PATCH -mm 2/7] PM: Remove saved_state from struct dev_pm_info

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The saved_state member of struct dev_pm_info, defined in include/linux/pm.h, is not used anywhere, so it can be removed. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- include/linux/pm.h |1 - 1 file changed, 1 deletion(-) Index: linux

[linux-usb-devel] [RFC][PATCH -mm 3/7] PM: Simplify suspend_device

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] Reduce code duplication in drivers/base/suspend.c by introducing a separate function for printing diagnostic messages. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- drivers/base/power/suspend.c | 49

[linux-usb-devel] [RFC][PATCH -mm 1/7] PM: Remove pm_parent from struct dev_pm_info

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The pm_parent member of struct dev_pm_info (defined in include/linux/pm.h) is only used to check if the device's parent is in the right state while the device is being suspended or resumed. However, this can be done just as well with the help

[linux-usb-devel] [RFC][PATCH -mm 4/7] PM: Remove suspend and resume support from struct device_type

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The suspend and resume support in struct device_type (include/linux/device.h) is not used anywhere. It is also undocumented, so it can be removed. Signed-off-by: Rafael J. Wysocki [EMAIL PROTECTED] --- drivers/base/power/resume.c |5 - drivers

[linux-usb-devel] [RFC][PATCH -mm 5/7] PM: Remove prev_state from struct dev_pm_info

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The prev_state member of struct dev_pm_info (defined in include/linux/pm.h) is only used during a resume to check if the device's state before the suspend was 'off', in which case the device is not resumed. However, in such cases the decision whether

[linux-usb-devel] [RFC][PATCH -mm 7/7] PM: Do not check parent state in suspend and resume core code

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The checks if the device's parent is in the right state done in drivers/base/power/suspend.c and drivers/base/power/resume.c serve no particular purpose, since if the parent is in a wrong power state, the device's suspend or resume callbacks are supposed

[linux-usb-devel] [RFC][PATCH -mm 6/7] PM: Remove power_state.event checks from suspend core code

2007-06-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki [EMAIL PROTECTED] The suspend routines should be called for every device during a system sleep transition, regardless of the device's state, so that drivers can regard these method calls as notifications that the system is about to go to sleep, rather than as directives

Re: [linux-usb-devel] [RFC][PATCH -mm 1/7] PM: Remove pm_parent from struct dev_pm_info

2007-06-11 Thread Rafael J. Wysocki
On Monday, 11 June 2007 17:59, Alan Stern wrote: On Mon, 11 Jun 2007, Rafael J. Wysocki wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] The pm_parent member of struct dev_pm_info (defined in include/linux/pm.h) is only used to check if the device's parent is in the right state

Re: [linux-usb-devel] ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-11 Thread Rafael J. Wysocki
On Saturday, 9 June 2007 23:26, Alan Stern wrote: On Sat, 9 Jun 2007, Rafael J. Wysocki wrote: You can try using the patch below to see what happens when you manually suspend the controller. It enables PCI devices to respond to the legacy power/state attribute. You should look

Re: [linux-usb-devel] [RFC][PATCH -mm 1/7] PM: Remove pm_parent from struct dev_pm_info

2007-06-11 Thread Rafael J. Wysocki
On Monday, 11 June 2007 20:52, Rafael J. Wysocki wrote: On Monday, 11 June 2007 17:59, Alan Stern wrote: On Mon, 11 Jun 2007, Rafael J. Wysocki wrote: From: Rafael J. Wysocki [EMAIL PROTECTED] The pm_parent member of struct dev_pm_info (defined in include/linux/pm.h) is only

Re: [linux-usb-devel] [2/2] 2.6.22-rc4: known regressions with patches v2

2007-06-10 Thread Rafael J. Wysocki
-By : Rafael J. Wysocki [EMAIL PROTECTED] Patch : http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc3/patches/21-firewire-implement-suspend-resume-hooks.patch Status : patch available The patch is already in 2.6.22-rc4, AFAICS. Greetings, Rafael -- Premature optimization

Re: [linux-usb-devel] ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-09 Thread Rafael J. Wysocki
On Sunday, 3 June 2007 17:31, Alan Stern wrote: On Sun, 3 Jun 2007, Rafael J. Wysocki wrote: Hi, One of my test boxes suspends to RAM just fine except that if ehci_hcd is loaded before the suspend, the box resumes immediately after going to sleep. Evidently the hardware thinks

Re: [linux-usb-devel] blank filenames in /sys/modules, kernel 2.6.21

2007-06-08 Thread Robert P. J. Day
that is invoked only once throughout the entire tree. rday -- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page

Re: [linux-usb-devel] blank filenames in /sys/modules, kernel 2.6.21

2007-06-08 Thread Robert P. J. Day
-- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page

Re: [linux-usb-devel] blank filenames in /sys/modules, kernel 2.6.21

2007-06-08 Thread Robert P. J. Day
On Fri, 8 Jun 2007, Greg KH wrote: On Fri, Jun 08, 2007 at 02:05:22PM -0400, Robert P. J. Day wrote: On Fri, 8 Jun 2007, Chuck Ebbert wrote: We just found a file with this name in 2.6.21: Directory name: /sys/module/nousb/parameters File name: IOW the file has

[linux-usb-devel] ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-03 Thread Rafael J. Wysocki
Hi, One of my test boxes suspends to RAM just fine except that if ehci_hcd is loaded before the suspend, the box resumes immediately after going to sleep. Greetings, Rafael -- Premature optimization is the root of all evil. - Donald Knuth

Re: [linux-usb-devel] ehci_hcd causes box to resume immediately after suspend to RAM

2007-06-03 Thread Rafael J. Wysocki
On Sunday, 3 June 2007 17:31, Alan Stern wrote: On Sun, 3 Jun 2007, Rafael J. Wysocki wrote: Hi, One of my test boxes suspends to RAM just fine except that if ehci_hcd is loaded before the suspend, the box resumes immediately after going to sleep. Evidently the hardware thinks

Re: [linux-usb-devel] [Bugme-new] [Bug 8565] New: panic on s3 resume with uhci_hcd module

2007-06-01 Thread Rafael J. Wysocki
On Saturday, 2 June 2007 00:12, Andrew Morton wrote: On Fri, 1 Jun 2007 14:08:37 -0700 [EMAIL PROTECTED] wrote: Please follow up via emailed reply-to-all, rather than via the bugzilla web interface, thanks. Michal, please track this as a post-2.6.21 regression.

Re: [linux-usb-devel] 2.6.22-rc2-mm1

2007-05-23 Thread Rafael J. Wysocki
On Wednesday, 23 May 2007 09:48, Andrew Morton wrote: On Wed, 23 May 2007 00:42:33 -0700 Andrew Morton [EMAIL PROTECTED] wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/ This is intermittently getting resume-from-RAM failures. It is not

[linux-usb-devel] [PATCH 2.6.21.1] host: remove EHCI atomic reference counting

2007-05-08 Thread Steven J. Hill
on the reference counter for EHCI is attached. Thank you. -Steve Signed-off-by: Steven J. Hill [EMAIL PROTECTED] diff -ur linux-2.6.21.1/drivers/usb/host/ehci.h linux-2.6.21.1-patched/drivers/usb/host/ehci.h --- linux-2.6.21.1/drivers/usb/host/ehci.h 2007-05-08 09:22:05.0 -0500 +++ linux-2.6.21.1

Re: [linux-usb-devel] [PATCH 0/6] Composite Gadget Support

2007-05-05 Thread Stephen J. Gowdy
/powerbar/db2/ ___ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel -- /+-\ |Stephen J. Gowdy

[linux-usb-devel] dead CONFIG_ variables: drivers/usb/

2007-05-03 Thread Robert P. J. Day
-- Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page

Re: [linux-usb-devel] USB: on suspend to ram/disk all usb devices are replugged

2007-04-02 Thread Rafael J. Wysocki
On Monday, 2 April 2007 04:54, Alan Stern wrote: On Sun, 1 Apr 2007, Rafael J. Wysocki wrote: Hi, On Sunday, 1 April 2007 20:34, Pavel Machek wrote: Hi! Problem is that suspending _with_ removable mass storage devices attached just will not work. User will unplug them

Re: [linux-usb-devel] USB: on suspend to ram/disk all usb devices are replugged

2007-04-01 Thread Rafael J. Wysocki
Hi, On Sunday, 1 April 2007 20:34, Pavel Machek wrote: Hi! Problem is that suspending _with_ removable mass storage devices attached just will not work. User will unplug them, then complain about corruption. Advanced user will unplug them, work with them somewhere else, replug

[linux-usb-devel] 【 在宅で収入 基盤 】 「20歳〜70 歳位まで」

2007-03-29 Thread digital-j
独占広告― ≪ パソコンを利用して、在宅での仕事に興味のある方 ≫ 「 空いた時間に 収入基盤を作りませんか? 」 募集要項    http://www.j-netshop.com/digital-j.html    ■空いた時間で、自宅から収入を希望される方        ■今の仕事を続けながら無理なく独立開業を希望される方     ※未成年・学生は不可です。  (今年の新卒者は資料請求までで卒業してからスタート)     ※インターネット・メール 

[linux-usb-devel] 【 パソコンで 副収入 】 「20歳〜7 0歳位まで」

2007-03-27 Thread digital-j
独占広告― 「 あなたも、パソコンを利用して    空いた時間に 収入基盤を作りませんか? 」 募集要項    http://www.j-netshop.com/digital-j.html    ■空いた時間で、自宅から収入を希望される方        ■今の仕事を続けながら無理なく独立開業を希望される方     ※未成年・学生は不可  (今年の新卒者は資料請求までで卒業してからスタート)     ※インターネット・メール レベルのパソコンスキル必須

[linux-usb-devel] 【 自宅で 収入 】 メンバー募 集 ※17期 残り5 名

2007-03-13 Thread digital-j
独占広告━━━        ◆家のパソコンを利用して、収入を得たい方      ◆空いた時間を利用して副業したい方      ◆自由な時間を利用しておこづかいを稼ぎたい主婦の方     FSS Home Office World Office inc.     ≪第17期募集要項≫   http://www.j-netshop.com/business.htm     ※すでにアメリカとヨーロッパで成功しているシステムを  

[linux-usb-devel] 【自宅で収入】 メンバー募集※17期 残 り8名

2007-03-05 Thread digital-j
独占広告━━━        ◆家のパソコンを利用して、収入を得たい方      ◆空いた時間を利用して副業したい方      ◆自由な時間を利用しておこづかいを稼ぎたい主婦の方     FSS Home Office World Office inc.     ≪第17期募集要項≫   http://www.j-netshop.com/business.htm     ※すでにアメリカとヨーロッパで成功しているシステムを  

Re: [linux-usb-devel] pl2303 usb serial - bad tty numbers starting at 2.6.20-git3

2007-03-03 Thread Adam J. Richter
On Sat, 3 Mar 2007 08:24:00 +0100, Oliver Neukum wrote: Am Freitag, 2. März 2007 22:12 schrieb Adam J. Richter: When I plug in a pl2303-based usb serial device, the device is supposed to appear as /dev/tts/USB0 (character device 188, 0). However, under kernels that I have tried from 2.6.20

[linux-usb-devel] plx2303 usb serial - bad tty numbers starting at 2.6.20-git3

2007-03-02 Thread Adam J. Richter
When I plug in a pl2303-based usb serial device, the device is supposed to appear as /dev/tts/USB0 (character device 188, 0). However, under kernels that I have tried from 2.6.20-git3 through 2.6.21-rc2-git1, /dev/tts/USBsome-random-number is created, and attempting to open that file

[linux-usb-devel] pl2303 usb serial - bad tty numbers starting at 2.6.20-git3

2007-03-02 Thread Adam J. Richter
When I plug in a pl2303-based usb serial device, the device is supposed to appear as /dev/tts/USB0 (character device 188, 0). However, under kernels that I have tried from 2.6.20-git3 through 2.6.21-rc2-git1, /dev/tts/USBsome-random-number is created, and attempting to open that file

[linux-usb-devel] 【 パソコンで 副収入 】 「20歳〜7 0歳位まで」

2007-02-26 Thread digital-j
独占広告― 「 あなたも、パソコンを利用して    空いた時間に 収入基盤を作りませんか? 」 募集要項    http://www.j-netshop.com/digital-j.html    ■空いた時間で、自宅から収入を希望される方        ■今の仕事を続けながら無理なく独立開業を希望される方     ※未成年・学生は不可  (今年の新卒者は資料請求までで卒業してからスタート)     ※インターネット・メール レベルのパソコンスキル必須

Re: [linux-usb-devel] testing of fixes for race conditions in usb serial driver #0

2007-01-09 Thread J
Hi, During the last few days me and Oliver Neukum exchanged some messages about fixing the usb-serial.c. We came to an agreement and I made a patch (which should be applied after 3 patches, which were posted by Oliver on 1/2/07 at linux-usb-devel@lists.sourceforge.net) We agreed that usb-serial

Re: [linux-usb-devel] testing of fixes for race conditions in usb serial driver #1

2007-01-02 Thread J
Hi, Sorry, I don't see how table_lock will fix the original problem, which I reported (race between serial_open and usb_serial_disconnect). I copied my original sequence of events below and I don't think that the proposed table_lock will change anything. As I wrote before, the error is that

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-22 Thread J
This problem will need some deeper surgery probably involving removal of the refcounting. Refcounting may be OK if used consistently. It is not OK when some pointers are ref-counted, but other (in serial_table) are not (like it is in the current version). As for the deeper surgery, what do

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-22 Thread J
if (!port || port-serial-dev-state == USB_STATE_NOTATTACHED) There's no use checking for attachement. The state may have changed. In fact, if a device is disconnected via sysfs, this code will happily write to a device somebody else has claimed. I don't understand. serial-dev is

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-22 Thread J
OK, if I got you right, usb-serial is not supposed to access any USB stuff after usb_serial_disconnect because device to driver association is already broken (even if usb_device structure is still in memory by means of ref counting), In fact, I just noticed the following comment (in

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-22 Thread J
No, this is a fundamental problem. You don't refcount a pointer, you refcount a data structure. But this is insufficient. We need to make sure the pointer points to valid memory. I understand. But a typical definition of ref-count requires the count in the data structure to be equal to the

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-22 Thread J
Apparently, my earlier reply was lost, trying again: 2. You must not do IO after returning from disconnect Does usb_kill_urb count as IO? Many drivers call it from their shutdown routines, which may be called after disconnect. It is perfectly valid to do (in pseudocode) disconnect:

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-20 Thread J
Please send in a patch for 2.4. It's very important to have a very reliable ultraconservative tested kernel available. I will try later. I am new to Linux driver development and never submitted any patches before. Also I am not yet 100% sure about the correct way to solve this issue. I will

Re: [linux-usb-devel] Possible race condition in usb-serial.c

2006-12-20 Thread J
Thank you for your reply. Which usb-serial driver are you having problems with? What is the oops trace? What version of the 2.4 kernel are you using? I was told to fix an old embedded device, which my company bought from somebody many years ago. It appears to have kernel 2.4.9 and a

Re: [linux-usb-devel] [PATCH 0/3] Change ohci-hcd autosuspend mechanism

2006-09-25 Thread Rafael J. Wysocki
Hi, On Monday, 25 September 2006 21:40, Alan Stern wrote: Greg and Andrew: This series of patches completely reworks the way ohci-hcd carries out root-hub autosuspends. The existing code is not compatible with the new core USB autosuspend mechanism. Patch 1 is a simple one-line change

Re: [linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd does not recognize new devices

2006-09-22 Thread Rafael J. Wysocki
On Friday, 22 September 2006 17:18, Alan Stern wrote: On Fri, 22 Sep 2006, Rafael J. Wysocki wrote: I have tested 2.6.18-rc6-mm2 with your patch applied (it is called 2.6.18-rc6 in the attached dmesg outputs, but that's because I have a customized 2.6.18-rc6-mm2 installed and I didn't

[linux-usb-devel] Fwd: USB device not getting detected.

2006-09-19 Thread Jinesh K J
-- Forwarded message -- From: pankaj chauhan [EMAIL PROTECTED] Date: Sep 18, 2006 7:31 PM Subject: USB device not getting detected. To: [EMAIL PROTECTED] hi all, i am using 2.6.11, and EHCI HCD. during boot up i get following message: usb 1-0:1.0: over-current change on port 1

Re: [linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd sometimes does not initialize properly on x86_64

2006-09-19 Thread Rafael J. Wysocki
On Tuesday, 19 September 2006 02:04, David Brownell wrote: On Friday 15 September 2006 3:13 pm, Rafael J. Wysocki wrote: Hi, It looks like the ohci_hcd driver sometimes has problems with the initialization (eg. USB mouse doesn't work after a fresh boot and reloading of the driver helps

Re: [linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd does not recognize new devices

2006-09-18 Thread Rafael J. Wysocki
On Saturday, 16 September 2006 10:13, Rafael J. Wysocki wrote: On Saturday, 16 September 2006 00:13, Rafael J. Wysocki wrote: It looks like the ohci_hcd driver sometimes has problems with the initialization (eg. USB mouse doesn't work after a fresh boot and reloading of the driver helps

Re: [linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd does not recognize new devices

2006-09-18 Thread Rafael J. Wysocki
On Monday, 18 September 2006 08:50, Jan De Luyck wrote: On Monday 18 September 2006 08:27, Rafael J. Wysocki wrote: On Saturday, 16 September 2006 10:13, Rafael J. Wysocki wrote: On Saturday, 16 September 2006 00:13, Rafael J. Wysocki wrote: It looks like the ohci_hcd driver sometimes

Re: [linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd does not recognize new devices

2006-09-18 Thread Rafael J. Wysocki
On Monday, 18 September 2006 17:07, Alan Stern wrote: On Mon, 18 Sep 2006, Rafael J. Wysocki wrote: Actually, the problem is ohci_hcd doesn't seem to recognize devices plugged into the USB ports. For example, if I unplug and replug a mouse (that worked before unplugging

[linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd does not recognize new devices

2006-09-16 Thread Rafael J. Wysocki
Hi, On Saturday, 16 September 2006 00:13, Rafael J. Wysocki wrote: It looks like the ohci_hcd driver sometimes has problems with the initialization (eg. USB mouse doesn't work after a fresh boot and reloading of the driver helps). I have observed this on two different x86_64 boxes (HPC 6325

Re: [linux-usb-devel] 2.6.18-rc6-mm2: rmmod ohci_hcd oopses on HPC 6325

2006-09-16 Thread Rafael J. Wysocki
On Saturday, 16 September 2006 00:45, Pete Zaitcev wrote: On Thu, 14 Sep 2006 13:19:53 +0200, Rafael J. Wysocki [EMAIL PROTECTED] wrote: In fact I can reproduce it on two different boxes now. How about the attached? Apparently works. :-) Thanks, Rafael -- You never change things

[linux-usb-devel] 2.6.18-rc6-mm2 (-mm1): ohci_hcd sometimes does not initialize properly on x86_64

2006-09-15 Thread Rafael J. Wysocki
Hi, It looks like the ohci_hcd driver sometimes has problems with the initialization (eg. USB mouse doesn't work after a fresh boot and reloading of the driver helps). I have observed this on two different x86_64 boxes (HPC 6325, Asus L5D), but it is not readily reproducible. Anyway I've got a

Re: [linux-usb-devel] 2.6.18-rc6-mm2: rmmod ohci_hcd oopses on HPC 6325

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 00:31, Pete Zaitcev wrote: On Wed, 13 Sep 2006 14:44:48 -0400 (EDT), Alan Stern [EMAIL PROTECTED] wrote: This problem has already been identified by Pete Zaitcev in this thread: http://marc.theaimsgroup.com/?t=11576951281r=1w=2 Perhaps Pete

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 23:55, Alan Stern wrote: On Wed, 13 Sep 2006, Rafael J. Wysocki wrote: Try this patch instead. It looks for problems occurring a little earlier in the call chain. I've applied both patches at a time (I hope they don't conflict). The dmesg output

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 15:14, Rafael J. Wysocki wrote: On Wednesday, 13 September 2006 23:55, Alan Stern wrote: On Wed, 13 Sep 2006, Rafael J. Wysocki wrote: Try this patch instead. It looks for problems occurring a little earlier in the call chain. I've applied

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 17:04, Alan Stern wrote: On Thu, 14 Sep 2006, Rafael J. Wysocki wrote: Try adding some ehci_dbg() lines in there (copy the form of the line just after restart:). We want to follow the value of hcd-self.root_hub-state. Initially it should

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 18:17, Alan Stern wrote: On Thu, 14 Sep 2006, Alan Stern wrote: Now of course, the autosuspend stuff has to work properly no matter what the kernel configuration is. I'll go back and rebuild the drivers with USB_SUSPEND turned off and see what happens.

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 19:08, Rafael J. Wysocki wrote: On Thursday, 14 September 2006 18:17, Alan Stern wrote: On Thu, 14 Sep 2006, Alan Stern wrote: Now of course, the autosuspend stuff has to work properly no matter what the kernel configuration is. I'll go back and rebuild

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 19:22, Alan Stern wrote: On Thu, 14 Sep 2006, Rafael J. Wysocki wrote: Now USB didn't work after the first resume (kernel configured with USB_SUSPEND unset). The dmesg output is attached. This is getting too confusing. :-( Sorry for the confusion

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 20:28, Alan Stern wrote: On Thu, 14 Sep 2006, Rafael J. Wysocki wrote: Let's try a simpler test. Leave USB_SUSPEND unset. First rmmod ohci-hcd. None of your full-speed USB devices will work, but that's okay. Try the suspend-twice test and see what

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 21:37, Rafael J. Wysocki wrote: On Thursday, 14 September 2006 20:28, Alan Stern wrote: On Thu, 14 Sep 2006, Rafael J. Wysocki wrote: Let's try a simpler test. Leave USB_SUSPEND unset. First rmmod ohci-hcd. None of your full-speed USB devices

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-14 Thread Rafael J. Wysocki
On Thursday, 14 September 2006 22:55, Alan Stern wrote: On Thu, 14 Sep 2006, Rafael J. Wysocki wrote: Well, sorry. This test has been passed, but after a reboot it refused to suspend just once giving the same messages that I've got from the kernel with USB_SUSPEND set (the relevant dmesg

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-13 Thread Rafael J. Wysocki
On Saturday, 9 September 2006 00:57, Rafael J. Wysocki wrote: On Friday, 8 September 2006 22:44, Alan Stern wrote: On Fri, 8 Sep 2006, Andrew Morton wrote: Alan, is this likely to be due to your USB PM changes? It's possible. Most of those changes are innocuous. They add routines

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-13 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 14:07, Rafael J. Wysocki wrote: On Saturday, 9 September 2006 00:57, Rafael J. Wysocki wrote: On Friday, 8 September 2006 22:44, Alan Stern wrote: On Fri, 8 Sep 2006, Andrew Morton wrote: Alan, is this likely to be due to your USB PM changes

[linux-usb-devel] 2.6.18-rc6-mm2: rmmod ohci_hcd oopses on HPC 6325

2006-09-13 Thread Rafael J. Wysocki
On Tuesday, 12 September 2006 09:06, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/ 'rmmod ohci_hcd' causes the following oops to appear on my HPC 6325 every time (happens also on -rc6-mm1, does not happen on -rc7): Unable to

Re: [linux-usb-devel] 2.6.18-rc6-mm2: rmmod ohci_hcd oopses on HPC 6325

2006-09-13 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 15:58, Rafael J. Wysocki wrote: On Tuesday, 12 September 2006 09:06, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm2/ 'rmmod ohci_hcd' causes the following oops to appear on my HPC 6325 every

Re: [linux-usb-devel] 2.6.18-rc6-mm1

2006-09-13 Thread Rafael J. Wysocki
On Tuesday, 12 September 2006 22:10, Alan Stern wrote: On Tue, 12 Sep 2006, Mattia Dongili wrote: No luck here. I'll give -mm2 a run just to full dmesg with patch applied[1]: http://oioio.altervista.org/linux/dmesg-2.6.18-rc6-mm1-fail-S3-2 without it (it's almost identical :)):

Re: [linux-usb-devel] 2.6.18-rc6-mm2: rmmod ohci_hcd oopses on HPC 6325

2006-09-13 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 20:44, Alan Stern wrote: On Wed, 13 Sep 2006, Rafael J. Wysocki wrote: 'rmmod ohci_hcd' causes the following oops to appear on my HPC 6325 every time (happens also on -rc6-mm1, does not happen on -rc7): Unable to handle kernel NULL pointer dereference

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-13 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 20:38, Alan Stern wrote: On Wed, 13 Sep 2006, Rafael J. Wysocki wrote: Well, I have reproduced it with gregkh-usb-usbcore-remove-usb_suspend_root_hub.patch reverted too. Attached is the output of dmesg from the failing case with USB_DEBUG set

Re: [linux-usb-devel] 2.6.18-rc6-mm1 (-mm2): ohci resume problem

2006-09-13 Thread Rafael J. Wysocki
On Wednesday, 13 September 2006 23:01, Alan Stern wrote: On Wed, 13 Sep 2006, Rafael J. Wysocki wrote: The patch below will add some extra debugging information. We need to find out why the resume didn't succeed. Oh -- and of course, you should reinstate all those autosuspend patches

Re: [linux-usb-devel] 2.6.18-rc6-mm1

2006-09-11 Thread Rafael J. Wysocki
On Saturday, 9 September 2006 00:57, Rafael J. Wysocki wrote: On Friday, 8 September 2006 22:44, Alan Stern wrote: On Fri, 8 Sep 2006, Andrew Morton wrote: Alan, is this likely to be due to your USB PM changes? It's possible. Most of those changes are innocuous. They add routines

Re: [linux-usb-devel] 2.6.18-rc6-mm1

2006-09-08 Thread Rafael J. Wysocki
On Friday, 8 September 2006 10:13, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc6/2.6.18-rc6-mm1/ ohci_hcd doesn't work after a resume from disk on HPC nx6325, worked on 2.6.18-rc5-mm1. It helps if I rmmod and modprobe it after the resume.

Re: [linux-usb-devel] 2.6.18-rc6-mm1

2006-09-08 Thread Rafael J. Wysocki
On Friday, 8 September 2006 22:44, Alan Stern wrote: On Fri, 8 Sep 2006, Andrew Morton wrote: Alan, is this likely to be due to your USB PM changes? It's possible. Most of those changes are innocuous. They add routines that don't get used until a later patch. However one of them might

Re: [linux-usb-devel] 2.6.18-rc1-mm2

2006-07-14 Thread Rafael J. Wysocki
On Friday 14 July 2006 07:48, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc1/2.6.18-rc1-mm2/ - Patches were merged, added, dropped and fixed. Nothing particularly exciting. This happens on my box at startup, every time: ehci_hcd

Re: [linux-usb-devel] 2.6.18-rc1-mm2

2006-07-14 Thread Rafael J. Wysocki
On Friday 14 July 2006 20:36, Michal Piotrowski wrote: Hi Andrew, On 14/07/06, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 14 Jul 2006 13:36:08 +0200 Rafael J. Wysocki [EMAIL PROTECTED] wrote: Unable to handle kernel NULL pointer dereference at 0038 RIP

Re: [linux-usb-devel] system hang when working with 32 devices connected to single root hub port

2006-06-29 Thread Jinesh K J
On 6/29/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi, hi, I am working on an tool which is used for end to end testing of a telephone network. As a part of the tool, we have mobiles connected to the system (with kernel-2.6.16.13). The mobiles(CDC devices) being used are USB 2.0 full

Re: [linux-usb-devel] boot from usb again

2006-06-20 Thread Jinesh K J
On 6/20/06, Ken Cobler [EMAIL PROTECTED] wrote: Wojciech Kromer wrote: Dnia 2006-06-19 13:13, Użytkownik Jinesh K J napisał: On 6/19/06, Wojciech Kromer [EMAIL PROTECTED] wrote: After reading lot of discusions on this issue, I can't still get why there is an error booting from root

Re: [linux-usb-devel] boot from usb again

2006-06-19 Thread Jinesh K J
On 6/19/06, Wojciech Kromer [EMAIL PROTECTED] wrote: After reading lot of discusions on this issue, I can't still get why there is an error booting from root=/dev/sda1 or even root=8:1. so, what is the error shown? i hope usb-storage module is built into the kernel! and I can mount it after

Re: [linux-usb-devel] platform_device.dev.release not getting called under X Windows

2006-06-09 Thread Jinesh K J
hi, are u using printk() for tracing the function calls. then it might happen that xterm is just not displaying the output. i'm not familiar with pcmcia, so please forgive me for any foolish comments. On 6/9/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi all, We are developing a device

  1   2   3   >