[linux-usb-devel] [PATCH] please review mcs7830 (DeLOCK USB etherner) driver

2006-08-07 Thread Arnd Bergmann
I've been unfortunate to stumble over the MosChip 7830 USB2 10/100 Ethernet adapter. There was a driver for it provided on the manufacturer's web site, but since I intend need to use the device in the future, I decided to clean that driver up and get it into shape for inclusion. The code below sho

Re: [linux-usb-devel] [PATCH] please review mcs7830 (DeLOCK USB etherner) driver

2006-08-07 Thread David Hollis
On Mon, 2006-08-07 at 15:00 +0200, Arnd Bergmann wrote: > + > +/* index for PHY registers */ > +enum { > + PHY_CONTROL_REG_INDEX = 0, > + PHY_STATUS_REG_INDEX= 1, > + PHY_IDENTIFICATION1_REG_INDEX = 2, > + PHY_IDENTIFICATION2_REG_IN

Re: [linux-usb-devel] [PATCH] please review mcs7830 (DeLOCK USB etherner) driver

2006-08-07 Thread Arnd Bergmann
On Monday 07 August 2006 16:54, David Hollis wrote: > These values are dupes of the MII_ constants from linux/mii.h.  It > would be clearer and more consistent to use those instead ok > These values are device specific so you would want to define them here. > Following the MII_x naming co