[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-21 Thread Linus Torvalds
On Sat, 21 Jun 2003, Linus Torvalds wrote: > > > So, if my theory sounds correct to you, can you try moving the call to > > scsi_device_register() to the end of scsi_add_lun()? > > Yes. > > I also have this strong urge make the default "use_10_for_ms" value be 1, > since making the default val

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-21 Thread Matthew Dharm
On Sat, Jun 21, 2003 at 11:49:47AM -0700, Linus Torvalds wrote: > On Sat, 21 Jun 2003, Matthew Dharm wrote: > > > > However, my top suspect is the call to scsi_device_register() in > > scsi_add_lun(), which takes place _well_ before the sdev is properly > > configured. At first, I thought that ju

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-21 Thread Linus Torvalds
On Sat, 21 Jun 2003, Matthew Dharm wrote: > > However, my top suspect is the call to scsi_device_register() in > scsi_add_lun(), which takes place _well_ before the sdev is properly > configured. At first, I thought that just creates some devfs entries, but > if that is what triggers the probing

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-21 Thread Matthew Dharm
On Fri, Jun 20, 2003 at 08:22:16PM -0700, Linus Torvalds wrote: > > On Fri, 20 Jun 2003, Linus Torvalds wrote: > > > > Are you sure that your devices don't just handle READ_6 and SENSE_6 ok? > > I'm pretty sure your devices just handle it. I'm dead certain they don't. My logs (USB Mass Storage

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-20 Thread Linus Torvalds
On Fri, 20 Jun 2003, Linus Torvalds wrote: > > Are you sure that your devices don't just handle READ_6 and SENSE_6 ok? I'm pretty sure your devices just handle it. Because adding some debugging code seems to clearly show that when you moved the setting of "use_10_for_XX" to the scanning phase,

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-20 Thread Linus Torvalds
On Fri, 20 Jun 2003, Matthew Dharm wrote: > > This is actually the second complaint I've gotten along these lines... in > the other case, it appeared that the MODE_SENSE/MODE_SENSE_10 logic had > gotten screwed up. > > I think it might actually be a merging problem somewhere along the line, > bec

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-20 Thread Matthew Dharm
This is actually the second complaint I've gotten along these lines... in the other case, it appeared that the MODE_SENSE/MODE_SENSE_10 logic had gotten screwed up. I think it might actually be a merging problem somewhere along the line, because my tree (which is based off of the USB tree) works j

[linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.72

2003-06-20 Thread Linus Torvalds
USB storage is broken for me recently (like in the last 5 days or so). My good old SIIG USB-2 "hi-speed" CF reader that used to be very reliable now will refuse to even read the partition table. The problem _seems_ to be that somebody broken the READ_10 logic, and it now always does a READ_6. W