[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-07 Thread nardelli
Richard B. Johnson wrote: On Mon, 7 Jun 2004, nardelli wrote: Greg KH wrote: On Fri, Jun 04, 2004 at 05:34:41PM +0100, Ian Abbott wrote: On 04/06/2004 15:59, nardelli wrote: [SNIPPED...] = drivers/usb/serial/visor.c 1.114 vs edited = --- 1.114/drivers/usb/serial/visor.cFri Jun 4 07:

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-07 Thread Richard B. Johnson
On Mon, 7 Jun 2004, nardelli wrote: > Greg KH wrote: > > On Fri, Jun 04, 2004 at 05:34:41PM +0100, Ian Abbott wrote: > > > >>On 04/06/2004 15:59, nardelli wrote: [SNIPPED...] > > > > > > = drivers/usb/serial/visor.c 1.114 vs edited = > > --- 1.114/drivers/usb/serial/visor.cFri Jun

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-07 Thread nardelli
Greg KH wrote: On Fri, Jun 04, 2004 at 05:34:41PM +0100, Ian Abbott wrote: On 04/06/2004 15:59, nardelli wrote: A related problem with the current implementation is that is easy to run out of memory by running something similar to this: # cat /dev/zero > /dev/ttyUSB0 That affects both the ftdi_si

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-07 Thread Ian Abbott
On 04/06/2004 19:04, Pete Zaitcev wrote: On Fri, 04 Jun 2004 17:34:41 +0100 Ian Abbott <[EMAIL PROTECTED]> wrote: I made the original change to ftdi_sio.c to allocate the write urbs and their transfer buffers dynamically (instead of using a preallocated pool) and I copied that technique from viso

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 05:34:41PM +0100, Ian Abbott wrote: > On 04/06/2004 15:59, nardelli wrote: > >Note that I have not verified any of the below on > >hardware associated with drivers/usb/serial/ftdi_sio.c, > >only with drivers/usb/serial/visor.c. If anyone has > >hardware for this device, I w

Re: [linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Peter Horton
On Fri, Jun 04, 2004 at 05:34:41PM +0100, Ian Abbott wrote: > > A related problem with the current implementation is that is easy to > run out of memory by running something similar to this: > > # cat /dev/zero > /dev/ttyUSB0 > I got bitten by this a couple of days ago. There is effectively n

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 02:47:51PM -0400, nardelli wrote: > ^*(&*(# editor not copying tabs - I should have caught that. > Here's another try: > > > This was prepared against 2.6.7-rc2. Heh, much better. Applied, thanks. greg k-h --- This

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread nardelli
^*(&*(# editor not copying tabs - I should have caught that. Here's another try: This was prepared against 2.6.7-rc2. Signed-off-by: Joe Nardelli <[EMAIL PROTECTED]> diff -uprN -X dontdiff linux-2.6.7-rc2.orig/drivers/usb/serial/ftdi_sio.c linux-2.6.7-rc2/drivers/usb/serial/ftdi_sio.c --- linux-

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Greg KH
On Fri, Jun 04, 2004 at 10:59:57AM -0400, nardelli wrote: > Note that I have not verified any of the below on > hardware associated with drivers/usb/serial/ftdi_sio.c, > only with drivers/usb/serial/visor.c. If anyone has > hardware for this device, I would appreciate your comments. > > A memory

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Pete Zaitcev
On Fri, 04 Jun 2004 17:34:41 +0100 Ian Abbott <[EMAIL PROTECTED]> wrote: > I made the original change to ftdi_sio.c to allocate the write urbs > and their transfer buffers dynamically (instead of using a > preallocated pool) and I copied that technique from visor.c! > > A related problem with t

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread Ian Abbott
On 04/06/2004 15:59, nardelli wrote: Note that I have not verified any of the below on hardware associated with drivers/usb/serial/ftdi_sio.c, only with drivers/usb/serial/visor.c. If anyone has hardware for this device, I would appreciate your comments. A memory leak occurs in both drivers/usb/se

[linux-usb-devel] Re: [PATCH] Memory leak in visor.c and ftdi_sio.c

2004-06-04 Thread nardelli
Ian Abbott wrote: On 04/06/2004 15:59, nardelli wrote: Note that I have not verified any of the below on hardware associated with drivers/usb/serial/ftdi_sio.c, only with drivers/usb/serial/visor.c. If anyone has hardware for this device, I would appreciate your comments. A memory leak occurs in b