On Fri, 03 Mar 2006 07:53:28 +0100, Arjan van de Ven wrote:
> On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
>> So you are saying that, for example
>>
>> spin_lock_irqsave(&cs->ev_lock, flags);
>> head = cs->ev_head;
>> tail = cs->ev_tail;
>> spin_unlock_irqrestore(&
On Fri, Mar 03, 2006 at 07:53:28AM +0100, Arjan van de Ven wrote:
> On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
...
>
> > >>+#define IFNULL(a) \
> > >>+ if (unlikely(!(a)))
> > >
> > > please please get rid of this!
> > > (same goes for the variants of this just below this)
> >
On Fri, 2006-03-03 at 00:03 +0100, Tilman Schmidt wrote:
> Thank you very much, Arjan, for your review of our code and your
> extensive comments. We are working on taking them into account for the
> next attempt at submitting the driver. Most of them are quite clear and
> don't need discussing. Jus
> So you are saying that, for example
>
> spin_lock_irqsave(&cs->ev_lock, flags);
> head = cs->ev_head;
> tail = cs->ev_tail;
> spin_unlock_irqrestore(&cs->ev_lock, flags);
>
> is (mutatis mutandis) actually cheaper than
>
> head = atomic_read(&cs->ev_head);
>
Thank you very much, Arjan, for your review of our code and your
extensive comments. We are working on taking them into account for the
next attempt at submitting the driver. Most of them are quite clear and
don't need discussing. Just a few remarks and questions:
On 27.02.2006, Arjan van de Ven w
On Mon, 2006-02-27 at 07:23 +0100, Hansjoerg Lipp wrote:
> The following patches add drivers for the Siemens Gigaset 3070 family of
> ISDN DECT PABXes connected via USB, either directly or over a DECT link
> using a Gigaset M105 or compatible DECT data adapter. The devices are
> integrated as ISDN
