Re: [linux-usb-devel] Re: [PATCH 2.6.11.7 1/2] USB HID: Patch for Cherry CyMotion Linux keyboard

2005-04-19 Thread Andy Armstrong
On 19 Apr 2005, at 13:15, Vojtech Pavlik wrote: How would you see that working? (You'll have to forgive me - I haven't actually looked at the HID code before). Have a static __devinit array with the whole descriptor, and simply copy that into the request buffer instead of trying to get it from the

Re: [linux-usb-devel] Re: [PATCH 2.6.11.7 1/2] USB HID: Patch for Cherry CyMotion Linux keyboard

2005-04-19 Thread Vojtech Pavlik
On Tue, Apr 19, 2005 at 01:12:45PM +0100, Andy Armstrong wrote: > >The patch looks fairly well, however, I'd prefer to replace the HID > >descriptor completely instead of patching it in the patch. This will > >allow to add fixed descriptors for other devices where the descriptors > >are broken. >

Re: [linux-usb-devel] Re: [PATCH 2.6.11.7 1/2] USB HID: Patch for Cherry CyMotion Linux keyboard

2005-04-19 Thread Andy Armstrong
On 19 Apr 2005, at 12:58, Vojtech Pavlik wrote: The patch looks fairly well, however, I'd prefer to replace the HID descriptor completely instead of patching it in the patch. This will allow to add fixed descriptors for other devices where the descriptors are broken. How would you see that working?

[linux-usb-devel] Re: [PATCH 2.6.11.7 1/2] USB HID: Patch for Cherry CyMotion Linux keyboard

2005-04-19 Thread Vojtech Pavlik
On Mon, Apr 18, 2005 at 09:49:50PM +0100, Andy Armstrong wrote: > For those who haven't seen it the Cherry CyMotion Linux keyboard is a > decent quality keyboard with the Windows specific keys replaced with > Linux keys. It's got a nice little picture of Tux on it too. The > supplied patches aren