Re: [linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-19 Thread Andries Brouwer
On Tue, Nov 19, 2002 at 04:47:58PM -0800, David Brownell wrote: > > >>Yeah, looking at struct urb, transfer_buffer is a void *, so nevermind, > >>I'll take this patch. Sorry for the noise :) > > > >It's really a bunch of bytes, right? So u8 * would be a better description? > > Doesn't "void *" b

Re: [linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-19 Thread Greg KH
On Tue, Nov 19, 2002 at 04:47:58PM -0800, David Brownell wrote: > > >>Yeah, looking at struct urb, transfer_buffer is a void *, so nevermind, > >>I'll take this patch. Sorry for the noise :) > > > >It's really a bunch of bytes, right? So u8 * would be a better description? > > Doesn't "void *" b

Re: [linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-18 Thread Greg KH
On Mon, Nov 18, 2002 at 05:19:27PM +1100, Brad Hards wrote: > On Mon, 18 Nov 2002 12:22, Greg KH wrote: > > On Sun, Nov 17, 2002 at 04:07:50PM -0800, Matthew Dharm wrote: > > > It's a matter of avoiding typecasts everywhere. We get a void*, and > > > we send void* on to other places. > > > > Yeah,

Re: [linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-17 Thread Brad Hards
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 18 Nov 2002 12:22, Greg KH wrote: > On Sun, Nov 17, 2002 at 04:07:50PM -0800, Matthew Dharm wrote: > > It's a matter of avoiding typecasts everywhere. We get a void*, and > > we send void* on to other places. > > Yeah, looking at struct urb, t

[linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-17 Thread Greg KH
On Sun, Nov 17, 2002 at 04:07:50PM -0800, Matthew Dharm wrote: > It's a matter of avoiding typecasts everywhere. We get a void*, and > we send void* on to other places. Yeah, looking at struct urb, transfer_buffer is a void *, so nevermind, I'll take this patch. Sorry for the noise :) thanks,

[linux-usb-devel] Re: [usb-storage] Re: PATCH: change function signatures and cleanup debug msgs

2002-11-17 Thread Matthew Dharm
It's a matter of avoiding typecasts everywhere. We get a void*, and we send void* on to other places. If you look at one of the other patches I sent today, you'll notice that if you apply it, you'll get warnings because of the disparity. I guess we could fix it by switching everything to char* i