[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-27 Thread Alan Stern
On Sun, 27 Nov 2005, Pavel Machek wrote: > Hi! > > Of course I forgot the patch... > > Pavel > > Remove useless initalizers. > > Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> Signed-off-by: Alan Stern <[EMAIL PROTECTED]> > > diff --git

[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Pavel Machek
Hi! Of course I forgot the patch... Pavel Remove useless initalizers. Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/usb/gadget/file_storage.c b/drivers/usb/gadget/file_storage.c --- a/drivers/usb/gadget/file_storag

[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Pavel Machek
Hi! > > > What's the reason for this prejudice against C++-style comments in the > > > kernel? I've never understood it... They seem so obviously useful, > > > saving 3 characters of typing at the end of each comment line. > > > > I've never seen a piece of non-crappy code using them... that's

[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Alan Stern
On Sat, 26 Nov 2005, Pavel Machek wrote: > Hi! > > > > This converts comments into C-style, > > > > You missed a lot of them. > > Yes, I know, at one point I realized you probably liked it that > way. Shall I resent just the "remove the initializer" part? Yes, okay. If nobody really minds the

Re: [linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Pete Zaitcev
On Sat, 26 Nov 2005 22:06:58 +0100, Pavel Machek <[EMAIL PROTECTED]> wrote: > > > It uses 'volatile' quite heavily, and that scares me a lot. > > > > Alan Cox didn't like it either, but he wasn't able to give a clear > > explanation why not. He just mumbled something about C compilers > > gen

[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Pavel Machek
Hi! > > This converts comments into C-style, > > You missed a lot of them. Yes, I know, at one point I realized you probably liked it that way. Shall I resent just the "remove the initializer" part? > What's the reason for this prejudice against C++-style comments in the > kernel? I've never u

[linux-usb-devel] Re: Cleanups for usb gadget mass-storage

2005-11-26 Thread Alan Stern
On Sat, 26 Nov 2005, Pavel Machek wrote: > Hi! > > This converts comments into C-style, You missed a lot of them. What's the reason for this prejudice against C++-style comments in the kernel? I've never understood it... They seem so obviously useful, saving 3 characters of typing at the end