Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2002-01-03 Thread Oliver.Neukum
On Thu, 3 Jan 2002, Greg KH wrote: > On Thu, Jan 03, 2002 at 10:33:55AM +0100, [EMAIL PROTECTED] wrote: > > > > Regarding devio.c, specifically proc_ioctl(). > > How is it ensured that the ps->dev pointer stays valid although the memory > > allocations might sleep ? > > That's a good question, bu

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2002-01-03 Thread Greg KH
On Thu, Jan 03, 2002 at 10:33:55AM +0100, [EMAIL PROTECTED] wrote: > > Regarding devio.c, specifically proc_ioctl(). > How is it ensured that the ps->dev pointer stays valid although the memory > allocations might sleep ? That's a good question, but it's not relevant to the __MOD_* change that I

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2002-01-03 Thread Oliver.Neukum
On Wed, 2 Jan 2002, Greg KH wrote: > On Wed, Dec 19, 2001 at 10:31:31AM +0100, [EMAIL PROTECTED] wrote: > > Hi, > > > > this adds module usage count handling during probe and disconnect to the > > usb core. It applies to 2.5.1 and is now in the smallest possible form. > > I did not go at the old

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-25 Thread Oliver.Neukum
> > I don't think it _can_ go away. Among other things, driver > > frameworks layered on top of USB (say, usb-serial :) need > > to rely on it, since the device-specific code isn't what's > > managing all the probe() calls. > > Exactly. It will not go away. > > Oliver, can you redo your patch an

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-25 Thread Oliver.Neukum
> > > What do you mean "old style probe"? > > > > The special casing for drivers that don't supply an id_table. > > IMHO it should go away. > > I don't think it _can_ go away. Among other things, driver > frameworks layered on top of USB (say, usb-serial :) need > to rely on it, since the device-

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-25 Thread Oliver.Neukum
On Fri, 21 Dec 2001, David Brownell wrote: > > > But the drivers' ID tables are part of the module ... > > > what's the locking being done to prevent rmmod > > > during the usb_match_id() call? > > > > On 2.5 it is protected, once the module subsystem patches are in, by > > usb_match_id() not sle

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-22 Thread Greg KH
On Fri, Dec 21, 2001 at 10:41:43AM -0800, David Brownell wrote: > > > > I did not go at the old style probe, as it shoulde be IMO removed. > > > > > > What do you mean "old style probe"? > > > > The special casing for drivers that don't supply an id_table. > > IMHO it should go away. > > I don't

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-22 Thread David Brownell
> > But the drivers' ID tables are part of the module ... > > what's the locking being done to prevent rmmod > > during the usb_match_id() call? > > On 2.5 it is protected, once the module subsystem patches are in, by > usb_match_id() not sleeping. And you're expecting every probe() to not sleep

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-22 Thread David Brownell
> > > I did not go at the old style probe, as it shoulde be IMO removed. > > > > What do you mean "old style probe"? > > The special casing for drivers that don't supply an id_table. > IMHO it should go away. I don't think it _can_ go away. Among other things, driver frameworks layered on top o

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-21 Thread Oliver.Neukum
On Wed, 19 Dec 2001, Greg KH wrote: > On Wed, Dec 19, 2001 at 10:31:31AM +0100, [EMAIL PROTECTED] wrote: > > Hi, > > > > this adds module usage count handling during probe and disconnect to the > > usb core. It applies to 2.5.1 and is now in the smallest possible form. > > I did not go at the old

Re: [linux-usb-devel] patch to handle module usage counts in usbcore

2001-12-21 Thread Oliver.Neukum
On Wed, 19 Dec 2001, David Brownell wrote: > But the drivers' ID tables are part of the module ... > what's the locking being done to prevent rmmod > during the usb_match_id() call? On 2.5 it is protected, once the module subsystem patches are in, by usb_match_id() not sleeping. As this patch is