On Friday 04 February 2005 5:39 am, Thomas Brinker wrote:
> > Three problems raised with what you sent:
> > (a) #ifdef ARM is clearly wrong
> I just kicked it out
Thanks.
> > ; and as Sergey said, (b) the right value is NET_IP_ALIGN as defined
> > in ,
> Yeah thats much better
> > plus (c)
Hi!
Am Freitag, 4. Februar 2005 08:28 schrieben Sie:
> On Wednesday 26 January 2005 1:30 pm, you wrote:
> > Am Mittwoch, 26. Januar 2005 21:39 schrieben Sie:
> > > And it's _demonstrably false_ that IP packets are always aligned on
> > > such boundaries. Remember, lots of other ARM platforms (v4 a
On Wed, Jan 26, 2005 at 06:29:16PM +0100, Thomas Brinker wrote:
> Ok, I have got it!
>
> The IP Packets must be aligned to 32bit on ARM.
>
> This patch takes care about the alignment. Please consider applying.
With this change the skb buffer would be overflowed - the size specified
in the alloc_
Am Mittwoch, 26. Januar 2005 18:29 schrieb Thomas Brinker:
> Hi!
>
> Ok, I have got it!
>
> The IP Packets must be aligned to 32bit on ARM.
>
> This patch takes care about the alignment. Please consider applying.
That alignment won't hurt on any platform. What happens if IP
is encapsulated in a
Am Mittwoch, 26. Januar 2005 18:48 schrieb Oliver Neukum:
> That alignment won't hurt on any platform. What happens if IP
> is encapsulated in another protocol?
In fact the IP-Packets are encapsulated in an ethernet frame and because
ethernet headers are 14Byte, the IP-Header starts at an not 32Bi
On Wednesday 26 January 2005 9:29 am, Thomas Brinker wrote:
>
> The IP Packets must be aligned to 32bit on ARM.
That's not true; that driver is used on lots of ARM chips without
any such alignment. There must be a bug in your new UDC driver.
> Is it OK not to have a ethnernet ckechsum?
In fac
Hi!
Ok, I have got it!
The IP Packets must be aligned to 32bit on ARM.
This patch takes care about the alignment. Please consider applying.
Regards
Thomas
--- drivers/usb/gadget/ether.c_ori 2005-01-26 18:22:17.0 +0100
+++ drivers/usb/gadget/ether.c 2005-01-26 18:22:19.0 +0100
@@