On 9 July 2015 at 14:46, Rafał Miłecki zaj...@gmail.com wrote:
Broadcom's firmware requires every BSS to use MAC address with unique
last 2 bits. Otherwise it rejects submitted MAC which results in:
brcmfmac: _brcmf_set_mac_address: Setting cur_etheraddr failed, -52
Set addr_mask properly to
On Wed, Jul 08, 2015 at 12:19:18PM +0200, Zefir Kurtisi wrote:
My claim is that in its current state the regdb does not exactly formalize the
limitations given by regulatory for a simple reason: it uses channel semantics
where it should only handle frequency ranges. Take the discussed rules for
Broadcom's firmware requires every BSS to use MAC address with unique
last few bits. The amount of bits may depend on a particular firmware,
it was verified to be 2 for BCM43602 one.
If this condition won't be fulfilled firmware will reject such MAC:
brcmfmac: _brcmf_set_mac_address: Setting
On Fri, 2015-07-03 at 06:10 +, David Lin wrote:
Hello,
The Linux driver for WRT1900AC. The work was initially developed as
part of openwrt effort and maintained on
https://github.com/kaloz/mwlwifi.
I see *massive* code duplication with the mwl8k driver.
This is, I guess, not a surprise
Add IEEE80211_HW_SUPPORTS_PS to ieee80211_hw flags
enabling this feature.
Signed-off-by: Malcolm Priestley tvbox...@gmail.com
---
v2 rebased for 4.2
drivers/staging/vt6655/device_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vt6655/device_main.c
Sometimes bssid can go null on failed association.
Signed-off-by: Malcolm Priestley tvbox...@gmail.com
Cc: sta...@vger.kernel.org # v3.19+
---
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c
On Wed, Jul 08, 2015 at 05:27:38PM +0200, SF Markus Elfring wrote:
Note also that some maintainers have work flow that deliberately smash
the date (i.e., because they are using a system such as guilt),
so if you are depending on the submitted timestamp, it's going to
break on you.
On 07/09/2015 08:25 PM, Arend van Spriel wrote:
On 07/09/2015 10:13 AM, Vineet Gupta wrote:
There's already a generic implementation so use that instead.
There is or there was? If there is now I am fine with this patch, but if
it already was there the author might have had a reason for adding
On 07/08/2015 10:22 PM, Christophe JAILLET wrote:
Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve
readability.
Not sure if readability is really the issue here. At most it is a small
reduction of driver code by using kstrdup(). Anyway, the patch looks fine so
Acked-by:
Hello again.
After fixing user space - brcmfmac communication for using valid MACs:
[PATCH] brcmfmac: set wiphy's addresses to provide valid MACs
i started testing multiple interfaces.
It seems there are many bugs in brcmfmac :(
So after running 3 AP interfaces and switching my STA device
On 07/09/2015 09:07 AM, Rafał Miłecki wrote:
Hey guys, I'm afraid I hit another brcmfmac bug.
First of all, I implemented a trivial workaround for the previous bug
reported in the:
brcmfmac: one faulty iw interface add command breaks in-firmware BSS state
See my workaround in OpenWrt git:
On 9 July 2015 at 20:08, Arend van Spriel ar...@broadcom.com wrote:
On 07/09/2015 09:07 AM, Rafał Miłecki wrote:
Hey guys, I'm afraid I hit another brcmfmac bug.
First of all, I implemented a trivial workaround for the previous bug
reported in the:
brcmfmac: one faulty iw interface add
On 07/09/2015 10:13 AM, Vineet Gupta wrote:
There's already a generic implementation so use that instead.
There is or there was? If there is now I am fine with this patch, but if
it already was there the author might have had a reason for adding a
local function and I would like to hear that
On 9 July 2015 at 20:48, Arend van Spriel ar...@broadcom.com wrote:
On 07/09/2015 08:01 PM, Rafał Miłecki wrote:
After fixing user space - brcmfmac communication for using valid MACs:
[PATCH] brcmfmac: set wiphy's addresses to provide valid MACs
i started testing multiple interfaces.
It
On 07/09/2015 08:01 PM, Rafał Miłecki wrote:
Hello again.
After fixing user space - brcmfmac communication for using valid MACs:
[PATCH] brcmfmac: set wiphy's addresses to provide valid MACs
i started testing multiple interfaces.
It seems there are many bugs in brcmfmac :(
Well, you are
On 10 July 2015 at 02:03, Ben Greear gree...@candelatech.com wrote:
Suppose one is doing heavy download (AP - peer traffic), and there are lots
of frames in the
NIC's tx buffers (ath10k firmware, in this case).
Then, peer sends a power-save pkt telling AP it is going off-channel or
On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote:
On 07/09/2015 10:13 AM, Vineet Gupta wrote:
There's already a generic implementation so use that instead.
There is or there was? If there is now I am fine with this patch, but if
it already was there the author might have had a
Last argument of wilc_wlan_cfg_set function is actually structure's address.
This should be changed to be compatible with 64bit machine.
Because wilc_wlan_cfg_set function is mapped by function pointer later,
wilc_wlan_oup_t.wlan_cfg_set should be changed together.
tstrWILC_WFIDrv structure is
This patch replaces a integer argument of SendConfigPkt function with
void type pointer and fix code that the function is called.
Because tstrWILC_WFIDrv structure is defined after SendConfigPkt function
is defined, the function can not refer to the structure type.
So this patch change the
Hello Greg.
This driver convert pointer address to integer value and use it
as function argument. because the value has a limited 32bit size,
current driver happen many issues on x64 machine.
I have split it up enough sensibliy to allow review. If this patches
are accepted, I will update more
A argument of wilc_wlan_cfg_commit() is address of structure.
But because the size is restricted to 32bit, it is not correct
for 64bit machine.
So, this changes the interger value to obvious structure pointer.
Signed-off-by: Johnny Kim johnny@atmel.com
---
gu8FlushedJoinReqDrvHandler variable is be using to save structure pointer.
But because that is restricted to 32bit and has needless casting,
the varibale should be changed to pointer of same type.
Signed-off-by: Johnny Kim johnny@atmel.com
---
drivers/staging/wilc1000/host_interface.c | 16
Last argument of wilc_wlan_cfg_get function is actually structure's address.
This should be changed to be compatible with 64bit machine.
Because wilc_wlan_cfg_get function is mapped by function pointer later,
wilc_wlan_oup_t.wlan_cfg_get should be changed together.
tstrWILC_WFIDrv structure is
Found incorrect sequence in ath10k_core_stop() where wmi pktlog
disable cmd is passed from ath10k_debug_stop() to firmware
immediately after wmi pdev suspend cmd. Firmware will not accept
any wmi cmd after receiving wmi pdev suspend cmd.
Fix this issue in ath10k_core_stop() by moving
If .pull_fw_stats() fails for some reason while processing
fw stats event, collected pdev/vdev/peer stats just before
the failure should be freed. This is unlikely to happen,
just code review catch.
Signed-off-by: Raja Mani rm...@qti.qualcomm.com
---
drivers/net/wireless/ath/ath10k/debug.c | 3
On 9 July 2015 at 09:07, Rafał Miłecki zaj...@gmail.com wrote:
The problem appears when trying to use more than 1 interface. It gets
created correctly, but setting its MAC fails. It results in wlan0-1
having the same MAC as wlan0 and finally having two networks (SSIDs)
using the same MAC. That
The expiration function must not be called when
roc is explicitly cancelled by mac80211. However
since fcf9844636be (ath10k: fix hw roc
expiration) the notification was never sent when
roc actually expired.
This fixes some P2P connection setup issues.
Signed-off-by: Michal Kazior
Concurrent AP/GO operation on different channels
isn't really supported well by the firmware so
it's better to remove it from being advertised.
Also tune the way station and p2p client interface
limits are expressed to allow station + 2x p2p
client or station + p2p client + p2p go.
mac80211 already does provide complete IEs for
Probe Requests for hw scan and ath10k firmware was
appending duplicate Supported Rates IEs
unnecessarily.
Signed-off-by: Michal Kazior michal.kaz...@tieto.com
---
drivers/net/wireless/ath/ath10k/mac.c | 3 ---
drivers/net/wireless/ath/ath10k/wmi.c |
Psmode can be forcefully enabled when vdev isn't
started. It isn't guaranteed that mac80211 will
re-issue psmode setting after vdev is started
unless actual bss_conf.ps value has changed.
Even if this doesn't fix any problems now it may
prevent future breakage.
Signed-off-by: Michal Kazior
Further testing proved that multi-channel AP+STA
on QCA6174 with RM.2.0-00088 should have powersave
force-disabled to avoid beacon misses/skipping on
either side which in turn could disrupt
communication.
Since AP never has arvif-ps don't even bother
checking it. Other combinations may be broken
Whenever any vdev was supposed to be paused all Tx
queues were stopped (except offchannel) instead of
only these associated with the given vdev.
This caused subtle issues with
multi-channel/multi-vif scenarios, e.g.
authentication of station vif could sometimes fail
depending on fw tx pause
I've done most of the patches while testing P2P
but they aren't limited to that scope.
There are no inter-dependencies within the patchset
so single patches should be easily cherry-pickable
in case, e.g. some patches raise concerns or are
decided to be dropped during review.
Michal Kazior (6):
There's already a generic implementation so use that instead.
---
I'm not sure if the driver usage of atomic_or?() is correct in terms of
storage size of @val for 64 bit arches.
Assuming LP64 programming model for linux on say x86_64: atomic_or()
callers in this driver use long (sana 64 bit)
On Wednesday, July 08, 2015 10:06:37 PM Emmanuel Grumbach wrote:
So your device is able to replicate and update the IP / TCP header?
I don't really follow what your device is able to do.
You seem to be cutting the frags so that their length sums up to mss.
Which hints that your device can't
Setup rxfiler correctly for offchannel ctx.
This fix problem we didn't configure rxfilter, next
didn't receive probe requests and next failed
p2p_find. This was seen when ath9k loaded with
use_chanctx=1
Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com
---
While mac80211 setup this per HW, set same
rxfilter configuration for all chanctx.
Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com
---
drivers/net/wireless/ath/ath9k/main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c
On 9 July 2015 at 12:38, Rafał Miłecki zaj...@gmail.com wrote:
On 9 July 2015 at 09:07, Rafał Miłecki zaj...@gmail.com wrote:
The problem appears when trying to use more than 1 interface. It gets
created correctly, but setting its MAC fails. It results in wlan0-1
having the same MAC as wlan0
On Thu, Jul 9, 2015 at 2:37 PM, Vladimir Kondratiev
qca_vkond...@qca.qualcomm.com wrote:
On Wednesday, July 08, 2015 10:06:37 PM Emmanuel Grumbach wrote:
So your device is able to replicate and update the IP / TCP header?
I don't really follow what your device is able to do.
You seem to be
While compiling ath9k with some extra flags I've
found that:
ath9k/xmit.c +2473 ## 16: warning: restricted __le16 degrades to integer
ath9k/xmit.c +2474 ## 36: warning: invalid assignment: =
ath9k/xmit.c +2474 ## 36:left side has type restricted __le16
ath9k/xmit.c +2474 ## 36:right
On 7 July 2015 at 17:00, Jouni Malinen j...@w1.fi wrote:
On Thu, Jul 02, 2015 at 10:24:33AM +0200, Michal Kazior wrote:
After looking into hostapd code I noticed something strange and I wonder if
anyone else is already aware of this problem:
1. AP starts
2. STA-AP auth OTA
3. AP-STA auth
Broadcom's firmware requires every BSS to use MAC address with unique
last 2 bits. Otherwise it rejects submitted MAC which results in:
brcmfmac: _brcmf_set_mac_address: Setting cur_etheraddr failed, -52
Set addr_mask properly to hint only last 2 bits can be modified. This
isn't exactly true as
With a basic Linux userspace, the messages Calling CRDA to update
world regulatory domain appears 10 times after boot every second or
so, followed by a final Exceeded CRDA call max attempts. Not calling
CRDA. For those of us not having the corresponding userspace parts,
having those messages
On Tuesday, July 07, 2015 11:56:21 PM Szőts Ákos wrote:
I have an RTL8191SU 802.11n USB WLAN Adapter with rtl8192su driver.
Unfortunately, I have to turn it off and on sometimes to make it work. I use
NetworkManager with KDE 5 nm-applet in which I simply turn off the wireless
capability
On Fri, Jul 3, 2015 at 3:41 PM, Bob Copeland m...@bobcopeland.com wrote:
Instead of using peer link id for AID, generate a new
AID when creating mesh STAs in the kernel peering manager.
I missed a case where llid was used for aid in
ieee80211_mps_frame_release() -- will send a v3 for the
On Thu, Jul 09, 2015 at 08:31:16PM +0200, Arend van Spriel wrote:
There is or there was? If there is now I am fine with this patch, but if
it already was there the author might have had a reason for adding a
local function and I would like to hear that reason.
Nevermind. Just noticed you are
Sometimes bssid can go null on failed association.
Signed-off-by: Malcolm Priestley tvbox...@gmail.com
Cc: sta...@vger.kernel.org # v3.17+
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c
On Wed, Jul 08, 2015 at 11:07:20AM +0800, Chen-Yu Tsai wrote:
Thanks. I think there should be a written document about what the
rules should be like, or what is expected:
1. WiFi channel boundaries or band boundaries
2. peak output power or peak power spectral density
In
Suppose one is doing heavy download (AP - peer traffic), and there are lots of
frames in the
NIC's tx buffers (ath10k firmware, in this case).
Then, peer sends a power-save pkt telling AP it is going off-channel or
otherwise
will be unavailable.
What is the appropriate behaviour from the AP?
49 matches
Mail list logo
