rtl8723au driver treats REG_9346CR register as either 8- or 16-bit wide,
while rtl8192cu driver treats it as 8-bit wide, and so does rtl8188eu
driver. Use the lowest common denominator strategy.
Signed-off-by: Jakub Sitnicki
---
Hi Jes,
I'm posting this patch set to show in what direction the work is
going. Hopefully any changes (e.g. renames) which you wouldn't see
fit for this driver can be identified early this way.
The work is nowhere near the end. These changes only get me past the
parse_efuse() step in the
Remove the redundant infix ("tx_power") from field names.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 92
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 18 ++---
2 files changed, 55 insertions(+), 55
Preparatory step for adding support for RTL8188EU devices.
Signed-off-by: Jakub Sitnicki
---
Notes:
An alternative approach to keeping a buffer that is big enough to hold
the efuse map of any of the supported chips would be to allocate the
efuse map on-the-go to
From: Alan Liu
Add WMI-TLV and FW API support in ath10k testmode.
Ath10k can get right wmi command format from UTF image
to communicate UTF firmware.
Signed-off-by: Alan Liu
Signed-off-by: Kalle Valo
---
Hi there,
it's been a while, but I have good news: tried Kernel 4.2.3 from
Fedora and it just works! No need to use irq_mode=1 (and I also
removed skip_opt), tested with firmware API 5 from ath10k-firmware
since a couple of days now. No issue so far.
Thank you for the help and the work, and
From: Manikanta Pubbisetty
This patch adds support for getting firmware debug stats in 10.4 fw.
Signed-off-by: Manikanta Pubbisetty
Signed-off-by: Tamizh chelvam
---
v3:
>Fixed the parsing error for
Signed-off-by: Bruno Randolf
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
index
Monitor mode is enabled by handling the filter flags we get from mac80211 in
rtl8xxxu_configure_filter() and writing them to the RCR register.
By handling these filters correctly we can also stop setting the BSSID filters
in the association event.
Also remove initial setting of the RCR register
Ben Hutchings writes:
> On Sun, 2015-10-18 at 19:23 +0100, Ben Hutchings wrote:
>> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
>> > In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as
>> > firmware-4.bin") I
>> > forgot to commit board.bin file and that's
Some of the ath9k_phyerr enums were wrong from the
beginning (and even before). Most of the time the
codes were used for counters to be displayed over
debugfs, which made this a non-functional issue.
Some (e.g. ATH9K_PHYERR_FALSE_RADAR_EXT) are used
for radar detection and require the correct
Ben Hutchings writes:
> On Thu, 2015-10-15 at 13:40 +0300, Kalle Valo wrote:
>> In commit 40d14143b787 ("ath10k: add firmware 10.2.4.45 as firmware-4.bin") I
>> forgot to commit board.bin file and that's why it was not included in the
>> commit even I had added an entry to
As opposed to the vendor driver (rtl8188eu), extract from efuse only
these TX power values that are going to be of use later on.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 35 +++-
This is a preparatory step for adding support for RTL8188EU chips
which have different efuse length.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 5 -
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
2 files changed, 5
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 16 +-
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 38
2 files changed, 27 insertions(+), 27 deletions(-)
diff --git
Preparatory step for adding support for RTL8188EU chips.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 --
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 95
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 30
2 files changed, 66 insertions(+), 59 deletions(-)
diff --git
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 26 +---
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
index
Preparatory step for adding support for RTL8188EU chips. We follow the
same approach as with efuse here.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 +++---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 +++-
2 files
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 29
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 32
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 6 -
2 files changed, 37 insertions(+), 1 deletion(-)
diff --git
Avoid a negative conditional and an extra level of indentation in the
bigger part of the loop body.
Signed-off-by: Jakub Sitnicki
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 28 +++-
1 file changed, 13 insertions(+), 15 deletions(-)
diff
This patch reverts the commit, d79fd35b8c5d927695b48fa35aa586919818cce9.
The WID_JOIN_REQ_EXTENDED among WIDs needs two parameters for the request to
be sent to the firmware, which are the SA and the BSSID. For this case, both
is the same bssid in the handle_connect function. So, it's required to
From: Glen Lee
This patch use netdev private data member wilc instead of global variable
g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 25 +
1 file
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 16 +---
1 file changed, 9
From: Glen Lee
This patch changes function parameter type wilc with net_device and use netdev
private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 85 ---
1 file
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 20
1 file changed, 12
From: Glen Lee
This patch changes function argument wilc with net_device and use nic->wilc
instead of global variable g_linux_wlan. The null check codes should be placed
before it is used so move it.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
From: Glen Lee
This patch add wilc to struct perInterface_wlan_t which is netdev private
data to access wilc via netdev_priv function. Assign wilc to nic->wilc.
The global variable g_linux_wlan will be replaced with netdev private data
member wilc step by step.
From: Johannes Berg
Group station statistics by where they're (mostly) updated
(TX, RX and TX-status) and group them into sub-structs of
the struct sta_info.
Also rename the variables since the grouping now makes it
obvious where they belong.
This makes it easier to
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++--
1 file changed, 6
From: Johannes Berg
This file only feeds a debugfs file that isn't very useful, so remove
it. If necessary, we can add other ways to get this information, for
example in the NL80211_CMD_PROBE_CLIENT response.
Signed-off-by: Johannes Berg
---
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8 ++--
1 file changed, 6
From: Glen Lee
This patch changes function argument type wilc with net_device and use
netdev private data member wilc instead of p_nic.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 18
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +-
1 file changed, 5
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +-
1 file changed, 5
From: Johannes Berg
There's little point in keeping (and even sending to userspace)
the beacon_loss_count value per station, since it can only apply
to the AP on a managed-mode connection. Move the value to ifmgd,
advertise it only in managed mode, and remove it from
From: Glen Lee
Use netdev private data member wilc instead of global variable g_linux_wlan.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 7 +++
1 file changed, 3
From: Manikanta Pubbisetty
This patch combines several if statements into a single if condition
in WMI management rx handler. Found during code review.
Signed-off-by: Manikanta Pubbisetty
---
drivers/net/wireless/ath/ath10k/wmi.c
From: Manikanta Pubbisetty
This patch replaces mutliple if conditional checks with a single if condition
in WMI management rx handler. Found during code review.
Signed-off-by: Manikanta Pubbisetty
---
v2:
1) Changed commit
On 10/20/2015 04:55 PM, Kalle Valo wrote:
From: Alan Liu
Add WMI-TLV and FW API support in ath10k testmode.
Ath10k can get right wmi command format from UTF image
to communicate UTF firmware.
Signed-off-by: Alan Liu
Signed-off-by: Kalle
From: Ben Greear
If a user restricts the rateset for some reason, then the
probe requests should not advertise rates that are not
selected by the user.
To implement this, we save the requested bitrates at
the mac80211 level and take it into account when building
the
From: Ben Greear
When sending the association request, pay attention to the
legacy rates configured by the user, and do not advertise support
for any that are not configured.
This makes the assoc request packet look more correct when
making modern hardware act like a /b
This is to make sure that the notice files get automatically included.
Signed-off-by: Kalle Valo
---
WHENCE |5 +
1 file changed, 5 insertions(+)
diff --git a/WHENCE b/WHENCE
index 9b7e8e8526aa..ded2e7ad161b 100755
--- a/WHENCE
+++ b/WHENCE
@@ -2393,17 +2393,22
Hello Marty,
On Mon, Oct 19, 2015 at 11:49 AM, Marty Faltesek wrote:
>
> In uap mode the carrier is not enabled until after the first STA joins.
> The carrier triggers the bridge to start its state machine, and if STP
> is enabled, it takes 4 seconds as it transitions from
The wilc1000_hif_spi and wilc1000_hif_sdio structures are part of
the bus specific code, and the generic code should have no knowledge
of their addresses.
This changes the code to reference them only from the bus
specific initialization code, which we can then use to split
up the driver into
The two instances of struct wilc1000_ops reference functions that
are defined in just one file each. By moving the operations there,
we can mark all those functions as 'static' and avoid a number
of #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c
As a preparation for turning the SDIO side of wilc1000 into a separate
module, this removes the last direct caller from the core module into
the sdio specific portion. All calls to wilc1000_sdio_enable_interrupt()
and wilc1000_sdio_disable_interrupt() now go through a function pointer
in
'extern' declarations belong into a header file rather than
a .c file, to ensure that the definition matches the declaration.
This moves all declarations into a header file that seems
most appropriate for it.
Signed-off-by: Arnd Bergmann
---
The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so
this is where the init and exit functions should be. Splitting this up
enables further cleanups, including eventually allowing both modules
to be built together.
Signed-off-by: Arnd Bergmann
---
So far, my patches tried to do equivalent conversions of the
existing code. This one goes beyond that by restructuring
how the devices get probed. In particular, the spi driver
no longer creates the netdev until the device is probed,
and I've removed the global wilc1000_sdio_func and wilc_spi_dev
All symbols that are only referenced in the file that defines
them can be declared 'static' to avoid namespace pollution,
to produce better object code, and to make the source more
readable.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/Makefile | 3
wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c
to have knowledge of the specific sdio and spi front-ends. This
removes the structure and places the members with a constant
'struct wilc1000_ops' pointer inside of 'struct wilc'.
Signed-off-by: Arnd Bergmann
The linux_wlan.c file uses a set of enums from wilc_wlan_if.h,
with the exception of the NO_ENCRYPT that comes from
wilc_wfi_cfgoperations.h. The two sets of enums clearly have
the same intention but are defined a bit different.
To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this
wilc_create_wiphy tries to get a pointer to a device from the
global wilc1000_sdio_func variable. This is a layering violation
and we can use the wilc1000_dev->dev pointer instead.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
The COMPLEMENT_BOOT code is used only for SDIO and is aware of
details of the SDIO implementation that don't belong into
the common linux_wlan.c file.
This moves the functions to linux_wlan_sdio.c to get them out of
the way.
Signed-off-by: Arnd Bergmann
---
The last remaining user of WILC_SDIO macro checks for the correct
time to wait in an interrupt for the PLL to settle. We can
replace this with a runtime check and remove both WILC_SDIO and
WILC_SPI, as we no longer need conditional compilation based on
the hardware type.
Signed-off-by: Arnd
The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes
and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c
and should not be shared in a header file.
This moves over all that data into the .c file, and also moves all
the macro definitions from the file that
On Monday 19 October 2015 11:53:40 Arnd Bergmann wrote:
> On Monday 19 October 2015 11:39:31 Arnd Bergmann wrote:
> > On Monday 19 October 2015 16:54:23 Tony Cho wrote:
> > > Hi Arnd Bergmann,
> > >
> > > When I apply this patch, I cannot make WILC1000 module (wilc1000.ko)
> > > because
struct wilc has two pointers to store the device, one for sdio_func
and one for spi_device. By changing the pointer to a 'struct device',
we can simplify the logic and avoid a few #ifdefs.
Signed-off-by: Arnd Bergmann
---
drivers/staging/wilc1000/linux_wlan.c | 29
Whether the SDIO function uses an internal or external interrupt
should not be a compiletime decision but be determined at runtime.
This changes the code to pass a GPIO number from the init code
as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO
to preserve the previous behavior.
The driver provides an interface for custom power management
and detection that is meant to be filled by people customizing
the driver. The default implementation of this is empty, and
we don't actually want people to have to modify the source code.
If anybody needs this, they need to describe
After I screwed up two or three times trying to get the dependencies
with the SPI and SDIO backends right, I ended up taking the time
to do the real fix and make both coexist.
This is a series of patches that address various issues with the
driver, but is mainly targetted at splitting out the spi
This is to make sure that the notice files get automatically included.
Signed-off-by: Kalle Valo
---
WHENCE |5 +
1 file changed, 5 insertions(+)
diff --git a/WHENCE b/WHENCE
index 9b7e8e8526aa..5cc01414e915 100755
--- a/WHENCE
+++ b/WHENCE
@@ -2393,17 +2393,22
On Tue, 2015-10-20 at 17:53 +0300, Kalle Valo wrote:
> This is to make sure that the notice files get automatically included.
>
> Signed-off-by: Kalle Valo
While it isn't actually specified here, I expect the File: lines to
refer to the firmware itself. Please put these
Ben Hutchings writes:
> On Tue, 2015-10-20 at 17:53 +0300, Kalle Valo wrote:
>> This is to make sure that the notice files get automatically included.
>>
>> Signed-off-by: Kalle Valo
>
> While it isn't actually specified here, I expect the File:
Jakub Sitnicki writes:
> rtl8723au driver treats REG_9346CR register as either 8- or 16-bit wide,
> while rtl8192cu driver treats it as 8-bit wide, and so does rtl8188eu
> driver. Use the lowest common denominator strategy.
>
> Signed-off-by: Jakub Sitnicki
Jakub Sitnicki writes:
> rtl8192cu driver doesn't read/write the REG_EFUSE_TEST register.
> Neither does the rtl8188eu driver. Do it only for RTL8192CU-based
> devices.
>
> Signed-off-by: Jakub Sitnicki
> ---
>
Jakub Sitnicki writes:
> Hi Jes,
>
> I'm posting this patch set to show in what direction the work is
> going. Hopefully any changes (e.g. renames) which you wouldn't see
> fit for this driver can be identified early this way.
>
> The work is nowhere near the end. These
Jakub Sitnicki writes:
> Avoid a negative conditional and an extra level of indentation in the
> bigger part of the loop body.
>
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 28
> +++-
>
Jakub Sitnicki writes:
> It is enough to check for either illegal offset or illegal map address
> because map address is a value derived from an offset:
>
> map_addr = offset * 8
> EFUSE_MAP_LEN_8723A = EFUSE_MAX_SECTION_8723A * 8
>
> Leave just the check for an illegal
Jakub Sitnicki writes:
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 95
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 30
> 2 files changed, 66 insertions(+), 59
Jakub Sitnicki writes:
> As opposed to the vendor driver (rtl8188eu), extract from efuse only
> these TX power values that are going to be of use later on.
>
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 35
Jakub Sitnicki writes:
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
>
Jakub Sitnicki writes:
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 26
> +---
> 1 file changed, 14 insertions(+), 12 deletions(-)
This cleans up the code nicely - so I applied both of
Jakub Sitnicki writes:
> Preparatory step for adding support for RTL8188EU devices.
>
> Signed-off-by: Jakub Sitnicki
> ---
>
> Notes:
> An alternative approach to keeping a buffer that is big enough to hold
> the efuse map of any of the
Jakub Sitnicki writes:
> Preparatory step for adding support for RTL8188EU chips.
>
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 6 --
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
> 2 files
Hi Avinash
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless-
> ow...@vger.kernel.org] On Behalf Of Avinash Patil
> Sent: Wednesday, October 21, 2015 1:50 AM
> To: Marty Faltesek
> Cc: linux-wireless@vger.kernel.org; Amitkumar Karwar; Nishant
> Sarmukadam; Denton Gentry; Avery
Jakub Sitnicki writes:
> Signed-off-by: Jakub Sitnicki
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 16 +-
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 38
>
> 2 files changed, 27 insertions(+), 27
Jakub Sitnicki writes:
> This is a preparatory step for adding support for RTL8188EU chips
> which have different efuse length.
The way the EFUSES are stored, it doesn't matter that you try to read
more data as the EFUSE will stop. I already added support for reading
the
82 matches
Mail list logo