[PATCH 2/5] mac80211: mesh: use hlist for rmc cache

2016-03-18 Thread Bob Copeland
The RMC cache has 256 list heads plus a u32, which puts it at the unfortunate size of 4104 bytes with padding. kmalloc() will then round this up to the next power-of-two, so we wind up actually using two pages here where most of the second is wasted. Switch to hlist heads here to reduce the struc

RE: [PATCH] mwifiex: fw download does not release sdio bus during failure

2016-03-18 Thread Amitkumar Karwar
> From: Marty Faltesek [mailto:mfalte...@google.com] > Sent: Tuesday, March 15, 2016 4:49 AM > To: Amitkumar Karwar > Cc: linux-wireless@vger.kernel.org > Subject: [PATCH] mwifiex: fw download does not release sdio bus during > failure > > --- > drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--

[PATCH v2] mac80211: mesh: fix crash in mesh_path_timer

2016-03-18 Thread Bob Copeland
The mesh_path_reclaim() function, called from an rcu callback, cancels the mesh_path_timer associated with a mesh path. Unfortunately, this call can happen much later, perhaps after the hash table itself is destroyed. Such a situation led to the following crash in mesh_path_send_to_gates() when d

[PATCH] staging: refresh TODO for rtl8723au

2016-03-18 Thread Xose Vazquez Perez
People should not waste time and energy working on this staging driver. A replacement(rtl8xxxu) using the kernel wireless stack already was merged in the 4.3 kernel. Cc: Jes Sorensen Cc: Larry Finger Cc: Kalle Valo Cc: Greg Kroah-Hartman Cc: Linux Driver Project Developer List Cc: Linux Wirel

Re: pull request: iwlwifi-2016-02-16

2016-03-18 Thread Arend Van Spriel
On 15-2-2016 12:57, Grumbach, Emmanuel wrote: > * Luca fixes a very visible bug in scheduled scan: our firmware > doesn't support scheduled scan with no profile configured and > the supplicant sometimes requests such scheduled scans. Hi Luca, I have seen this happening as well, but did not fi

[PATCH 1/5] mac80211: mesh: handle failed alloc for rmc cache

2016-03-18 Thread Bob Copeland
In the unlikely case that mesh_rmc_init() fails with -ENOMEM, the rmc pointer will be left as NULL but the interface is still operational because ieee80211_mesh_init_sdata() is not allowed to fail. If this happens, we would blindly dereference rmc when checking whether a multicast frame is in the

[PATCH 5/5] mac80211: mesh: fix mesh path kerneldoc

2016-03-18 Thread Bob Copeland
Several of the mesh path fields are undocumented and some of the documentation is no longer correct or relevant after the switch to rhashtable. Clean up the kernel doc accordingly and reorder some fields to match the structure layout. Signed-off-by: Bob Copeland --- net/mac80211/mesh.h | 20 +++

[PATCH 3/5] mac80211: mesh: embed gates hlist head directly

2016-03-18 Thread Bob Copeland
Since we have converted the mesh path tables to rhashtable, we are no longer swapping out the entire mesh_pathtbl pointer with RCU. As a result, we no longer need indirection to the hlist head for the gates list and can simply embed it, saving a pair of pointer-sized allocations. Signed-off-by: Bo

[PATCH 4/5] mac80211: mesh: reorder structure members

2016-03-18 Thread Bob Copeland
Reduce padding waste in struct mesh_table and struct rmc_entry by moving the smaller fields to the end. Signed-off-by: Bob Copeland --- net/mac80211/mesh.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h index 46b540a25d9d..4a59c

[PATCH 0/5] mesh struct cleanups

2016-03-18 Thread Bob Copeland
This series makes a few minor mesh cleanups after the rhashtable rework -- mostly some reductions in padding and allocation waste. Bob Copeland (5): mac80211: mesh: handle failed alloc for rmc cache mac80211: mesh: use hlist for rmc cache mac80211: mesh: embed gates hlist head directly mac

Re: [PATCH] dt: bindings: add new dt entry for pre calibration in qcom,ath10k.txt

2016-03-18 Thread Rob Herring
On Thu, Mar 10, 2016 at 03:42:04PM +0530, Raja Mani wrote: > There two things done in this patch, > > 1) Existing device tree entry 'qcom,ath10k-calibration-data' carries >not only calibration data, it carries board specific data too. >So, make appropriate update in doc. > > 2) ipq4019 wi

Re: [PATCH] rt2x00usb: Use usb anchors to manage URB

2016-03-18 Thread Vishal Thanki
Hi, On Thu, Mar 17, 2016 at 09:43:32AM +0100, Stanislaw Gruszka wrote: > Hi > > On Wed, Mar 16, 2016 at 06:28:51PM +0100, Vishal Thanki wrote: > > +struct rt2x00usb_anchors { > > + struct usb_anchor async_urb; > > + struct usb_anchor tx_submitted; > > + struct usb_anchor rx_submitted; > > +

[PATCH 10/19] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

2016-03-18 Thread Julian Calaby
From: Jia-Ju Bai The memory allocated by kzalloc in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init is not freed. This patch fixes the bug by adding kfree in b43_ssb_remove, b43_bcma_remove and error handling code of b43_bcma_probe. Thanks Michael for his suggestion. Signed-off-by: Jia-Ju Bai T

[PATCH] ath9k: fix rng high cpu load

2016-03-18 Thread miaoqing
From: Miaoqing Pan If no valid ADC randomness output, ath9k rng will continuously reading ADC, which will cause high CPU load. So increase the delay to wait for ADC ready. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=114261 Signed-off-by: Miaoqing Pan --- drivers/net/wireless/ath/ath9

[PATCH 1/2] mac80211: don't send deferred frames outside the SP

2016-03-18 Thread Emmanuel Grumbach
Frames that are sent between ampdu_action(IEEE80211_AMPDU_TX_START) and the move to the HT_AGG_STATE_OPERATIONAL state are buffered. If we try to start an A-MPDU session while the peer is sleeping and polling frames with U-APSD, we may have frames that will be buffered by ieee80211_tx_prep_agg. The

Re: [PATCH CONTROVERSIAL 19/19] iwlegacy: Rename label in il_eeprom_init()

2016-03-18 Thread Julian Calaby
Hi Dan, On Fri, Mar 18, 2016 at 10:01 PM, Dan Carpenter wrote: > On Fri, Mar 18, 2016 at 01:29:39PM +1100, Julian Calaby wrote: >> From: Markus Elfring >> >> Rename a jump label according to the current Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> [Rewrote commit title]

Re: [PATCH] staging: refresh TODO for rtl8723au

2016-03-18 Thread Jes Sorensen
Joe Perches writes: > On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote: >> Xose Vazquez Perez writes: >> > People should not waste time and energy working on this staging driver. >> > A replacement(rtl8xxxu) using the kernel wireless stack already was merged >> > in the 4.3 kernel. > [] >> >

[PATCH v3] rt2x00usb: Use usb anchor to manage URB

2016-03-18 Thread Vishal Thanki
With current driver, it is observed that a URB is not completed while the USB disconnect is initiated. Due to that, the URB completion hanlder is trying to access the resource which was freed as a part of USB disconnect. Managing the URBs with anchor will make sure that all the URBs are handled gra

Re: [PATCH] staging: refresh TODO for rtl8723au

2016-03-18 Thread Joe Perches
On Fri, 2016-03-18 at 23:58 -0400, Jes Sorensen wrote: > Joe Perches writes: > > On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote: > > > Xose Vazquez Perez writes: > > > > > > > > People should not waste time and energy working on this staging driver. > > > > A replacement(rtl8xxxu) using t

Re: [PATCH v5] ath10k: Enable debugfs provision to enable Peer Stats feature

2016-03-18 Thread Mohammed Shafi Shajakhan
Hi Kalle, I had resent this change (to avoid any confusions with compilation issues) as a part of the below series [PATCH v1 1/3] ath10k: Enable debugfs provision to enable Peer Stats feature [PATCH v1 2/3] ath10k: Introduce Extended Resource Config support for 10.4 [PATCH v1 3/3] ath10k: Enable

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-18 Thread Michal Kazior
On 16 March 2016 at 16:37, Dave Taht wrote: > it is helpful to name the test files coherently in the flent tests, in > addition to using a directory structure and timestamp. It makes doing > comparison plots in data->add-other-open-data-files simpler. "-t > patched-mac-300mbps", for example. Sorr

[PATCH MOREWORK 15/19] rsi: Move variable initialisation into error code

2016-03-18 Thread Julian Calaby
From: Markus Elfring In rsi_send_data_pkt(), it's a little more logical to assign 'status' in the actual error handling code as opposed to at the top of the functon. Signed-off-by: Markus Elfring [Deleted controversial bits, rewrote commit message] Signed-off-by: Julian Calaby --- I'm not fu

[PATCH 7/9] rtlwifi: rtl8723ae: Fix Smatch warning

2016-03-18 Thread Larry Finger
Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c:137 rtl8723e_dm_bt_need_to_dec_bt_pwr() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rt

Re: [PATCH 1/1] ath6kl: Fix SDIO broken scatter hif-scatter

2016-03-18 Thread Julian Calaby
Hi Robert, On Fri, Nov 6, 2015 at 7:42 PM, Robert Deliën wrote: > This patch fixes broken hif-scatter in ath6kl SDIO. It is not my work; I have > found it as a difference between two Digi distributed Kernel source trees. No > commit comment was recorded. I am sure there are better/nicer/cleaner

Re: iwlwifi incomplete initialization in Linux 4.5?

2016-03-18 Thread Grumbach, Emmanuel
Replying to self to remove people who were added in CC and should really have been BCC'ed. On 03/16/2016 11:13 PM, Grumbach, Emmanuel wrote: > Hi Linus, > > On 03/16/2016 10:48 PM, Linus Torvalds wrote: >> So I upgraded the firmware on my Intel NUC (NUC6i3SYK), and that made >> the wireless no lo

Re: [Outreachy kernel] [PATCH v2] iwlwifi: dvm: use alloc_ordered_workqueue()

2016-03-18 Thread Tejun Heo
On Fri, Mar 18, 2016 at 12:19:21AM +0800, Eva Rachel Retuya wrote: > Use alloc_ordered_workqueue() to allocate the workqueue instead of > create_singlethread_workqueue() since the latter is deprecated and is > scheduled > for removal. > > There are work items doing related operations that shouldn

[PATCH 2/9] rtlwifi: btcoexist: Fix Smatch warning

2016-03-18 Thread Larry Finger
Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3078 btc8723b2ant_run_coexist_mechanism() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/

[PATCH v2 2/2] ath10k: Remove debugfs support for Per STA total rx duration

2016-03-18 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan cfg80211/nl80211 interface changes for per STA total rx-duration and very basic 'ath10k_sta_statistics' mac80211 callback is implemented to extend support for per station statistics from the driver. Also provision in 'iw dev wlan#N station dump' to parse rx-durati

[PATCH v3] iwlwifi: dvm: use alloc_ordered_workqueue()

2016-03-18 Thread Eva Rachel Retuya
Use alloc_ordered_workqueue() to allocate the workqueue instead of create_singlethread_workqueue() since the latter is deprecated and is scheduled for removal. There are work items doing related operations that shouldn't be swapped when queued in a certain order hence preserve the strict execution

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-18 Thread J. Bruce Fields
On Fri, Mar 18, 2016 at 04:46:23PM -0400, Tejun Heo wrote: > Hello, Jeff. > > On Thu, Mar 17, 2016 at 09:32:16PM -0400, Jeff Layton wrote: > > > * Are network devices expected to be able to serve as a part of > > > storage stack which is depended upon for memory reclamation? > > > > I think the

Re: [PATCH v5 2/4] mwifiex: add platform specific wakeup interrupt support

2016-03-18 Thread Wei-Ning Huang
Reviewed-by: Wei-Ning Huang Tested-by: Wei-Ning Huang On Fri, Mar 18, 2016 at 7:03 PM, Amitkumar Karwar wrote: > From: Xinming Hu > > On some arm-based platforms, we need to configure platform specific > parameters by device tree node and also define our node as a child > node of parent SDIO h

[PATCH v5 1/2] dt: bindings: add MARVELL's sd8xxx wireless device

2016-03-18 Thread Amitkumar Karwar
From: Xinming Hu Add device tree binding documentation for MARVELL's sd8xxx (sd8897 and sd8997) wlan chip. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- Listing changelist for both 1/2 and 2/2 patches v3: Don't update adapter->dt_node if mwifiex_plt_dev is NULL v4: a)Corrected

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-18 Thread Michal Kazior
On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan wrote: [...] > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif > *vif, > + struct ieee80211_sta *sta, > + struct station_info *sinfo) > +{ > + struct ath10k_sta *a

Re: [PATCH v2 1/2] ath10k: Add support for ath10k_sta_statistics support

2016-03-18 Thread Michal Kazior
On 17 March 2016 at 12:20, Mohammed Shafi Shajakhan wrote: > Hi Michal, > > On Thu, Mar 17, 2016 at 12:12:31PM +0100, Michal Kazior wrote: >> On 17 March 2016 at 11:48, Mohammed Shafi Shajakhan >> wrote: >> [...] >> > +void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif >> >

[PATCH 1/9] rtlwifi: Fix Smatch warnings

2016-03-18 Thread Larry Finger
Smatch reports the following: CHECK drivers/net/wireless/realtek/rtlwifi/pci.c drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv() error: we previously assumed 'tpriv' could be null (see line 368) drivers/net/wireless/realtek/rtlwifi/pci.c:1216 _rtl_pci_init_struct() war

[PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4

2016-03-18 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Rx duration support for per station is part of extended peer stats, enable provision to parse the same and provide backward compatibility based on the 'stats_id' event Signed-off-by: Mohammed Shafi Shajakhan --- drivers/net/wireless/ath/ath10k/core.c | 19 +

Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

2016-03-18 Thread Julian Calaby
Hi, On Mon, Jan 25, 2016 at 8:52 PM, Arend van Spriel wrote: > > > On 20-1-2016 14:06, Rafał Miłecki wrote: >> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION. >> >> Signed-off-by: Rafał Miłecki >> --- >> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes >

Re: iwlwifi incomplete initialization in Linux 4.5?

2016-03-18 Thread Linus Torvalds
On Wed, Mar 16, 2016 at 2:13 PM, Grumbach, Emmanuel wrote: > > This ... typically means that the firmware got stuck while sending > packets. Can you tell me on what band your router operates? 2.4GHz or > 5.2GHz? Both. > Do you use 20Mhz or 40MHz? HT20 on 2.4GHz, HT40 on 5GHz. At least that's t

[PATCH v5 2/4] mwifiex: add platform specific wakeup interrupt support

2016-03-18 Thread Amitkumar Karwar
From: Xinming Hu On some arm-based platforms, we need to configure platform specific parameters by device tree node and also define our node as a child node of parent SDIO host controller. This patch parses these parameters from device tree. It includes calibration data dowoload to firmware, wake

[PATCH] staging: r8723au: This patch tries to fix some byte order issues that is found by sparse check.

2016-03-18 Thread Jandy Gou
make C=1 M=drivers/staging/rtl8723au/ drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:96:38: warning: cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_cmd.c:100:27: warning: cast to restricted __le32 Signed-off-by: Jandy Gou --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 4 ++--

Re: [PATCH 05/19] rtlwifi: use to_delayed_work()

2016-03-18 Thread Larry Finger
On 03/17/2016 09:22 PM, Julian Calaby wrote: From: Geliang Tang Use to_delayed_work() instead of open-coding it. Signed-off-by: Geliang Tang [Update commit message] Signed-off-by: Julian Calaby Acked-by: Larry Finger Larry --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 +- 1 fi

Why does ieee80211_rx() requires the bottom halves to be disbaled?

2016-03-18 Thread Neelansh
3823 static inline void ieee80211_rx_ni(struct ieee80211_hw *hw, 3824struct sk_buff *skb) 3825 { 3826 local_bh_disable(); 3827 ieee80211_rx(hw, skb); 3828 local_bh_enable(); 3829 } Why bottom halves on the local processor need to disabled

[PATCH 5/9] rtlwifi: rtl8192ee: Fix Smatch warning

2016-03-18 Thread Larry Finger
Smatch lists the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c:371 rtl92ee_rx_query_desc() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/trx.c | 2 +-

[PATCH 6/9] rtlwifi: rtl8192se: Fix Smatch warning

2016-03-18 Thread Larry Finger
Smatch lists the following: CHECK drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c:648 rtl92s_phy_set_rf_power_state() warn: inconsistent indenting Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/rtl8192se/phy.c